mini_magick 4.4.0 → 4.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7f0d6f6689137d1749757919b43718103e708beb
-  data.tar.gz: 310371ca24dc3ab384f2eaff5dcfc2053cdf0d99
+  metadata.gz: 7fc96fb4e4e78fcb998445df1fd45fdcb54ff166
+  data.tar.gz: 4c51452698c426bf5ce84fc9e7d99f3b0eda5e6b
 SHA512:
-  metadata.gz: bbaa819729b8f53bd43cfbc3f3d82bba32ca50d6f76730176ec99239ecf519752962f1040b11b5fbca17d4d092f9ddd362aa0e87aab62410043cc2375c6e2bc2
-  data.tar.gz: 1a3163bcc33173731cd6c0d22e3b0cf2a54c3516426dc72bf2eb67826f5efc431af8b8ea1af6435539d4a035b70466728448e1d00d63685a785d79d3870d40e2
+  metadata.gz: 70d1dc21bd68480aa447ccb2b271b9e36914ef796db9d4871d3fef773a5c181c27c3c5b7d741ec7507f0e5306be8740566bdae102d3b6f15a2c55cfe3055658a
+  data.tar.gz: e434f8e994c40ee2a6cd720584e87a52fecc1e3688a634192d2664042c71c778cbc8d147d358339b0c7d497dd976f28c57ef5c177755c7cb3326e8d0ceeca835

data/lib/mini_magick/configuration.rb

@@ -1,4 +1,5 @@
 require 'mini_magick/utilities'
+require 'logger'
 
 module MiniMagick
   module Configuration
@@ -86,6 +87,7 @@ module MiniMagick
       base.validate_on_write = true
       base.whiny = true
       base.shell_api = "open3"
+      base.logger = Logger.new($stdout)
     end
 
     ##
@@ -140,13 +142,14 @@ module MiniMagick
       @cli_path || @processor_path
     end
 
-    def logger
-      @logger || MiniMagick::Logger.new($stdout)
+    def debug=(value)
+      warn "MiniMagick.debug is deprecated and will be removed in MiniMagick 5. Use `MiniMagick.logger.level = Logger::DEBUG` instead."
+      logger.level = Logger::DEBUG
     end
 
     # Backwards compatibility
     def reload_tools
-      warn "[MiniMagick] MiniMagick.reload_tools is deprecated because it is no longer necessary"
+      warn "MiniMagick.reload_tools is deprecated because it is no longer necessary"
     end
 
   end

data/lib/mini_magick/image.rb

@@ -340,8 +340,7 @@ module MiniMagick
         new_tempfile = MiniMagick::Utilities.tempfile(".#{format}")
         new_path = new_tempfile.path
       else
-        new_path = path.sub(/(\.\w+)?$/, ".#{format}")
-        new_path.sub!(/\[(\d+)\]/, '_\1') if layer?
+        new_path = Pathname(path).sub_ext(".#{format}").to_s
       end
 
       input_path = path.dup
@@ -354,7 +353,7 @@ module MiniMagick
       end
 
       if @tempfile
-        @tempfile.unlink
+        destroy!
         @tempfile = new_tempfile
       else
         File.delete(path) unless path == new_path || layer?
@@ -467,7 +466,10 @@ module MiniMagick
     # Destroys the tempfile (created by {.open}) if it exists.
     #
     def destroy!
-      @tempfile.unlink if @tempfile
+      if @tempfile
+        FileUtils.rm_f @tempfile.path.sub(/mpc$/, "cache") if @tempfile.path.end_with?(".mpc")
+        @tempfile.unlink
+      end
     end
 
     ##

data/lib/mini_magick/shell.rb

@@ -1,5 +1,5 @@
-require "mini_magick/logger"
 require "timeout"
+require "benchmark"
 
 module MiniMagick
   ##
@@ -11,25 +11,25 @@ module MiniMagick
   class Shell
 
     def run(command, options = {})
-      stdout, stderr, code = execute(command)
+      stdout, stderr, status = execute(command, stdin: options[:stdin])
 
-      case code
+      case status
       when 1
         fail MiniMagick::Error, "`#{command.join(" ")}` failed with error:\n#{stderr}"
       when 127
         fail MiniMagick::Error, stderr
-      end if options.fetch(:whiny, true)
+      end if options.fetch(:whiny, MiniMagick.whiny)
 
       $stderr.print(stderr) unless options[:stderr] == false
 
-      stdout
+      [stdout, stderr, status]
     end
 
-    def execute(command)
+    def execute(command, options = {})
       stdout, stderr, status =
-        MiniMagick.logger.debug(command.join(" ")) do
+        log(command.join(" ")) do
           Timeout.timeout(MiniMagick.timeout) do
-            send("execute_#{MiniMagick.shell_api.gsub("-", "_")}", *command)
+            send("execute_#{MiniMagick.shell_api.gsub("-", "_")}", command, options)
           end
         end
 
@@ -38,18 +38,31 @@ module MiniMagick
       ["", "executable not found: \"#{command.first}\"", 127]
     end
 
-    def execute_open3(*command)
+    private
+
+    def execute_open3(command, options = {})
       require "open3"
-      Open3.capture3(*command)
+
+      Open3.capture3(*command, binmode: true, stdin_data: options[:stdin].to_s)
     end
 
-    def execute_posix_spawn(*command)
+    def execute_posix_spawn(command, options = {})
       require "posix-spawn"
+
       pid, stdin, stdout, stderr = POSIX::Spawn.popen4(*command)
+      [stdin, stdout, stderr].each(&:binmode)
+      stdin.write(options[:stdin].to_s)
       Process.waitpid(pid)
 
       [stdout.read, stderr.read, $?]
     end
 
+    def log(command, &block)
+      value = nil
+      duration = Benchmark.realtime { value = block.call }
+      MiniMagick.logger.debug "[%.2fs] %s" % [duration, command]
+      value
+    end
+
   end
 end

data/lib/mini_magick/tool.rb

@@ -49,13 +49,15 @@ module MiniMagick
     # @param whiny [Boolean] Whether to raise errors on exit codes different
     #   than 0.
     # @example
-    #   MiniMagick::Tool::Identify.new(false) do |identify|
+    #   MiniMagick::Tool::Identify.new(whiny: false) do |identify|
     #     identify.help # returns exit status 1, which would otherwise throw an error
     #   end
-    def initialize(name, whiny = MiniMagick.whiny)
+    def initialize(name, options = {})
+      warn "MiniMagick::Tool.new(false) is deprecated and will be removed in MiniMagick 5, use MiniMagick::Tool.new(whiny: false) instead." if !options.is_a?(Hash)
+
       @name  = name
-      @whiny = whiny
       @args  = []
+      @whiny = options.is_a?(Hash) ? options.fetch(:whiny, MiniMagick.whiny) : options
     end
 
     ##
@@ -67,16 +69,30 @@ module MiniMagick
     #   mogrify << "path/to/image.jpg"
     #   mogrify.call # executes `mogrify -resize 500x500 path/to/image.jpg`
     #
-    # @param whiny [Boolean] Whether you want an error to be raised when
-    #   ImageMagick returns an exit code of 1. You may want this because
-    #   some ImageMagick's commands (`identify -help`) return exit code 1,
-    #   even though no error happened.
+    # @example
+    #   mogrify = MiniMagick::Tool::Mogrify.new
+    #   # build the command
+    #   mogrify.call do |stdout, stderr, status|
+    #     # ...
+    #   end
+    #
+    # @yield [Array] Optionally yields stdout, stderr, and exit status
     #
-    # @return [String] Output of the command
+    # @return [String] Returns the output of the command
     #
-    def call(whiny = @whiny, options = {})
+    def call(*args)
+      options = args[-1].is_a?(Hash) ? args.pop : {}
+      warn "Passing whiny to MiniMagick::Tool#call is deprecated and will be removed in MiniMagick 5, use MiniMagick::Tool.new(whiny: false) instead." if args.any?
+      whiny = args.fetch(0, @whiny)
+
+      options[:whiny] = whiny
+      options[:stderr] = false if block_given?
+
       shell = MiniMagick::Shell.new
-      shell.run(command, options.merge(whiny: whiny)).strip
+      stdout, stderr, status = shell.run(command, options)
+      yield stdout, stderr, status if block_given?
+
+      stdout.strip
     end
 
     ##
@@ -171,6 +187,19 @@ module MiniMagick
       self << ")"
     end
 
+    ##
+    # Adds ImageMagick's pseudo-filename `-` for standard input.
+    #
+    # @example
+    #   identify = MiniMagick::Tool::Identify.new
+    #   identify.stdin
+    #   identify.call(stdin: image_content)
+    #   # executes `identify -` with the given standard input
+    #
+    def stdin
+      self << "-"
+    end
+
     ##
     # Define creator operator methods
     #
@@ -216,9 +245,9 @@ module MiniMagick
 
     def self.option_methods
       @option_methods ||= (
-        tool = new
+        tool = new(whiny: false)
         tool << "-help"
-        help_page = tool.call(false, stderr: false)
+        help_page = tool.call(stderr: false)
 
         cli_options = help_page.scan(/^\s+-[a-z\-]+/).map(&:strip)
         if tool.name == "mogrify" && MiniMagick.graphicsmagick?

data/lib/mini_magick/version.rb

@@ -8,7 +8,7 @@ module MiniMagick
 
   module VERSION
     MAJOR = 4
-    MINOR = 4
+    MINOR = 5
     TINY  = 0
     PRE   = nil
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mini_magick
 version: !ruby/object:Gem::Version
-  version: 4.4.0
+  version: 4.5.0
 platform: ruby
 authors:
 - Corey Johnson
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-06 00:00:00.000000000 Z
+date: 2016-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -76,7 +76,6 @@ files:
 - lib/mini_magick/configuration.rb
 - lib/mini_magick/image.rb
 - lib/mini_magick/image/info.rb
-- lib/mini_magick/logger.rb
 - lib/mini_magick/shell.rb
 - lib/mini_magick/tool.rb
 - lib/mini_magick/tool/animate.rb
@@ -113,7 +112,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - You must have ImageMagick or GraphicsMagick installed
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Manipulate images with minimal use of memory via ImageMagick / GraphicsMagick

data/lib/mini_magick/logger.rb

@@ -1,38 +0,0 @@
-require "benchmark"
-
-module MiniMagick
-  ##
-  # Responsible for logging commands to stdout (activated when
-  # `MiniMagick.debug` is set to `true`). Implements a simplified Logger
-  # interface.
-  #
-  # @private
-  #
-  class Logger
-
-    attr_accessor :format
-
-    def initialize(io)
-      @io     = io
-      @format = "[%<duration>.2fs] %<command>s"
-    end
-
-    def debug(command, &action)
-      benchmark(action) do |duration|
-        output(duration: duration, command: command) if MiniMagick.debug
-      end
-    end
-
-    def output(data)
-      printf @io, "#{format}\n", data
-    end
-
-    def benchmark(action)
-      return_value = nil
-      duration = Benchmark.realtime { return_value = action.call }
-      yield duration
-      return_value
-    end
-
-  end
-end