mini_kraken 0.1.04 → 0.1.09

data/spec/core/succeed_spec.rb

@@ -24,18 +24,18 @@ module MiniKraken
         it 'should unconditionally return a success result' do
           args = double('fake-args')
           env = double('fake-env')
-          
+
           solver = nil
           expect { solver = subject.solver_for(args, env) }.not_to raise_error
-          
+
           # Solver should quack like a Fiber
           dummy_arg = double('dummy-stuff')
           result = solver.resume(dummy_arg)
           expect(result).to eq(BasicSuccess)
-          
+
           # Only one "solution", next 'resume' call should return nil
           result = solver.resume(dummy_arg)
-          expect(result).to be_nil          
+          expect(result).to be_nil
         end
       end # context
     end # describe

data/spec/core/variable_ref_spec.rb

@@ -18,10 +18,6 @@ module MiniKraken
         it 'should know the name of a variable' do
           expect(subject.var_name).to eq('q')
         end
-
-        # it 'should be fresh by default' do
-          # expect(subject).to be_fresh
-        # end
       end # context
 
       context 'Provided services:' do

data/spec/core/vocabulary_spec.rb

@@ -1,18 +1,18 @@
 # frozen_string_literal: true
 
 require_relative '../spec_helper' # Use the RSpec framework
-require_relative '../../lib/mini_kraken/core/association'
 require_relative '../../lib/mini_kraken/core/k_symbol'
+require_relative '../../lib/mini_kraken/core/variable'
 require_relative '../../lib/mini_kraken/core/variable_ref'
 require_relative '../support/factory_methods'
 
 # Load the class under test
-require_relative '../../lib/mini_kraken/core/vocabulary'
+# frozen_string_literal: true
 
+require_relative '../../lib/mini_kraken/core/vocabulary'
 
 module MiniKraken
   module Core
-
     class TestVocabulary
       include Vocabulary
 
@@ -21,16 +21,20 @@ module MiniKraken
       end
     end # class
 
+    # Helper module that simulates an environment-like object.
     module VariableBearer
       attr_reader :vars
+      attr_accessor :ivars
 
       def init_var_bearer
         @vars = {}
+        @ivars = {}
         self
       end
 
       def add_var(aVarName)
-        vars[aVarName] = aVarName.hash # Just for testing purposes
+        vars[aVarName] = Variable.new(aVarName)
+        ivars[aVarName] = Set.new([aVarName])
       end
     end # module
 
@@ -75,11 +79,11 @@ module MiniKraken
 
         it 'should provide a walker over ancestors' do
           walker = subject.ancestor_walker
-          expect(walker).to be_kind_of(Fiber)
-          expect(walker.resume).to eq(subject)
-          expect(walker.resume).to eq(mother)
-          expect(walker.resume).to eq(grandma)
-          expect(walker.resume).to be_nil
+          expect(walker).to be_kind_of(Enumerator)
+          expect(walker.next).to eq(subject)
+          expect(walker.next).to eq(mother)
+          expect(walker.next).to eq(grandma)
+          expect(walker.next).to be_nil
         end
 
         it 'should know if a variable is defined' do
@@ -99,11 +103,12 @@ module MiniKraken
         it 'should allow the addition of associations' do
           grandma.add_var('q')
           expect(subject['q']).to be_empty
-          mother.add_assoc(Association.new('q', pea))
+          res_add = mother.add_assoc('q', pea)
+          expect(res_add).to be_kind_of(Association)
           expect(subject['q'].size).to eq(1)
           expect(subject['q'].first.value).to eq(pea)
 
-          subject.add_assoc(Association.new('q', ref_x))
+          subject.add_assoc('q', ref_x)
           expect(subject['q'].size).to eq(2)
           expect(subject['q'].first.value).to eq(ref_x)
           expect(subject['q'].last.value).to eq(pea)
@@ -111,8 +116,8 @@ module MiniKraken
 
         it 'should allow the deletion of associations' do
           grandma.add_var('q')
-          mother.add_assoc(Association.new('q', pea))
-          subject.add_assoc(Association.new('q', ref_x))
+          mother.add_assoc('q', pea)
+          subject.add_assoc('q', ref_x)
           expect(mother.associations.size).to eq(1)
           expect(subject.associations.size).to eq(1)
 
@@ -127,18 +132,18 @@ module MiniKraken
           grandma.add_var('q')
           grandma.add_var('x')
           expect(subject.fresh?(ref_q)).to be_truthy
-          subject.add_assoc(Association.new('q', ref_x)) # Dependency: q --> x
+          subject.add_assoc('q', ref_x) # Dependency: q --> x
           expect(subject.fresh?(ref_x)).to be_truthy
         end
 
         it 'should say not fresh when variable --> atomic value' do
           grandma.add_var('q')
           grandma.add_var('x')
-          subject.add_assoc(Association.new('q', ref_x)) # Dependency: q --> x
+          subject.add_assoc('q', ref_x) # Dependency: q --> x
           expect(subject.fresh?(ref_q)).to be_truthy
 
           # Associate with an atomic term
-          subject.add_assoc(Association.new('q', pea))
+          subject.add_assoc('q', pea)
           expect(subject.fresh?(ref_q)).to be_falsey
         end
 
@@ -147,16 +152,16 @@ module MiniKraken
 
           # Composite having only atomic terms as leaf elements
           expr = cons(pea, cons(pod))
-          subject.add_assoc(Association.new('q', expr))
+          subject.add_assoc('q', expr)
           expect(subject.fresh?(ref_q)).to be_falsey
         end
 
         it 'say not fresh when variable --> composite of atomics & bound var' do
           grandma.add_var('q')
           grandma.add_var('x')
-          subject.add_assoc(Association.new('x', pea)) # Dependency: x --> pea
+          subject.add_assoc('x', pea) # Dependency: x --> pea
           expr = cons(pea, cons(pod, cons(ref_x)))
-          subject.add_assoc(Association.new('q', expr))
+          subject.add_assoc('q', expr)
           expect(subject.fresh?(ref_q)).to be_falsey
         end
 
@@ -164,7 +169,7 @@ module MiniKraken
           grandma.add_var('q')
           grandma.add_var('x')
           expr = cons(pea, cons(pod, cons(ref_x)))
-          subject.add_assoc(Association.new('q', expr))
+          subject.add_assoc('q', expr)
           expect(subject.fresh?(ref_q)).to be_truthy
         end
 
@@ -173,13 +178,14 @@ module MiniKraken
           grandma.add_var('x')
 
           # Beware of cyclic structure
-          subject.add_assoc(Association.new('q', ref_x)) # Dependency: q --> x
-          subject.add_assoc(Association.new('x', ref_q)) # Dependency: x --> q
+          subject.add_assoc('q', ref_x) # Dependency: q --> x
+          subject.add_assoc('x', ref_q) # Dependency: x --> q
           expect(subject.fresh?(ref_x)).to be_truthy
           expect(subject.fresh?(ref_q)).to be_truthy
+          expect(subject.associations).to be_empty
 
           # Associate with an atomic term
-          subject.add_assoc(Association.new('x', pea))
+          subject.add_assoc('x', pea)
           expect(subject.fresh?(ref_q)).to be_falsey
         end
 
@@ -190,16 +196,16 @@ module MiniKraken
             expect(subject.get_rank('c')).to eq(2)
           end
         end
-        
+
         it 'should clear the rankings' do
           expect(subject.get_rank('a')).to eq(0)
           expect(subject.get_rank('z')).to eq(1)
-          
+
           subject.clear_rankings
           expect(grandma.rankings).to be_empty
 
-          expect(subject.get_rank('z')).to eq(0)    
-          expect(subject.get_rank('a')).to eq(1)          
+          expect(subject.get_rank('z')).to eq(0)
+          expect(subject.get_rank('a')).to eq(1)
         end
       end # context
     end # describe

data/spec/glue/fresh_env_spec.rb

@@ -3,7 +3,9 @@
 require_relative '../spec_helper' # Use the RSpec framework
 require_relative '../../lib/mini_kraken/core/goal'
 require_relative '../../lib/mini_kraken/core/equals'
+require_relative '../../lib/mini_kraken/core/fail'
 require_relative '../../lib/mini_kraken/core/k_symbol'
+require_relative '../../lib/mini_kraken/core/succeed'
 
 # Load the class under test
 require_relative '../../lib/mini_kraken/glue/fresh_env'
@@ -15,17 +17,41 @@ module MiniKraken
       let(:pea) { Core::KSymbol.new(:pea) }
       let(:pod) { Core::KSymbol.new(:pod) }
       let(:sample_goal) do
-        Core::Goal.new(Core::Equals.instance, [pea, pod]) 
+        Core::Goal.new(Core::Equals.instance, [pea, pod])
       end
+      let(:pea_goal) do
+        Core::Goal.new(Core::Equals.instance, [pea, pea])
+      end
+      let(:goal_succeeds) { Core::Goal.new(Core::Succeed.instance, []) }
+      let(:goal_fails) { Core::Goal.new(Core::Fail.instance, []) }
       subject { FreshEnv.new(['q'], sample_goal) }
 
       context 'Initialization:' do
-        it 'should be initialized with an array of names' do
+        it 'could be initialized with names and a goal' do
           expect { FreshEnv.new(['q'], sample_goal) }.not_to raise_error
         end
 
+        it 'could be  initialized with names and goals' do
+          expect { FreshEnv.new(%w[x y], [pea_goal, goal_succeeds]) }.not_to raise_error
+        end
+
         it 'should know its variables' do
           expect(subject.vars['q']).not_to be_nil
+
+          instance = FreshEnv.new(%w[x y], sample_goal)
+          expect(instance.vars['x']).not_to be_nil
+          expect(instance.vars['y']).not_to be_nil
+        end
+
+        it 'should know its goal' do
+          # Single goal at initialization
+          expect(subject.goal).to eq(sample_goal)
+
+          # Multiple goals at initialization
+          instance = FreshEnv.new(['q'], [pea_goal, goal_succeeds])
+          expect(instance.goal.relation.name).to eq('conj2')
+          expect(instance.goal.actuals[0]).to eq(pea_goal)
+          expect(instance.goal.actuals[1]).to eq(goal_succeeds)
         end
       end # context
 

data/spec/glue/run_star_expression_spec.rb

@@ -2,6 +2,8 @@
 
 require_relative '../spec_helper' # Use the RSpec framework
 require_relative '../../lib/mini_kraken/core/goal'
+require_relative '../../lib/mini_kraken/core/conj2'
+require_relative '../../lib/mini_kraken/core/disj2'
 require_relative '../../lib/mini_kraken/core/equals'
 require_relative '../../lib/mini_kraken/core/fail'
 require_relative '../../lib/mini_kraken/core/succeed'
@@ -19,16 +21,26 @@ module MiniKraken
       let(:pea) { k_symbol(:pea) }
       let(:pod) { k_symbol(:pod) }
       let(:sample_goal) { equals_goal(pea, pod) }
+      let(:fails) { Core::Goal.new(Core::Fail.instance, []) }
+      let(:succeeds) { Core::Goal.new(Core::Succeed.instance, []) }
       subject { RunStarExpression.new('q', sample_goal) }
 
       context 'Initialization:' do
-        it 'should be initialized with a name and a goal' do
+        it 'could be initialized with a name and a goal' do
           expect { RunStarExpression.new('q', sample_goal) }.not_to raise_error
         end
 
+        it 'could be initialized with multiple names and a goal' do
+          expect { RunStarExpression.new(%w[r x y], sample_goal) }.not_to raise_error
+        end
+
+        it 'could be initialized with multiple names and goals' do
+          expect { RunStarExpression.new(%w[r x y], [succeeds, succeeds]) }.not_to raise_error
+        end
+
         it 'should know its variables' do
           expect(subject.env.vars['q']).not_to be_nil
-          expect(subject.var.name).to eq('q')
+          expect(subject.env.vars.values[0].name).to eq('q')
         end
 
         it 'should know its goal' do
@@ -37,24 +49,33 @@ module MiniKraken
       end # context
 
       context 'Provided services:' do
+        let(:bean) { k_symbol(:bean) }
+        let(:corn) { k_symbol(:corn) }
+        let(:meal) { k_symbol(:meal) }
+        let(:oil) { k_symbol(:oil) }
+        let(:olive) { k_symbol(:olive) }
+        let(:red) { k_symbol(:red) }
+        let(:soup) { k_symbol(:soup) }
+        let(:split) { k_symbol(:split) }
+        let(:virgin) { k_symbol(:virgin) }
         let(:ref_q) { Core::VariableRef.new('q') }
+        let(:ref_r) { Core::VariableRef.new('r') }
         let(:ref_x) { Core::VariableRef.new('x') }
         let(:ref_y) { Core::VariableRef.new('y') }
         let(:ref_s) { Core::VariableRef.new('s') }
         let(:ref_t) { Core::VariableRef.new('t') }
-        let(:ref_u) { Core::VariableRef.new('u') }        
+        let(:ref_u) { Core::VariableRef.new('u') }
 
-        it "should return a null list with the fail goal" do
+        it 'should return a null list with the fail goal' do
           # Reasoned S2, frame 1:7
           # (run* q #u) ;; => ()
           failing = Core::Goal.new(Core::Fail.instance, [])
           instance = RunStarExpression.new('q', failing)
 
           expect(instance.run).to be_null
-          expect(ref_q.fresh?(instance.env)).to be_truthy
         end
 
-        it "should return a null list when a goal fails" do
+        it 'should return a null list when a goal fails' do
           # Reasoned S2, frame 1:10
           # (run* q (== 'pea 'pod) ;; => ()
 
@@ -69,7 +90,6 @@ module MiniKraken
           # Reasoned S2, frame 1:11
           # (run* q (== q 'pea) ;; => (pea)
           expect(instance.run.car).to eq(pea)
-          expect(ref_q.fresh?(instance.env)).to be_falsey
         end
 
         it 'should unify the righthand variable(s)' do
@@ -79,19 +99,14 @@ module MiniKraken
           # Reasoned S2, frame 1:12
           # (run* q (== 'pea q) ;; => (pea)
           expect(instance.run.car).to eq(pea)
-
-          # Reasoned S2, frame 1:15
-          expect(ref_q.fresh?(instance.env)).to be_falsey
         end
 
         it 'should return a null list with the succeed goal' do
-          success = Core::Goal.new(Core::Succeed.instance, [])
-          instance = RunStarExpression.new('q', success)
+          instance = RunStarExpression.new('q', succeeds)
 
           # (display (run* q succeed)) ;; => (_0)
           # Reasoned S2, frame 1:16
           result = instance.run
-          expect(ref_q.fresh?(instance.env)).to be_truthy
 
           # Reasoned S2, frame 1:17
           expect(result.car).to eq(any_value(0))
@@ -104,7 +119,6 @@ module MiniKraken
           # (display (run* q (== 'pea 'pea))) ;; => (_0)
           # Reasoned S2, frame 1:19
           result = instance.run
-          expect(ref_q.fresh?(instance.env)).to be_truthy
           expect(result.car).to eq(any_value(0))
         end
 
@@ -117,7 +131,6 @@ module MiniKraken
           # (display (run* q (== q q))) ;; => (_0)
           # Reasoned S2, frame 1:20
           result = instance.run
-          expect(ref_q.fresh?(instance.env)).to be_truthy
           expect(result.car).to eq(any_value(0))
         end
 
@@ -129,8 +142,6 @@ module MiniKraken
           # Reasoned S2, frame 1:21..23
           # (run* q (fresh (x) (== 'pea q))) ;; => (pea)
           result = instance.run
-          expect(ref_q.fresh?(instance.env)).to be_falsey
-          expect(ref_x.fresh?(fresh_env)).to be_truthy
 
           #  Reasoned S2, frame 1:40
           expect(ref_q.different_from?(ref_x, fresh_env)).to be_truthy
@@ -145,8 +156,6 @@ module MiniKraken
           # Reasoned S2, frame 1:24
           # (run* q (fresh (x) (== 'pea x))) ;; => (_0)
           result = instance.run
-          expect(ref_q.fresh?(instance.env)).to be_truthy
-          expect(ref_x.fresh?(fresh_env)).to be_falsey
           expect(result.car).to eq(any_value(0))
         end
 
@@ -158,8 +167,6 @@ module MiniKraken
           # Reasoned S2, frame 1:25
           # (run* q (fresh (x) (== (cons x '()) q))) ;; => ((_0))
           result = instance.run
-          expect(ref_q.fresh?(instance.env)).to be_truthy
-          expect(ref_x.fresh?(fresh_env)).to be_truthy
           expect(result.car).to eq(cons(any_value(0)))
         end
 
@@ -190,7 +197,6 @@ module MiniKraken
           # Reasoned S2, frame 1:32
           # (run* q (==  '(((pea)) pod) '(((pea)) pod))) ;; => (_0)
           result = instance.run
-          expect(ref_q.fresh?(instance.env)).to be_truthy
           expect(result.car).to eq(any_value(0))
         end
 
@@ -204,7 +210,6 @@ module MiniKraken
           # Reasoned S2, frame 1:33
           # (run* q (==  '(((pea)) pod) `(((pea)) ,q))) ;; => ('pod)
           result = instance.run
-          expect(ref_q.fresh?(instance.env)).to be_falsey
           expect(result.car).to eq(pod)
         end
 
@@ -217,7 +222,6 @@ module MiniKraken
           # Reasoned S2, frame 1:34
           # (run* q (==  '(((,q)) pod) `(((pea)) pod))) ;; => ('pod)
           result = instance.run
-          expect(ref_q.fresh?(instance.env)).to be_falsey
           expect(result.car).to eq(pea)
         end
 
@@ -231,8 +235,6 @@ module MiniKraken
           # Reasoned S2, frame 1:35
           # (run* q (fresh (x) (==  '(((,q)) pod) `(((,x)) pod)))) ;; => (_0)
           result = instance.run
-          expect(ref_q.fresh?(instance.env)).to be_truthy
-          expect(ref_x.fresh?(fresh_env)).to be_truthy
           expect(result.car).to eq(any_value(0))
         end
 
@@ -246,11 +248,6 @@ module MiniKraken
           instance = RunStarExpression.new('q', fresh_env)
 
           result = instance.run
-
-          # Does propagate work correctly?
-          expect(ref_q.fresh?(instance.env)).to be_truthy # x isn't defined here
-          expect(ref_q.fresh?(fresh_env)).to be_falsey
-          expect(ref_x.fresh?(fresh_env)).to be_falsey
           expect(result.car).to eq(pod)
         end
 
@@ -263,9 +260,6 @@ module MiniKraken
           instance = RunStarExpression.new('q', fresh_env)
 
           result = instance.run
-          expect(ref_q.fresh?(instance.env)).to be_truthy # x isn't defined here
-          expect(ref_q.fresh?(fresh_env)).to be_truthy
-          expect(ref_x.fresh?(fresh_env)).to be_truthy
           expect(result.car).to eq(cons(any_value(0), cons(any_value(0))))
         end
 
@@ -280,17 +274,16 @@ module MiniKraken
           instance = RunStarExpression.new('q', fresh_env_x)
 
           result = instance.run
-          expect(ref_q.fresh?(fresh_env_y)).to be_truthy
-          expect(ref_q.bound?(fresh_env_y)).to be_truthy
-          expect(ref_x.fresh?(fresh_env_y)).to be_truthy
-          expect(ref_x.bound?(fresh_env_y)).to be_truthy
-          expect(ref_y.fresh?(fresh_env_y)).to be_truthy
-          expect(ref_y.bound?(fresh_env_y)).to be_truthy
 
           # y should be fused with x...
+          var_x = fresh_env_y.name2var('x')
+          var_y = fresh_env_y.name2var('y')
+          expect(var_x.i_name).to eq(var_y.i_name)
           expect(ref_y.fused_with?(ref_x, fresh_env_y)).to be_truthy
           expect(ref_x.names_fused(fresh_env_y)).to eq(['y'])
           expect(ref_y.names_fused(fresh_env_y)).to eq(['x'])
+
+          # q should be bound to '(,x ,x)
           expect(result.car).to eq(cons(any_value(0), cons(any_value(0))))
         end
 
@@ -304,16 +297,10 @@ module MiniKraken
           instance = RunStarExpression.new('q', fresh_env_x)
 
           result = instance.run
-          expect(ref_q.fresh?(fresh_env_y)).to be_truthy
           # q should be bound to '(,x ,y)
-          expect(ref_q.bound?(fresh_env_y)).to be_truthy
-          expect(ref_x.fresh?(fresh_env_y)).to be_truthy
-          expect(ref_x.bound?(fresh_env_y)).to be_falsey
-          expect(ref_y.fresh?(fresh_env_y)).to be_truthy
-          expect(ref_y.bound?(fresh_env_y)).to be_falsey
           expect(result.car).to eq(cons(any_value(0), cons(any_value(1))))
         end
-        
+
         it 'should work with variable names' do
           # Reasoned S2, frame 1:42
           # (run* s (fresh (t) (fresh (u) (==  '( ,t ,u) s)))) ;; => (_0 _1)
@@ -324,15 +311,9 @@ module MiniKraken
           instance = RunStarExpression.new('s', fresh_env_t)
 
           result = instance.run
-          expect(ref_s.fresh?(fresh_env_u)).to be_truthy
           # s should be bound to '(,t ,u)
-          expect(ref_s.bound?(fresh_env_u)).to be_truthy
-          expect(ref_t.fresh?(fresh_env_u)).to be_truthy
-          expect(ref_t.bound?(fresh_env_u)).to be_falsey
-          expect(ref_u.fresh?(fresh_env_u)).to be_truthy
-          expect(ref_u.bound?(fresh_env_u)).to be_falsey
           expect(result.car).to eq(cons(any_value(0), cons(any_value(1))))
-        end  
+        end
 
         it 'should support repeated variables' do
           # Reasoned S2, frame 1:43
@@ -344,13 +325,343 @@ module MiniKraken
           instance = RunStarExpression.new('q', fresh_env_x)
 
           result = instance.run
-          expect(ref_q.fresh?(fresh_env_y)).to be_truthy
           # q should be bound to '(,x ,y, ,x)
-          expect(ref_q.bound?(fresh_env_y)).to be_truthy
-          expect(ref_x.fresh?(fresh_env_y)).to be_truthy
-          expect(ref_y.fresh?(fresh_env_y)).to be_truthy
           expect(result.car).to eq(cons(any_value(0), cons(any_value(1), cons(any_value(0)))))
-        end        
+        end
+
+        it 'should support conjunction of two succeed' do
+          goal = conj2_goal(succeeds, succeeds)
+          instance = RunStarExpression.new('q', goal)
+
+          # Reasoned S2, frame 1:50
+          # (run* q (conj2 succeed succeed)) ;; => (_0)
+          result = instance.run
+          expect(result.car).to eq(any_value(0))
+        end
+
+        # TODO: fix erratic RSpec failure
+        it 'should support conjunction of one succeed and a successful goal' do
+          subgoal = equals_goal(corn, ref_q)
+          goal = conj2_goal(succeeds, subgoal)
+          instance = RunStarExpression.new('q', goal)
+
+          # Reasoned S2, frame 1:51
+          # (run* q (conj2 succeed (== 'corn q)) ;; => ('corn)
+          result = instance.run
+          expect(result.car).to eq(corn)
+        end
+
+        it 'should support conjunction of one fail and a successful goal' do
+          subgoal = equals_goal(corn, ref_q)
+          goal = conj2_goal(fails, subgoal)
+          instance = RunStarExpression.new('q', goal)
+
+          # Reasoned S2, frame 1:52
+          # (run* q (conj2 fail (== 'corn q)) ;; => ()
+          expect(instance.run).to be_null
+        end
+
+        it 'should support conjunction of two contradictory goals' do
+          subgoal1 = equals_goal(corn, ref_q)
+          subgoal2 = equals_goal(meal, ref_q)
+          goal = conj2_goal(subgoal1, subgoal2)
+          instance = RunStarExpression.new('q', goal)
+
+          # Reasoned S2, frame 1:53
+          # (run* q (conj2 (== 'corn q)(== 'meal q)) ;; => ()
+          expect(instance.run).to be_null
+        end
+
+        it 'should succeed the conjunction of two identical goals' do
+          subgoal1 = equals_goal(corn, ref_q)
+          subgoal2 = equals_goal(corn, ref_q)
+          goal = conj2_goal(subgoal1, subgoal2)
+          instance = RunStarExpression.new('q', goal)
+
+          # Reasoned S2, frame 1:54
+          # (run* q (conj2 (== 'corn q)(== 'corn q)) ;; => ('corn)
+          result = instance.run
+          expect(result.car).to eq(corn)
+        end
+
+        it 'should not yield solution when both disjunction arguments fail' do
+          goal = disj2_goal(fails, fails)
+          instance = RunStarExpression.new('q', goal)
+
+          # Reasoned S2, frame 1:55
+          # (run* q (disj2 fail fail)) ;; => ()
+          expect(instance.run).to be_null
+        end
+
+        it 'should yield solution when first argument succeed' do
+          subgoal = Core::Goal.new(Core::Equals.instance, [olive, ref_q])
+          goal = disj2_goal(subgoal, fails)
+          instance = RunStarExpression.new('q', goal)
+
+          # Reasoned S2, frame 1:56
+          # (run* q (disj2 (== 'olive q) fail)) ;; => ('olive)
+          result = instance.run
+          expect(result.car).to eq(olive)
+        end
+
+        it 'should yield solution when second argument succeed' do
+          subgoal = Core::Goal.new(Core::Equals.instance, [oil, ref_q])
+          goal = disj2_goal(fails, subgoal)
+          instance = RunStarExpression.new('q', goal)
+
+          # Reasoned S2, frame 1:57
+          # (run* q (disj2 fail (== 'oil q))) ;; => (oil)
+          result = instance.run
+          expect(result.car).to eq(oil)
+        end
+
+        it 'should yield solutions when both arguments succeed' do
+          subgoal1 = Core::Goal.new(Core::Equals.instance, [olive, ref_q])
+          subgoal2 = Core::Goal.new(Core::Equals.instance, [oil, ref_q])
+          goal = disj2_goal(subgoal1, subgoal2)
+          instance = RunStarExpression.new('q', goal)
+
+          # Reasoned S2, frame 1:58
+          # (run* q (disj2 (== 'olive q) (== 'oil q))) ;; => (olive oil)
+          result = instance.run
+          expect(result.car).to eq(olive)
+          expect(result.cdr.car).to eq(oil)
+        end
+
+        it 'should support the nesting of variables and disjunction' do
+          # Reasoned S2, frame 1:59
+          # (run* q (fresh (x) (fresh (y) (disj2  (== '( ,x ,y ) q) (== '( ,x ,y ) q)))))
+          # ;; => ((_0 _1) (_0 _1))
+          expr1 = cons(ref_x, cons(ref_y))
+          subgoal1 = equals_goal(expr1, ref_q)
+          expr2 = cons(ref_y, cons(ref_x))
+          subgoal2 = equals_goal(expr2, ref_q)
+          goal = disj2_goal(subgoal1, subgoal2)
+          fresh_env_y = FreshEnv.new(['y'], goal)
+          fresh_env_x = FreshEnv.new(['x'], fresh_env_y)
+          instance = RunStarExpression.new('q', fresh_env_x)
+
+          result = instance.run
+          # q should be bound to '(,x ,y), then to '(,y ,x)
+          expect(result.car).to eq(cons(any_value(0), cons(any_value(1))))
+          expect(result.cdr.car).to eq(cons(any_value(0), cons(any_value(1))))
+        end
+
+        it 'should accept nesting of disj2 and conj2 (I)' do
+          conj_subgoal = Core::Goal.new(Core::Equals.instance, [olive, ref_x])
+          conjunction = conj2_goal(conj_subgoal, fails)
+          subgoal = Core::Goal.new(Core::Equals.instance, [oil, ref_x])
+          goal = disj2_goal(conjunction, subgoal)
+          instance = RunStarExpression.new('x', goal)
+
+          # Reasoned S2, frame 1:62
+          # (run* x (disj2
+          #           (conj2 (== 'olive x) fail)
+          #           ('oil x))) ;; => (oil)
+          result = instance.run
+          expect(result.car).to eq(oil)
+        end
+
+        it 'should accept nesting of disj2 and conj2 (II)' do
+          conj_subgoal = Core::Goal.new(Core::Equals.instance, [olive, ref_x])
+          conjunction = conj2_goal(conj_subgoal, succeeds)
+          subgoal = Core::Goal.new(Core::Equals.instance, [oil, ref_x])
+          goal = disj2_goal(conjunction, subgoal)
+          instance = RunStarExpression.new('x', goal)
+
+          # Reasoned S2, frame 1:63
+          # (run* x (disj2
+          #           (conj2 (== 'olive x) succeed)
+          #           ('oil x))) ;; => (olive oil)
+          result = instance.run
+          expect(result.car).to eq(olive)
+          expect(result.cdr.car).to eq(oil)
+        end
+
+        it 'should accept nesting of disj2 and conj2 (III)' do
+          conj_subgoal = Core::Goal.new(Core::Equals.instance, [olive, ref_x])
+          conjunction = conj2_goal(conj_subgoal, succeeds)
+          subgoal = Core::Goal.new(Core::Equals.instance, [oil, ref_x])
+          goal = disj2_goal(subgoal, conjunction)
+          instance = RunStarExpression.new('x', goal)
+
+          # Reasoned S2, frame 1:64
+          # (run* x (disj2
+          #           ('oil x)
+          #           (conj2 (== 'olive x) succeed))) ;; => (oil olive)
+          result = instance.run
+          expect(result.car).to eq(oil)
+          expect(result.cdr.car).to eq(olive)
+        end
+
+        it 'should accept nesting of disj2 and conj2 (IV)' do
+          oil_goal = Core::Goal.new(Core::Equals.instance, [oil, ref_x])
+          disja = disj2_goal(succeeds, oil_goal)
+          olive_goal = Core::Goal.new(Core::Equals.instance, [olive, ref_x])
+          disjb = disj2_goal(olive_goal, disja)
+          virgin_goal = Core::Goal.new(Core::Equals.instance, [virgin, ref_x])
+          conjunction = conj2_goal(virgin_goal, fails)
+          goal = disj2_goal(conjunction, disjb)
+          instance = RunStarExpression.new('x', goal)
+
+          # Reasoned S2, frame 1:65
+          # (run* x (disj2
+          #           (conj2(== 'virgin x) fails)
+          #           (disj2
+          #             (== 'olive x)
+          #             (dis2
+          #               succeeds
+          #               (== 'oil x))))) ;; => (olive _0 oil)
+          result = instance.run
+          expect(result.car).to eq(olive)
+          expect(result.cdr.car).to eq(any_value(0))
+          expect(result.cdr.cdr.car).to eq(oil)
+        end
+
+        it 'should accept nesting fresh, disj2 and conj2 expressions (I)' do
+          subgoal1 = equals_goal(split, ref_x)
+          expr1 = equals_goal(pea, ref_y)
+          expr2 = equals_goal(cons(ref_x, cons(ref_y)), ref_r)
+          subgoal2 = conj2_goal(expr1, expr2)
+          goal = conj2_goal(subgoal1, subgoal2)
+          fresh_env_y = FreshEnv.new(['y'], goal)
+          fresh_env_x = FreshEnv.new(['x'], fresh_env_y)
+          instance = RunStarExpression.new('r', fresh_env_x)
+
+          # Reasoned S2, frame 1:67
+          # (run* r
+          #   (fresh x
+          #     (fresh y
+          #       (conj2
+          #           (== 'split x)
+          #           (conj2
+          #             (== 'pea y)
+          #             (== '(,x ,y) r)))))) ;; => ((split pea))
+          result = instance.run
+          expect(result.car.car).to eq(split)
+          expect(result.car.cdr.car).to eq(pea)
+        end
+
+        it 'should accept nesting fresh, disj2 and conj2 expressions (II)' do
+          expr1 = equals_goal(split, ref_x)
+          expr2 = equals_goal(pea, ref_y)
+          subgoal1 = conj2_goal(expr1, expr2)
+          subgoal2 = equals_goal(cons(ref_x, cons(ref_y)), ref_r)
+          goal = conj2_goal(subgoal1, subgoal2)
+          fresh_env_y = FreshEnv.new(['y'], goal)
+          fresh_env_x = FreshEnv.new(['x'], fresh_env_y)
+          instance = RunStarExpression.new('r', fresh_env_x)
+
+          # Reasoned S2, frame 1:68
+          # (run* r
+          #   (fresh x
+          #     (fresh y
+          #       (conj2
+          #         (conj2
+          #           (== 'split x)
+          #           (== 'pea y)
+          #         (== '(,x ,y) r)))))) ;; => ((split pea))
+          result = instance.run
+          expect(result.car.car).to eq(split)
+          expect(result.car.cdr.car).to eq(pea)
+        end
+
+        it 'should accept fresh with multiple variables' do
+          expr1 = equals_goal(split, ref_x)
+          expr2 = equals_goal(pea, ref_y)
+          subgoal1 = conj2_goal(expr1, expr2)
+          subgoal2 = equals_goal(cons(ref_x, cons(ref_y)), ref_r)
+          goal = conj2_goal(subgoal1, subgoal2)
+          fresh_env = FreshEnv.new(%w[x y], goal)
+          instance = RunStarExpression.new('r', fresh_env)
+
+          # Reasoned S2, frame 1:70
+          # (run* r
+          #   (fresh (x y)
+          #     (conj2
+          #       (conj2
+          #         (== 'split x)
+          #         (== 'pea y)
+          #       (== '(,x ,y) r))))) ;; => ((split pea))
+          result = instance.run
+          expect(result.car.car).to eq(split)
+          expect(result.car.cdr.car).to eq(pea)
+        end
+
+        it 'should accept multiple variables' do
+          expr1 = equals_goal(split, ref_x)
+          expr2 = equals_goal(pea, ref_y)
+          subgoal1 = conj2_goal(expr1, expr2)
+          subgoal2 = equals_goal(cons(ref_x, cons(ref_y)), ref_r)
+          goal = conj2_goal(subgoal1, subgoal2)
+          instance = RunStarExpression.new(%w[r x y], goal)
+
+          # Reasoned S2, frame 1:72
+          # (run* (r x y)
+          #   (conj2
+          #     (conj2
+          #       (== 'split x)
+          #       (== 'pea y))
+          #     (== '(,x ,y) r))) ;; => (((split pea) split pea))
+          #             o
+          #            / \
+          #            o  nil
+          #          /  \
+          #         /    \
+          #        /      \
+          #       /        \
+          #      /          \
+          #      o           o
+          #     / \         / \
+          # split  o   split   o
+          #       / \         / \
+          #    pea  nil     pea  nil
+          result = instance.run
+          expect(result.car.car.car).to eq(split)
+          expect(result.car.car.cdr.car).to eq(pea)
+          expect(result.car.car.cdr.cdr).to be_nil
+          expect(result.car.cdr.car).to eq(split)
+          expect(result.car.cdr.cdr.car).to eq(pea)
+          expect(result.car.cdr.cdr.cdr).to be_nil
+        end
+
+        it 'should allow simplication of expressions' do
+          expr1 = equals_goal(split, ref_x)
+          expr2 = equals_goal(pea, ref_y)
+          goal = conj2_goal(expr1, expr2)
+          instance = RunStarExpression.new(%w[x y], goal)
+
+          # Reasoned S2, frame 1:75
+          # (run* (x y)
+          #   (conj2
+          #     (== 'split x)
+          #     (== 'pea y))) ;; => ((split pea))
+          result = instance.run
+          expect(result.car.car).to eq(split)
+          expect(result.car.cdr.car).to eq(pea)
+        end
+
+        it 'should allow simplication of expressions' do
+          expr1 = equals_goal(split, ref_x)
+          expr2 = equals_goal(pea, ref_y)
+          subgoal1 = conj2_goal(expr1, expr2)
+          expr3 = equals_goal(red, ref_x)
+          expr4 = equals_goal(bean, ref_y)
+          subgoal2 = conj2_goal(expr3, expr4)
+          goal = disj2_goal(subgoal1, subgoal2)
+          instance = RunStarExpression.new(%w[x y], goal)
+
+          # Reasoned S2, frame 1:76
+          # (run* (x y)
+          #   (disj2
+          #     (conj2 (== 'split x) (== 'pea y))
+          #     (conj2 (== 'red x) (== 'bean y)))) ;; => ((split pea)(red bean))
+          result = instance.run
+          expect(result.car.car).to eq(split)
+          expect(result.car.cdr.car).to eq(pea)
+          expect(result.cdr.car.car).to eq(red)
+          expect(result.cdr.car.cdr.car).to eq(bean)
+        end
       end # context
     end # describe
   end # module