mini_histogram 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a1d07dadd88ba1bc23f7a24c225a8a7146a657f932122e4681843478ef61ec14
-  data.tar.gz: fed4add367a52b8dc55f67389877ed6444413c10899c6cb1979af262aa279f7c
+  metadata.gz: 0b30a210cd0f63b3f9cba87a75876fe936cbdb5ccb8f0d9130a3fbb7edabb253
+  data.tar.gz: 36bf1ad5fc457f2b8766ea3e902952a9aea49e4c48bc4c07828deac4c7a764e8
 SHA512:
-  metadata.gz: 407f81d19278447ed837bf983e7794a229eefeee71d5f68f1b1b20929e755057a5047296554c84ec0af6144f2340c6d08dd1770327aa1f28633b80ca01e5e0ef
-  data.tar.gz: 989f6b2acc56666c9c20c9bb05944a828ed2cef0cab0fc8a54fd7aa7ebb272e2ce7bbee37ecf465d489021be07cc1777e249d54f1fb088c4ffdfc754c3dddf60
+  metadata.gz: 1de6bd55a51f9b5dfa8e31b91a069a52aa6737f76ca9f7ae05f2a77e925ffd9f19e94751daa6f9bdc1026cfde9a7822e1dfccd8b6deaf281d200be2407df20b8
+  data.tar.gz: 765c3657976e4ca6a56570af53ba22ac7d3c7fd910d9cff8d5bbcc2059da7dd8f0c49323ca3469fc0482dfcd1ce07dc17d3a1151690c4a32aef0a46bc1b7583d

data/.github/workflows/check_changelog.yml

@@ -0,0 +1,10 @@
+name: Check Changelog
+on: [pull_request]
+jobs:
+ build:
+   runs-on: ubuntu-latest
+   steps:
+   - uses: actions/checkout@v1
+   - name: Check that CHANGELOG is touched
+     run: |
+       cat $GITHUB_EVENT_PATH | jq .pull_request.title |  grep -i '\[\(\(changelog skip\)\|\(ci skip\)\)\]' ||  git diff remotes/origin/${{ github.base_ref }} --name-only | grep CHANGELOG.md

data/.gitignore

@@ -6,3 +6,5 @@
 /pkg/
 /spec/reports/
 /tmp/
+
+Gemfile.lock

data/.travis.yml

@@ -7,4 +7,3 @@ rvm:
   - 2.5
   - 2.6
   - 2.7.0
-before_install: gem install bundler -v 2.1.2

data/CHANGELOG.md

@@ -0,0 +1,9 @@
+## Master
+
+## 0.1.1
+
+- Fix multi histogram weights, with set_average_edges! method (https://github.com/zombocom/mini_histogram/pull/1)
+
+## 0.1.0
+
+- First

data/README.md

@@ -1,4 +1,4 @@
-# MiniHistogram
+# MiniHistogram [![Build Status](https://travis-ci.org/zombocom/mini_histogram.svg?branch=master)](https://travis-ci.org/zombocom/mini_histogram)
 
 What's a histogram and why should you care? First read [Lies, Damned Lies, and Averages: Perc50, Perc95 explained for Programmers](https://schneems.com/2020/03/17/lies-damned-lies-and-averages-perc50-perc95-explained-for-programmers/). This library lets you build histograms in pure Ruby.
 

data/Rakefile

@@ -19,8 +19,8 @@ task :bench do
 
   array = 1000.times.map { rand }
 
-  edges = MiniHistogram.edges(array)
-  my_weights = MiniHistogram.counts_from_edges(array, edges: edges)
+  histogram = MiniHistogram.new(array)
+  my_weights = histogram.weights
   puts array.histogram.weights == my_weights
   puts array.histogram.weights.inspect
   puts my_weights.inspect
@@ -29,8 +29,7 @@ task :bench do
   Benchmark.ips do |x|
     x.report("enumerable stats") { array.histogram }
     x.report("mini histogram  ") {
-      edges = MiniHistogram.edges(array)
-      MiniHistogram.counts_from_edges(array, edges: edges)
+      MiniHistogram.new(array).weights
     }
     x.compare!
   end

data/lib/mini_histogram.rb

@@ -1,5 +1,4 @@
 require "mini_histogram/version"
-require 'math'
 
 # A class for building histogram info
 #
@@ -20,13 +19,14 @@ require 'math'
 #
 class MiniHistogram
   class Error < StandardError; end
-  attr_reader :array, :left_p
+  attr_reader :array, :left_p, :max
 
   def initialize(array, left_p: false, edges: nil)
     @array = array
     @left_p = left_p
     @edges = edges
     @weights = nil
+    @max = array.max
   end
 
   def edges_min
@@ -37,10 +37,19 @@ class MiniHistogram
     edges.max
   end
 
+  def histogram(*_)
+    self
+  end
+
+  def closed
+    :left
+  end
+
   # Sets the edge value to something new,
   # also clears any previously calculated values
-  def set_edges(value)
-    @edges = value
+  def update_values(edges:, max: )
+    @edges = edges
+    @max = max
     @weights = nil # clear memoized value
   end
 
@@ -81,7 +90,7 @@ class MiniHistogram
     lo = edges.first
     step = edges[1] - edges[0]
 
-    max_index = ((array.max  - lo) / step).floor
+    max_index = ((@max  - lo) / step).floor
     @weights = Array.new(max_index + 1, 0)
 
     array.each do |x|
@@ -194,6 +203,8 @@ class MiniHistogram
     steps = array_of_histograms.map(&:bin_size)
     avg_step_size = steps.inject(&:+).to_f / steps.length
 
+    max_value = array_of_histograms.map(&:max).max
+
     max_edge = array_of_histograms.map(&:edges_max).max
     min_edge = array_of_histograms.map(&:edges_min).min
 
@@ -202,7 +213,7 @@ class MiniHistogram
       average_edges << average_edges.last + avg_step_size
     end
 
-    array_of_histograms.each {|h| h.set_edges(average_edges) }
+    array_of_histograms.each {|h| h.update_values(edges: average_edges, max: max_value) }
 
     return array_of_histograms
   end

data/lib/mini_histogram/version.rb

@@ -1,3 +1,3 @@
 class MiniHistogram
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mini_histogram
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - schneems
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-03-21 00:00:00.000000000 Z
+date: 2020-03-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: m
@@ -32,11 +32,12 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/check_changelog.yml"
 - ".gitignore"
 - ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile

data/Gemfile.lock

@@ -1,26 +0,0 @@
-PATH
-  remote: .
-  specs:
-    mini_histogram (0.1.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    m (1.5.1)
-      method_source (>= 0.6.7)
-      rake (>= 0.9.2.2)
-    method_source (0.9.2)
-    minitest (5.14.0)
-    rake (12.3.3)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  m
-  mini_histogram!
-  minitest (~> 5.0)
-  rake (~> 12.0)
-
-BUNDLED WITH
-   2.1.2