mini_api 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 14a8f16f154f4f5c49499da422027fefd65c8c89b19ef9b59aef90dcf2f13f8c
-  data.tar.gz: 061a3a10595c82455343eab9c59f4bcf2a734ec5a2a04d69bd8ac5575b682096
+  metadata.gz: c6068dbc415de617d267b2e42d438eb85f36fdbbf0d083cf63efe86042130f96
+  data.tar.gz: 31f694de691b4c4d271d0d38273a5df7476aa6bb2118ecceadeca639ca7883f9
 SHA512:
-  metadata.gz: f295a7cf808f32dc15f06766259116e95f66e4ca7143777a4d32b20c6f11cb2e33a71355e474ac29d8c46e529cf1e4dc481fe9a1a1027f72ab4e0488116bcdaf
-  data.tar.gz: 85dc53237ece21101a3dd3ffd346e42e52327dabd3f06cc0592452cc69437fe95b5941f77913642c1ce61c33a359161edb08445a4d065bb929b401bb2cdf33c3
+  metadata.gz: 287a2711d205b18d07fb6295e36bf132ef64953aa6d91a2f2f8699fdecaf82cc5fe0cd3a2292235f523ecf36ce6983c40b6d99a3a5d89418fe295ef4c834275c
+  data.tar.gz: 8045d230ca7765a976b34ec73b5fe9020bdf7b40f662de12a1e1b5a0e72cd2c446c3d859f91e0921467c179eb6a6b0aa2fdc2af39dc3ba169586937775934d2f

data/README.md

@@ -3,7 +3,7 @@
 [![Test Coverage](https://api.codeclimate.com/v1/badges/ec2939be693459b7ce4d/test_coverage)](https://codeclimate.com/github/leoncruz/api-responder/test_coverage)
 
 # Mini Api
-A gem to standardize json responses in Rails applications, highly inspired on [Responders](https:github.com/heartcombo/responders)
+A gem to standardize json responses in Rails applications, highly inspired on [Responders](https://github.com/heartcombo/responders)
 
 ## Table of Contents
 - [Usage](#usage)

data/lib/mini_api/model_responder.rb

@@ -23,9 +23,13 @@ module MiniApi
         if resource_has_errors?
           { errors: @resource.errors.messages }.merge(body)
         else
-          { data: serialiable_body(@resource) }.merge(body)
+          { data: serialiable_body(@resource).as_json }.merge(body)
         end
 
+      # This is for an problem with ActiveModelSerializer that adds an error
+      # attribute when resource is an ActiveModel instance
+      body[:data] = body[:data].except('errors') if body[:data]&.key?('errors')
+
       @controller.render json: body, status: status_code
     end
 
@@ -40,9 +44,9 @@ module MiniApi
 
       return :unprocessable_entity if resource_has_errors?
 
-      return :created if @resource.previously_new_record?
+      return :created if previously_new_record?
 
-      return :no_content unless @resource.persisted?
+      return :no_content if destroyed?
 
       :ok
     end
@@ -57,5 +61,17 @@ module MiniApi
         default: ''
       )
     end
+
+    def previously_new_record?
+      return true if @resource.is_a?(ActiveRecord::Base) && @resource.previously_new_record?
+
+      false
+    end
+
+    def destroyed?
+      return true if @resource.is_a?(ActiveRecord::Base) && !@resource.persisted?
+
+      false
+    end
   end
 end

data/lib/mini_api/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MiniApi
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mini_api
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Leon Cruz
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-17 00:00:00.000000000 Z
+date: 2023-06-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails