mingle_events 0.1.7 → 0.1.8

data/test/mingle_events/processors/card_type_filter_test.rb

@@ -2,48 +2,44 @@ require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'test_hel
 
 module MingleEvents
   module Processors
-    
-    class CardTypeFilterTest < Test::Unit::TestCase
-      
-      def setup      
-        @story_event = stub_event(true)
+
+    class CardTypeFilterTest < MiniTest::Test
+
+      def setup
+        @story_event = stub_event(true, {:card_type_name => 'story'})
         @page_event = stub_event(false)
-        @bug_event = stub_event(true)
-        @issue_event = stub_event(true)
-        
-        @card_data = {
-          @story_event => {:card_type_name => 'story'},
-          @bug_event => {:card_type_name => 'bug'},
-          @issue_event => {:card_type_name => 'issue'}
-        }
+        @bug_event = stub_event(true, {:card_type_name => 'bug'})
+        @issue_event = stub_event(true, {:card_type_name => 'issue'})
+
+        @card_data = {}
         def @card_data.for_card_event(card_event)
-          self[card_event]
+          card_event.data
         end
-        
+
         @filter = CardTypeFilter.new(['story', 'issue'], @card_data)
       end
-      
+
       def test_does_not_match_non_card_events
         assert !@filter.match?(@page_event)
       end
-  
+
       def test_match_on_card_type
         assert @filter.match?(@story_event)
         assert @filter.match?(@issue_event)
         assert !@filter.match?(@bug_event)
       end
-      
+
       def test_does_not_match_deleted_cards
-        @card_data[@story_event] = nil
+        @story_event.data = nil
         assert !@filter.match?(@story_event)
       end
-      
+
       private
-      
-      def stub_event(is_card)
-        OpenStruct.new(:card? => is_card)
+
+      def stub_event(is_card, data=nil)
+        OpenStruct.new(:card? => is_card, :data => data)
       end
-      
+
     end
   end
 end

data/test/mingle_events/processors/category_filter_test.rb

@@ -2,8 +2,8 @@ require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'test_hel
 
 module MingleEvents
   module Processors
-    class CategoryFilterTest < Test::Unit::TestCase
-        
+    class CategoryFilterTest < MiniTest::Test
+
       def test_match_against_one_category
         filter = CategoryFilter.new([Feed::Category::CARD])
         assert filter.match?(stub_event(1, [Feed::Category::CARD, Feed::Category::COMMENT_ADDITION]))
@@ -11,16 +11,16 @@ module MingleEvents
         assert !filter.match?(stub_event(1, [Feed::Category::COMMENT_ADDITION]))
         assert !filter.match?(stub_event(1, [Feed::Category::REVISION_COMMIT, Feed::Category::COMMENT_ADDITION]))
       end
-      
+
       def test_match_against_multiple_categories
         filter = CategoryFilter.new([Feed::Category::CARD, Feed::Category::COMMENT_ADDITION])
         assert filter.match?(stub_event(1, [Feed::Category::CARD, Feed::Category::COMMENT_ADDITION]))
         assert !filter.match?(stub_event(1, [Feed::Category::CARD]))
         assert !filter.match?(stub_event(1, [Feed::Category::REVISION_COMMIT, Feed::Category::COMMENT_ADDITION]))
       end
-      
-      private 
-  
+
+      private
+
       def stub_event(id, categories)
         OpenStruct.new(:entry_id => id, :categories => categories)
       end

data/test/mingle_events/processors/custom_property_filter_test.rb

@@ -2,24 +2,20 @@ require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'test_hel
 
 module MingleEvents
   module Processors
-    
-    class CustomPropertyFilterTest < Test::Unit::TestCase
-  
+
+    class CustomPropertyFilterTest < MiniTest::Test
+
       def setup
-        @high_priority_event = stub_event(true)
+        @high_priority_event = stub_event(true, :custom_properties => {'Priority' => 'High'})
         @page_event = stub_event(false)
-        @low_priority_event = stub_event(true)
-        @high_severity_event = stub_event(true)
-        
-        @card_data = {
-          @high_priority_event => {:custom_properties => {'Priority' => 'High'}},
-          @low_priority_event => {:custom_properties => {'Priority' => 'Low'}},
-          @high_severity_event => {:custom_properties => {'Severity' => 'High'}}
-        }
+        @low_priority_event = stub_event(true, :custom_properties => {'Priority' => 'Low'})
+        @high_severity_event = stub_event(true, :custom_properties => {'Severity' => 'High'})
+
+        @card_data = {}
         def @card_data.for_card_event(card_event)
-          self[card_event]
+          card_event.data
         end
-        
+
         @filter = CustomPropertyFilter.new('Priority', 'High', @card_data)
       end
 
@@ -28,18 +24,18 @@ module MingleEvents
         assert !@filter.match?(@low_priority_event)
         assert !@filter.match?(@high_severity_event)
       end
-      
+
       def test_does_not_match_delete_card
-        @card_data[@high_priority_event] = nil
+        @high_priority_event.data = nil
         assert !@filter.match?(@high_priority_event)
       end
-              
+
       private
-      
-      def stub_event(is_card)
-        OpenStruct.new(:card? => is_card)
+
+      def stub_event(is_card, data=nil)
+        OpenStruct.new(:card? => is_card, :data => data)
       end
-      
+
     end
   end
 end

data/test/mingle_events/processors/filter_test.rb

@@ -2,12 +2,12 @@ require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'test_hel
 
 module MingleEvents
   module Processors
-    class FilterTest < Test::Unit::TestCase  
-      
+    class FilterTest < MiniTest::Test
+
       def test_returns_events_that_match
         assert_equal([0,2,4], MatchEvenFilter.new.process_events([0,1,2,3,4,5]))
       end
-      
+
       class MatchEvenFilter < Filter
         def match?(event)
           event % 2 == 0

data/test/mingle_events/processors/pipeline_test.rb

@@ -2,19 +2,19 @@ require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'test_hel
 
 module MingleEvents
   module Processors
-    class PipelineTest < Test::Unit::TestCase  
-      
+    class PipelineTest < MiniTest::Test
+
       def test_chains_all_processors
         events = [stub_event(100), stub_event(101), stub_event(102)]
         pipeline = Pipeline.new([DeleteLastProcessor.new, ReversingProcessor.new])
         processed_events = pipeline.process_events(events)
         assert_equal([101, 100], processed_events.map(&:entry_id))
       end
-  
+
       def stub_event(id)
         OpenStruct.new(:entry_id => id)
       end
-      
+
       class ReversingProcessor
         def process_events(events)
           events.reverse

data/test/mingle_events/processors/processor_test.rb

@@ -2,12 +2,12 @@ require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'test_hel
 
 module MingleEvents
   module Processors
-    class ProcessorTest < Test::Unit::TestCase  
-      
+    class ProcessorTest < MiniTest::Test
+
       def test_returns_events_that_match
         assert_equal([0,2,4], DoubleProcessor.new.process_events([0,1,2]))
       end
-      
+
       class DoubleProcessor < Processor
         def process(event)
           event * 2

data/test/mingle_events/project_custom_properties_test.rb

@@ -1,38 +1,38 @@
 require File.expand_path(File.join(File.dirname(__FILE__), '..', 'test_helper'))
 
 module MingleEvents
-  
-  class ProjectCustomPropertiesTest < Test::Unit::TestCase
-  
+
+  class ProjectCustomPropertiesTest < MiniTest::Test
+
     def test_can_lookup_property_name_by_column_name
-      property_definitions_xml = %{<?xml version="1.0" encoding="UTF-8"?> 
-        <property_definitions type="array"> 
-          <property_definition> 
-            <name>Account</name> 
-            <data_type>string</data_type> 
-            <is_numeric type="boolean">false</is_numeric> 
-            <column_name>cp_account</column_name> 
-          </property_definition> 
-          <property_definition> 
-            <name>Account ID</name> 
-            <data_type>string</data_type> 
-            <is_numeric type="boolean">false</is_numeric> 
-            <column_name>cp_account_id</column_name> 
-          </property_definition> 
-        </property_definitions>       
+      property_definitions_xml = %{<?xml version="1.0" encoding="UTF-8"?>
+        <property_definitions type="array">
+          <property_definition>
+            <name>Account</name>
+            <data_type>string</data_type>
+            <is_numeric type="boolean">false</is_numeric>
+            <column_name>cp_account</column_name>
+          </property_definition>
+          <property_definition>
+            <name>Account ID</name>
+            <data_type>string</data_type>
+            <is_numeric type="boolean">false</is_numeric>
+            <column_name>cp_account_id</column_name>
+          </property_definition>
+        </property_definitions>
       }
-      
+
       dummy_mingle_access = StubMingleAccess.new
       dummy_mingle_access.register_page_content(
         URIParser.escape('/api/v2/projects/atlas/property_definitions.xml'),
         property_definitions_xml
       )
-      
+
       project_custom_properties = ProjectCustomProperties.new(dummy_mingle_access, "atlas")
       assert_equal("Account ID", project_custom_properties.property_name_for_column("cp_account_id"))
-      
+
     end
-    
+
   end
-  
+
 end

data/test/mingle_events/project_event_fetcher_test.rb

@@ -1,25 +1,25 @@
 require File.expand_path(File.join(File.dirname(__FILE__), '..', 'test_helper'))
 
 module MingleEvents
-  class ProjectEventFetcherTest < Test::Unit::TestCase
-    
+  class ProjectEventFetcherTest < MiniTest::Test
+
     def test_can_fetch_all_entries_and_write_to_disk_when_no_initial_state
       state_dir = temp_dir
-      fetcher = ProjectEventFetcher.new('atlas', stub_mingle_access, state_dir)  
-      
+      fetcher = ProjectEventFetcher.new('atlas', stub_mingle_access, state_dir)
+
       latest_entries = fetcher.fetch_latest
       expected_latest_entries = [23, 97, 98, 99, 100, 101, 103].map{|n| entry(n)}
       assert_equal(expected_latest_entries, latest_entries.to_a)
       assert_equal entry(23), fetcher.first_entry_fetched
       assert_equal entry(103), fetcher.last_entry_fetched
     end
-    
+
     def test_can_fetch_all_entries_and_write_to_disk_when_existing_state
       state_dir = temp_dir
       fetcher = ProjectEventFetcher.new('atlas', stub_mingle_access, state_dir)
-      
+
       setup_current_state(23, 97, 97, fetcher)
-      
+
       latest_entries = fetcher.fetch_latest
       expected_latest_entries = [98, 99, 100, 101, 103].map{|n| entry(n)}
 
@@ -27,7 +27,7 @@ module MingleEvents
       assert_equal entry(23), fetcher.first_entry_fetched
       assert_equal entry(103), fetcher.last_entry_fetched
     end
-    
+
     def test_should_connect_existing_entries_and_newly_fetched_entries
       state_dir = temp_dir
       access = stub_mingle_access
@@ -93,18 +93,18 @@ module MingleEvents
       assert_equal entry(23), fetcher.first_entry_fetched
       assert_equal entry(103), fetcher.last_entry_fetched
     end
-    
+
     def test_no_new_entries_with_no_current_state
       state_dir = temp_dir
       mingle_access = StubMingleAccess.new
       mingle_access.register_page_content('/api/v2/projects/atlas/feeds/events.xml', EMPTY_EVENTS_XML)
       fetcher = ProjectEventFetcher.new('atlas', mingle_access, state_dir)
-      
+
       assert fetcher.fetch_latest.to_a.empty?
       assert_nil fetcher.first_entry_fetched
       assert_nil fetcher.last_entry_fetched
     end
-    
+
     def test_set_current_state_to_now_if_no_current_state_when_project_has_previous_history
       state_dir = temp_dir
       mingle_access = stub_mingle_access
@@ -112,7 +112,7 @@ module MingleEvents
 
       fetcher.set_current_state_to_now_if_no_current_state
       assert fetcher.fetch_latest.to_a.empty?
-      
+
       mingle_access.register_page_content('/api/v2/projects/atlas/feeds/events.xml',%{
         <feed xmlns="http://www.w3.org/2005/Atom" xmlns:mingle="http://www.thoughtworks-studios.com/ns/mingle">
 
@@ -134,16 +134,16 @@ module MingleEvents
           </entry>
         </feed>
       })
-            
+
       assert_equal([entry(104)], fetcher.fetch_latest.to_a)
     end
-    
+
     def test_set_current_state_to_now_if_no_current_state_is_ignored_if_there_is_already_local_current_state
       state_dir = temp_dir
       mingle_access = stub_mingle_access
       fetcher = ProjectEventFetcher.new('atlas', mingle_access, state_dir)
       fetcher.fetch_latest  # bring current state up to 103
-            
+
       mingle_access.register_page_content('/api/v2/projects/atlas/feeds/events.xml',%{
         <feed xmlns="http://www.w3.org/2005/Atom" xmlns:mingle="http://www.thoughtworks-studios.com/ns/mingle">
 
@@ -165,11 +165,11 @@ module MingleEvents
           </entry>
         </feed>
       })
-            
+
       fetcher.set_current_state_to_now_if_no_current_state
       assert_equal([entry(104)], fetcher.fetch_latest.to_a)
     end
-    
+
     def test_subseuqnce_set_current_state_to_now_if_no_current_state_calls_when_project_initially_had_no_history_do_not_prevent_initial_events_from_being_seen
       state_dir = temp_dir
       mingle_access = StubMingleAccess.new
@@ -177,7 +177,7 @@ module MingleEvents
       fetcher = ProjectEventFetcher.new('atlas', mingle_access, state_dir)
       fetcher.set_current_state_to_now_if_no_current_state
       assert fetcher.fetch_latest.to_a.empty?
-      
+
       mingle_access.register_page_content('/api/v2/projects/atlas/feeds/events.xml',%{
         <feed xmlns="http://www.w3.org/2005/Atom" xmlns:mingle="http://www.thoughtworks-studios.com/ns/mingle">
 
@@ -195,18 +195,18 @@ module MingleEvents
       fetcher.set_current_state_to_now_if_no_current_state
       assert_equal([entry(104)], fetcher.fetch_latest.to_a)
     end
-    
+
     private
-    
-    def setup_current_state(first_entry_id, second_entry_id, last_entry_id, fetcher)    
+
+    def setup_current_state(first_entry_id, second_entry_id, last_entry_id, fetcher)
       first_entry = entry(first_entry_id)
       second_entry = entry(second_entry_id)
       last_entry = entry(last_entry_id)
       fetcher.entry_cache.write(first_entry, second_entry)
-      fetcher.entry_cache.write(last_entry, nil)  
+      fetcher.entry_cache.write(last_entry, nil)
       fetcher.entry_cache.update_current_state(first_entry, last_entry)
     end
-            
+
     def entry(entry_id)
       entry_xml = %{
         <entry xmlns="http://www.w3.org/2005/Atom">

data/test/mingle_events/xml_test.rb

@@ -1,7 +1,7 @@
 require File.expand_path(File.join(File.dirname(__FILE__), '..', 'test_helper'))
 
 module MingleEvents
-  class XmlTest < Test::Unit::TestCase
+  class XmlTest < MiniTest::Test
     def test_get_inner_text
       assert_equal "s", Xml.parse("<a><b>s</b></a>").inner_text
       assert_equal "s", Xml.parse("<a><b>s</b></a>").inner_text("b")
@@ -38,6 +38,11 @@ module MingleEvents
 
     def test_element_to_hash
       assert_equal({:a => {:x => "s", :b => { :y => "t", :e => "0"}, :c => "1", :d => nil}}, Xml.parse('<a x="s"> <b y="t"> <e>0</e> </b> <c>1</c> <d nil="true" /> </a>').select("a").to_hash)
+
+      assert_equal({:a => 's'}, Xml.parse('<a x="y">s</a>').select('a').to_hash)
+      assert_equal({:a => "\u00A0"}, Xml.parse('<a>&#160;</a>').select('a').to_hash)
+      assert_equal({:a => { :x => 'y'}}, Xml.parse('<a x="y"></a>').select('a').to_hash)
+
     end
 
     def test_select_with_namespace

data/test/mingle_events/zip_directory_test.rb

@@ -1,7 +1,7 @@
 require File.expand_path(File.join(File.dirname(__FILE__), '..', 'test_helper'))
 
 module MingleEvents
-  class ZipDirectoryTest < Test::Unit::TestCase
+  class ZipDirectoryTest < MiniTest::Test
 
     def setup
       @dir = ZipDirectory.new("/tmp/foo")