minfraud 1.6.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6df345c5d62d26c7e778a55423ac6a542ec8b94c040c6a43d26ef0cdad484503
-  data.tar.gz: 9d7d427983c71db3e4aa8ac1f7ef1008388a4847b455db50179e579292ac8c61
+  metadata.gz: 0f6c78c29956e0fd0302d07fe250d84bf9d750fb0ef5d713f57afd8bd8ec355d
+  data.tar.gz: f438db4f7d05466e6074192031900ce47fffdd1f2f6256706b63fa2d49ca4c56
 SHA512:
-  metadata.gz: 2cb3b9e1e1d825c828cf1e73684b70784ee1ba5de18902a1d76cd08b5f625cb276bd3a276c64e74f8c3cf8a8269be9c7707a6cd5afa12700d59281985178d070
-  data.tar.gz: 55fd1da7ed9543c44a6efcd4b3638b03a1537c31de12773a0446789f129234ceed750e16e8b0c8c629bcf2956815ef0b0f00cfdfe482fe3e4ad736b0cef5b3ef
+  metadata.gz: 837c85526868ce32e3485da88043dc5d2d5ec1aeda9b66ed7f30dd75f609eb8bdf9a0645aade8a3ae7b7993384559dbe6d6455be1f36cae0cda873d10b4f829d
+  data.tar.gz: ebb55de945c03a0ba68a78ec6c75f3c71b51533be2a5adaf321f35a64e64c6905fca90ba9c996351d9ed190730a97d7cbbc19fb14147e919b29da7457ab409c4

data/.github/workflows/rubocop.yml

@@ -7,6 +7,6 @@ jobs:
       - uses: actions/checkout@v2
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.0'
+          ruby-version: 3.1
       - run: bundle install
       - run: bundle exec rake -t rubocop

data/.github/workflows/test.yml

@@ -13,6 +13,7 @@ jobs:
             2.6,
             2.7,
             '3.0',
+            3.1,
             jruby,
           ]
         exclude:

data/.rubocop.yml

@@ -40,7 +40,7 @@ Layout/IndentationStyle:
 # Style.
 
 Style/HashSyntax:
-  EnforcedStyle: ruby19_no_mixed_keys # Default is ruby19.
+  EnforcedStyle: ruby19_no_mixed_keys # Default is ruby19. This one is better.
 
 Style/CollectionMethods:
   Enabled: true # Default is false.
@@ -54,9 +54,6 @@ Style/NegatedIf: # I disagree with this.
 Style/IfUnlessModifier: # This doesn't always make sense.
   Enabled: false
 
-Style/SymbolArray:
-  EnforcedStyle: brackets # Default is percent, but 1.9 doesn't support that.
-
 # Trailing commas are often good.
 Style/TrailingCommaInArguments:
   Enabled: false
@@ -65,9 +62,6 @@ Style/TrailingCommaInArrayLiteral:
 Style/TrailingCommaInHashLiteral:
   Enabled: false
 
-Style/SafeNavigation:
-  Enabled: false # Default is true, but this 1.9 doesn't support it.
-
 # Default is both which is probably fine, but it changes code and I don't want
 # to investigate any possible behavior change right now.
 Style/EmptyElse:
@@ -76,25 +70,12 @@ Style/EmptyElse:
 Style/ConditionalAssignment:
   Enabled: false # This produces kind of strange results.
 
-Style/Dir:
-  Enabled: false # This is good, but not supported on 1.9.
-
-Style/ExpandPathArguments:
-  Enabled: false # This causes us to use __dir__ which 1.9 doesn't support.
-
 Style/GuardClause:
   Enabled: false # Doesn't always make sense.
 
-Style/Documentation:
-  Enabled: false # We should enable this, but allow for pre-existing code.
-
 Style/FormatStringToken:
   Enabled: false # Seems unnecessary.
 
-# Asks to use x.negative? instead of x < 0. But this isn't available until 2.3.
-Style/NumericPredicate:
-  Enabled: false
-
 # Seems unnecessary. Asks us to call super in a bunch of places when there's no
 # need.
 Lint/MissingSuper:

data/CHANGELOG.md

@@ -1,4 +1,79 @@
-# Minfraud Changelog
+# Changelog
+
+## v2.2.0 (2022-03-28)
+
+* Added the input `/credit_card/country`. This is the country where the
+  issuer of the card is located. This may be passed instead of the
+  `/credit_card/issuer_id_number` if you do not wish to pass partial
+  account numbers or if your payment processor does not provide them. You
+  may provide this using the `country` attribute on
+  `Minfraud::Components::CreditCard`.
+
+## v2.1.0 (2022-01-25)
+
+* Adds the following new processor to `Minfraud::Components::Payment`:
+  * `:windcave`
+* The `last_4_digits` input to `Minfraud::Components::CreditCard` has been
+  deprecated in favor of `last_digits` and will be removed in a future
+  release. `last_digits`/`last_4_digits` also now supports two digit values
+  in addition to the previous four digit values.
+* Eight digit `issuer_id_number` inputs are now supported by
+  `Minfraud::Components::CreditCard` in addition to the previously accepted
+  six digit `issuer_id_number`. In most cases, you should send the last four
+  digits for `last_digits`. If you send an `issuer_id_number` that contains
+  an eight digit IIN, and if the credit card brand is not one of the
+  following, you should send the last two digits for `last_digits`:
+  * `Discover`
+  * `JCB`
+  * `Mastercard`
+  * `UnionPay`
+  * `Visa`
+
+## v2.0.0 (2021-12-06)
+
+* Breaking change from 1.x: Removed deprecated methods
+  `is_in_european_union`, `is_anonymous`, `is_anonymous_vpn`,
+  `is_hosting_provider`, `is_public_proxy`, and `is_tor_exit_node`. The
+  non-deprecated equivalents are `in_european_union?`, `anonymous?`,
+  `anonymous_vpn?`, `hosting_provider?`, `public_proxy?`, and
+  `tor_exit_node?`.
+* Breaking change from 1.x: Removed deprecated methods for deprecated
+  subscores: `email_tenure` and `ip_tenure`. For `email_tenure`, please use
+  the `email_address` subscore instead. For `ip_tenure`, please use
+  `risk_score` instead.
+* Breaking change from 1.x: Removed deprecated method for deprecated
+  attribute `ip_address.country.is_high_risk`.
+* Breaking change from 1.x: Switches HTTP client from faraday to http.rb.
+  There should be no behavior change for most users, but this is
+  technically a breaking change from the perspective of semver. Most users
+  should not be affected as the changes are limited to attributes and
+  classes that would not normally be accessed outside the gem.
+* Breaking change from 1.x: `user_id` is no longer supported as a way to
+  configure your MaxMind account ID. Use `account_id` instead.
+* Breaking change from 1.x: Removed the `Minfraud.configuration` method.
+* Breaking change from 1.x: Localized names are no longer exposed via
+  methods on `names` objects, only as hash keys. For example, use
+  `response.ip_address.country.names['en']` instead of
+  `response.ip_address.country.names.en`. The latter was deprecated.
+* Adds mobile country code (MCC) and mobile network code (MNC) to minFraud
+  Insights and Factors responses. These are available at
+  `response.ip_address.traits.mobile_country_code` and
+  `response.ip_address.traits.mobile_network_code`. We expect this data to
+  be available by late January, 2022.
+* Adds the following new processors to `Minfraud::Components::Payment`:
+  * `:boacompra`
+  * `:boku`
+  * `:coregateway`
+  * `:fiserv`
+  * `:neopay`
+  * `:neosurf`
+  * `:openbucks`
+  * `:paysera`
+  * `:payvision`
+  * `:trustly`
+* Depend on the `maxmind-geoip2` gem. This allows us to delete classes from
+  that gem that we previously had included in this gem. There is no
+  functional difference.
 
 ## v1.6.0 (2021-08-19)
 
@@ -14,7 +89,7 @@
 
 ## v1.5.0 (2021-02-02)
 
-* Add the `hash_address` attribute to `Minfraud::Components::Email`. If
+* Adds the `hash_address` attribute to `Minfraud::Components::Email`. If
   this is `true`, the MD5 hash of the `address` will be sent instead of the
   plain text `address`. Use this if you prefer to send the hash of the
   `address` rather than the plain text. Note that this normalizes the
@@ -24,7 +99,7 @@
   input is set but the `domain` is not.
 * Adds new payment processors `:apple_pay` and `:aps_payments` to
   `Minfraud::Components::Payment`.
-* Added support for the IP address risk reasons in the minFraud Insights
+* Adds support for the IP address risk reasons in the minFraud Insights
   and Factors responses. This is available at `.ip_address.risk_reasons`.
   It is an array of `IPRiskReason` objects.
 
@@ -38,7 +113,7 @@
 
 * IMPORTANT: Ruby 2.0 is no longer supported. If you're using Ruby 2.0,
   please use version 1.3.0.
-* Add handling for the `REQUEST_INVALID` error code.
+* Adds handling for the `REQUEST_INVALID` error code.
 * The IP address is no longer a required input.
 * Adds new payment processor `:tsys` to `Minfraud::Components::Payment`.
 
@@ -103,6 +178,7 @@
 * Adds `amount` attribute to the `Minfraud::Components::Order` instances
 
 ## v1.0.3 (2016-11-24)
+
 * Adds `token` attribute to the `Minfraud::Components::CreditCard` instances
 according to the MinFraud Release Notes introduced on November 17, 2016
 

data/Gemfile

@@ -2,13 +2,4 @@
 
 source 'https://rubygems.org'
 
-# coveralls fails on Ruby 1.9. My understanding is we don't need to run this on
-# more than one version anyway, so restrict to the current latest.
-version_pieces = RUBY_VERSION.split('.')
-major_version  = version_pieces[0]
-minor_version  = version_pieces[1]
-if major_version == '2' && minor_version == '7'
-  gem 'coveralls', require: false
-end
-
 gemspec

data/LICENSE.txt

@@ -1,7 +1,7 @@
 The MIT License (MIT)
 
 Copyright (c) 2016-2020 kushnir.yb
-Copyright (c) 2020-2021 MaxMind, Inc.
+Copyright (c) 2020-2022 MaxMind, Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -3,9 +3,9 @@
 ## Description
 
 This package provides an API for the [MaxMind minFraud web
-services](https://dev.maxmind.com/minfraud/). This includes minFraud Score,
+services](https://dev.maxmind.com/minfraud?lang=en). This includes minFraud Score,
 Insights, and Factors. It also includes our [minFraud Report Transaction
-API](https://dev.maxmind.com/minfraud/report-transaction/).
+API](https://dev.maxmind.com/minfraud/report-a-transaction?lang=en).
 
 The legacy minFraud Standard and Premium services are not supported by this
 API.
@@ -123,7 +123,7 @@ assessment = Minfraud::Assessments.new(
   },
   credit_card: {
     issuer_id_number:         '411111',
-    last_4_digits:            '7643',
+    last_digits:              '7643',
     bank_name:                'Bank of No Hope',
     bank_phone_country_code:  '1',
     bank_phone_number:        '123-456-1234',
@@ -283,7 +283,7 @@ This API uses [Semantic Versioning](https://semver.org/).
 
 Copyright (c) 2016-2020 kushnir.yb.
 
-Copyright (c) 2020-2021 MaxMind, Inc.
+Copyright (c) 2020-2022 MaxMind, Inc.
 
 The gem is available as open source under the terms of the [MIT
 License](https://opensource.org/licenses/MIT).

data/lib/minfraud/assessments.rb

@@ -4,9 +4,8 @@ module Minfraud
   # Assessments is used to perform minFraud Score, Insights, and Factors
   # requests.
   #
-  # @see https://dev.maxmind.com/minfraud/
+  # @see https://dev.maxmind.com/minfraud?lang=en
   class Assessments
-    include ::Minfraud::HTTPService
     include ::Minfraud::Resolver
 
     # The Account component.
@@ -82,6 +81,8 @@ module Minfraud
     #
     # @return [Minfraud::HTTPService::Response]
     #
+    # @raise [JSON::ParserError] if there was invalid JSON in the response.
+    #
     # @raise [Minfraud::AuthorizationError] If there was an authentication
     #   problem.
     #
@@ -98,6 +99,8 @@ module Minfraud
     #
     # @return [Minfraud::HTTPService::Response]
     #
+    # @raise [JSON::ParserError] if there was invalid JSON in the response.
+    #
     # @raise [Minfraud::AuthorizationError] If there was an authentication
     #   problem.
     #
@@ -114,6 +117,8 @@ module Minfraud
     #
     # @return [Minfraud::HTTPService::Response]
     #
+    # @raise [JSON::ParserError] if there was invalid JSON in the response.
+    #
     # @raise [Minfraud::AuthorizationError] If there was an authentication
     #   problem.
     #
@@ -129,18 +134,22 @@ module Minfraud
     private
 
     def perform_request(endpoint)
-      raw = request.perform(
-        verb:     :post,
-        endpoint: endpoint.to_s,
-        body:     request_body,
-      )
+      response = nil
+      body     = nil
+      Minfraud.connection_pool.with do |client|
+        response = client.post(
+          "/minfraud/v2.0/#{endpoint}",
+          json: request_body,
+        )
+
+        body = response.to_s
+      end
 
       response = ::Minfraud::HTTPService::Response.new(
-        endpoint: endpoint,
-        locales:  @locales,
-        status:   raw.status.to_i,
-        body:     raw.body,
-        headers:  raw.headers
+        endpoint,
+        @locales,
+        response,
+        body,
       )
 
       ::Minfraud::ErrorHandler.examine(response)
@@ -153,9 +162,5 @@ module Minfraud
         mem.merge!(e.to_s => value.to_json)
       end
     end
-
-    def request
-      @request ||= Request.new(::Minfraud::HTTPService.configuration)
-    end
   end
 end

data/lib/minfraud/components/account.rb

@@ -4,7 +4,7 @@ module Minfraud
   module Components
     # Account corresponds to the account object of a minFraud request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Account_(/account)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--account
     class Account < Base
       include Minfraud::Validates
 

data/lib/minfraud/components/billing.rb

@@ -4,7 +4,7 @@ module Minfraud
   module Components
     # Billing corresponds to the billing object of a minFraud request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Billing_(/billing)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--billing
     class Billing < Addressable; end
   end
 end

data/lib/minfraud/components/credit_card.rb

@@ -4,20 +4,22 @@ module Minfraud
   module Components
     # CreditCard corresponds to the credit_card object of a minFraud request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Credit_Card_(/creditcard)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--credit-card
     class CreditCard < Base
       include Minfraud::Validates
 
-      # The issuer ID number for the credit card. This is the first 6 digits of
-      # the credit card number. It identifies the issuing bank.
+      # The issuer ID number for the credit card. This is the first 6 or 8
+      # digits of the credit card number. It identifies the issuing bank.
       #
       # @return [String, nil]
       attr_accessor :issuer_id_number
 
-      # The last four digits of the credit card number.
+      # The last two or four digits of the credit card number.
+      #
+      # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--credit-card__last_digits
       #
       # @return [String, nil]
-      attr_accessor :last_4_digits
+      attr_accessor :last_digits
 
       # The name of the issuing bank as provided by the end user.
       #
@@ -39,6 +41,16 @@ module Minfraud
       # @return [String, nil]
       attr_accessor :bank_phone_number
 
+      # The two character ISO 3166-1 alpha-2 country code where the issuer of
+      # the card is located. This may be passed instead of {::issuer_id_number}
+      # if you do not wish to pass partial account numbers, or if your payment
+      # processor does not provide them.
+      #
+      # @see https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2
+      #
+      # @return [String, nil]
+      attr_accessor :country
+
       # A token uniquely identifying the card. The token should consist of
       # non-space printable ASCII characters. If the token is all digits, it
       # must be more than 19 characters long. The token must not be a primary
@@ -72,12 +84,31 @@ module Minfraud
       # @return [Boolean, nil]
       attr_accessor :was_3d_secure_successful
 
+      # Get the last digits of the credit card number.
+      #
+      # @deprecated Use {::last_digits} instead.
+      #
+      # @return [String, nil]
+      def last_4_digits
+        @last_digits
+      end
+
+      # Set the last digits of the credit card number.
+      #
+      # @deprecated Use {::last_digits} instead.
+      #
+      # @return [String, nil]
+      def last_4_digits=(last4)
+        @last_digits = last4
+      end
+
       # @param params [Hash] Hash of parameters. Each key/value should
       #   correspond to one of the available attributes.
       def initialize(params = {})
         @bank_phone_country_code  = params[:bank_phone_country_code]
+        @country                  = params[:country]
         @issuer_id_number         = params[:issuer_id_number]
-        @last_4_digits            = params[:last_4_digits]
+        @last_digits              = params[:last_digits] || params[:last_4_digits]
         @bank_name                = params[:bank_name]
         @bank_phone_number        = params[:bank_phone_number]
         @avs_result               = params[:avs_result]
@@ -94,8 +125,9 @@ module Minfraud
         return if !Minfraud.enable_validation
 
         validate_telephone_country_code('bank_phone_country_code', @bank_phone_country_code)
-        validate_regex('issuer_id_number', /\A[0-9]{6}\z/, @issuer_id_number)
-        validate_regex('last_4_digits', /\A[0-9]{4}\z/, @last_4_digits)
+        validate_country_code('country', @country)
+        validate_regex('issuer_id_number', /\A(?:[0-9]{6}|[0-9]{8})\z/, @issuer_id_number)
+        validate_regex('last_digits', /\A(?:[0-9]{2}|[0-9]{4})\z/, @last_digits)
         validate_string('bank_name', 255, @bank_name)
         validate_string('bank_phone_number', 255, @bank_phone_number)
         validate_string('avs_result', 1, @avs_result)

data/lib/minfraud/components/custom_inputs.rb

@@ -5,7 +5,7 @@ module Minfraud
     # CustomInputs corresponds to the custom_inputs object of a minFraud
     # request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Custom_Inputs_(/custominputs)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--custom-inputs
     class CustomInputs < Base
       include Minfraud::Validates
 

data/lib/minfraud/components/device.rb

@@ -4,7 +4,7 @@ module Minfraud
   module Components
     # Device corresponds to the device object of a minFraud request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Device_(/device)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--device
     class Device < Base
       include Minfraud::Validates
 

data/lib/minfraud/components/email.rb

@@ -7,7 +7,7 @@ module Minfraud
   module Components
     # Email corresponds to the email object of a minFraud request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Email_(/email)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--email
     class Email < Base
       include Minfraud::Validates
 

data/lib/minfraud/components/event.rb

@@ -4,7 +4,7 @@ module Minfraud
   module Components
     # Event corresponds to the event object of a minFraud request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Event_(/event)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--event
     class Event < Base
       include ::Minfraud::Enum
       include Minfraud::Validates
@@ -43,16 +43,16 @@ module Minfraud
       #
       # @return [Symbol, nil]
       enum_accessor :type,
-                    [
-                      :account_creation,
-                      :account_login,
-                      :email_change,
-                      :password_reset,
-                      :payout_change,
-                      :purchase,
-                      :recurring_purchase,
-                      :referral,
-                      :survey,
+                    %i[
+                      account_creation
+                      account_login
+                      email_change
+                      password_reset
+                      payout_change
+                      purchase
+                      recurring_purchase
+                      referral
+                      survey
                     ]
 
       # @param params [Hash] Hash of parameters. Each key/value should

data/lib/minfraud/components/order.rb

@@ -4,7 +4,7 @@ module Minfraud
   module Components
     # Order corresponds to the order object of a minFraud request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Order_(/order)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--order
     class Order < Base
       include Minfraud::Validates