minfraud 1.6.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6df345c5d62d26c7e778a55423ac6a542ec8b94c040c6a43d26ef0cdad484503
-  data.tar.gz: 9d7d427983c71db3e4aa8ac1f7ef1008388a4847b455db50179e579292ac8c61
+  metadata.gz: 4e3c2e76357a683ceda7350bde7dc4c89cc6055d473b771ee74041d4371f05f7
+  data.tar.gz: 60aacbf2435a51f65c9d9702e209ddab469d21dd672ba8d5baf34dae807deb2f
 SHA512:
-  metadata.gz: 2cb3b9e1e1d825c828cf1e73684b70784ee1ba5de18902a1d76cd08b5f625cb276bd3a276c64e74f8c3cf8a8269be9c7707a6cd5afa12700d59281985178d070
-  data.tar.gz: 55fd1da7ed9543c44a6efcd4b3638b03a1537c31de12773a0446789f129234ceed750e16e8b0c8c629bcf2956815ef0b0f00cfdfe482fe3e4ad736b0cef5b3ef
+  metadata.gz: ebdccdbdb2d97665faabbf8486cdeb029e1a1d372a09a1ffeff226f5f900d99887e6e370e01515543983c46f86d4083fa347e557d82c5dde265b079e055adddc
+  data.tar.gz: 61f65f9cc64dd1e0c205c5c2f8df5acfb621dc1ae80b828d5df27e0616964ac0c0a1315b609a4a3228b1f9ecce78dd31411b66513c25eb4311532b3b9f71d775

data/.rubocop.yml

@@ -40,7 +40,7 @@ Layout/IndentationStyle:
 # Style.
 
 Style/HashSyntax:
-  EnforcedStyle: ruby19_no_mixed_keys # Default is ruby19.
+  EnforcedStyle: ruby19_no_mixed_keys # Default is ruby19. This one is better.
 
 Style/CollectionMethods:
   Enabled: true # Default is false.
@@ -54,9 +54,6 @@ Style/NegatedIf: # I disagree with this.
 Style/IfUnlessModifier: # This doesn't always make sense.
   Enabled: false
 
-Style/SymbolArray:
-  EnforcedStyle: brackets # Default is percent, but 1.9 doesn't support that.
-
 # Trailing commas are often good.
 Style/TrailingCommaInArguments:
   Enabled: false
@@ -65,9 +62,6 @@ Style/TrailingCommaInArrayLiteral:
 Style/TrailingCommaInHashLiteral:
   Enabled: false
 
-Style/SafeNavigation:
-  Enabled: false # Default is true, but this 1.9 doesn't support it.
-
 # Default is both which is probably fine, but it changes code and I don't want
 # to investigate any possible behavior change right now.
 Style/EmptyElse:
@@ -76,25 +70,12 @@ Style/EmptyElse:
 Style/ConditionalAssignment:
   Enabled: false # This produces kind of strange results.
 
-Style/Dir:
-  Enabled: false # This is good, but not supported on 1.9.
-
-Style/ExpandPathArguments:
-  Enabled: false # This causes us to use __dir__ which 1.9 doesn't support.
-
 Style/GuardClause:
   Enabled: false # Doesn't always make sense.
 
-Style/Documentation:
-  Enabled: false # We should enable this, but allow for pre-existing code.
-
 Style/FormatStringToken:
   Enabled: false # Seems unnecessary.
 
-# Asks to use x.negative? instead of x < 0. But this isn't available until 2.3.
-Style/NumericPredicate:
-  Enabled: false
-
 # Seems unnecessary. Asks us to call super in a bunch of places when there's no
 # need.
 Lint/MissingSuper:

data/CHANGELOG.md

@@ -1,4 +1,50 @@
-# Minfraud Changelog
+# Changelog
+
+## v2.0.0 (2021-12-06)
+
+* Breaking change from 1.x: Removed deprecated methods
+  `is_in_european_union`, `is_anonymous`, `is_anonymous_vpn`,
+  `is_hosting_provider`, `is_public_proxy`, and `is_tor_exit_node`. The
+  non-deprecated equivalents are `in_european_union?`, `anonymous?`,
+  `anonymous_vpn?`, `hosting_provider?`, `public_proxy?`, and
+  `tor_exit_node?`.
+* Breaking change from 1.x: Removed deprecated methods for deprecated
+  subscores: `email_tenure` and `ip_tenure`. For `email_tenure`, please use
+  the `email_address` subscore instead. For `ip_tenure`, please use
+  `risk_score` instead.
+* Breaking change from 1.x: Removed deprecated method for deprecated
+  attribute `ip_address.country.is_high_risk`.
+* Breaking change from 1.x: Switches HTTP client from faraday to http.rb.
+  There should be no behavior change for most users, but this is
+  technically a breaking change from the perspective of semver. Most users
+  should not be affected as the changes are limited to attributes and
+  classes that would not normally be accessed outside the gem.
+* Breaking change from 1.x: `user_id` is no longer supported as a way to
+  configure your MaxMind account ID. Use `account_id` instead.
+* Breaking change from 1.x: Removed the `Minfraud.configuration` method.
+* Breaking change from 1.x: Localized names are no longer exposed via
+  methods on `names` objects, only as hash keys. For example, use
+  `response.ip_address.country.names['en']` instead of
+  `response.ip_address.country.names.en`. The latter was deprecated.
+* Adds mobile country code (MCC) and mobile network code (MNC) to minFraud
+  Insights and Factors responses. These are available at
+  `response.ip_address.traits.mobile_country_code` and
+  `response.ip_address.traits.mobile_network_code`. We expect this data to
+  be available by late January, 2022.
+* Adds the following new processors to `Minfraud::Components::Payment`:
+  * `:boacompra`
+  * `:boku`
+  * `:coregateway`
+  * `:fiserv`
+  * `:neopay`
+  * `:neosurf`
+  * `:openbucks`
+  * `:paysera`
+  * `:payvision`
+  * `:trustly`
+* Depend on the `maxmind-geoip2` gem. This allows us to delete classes from
+  that gem that we previously had included in this gem. There is no
+  functional difference.
 
 ## v1.6.0 (2021-08-19)
 
@@ -103,6 +149,7 @@
 * Adds `amount` attribute to the `Minfraud::Components::Order` instances
 
 ## v1.0.3 (2016-11-24)
+
 * Adds `token` attribute to the `Minfraud::Components::CreditCard` instances
 according to the MinFraud Release Notes introduced on November 17, 2016
 

data/Gemfile

@@ -2,13 +2,4 @@
 
 source 'https://rubygems.org'
 
-# coveralls fails on Ruby 1.9. My understanding is we don't need to run this on
-# more than one version anyway, so restrict to the current latest.
-version_pieces = RUBY_VERSION.split('.')
-major_version  = version_pieces[0]
-minor_version  = version_pieces[1]
-if major_version == '2' && minor_version == '7'
-  gem 'coveralls', require: false
-end
-
 gemspec

data/README.md

@@ -3,9 +3,9 @@
 ## Description
 
 This package provides an API for the [MaxMind minFraud web
-services](https://dev.maxmind.com/minfraud/). This includes minFraud Score,
+services](https://dev.maxmind.com/minfraud?lang=en). This includes minFraud Score,
 Insights, and Factors. It also includes our [minFraud Report Transaction
-API](https://dev.maxmind.com/minfraud/report-transaction/).
+API](https://dev.maxmind.com/minfraud/report-a-transaction?lang=en).
 
 The legacy minFraud Standard and Premium services are not supported by this
 API.

data/lib/minfraud/assessments.rb

@@ -4,9 +4,8 @@ module Minfraud
   # Assessments is used to perform minFraud Score, Insights, and Factors
   # requests.
   #
-  # @see https://dev.maxmind.com/minfraud/
+  # @see https://dev.maxmind.com/minfraud?lang=en
   class Assessments
-    include ::Minfraud::HTTPService
     include ::Minfraud::Resolver
 
     # The Account component.
@@ -82,6 +81,8 @@ module Minfraud
     #
     # @return [Minfraud::HTTPService::Response]
     #
+    # @raise [JSON::ParserError] if there was invalid JSON in the response.
+    #
     # @raise [Minfraud::AuthorizationError] If there was an authentication
     #   problem.
     #
@@ -98,6 +99,8 @@ module Minfraud
     #
     # @return [Minfraud::HTTPService::Response]
     #
+    # @raise [JSON::ParserError] if there was invalid JSON in the response.
+    #
     # @raise [Minfraud::AuthorizationError] If there was an authentication
     #   problem.
     #
@@ -114,6 +117,8 @@ module Minfraud
     #
     # @return [Minfraud::HTTPService::Response]
     #
+    # @raise [JSON::ParserError] if there was invalid JSON in the response.
+    #
     # @raise [Minfraud::AuthorizationError] If there was an authentication
     #   problem.
     #
@@ -129,18 +134,22 @@ module Minfraud
     private
 
     def perform_request(endpoint)
-      raw = request.perform(
-        verb:     :post,
-        endpoint: endpoint.to_s,
-        body:     request_body,
-      )
+      response = nil
+      body     = nil
+      Minfraud.connection_pool.with do |client|
+        response = client.post(
+          "/minfraud/v2.0/#{endpoint}",
+          json: request_body,
+        )
+
+        body = response.to_s
+      end
 
       response = ::Minfraud::HTTPService::Response.new(
-        endpoint: endpoint,
-        locales:  @locales,
-        status:   raw.status.to_i,
-        body:     raw.body,
-        headers:  raw.headers
+        endpoint,
+        @locales,
+        response,
+        body,
       )
 
       ::Minfraud::ErrorHandler.examine(response)
@@ -153,9 +162,5 @@ module Minfraud
         mem.merge!(e.to_s => value.to_json)
       end
     end
-
-    def request
-      @request ||= Request.new(::Minfraud::HTTPService.configuration)
-    end
   end
 end

data/lib/minfraud/components/account.rb

@@ -4,7 +4,7 @@ module Minfraud
   module Components
     # Account corresponds to the account object of a minFraud request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Account_(/account)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--account
     class Account < Base
       include Minfraud::Validates
 

data/lib/minfraud/components/billing.rb

@@ -4,7 +4,7 @@ module Minfraud
   module Components
     # Billing corresponds to the billing object of a minFraud request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Billing_(/billing)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--billing
     class Billing < Addressable; end
   end
 end

data/lib/minfraud/components/credit_card.rb

@@ -4,7 +4,7 @@ module Minfraud
   module Components
     # CreditCard corresponds to the credit_card object of a minFraud request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Credit_Card_(/creditcard)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--credit-card
     class CreditCard < Base
       include Minfraud::Validates
 

data/lib/minfraud/components/custom_inputs.rb

@@ -5,7 +5,7 @@ module Minfraud
     # CustomInputs corresponds to the custom_inputs object of a minFraud
     # request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Custom_Inputs_(/custominputs)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--custom-inputs
     class CustomInputs < Base
       include Minfraud::Validates
 

data/lib/minfraud/components/device.rb

@@ -4,7 +4,7 @@ module Minfraud
   module Components
     # Device corresponds to the device object of a minFraud request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Device_(/device)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--device
     class Device < Base
       include Minfraud::Validates
 

data/lib/minfraud/components/email.rb

@@ -7,7 +7,7 @@ module Minfraud
   module Components
     # Email corresponds to the email object of a minFraud request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Email_(/email)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--email
     class Email < Base
       include Minfraud::Validates
 

data/lib/minfraud/components/event.rb

@@ -4,7 +4,7 @@ module Minfraud
   module Components
     # Event corresponds to the event object of a minFraud request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Event_(/event)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--event
     class Event < Base
       include ::Minfraud::Enum
       include Minfraud::Validates
@@ -43,16 +43,16 @@ module Minfraud
       #
       # @return [Symbol, nil]
       enum_accessor :type,
-                    [
-                      :account_creation,
-                      :account_login,
-                      :email_change,
-                      :password_reset,
-                      :payout_change,
-                      :purchase,
-                      :recurring_purchase,
-                      :referral,
-                      :survey,
+                    %i[
+                      account_creation
+                      account_login
+                      email_change
+                      password_reset
+                      payout_change
+                      purchase
+                      recurring_purchase
+                      referral
+                      survey
                     ]
 
       # @param params [Hash] Hash of parameters. Each key/value should

data/lib/minfraud/components/order.rb

@@ -4,7 +4,7 @@ module Minfraud
   module Components
     # Order corresponds to the order object of a minFraud request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Order_(/order)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--order
     class Order < Base
       include Minfraud::Validates
 

data/lib/minfraud/components/payment.rb

@@ -4,7 +4,7 @@ module Minfraud
   module Components
     # Payment corresponds to the payment object of a minFraud request.
     #
-    # @see https://dev.maxmind.com/minfraud/#Payment_(/payment)
+    # @see https://dev.maxmind.com/minfraud/api-documentation/requests?lang=en#schema--request--payment
     class Payment < Base
       include ::Minfraud::Enum
       include Minfraud::Validates
@@ -15,147 +15,157 @@ module Minfraud
       # @!attribute processor
       #
       # @return [Symbol, nil]
-      enum_accessor :processor, [
-        :adyen,
-        :affirm,
-        :afterpay,
-        :altapay,
-        :amazon_payments,
-        :american_express_payment_gateway,
-        :apple_pay,
-        :aps_payments,
-        :authorizenet,
-        :balanced,
-        :beanstream,
-        :bluepay,
-        :bluesnap,
-        :bpoint,
-        :braintree,
-        :cardknox,
-        :cardpay,
-        :cashfree,
-        :ccavenue,
-        :ccnow,
-        :cetelem,
-        :chase_paymentech,
-        :checkout_com,
-        :cielo,
-        :collector,
-        :commdoo,
-        :compropago,
-        :concept_payments,
-        :conekta,
-        :creditguard,
-        :credorax,
-        :ct_payments,
-        :cuentadigital,
-        :curopayments,
-        :cybersource,
-        :dalenys,
-        :dalpay,
-        :datacap,
-        :datacash,
-        :dibs,
-        :digital_river,
-        :dlocal,
-        :dotpay,
-        :ebs,
-        :ecomm365,
-        :ecommpay,
-        :elavon,
-        :emerchantpay,
-        :epay,
-        :eprocessing_network,
-        :epx,
-        :eway,
-        :exact,
-        :first_atlantic_commerce,
-        :first_data,
-        :g2a_pay,
-        :global_payments,
-        :gocardless,
-        :heartland,
-        :hipay,
-        :ingenico,
-        :interac,
-        :internetsecure,
-        :intuit_quickbooks_payments,
-        :iugu,
-        :klarna,
-        :komoju,
-        :lemon_way,
-        :mastercard_payment_gateway,
-        :mercadopago,
-        :mercanet,
-        :merchant_esolutions,
-        :mirjeh,
-        :mollie,
-        :moneris_solutions,
-        :nmi,
-        :oceanpayment,
-        :oney,
-        :onpay,
-        :openpaymx,
-        :optimal_payments,
-        :orangepay,
-        :other,
-        :pacnet_services,
-        :payeezy,
-        :payfast,
-        :paygate,
-        :paylike,
-        :payment_express,
-        :paymentwall,
-        :payone,
-        :paypal,
-        :payplus,
-        :paysafecard,
-        :paystation,
-        :paytm,
-        :paytrace,
-        :paytrail,
-        :payture,
-        :payu,
-        :payulatam,
-        :payway,
-        :payza,
-        :pinpayments,
-        :posconnect,
-        :princeton_payment_solutions,
-        :psigate,
-        :qiwi,
-        :quickpay,
-        :raberil,
-        :razorpay,
-        :rede,
-        :redpagos,
-        :rewardspay,
-        :safecharge,
-        :sagepay,
-        :securetrading,
-        :simplify_commerce,
-        :skrill,
-        :smartcoin,
-        :smartdebit,
-        :solidtrust_pay,
-        :sps_decidir,
-        :stripe,
-        :synapsefi,
-        :systempay,
-        :telerecargas,
-        :towah,
-        :transact_pro,
-        :tsys,
-        :usa_epay,
-        :vantiv,
-        :verepay,
-        :vericheck,
-        :vindicia,
-        :virtual_card_services,
-        :vme,
-        :vpos,
-        :wirecard,
-        :worldpay
+      enum_accessor :processor, %i[
+        adyen
+        affirm
+        afterpay
+        altapay
+        amazon_payments
+        american_express_payment_gateway
+        apple_pay
+        aps_payments
+        authorizenet
+        balanced
+        beanstream
+        bluepay
+        bluesnap
+        boacompra
+        boku
+        bpoint
+        braintree
+        cardknox
+        cardpay
+        cashfree
+        ccavenue
+        ccnow
+        cetelem
+        chase_paymentech
+        checkout_com
+        cielo
+        collector
+        commdoo
+        compropago
+        concept_payments
+        conekta
+        coregateway
+        creditguard
+        credorax
+        ct_payments
+        cuentadigital
+        curopayments
+        cybersource
+        dalenys
+        dalpay
+        datacap
+        datacash
+        dibs
+        digital_river
+        dlocal
+        dotpay
+        ebs
+        ecomm365
+        ecommpay
+        elavon
+        emerchantpay
+        epay
+        eprocessing_network
+        epx
+        eway
+        exact
+        first_atlantic_commerce
+        first_data
+        fiserv
+        g2a_pay
+        global_payments
+        gocardless
+        heartland
+        hipay
+        ingenico
+        interac
+        internetsecure
+        intuit_quickbooks_payments
+        iugu
+        klarna
+        komoju
+        lemon_way
+        mastercard_payment_gateway
+        mercadopago
+        mercanet
+        merchant_esolutions
+        mirjeh
+        mollie
+        moneris_solutions
+        neopay
+        neosurf
+        nmi
+        oceanpayment
+        oney
+        onpay
+        openbucks
+        openpaymx
+        optimal_payments
+        orangepay
+        other
+        pacnet_services
+        payeezy
+        payfast
+        paygate
+        paylike
+        payment_express
+        paymentwall
+        payone
+        paypal
+        payplus
+        paysafecard
+        paysera
+        paystation
+        paytm
+        paytrace
+        paytrail
+        payture
+        payu
+        payulatam
+        payvision
+        payway
+        payza
+        pinpayments
+        posconnect
+        princeton_payment_solutions
+        psigate
+        qiwi
+        quickpay
+        raberil
+        razorpay
+        rede
+        redpagos
+        rewardspay
+        safecharge
+        sagepay
+        securetrading
+        simplify_commerce
+        skrill
+        smartcoin
+        smartdebit
+        solidtrust_pay
+        sps_decidir
+        stripe
+        synapsefi
+        systempay
+        telerecargas
+        towah
+        transact_pro
+        trustly
+        tsys
+        usa_epay
+        vantiv
+        verepay
+        vericheck
+        vindicia
+        virtual_card_services
+        vme
+        vpos
+        wirecard
+        worldpay
       ]
 
       # The authorization outcome from the payment processor. If the

data/lib/minfraud/components/report/transaction.rb

@@ -5,7 +5,7 @@ module Minfraud
     module Report
       # Contains the fields used in the Report Transaction API.
       #
-      # @see https://dev.maxmind.com/minfraud/report-transaction/
+      # @see https://dev.maxmind.com/minfraud/report-a-transaction?lang=en
       class Transaction < Base
         include ::Minfraud::Enum
 
@@ -24,7 +24,7 @@ module Minfraud
         # @!attribute tag
         #
         # @return [Symbol, nil]
-        enum_accessor :tag, [:chargeback, :not_fraud, :spam_or_abuse, :suspected_fraud]
+        enum_accessor :tag, %i[chargeback not_fraud spam_or_abuse suspected_fraud]
 
         # A string which is provided by your payment processor indicating the
         # reason for the chargeback.