minfraud 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 992486331731cfd910c7ae3da4039bfa3b776277ff3eb3fb44ae62816299d2cb
-  data.tar.gz: db10a19261bdca8cb64df6f0992a2d102859c670fc47568cdc01e299c17318a6
+  metadata.gz: 5523cb6babed5c559ba622141b2db65a2396cbb016c6215ec641ba765fc01d10
+  data.tar.gz: 54dbf8b2cc34be45a428da2017f09b7cb2d7445c94ff7f37dda0a26c28a3fbfe
 SHA512:
-  metadata.gz: bd6e8c22d6557f26233b1f5c306ab3d358adb9f661f1452d02471ce0b705cd0037ecafc235af86646894bc4ab953c595989011148aa4f658132f6ec7c7218a4f
-  data.tar.gz: f8e53c39ef6a07271297e8555808682b9cb662efe43057ea6da9ea9400418b7a59bd168051888e8c69ebda1d9ed6947729e48de5b3a61df25b26536f13589bef
+  metadata.gz: 80142ac976fb6df365a3192a96dbf62c8ea7935f4ca9fea89333d0e2f2e64f5e4af402dc03814f58f268e354ed7adcb5c61134fb2d526c0a06b48581cad3fc54
+  data.tar.gz: a9b6caf26aaee87f5ebc479391cda46d3489cf591315772c481d722b343399edfc5ad40fca8eac0d740d826c0021bcf33d3aade2419247d26d1787328763599b

data/.github/workflows/test.yml

@@ -0,0 +1,46 @@
+name: ruby-versions
+on:
+  push:
+    paths-ignore:
+      - "**.md"
+  pull_request:
+    paths-ignore:
+      - "**.md"
+jobs:
+  run:
+    name: ruby
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+        version:
+          [
+            "2.2",
+            "2.3",
+            "2.4",
+            "2.5",
+            "2.6",
+            "2.7",
+            "head",
+            "jruby",
+            "jruby-head",
+          ]
+        exclude:
+          - os: windows-latest
+            version: "jruby"
+          - os: windows-latest
+            version: "jruby-head"
+    steps:
+      - name: checkout
+        uses: actions/checkout@v2
+
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.version }}
+      - name: ruby version
+        run: ruby -v
+      - run: bundler install
+        name: install
+      - run: bundler exec rake -t
+        name: test

data/.rubocop.yml

@@ -0,0 +1,127 @@
+Gemspec/RequiredRubyVersion:
+  Enabled: false # We support 1.9, but newer rubocops don't.
+
+# Metrics.
+
+Metrics/BlockLength:
+  Enabled: false # Default is true, but mostly hit in tests.
+
+Metrics/AbcSize:
+  Enabled: false # To allow for pre-existing code.
+
+Metrics/ClassLength:
+  Enabled: false # To allow for pre-existing code.
+
+Metrics/CyclomaticComplexity:
+  Enabled: false # To allow for pre-existing code.
+
+Metrics/MethodLength:
+  Enabled: false # To allow for pre-existing code.
+
+Metrics/PerceivedComplexity:
+  Enabled: false # To allow for pre-existing code.
+
+# Layout.
+
+Layout/LineLength:
+  Max: 150 # Default is 120.
+
+Layout/HashAlignment:
+  EnforcedHashRocketStyle: table # Default is key.
+  EnforcedColonStyle:      table # Default is key.
+
+Layout/ExtraSpacing:
+  ForceEqualSignAlignment: true # Default is false.
+
+Layout/IndentationStyle:
+  IndentationWidth: 2 # Default is <none>.
+
+# Style.
+
+Style/HashSyntax:
+  EnforcedStyle: ruby19_no_mixed_keys # Default is ruby19.
+
+Style/CollectionMethods:
+  Enabled: true # Default is false.
+
+Style/NumericLiterals:
+  MinDigits: 4 # Default is 5.
+
+Style/NegatedIf: # I disagree with this.
+  Enabled: false
+
+Style/IfUnlessModifier: # This doesn't always make sense.
+  Enabled: false
+
+Style/SymbolArray:
+  EnforcedStyle: brackets # Default is percent, but 1.9 doesn't support that.
+
+# Trailing commas are often good.
+Style/TrailingCommaInArguments:
+  Enabled: false
+Style/TrailingCommaInArrayLiteral:
+  Enabled: false
+Style/TrailingCommaInHashLiteral:
+  Enabled: false
+
+Style/SafeNavigation:
+  Enabled: false # Default is true, but this 1.9 doesn't support it.
+
+# Default is both which is probably fine, but it changes code and I don't want
+# to investigate any possible behavior change right now.
+Style/EmptyElse:
+  EnforcedStyle: empty
+
+Style/ConditionalAssignment:
+  Enabled: false # This produces kind of strange results.
+
+Style/Dir:
+  Enabled: false # This is good, but not supported on 1.9.
+
+Style/ExpandPathArguments:
+  Enabled: false # This causes us to use __dir__ which 1.9 doesn't support.
+
+Style/GuardClause:
+  Enabled: false # Doesn't always make sense.
+
+Style/Documentation:
+  Enabled: false # We should enable this, but allow for pre-existing code.
+
+Style/FormatStringToken:
+  Enabled: false # Seems unnecessary.
+
+# Naming.
+
+Naming/VariableNumber:
+  Enabled: false # Doesn't always make sense.
+
+# These are new and rubocop warns if you don't configure them.
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+Lint/RaiseException:
+  Enabled: true
+Lint/StructNewOverride:
+  Enabled: true
+Style/ExponentialNotation:
+  Enabled: true
+Style/HashEachMethods:
+  Enabled: true
+Style/HashTransformKeys:
+  Enabled: true
+Style/HashTransformValues:
+  Enabled: true
+Style/RedundantFetchBlock:
+  Enabled: true
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+Style/RedundantRegexpEscape:
+  Enabled: true
+Style/SlicingWithRange:
+  Enabled: true

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Minfraud Changelog
 
+## v1.2.0 (2020-07-15)
+
+* Adds new processor types to `Minfraud::Components::Payment`: `:cashfree`,
+  `:first_atlantic_commerce`, `:komoju`, `:paytm`, `:razorpay`, and
+  `:systempay`.
+* Adds support for three new Factors outputs: `/subscores/device` (the risk
+  associated with the device), `/subscores/email_local_part` (the risk
+  associated with the part of the email address before the @ symbol) and
+  `/subscores/shipping_address` (the risk associated with the shipping
+  address).
+* Adds support for providing your MaxMind account ID using the `account_id`
+  attribute instead of the `user_id` attribute. In a future release,
+  support for the `user_id` attribute will be removed.
+
 ## v1.1.0 (2020-06-19)
 
 * Adds support for the minFraud Report Transaction API. Reporting

data/Gemfile

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # coveralls fails on Ruby 1.9. My understanding is we don't need to run this on
 # more than one version anyway, so restrict to the current latest.
 version_pieces = RUBY_VERSION.split('.')
-major_version = version_pieces[0]
-minor_version = version_pieces[1]
+major_version  = version_pieces[0]
+minor_version  = version_pieces[1]
 if major_version == '2' && minor_version == '7'
   gem 'coveralls', require: false
 end

data/README.md

@@ -41,8 +41,8 @@ An account ID and license key are required to work with the web services.
 
 ```ruby
 Minfraud.configure do |c|
+  c.account_id  = 12345
   c.license_key = 'your_license_key'
-  c.user_id     = 'your_user_id'
 end
 ````
 

data/Rakefile

@@ -1,6 +1,21 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+RuboCop::RakeTask.new
+
+task default: :spec
+
+# The current version of rubocop supports Ruby 2.4+. While we could run its
+# older versions, the config isn't backwards compatible. Let's run it only for
+# 2.4+. This isn't perfect, but as long as 1.9+ tests pass we should be okay.
+version_pieces = RUBY_VERSION.split('.')
+major_version  = version_pieces[0]
+minor_version  = version_pieces[1]
+if major_version == '2' && minor_version.to_i >= 4
+  task default: :rubocop
+end

data/bin/console

@@ -1,7 +1,8 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-require "bundler/setup"
-require "minfraud"
+require 'bundler/setup'
+require 'minfraud'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +11,5 @@ require "minfraud"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start

data/lib/maxmind/geoip2/model/city.rb

@@ -68,9 +68,9 @@ module MaxMind
         # @!visibility private
         def initialize(record, locales)
           super(record, locales)
-          @city = MaxMind::GeoIP2::Record::City.new(record['city'], locales)
-          @location = MaxMind::GeoIP2::Record::Location.new(record['location'])
-          @postal = MaxMind::GeoIP2::Record::Postal.new(record['postal'])
+          @city         = MaxMind::GeoIP2::Record::City.new(record['city'], locales)
+          @location     = MaxMind::GeoIP2::Record::Location.new(record['location'])
+          @postal       = MaxMind::GeoIP2::Record::Postal.new(record['postal'])
           @subdivisions = create_subdivisions(record['subdivisions'], locales)
         end
 

data/lib/maxmind/geoip2/model/country.rb

@@ -69,16 +69,16 @@ module MaxMind
 
         # @!visibility private
         def initialize(record, locales)
-          @continent = MaxMind::GeoIP2::Record::Continent.new(
+          @continent           = MaxMind::GeoIP2::Record::Continent.new(
             record['continent'],
             locales,
           )
-          @country = MaxMind::GeoIP2::Record::Country.new(
+          @country             = MaxMind::GeoIP2::Record::Country.new(
             record['country'],
             locales,
           )
-          @maxmind = MaxMind::GeoIP2::Record::MaxMind.new(record['maxmind'])
-          @registered_country = MaxMind::GeoIP2::Record::Country.new(
+          @maxmind             = MaxMind::GeoIP2::Record::MaxMind.new(record['maxmind'])
+          @registered_country  = MaxMind::GeoIP2::Record::Country.new(
             record['registered_country'],
             locales,
           )
@@ -86,7 +86,7 @@ module MaxMind
             record['represented_country'],
             locales,
           )
-          @traits = MaxMind::GeoIP2::Record::Traits.new(record['traits'])
+          @traits              = MaxMind::GeoIP2::Record::Traits.new(record['traits'])
         end
       end
     end

data/lib/maxmind/geoip2/record/traits.rb

@@ -35,7 +35,7 @@ module MaxMind
           super(record)
           if !record.key?('network') && record.key?('ip_address') &&
              record.key?('prefix_length')
-            ip = IPAddr.new(record['ip_address']).mask(record['prefix_length'])
+            ip                = IPAddr.new(record['ip_address']).mask(record['prefix_length'])
             # We could use ip.prefix instead of record['prefix_length'], but that
             # method only becomes available in Ruby 2.5+.
             record['network'] = format('%s/%d', ip.to_s, record['prefix_length'])

data/lib/minfraud.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'minfraud'
 require 'minfraud/enum'
 require 'minfraud/components/base'
@@ -27,20 +29,41 @@ require 'minfraud/report'
 
 module Minfraud
   class << self
-    # @!attribute user_id
-    # @return [String] MaxMind account ID that is used for authorization
+    # The MaxMind account ID that is used for authorization.
+    #
+    # @return [Integer, nil]
+    attr_accessor :account_id
+
+    # The host to use when connecting to the web service.
+    #
+    # @return [String, nil]
+    attr_accessor :host
+
+    # The MaxMind account ID that is used for authorization.
+    #
+    # @deprecated Use {::account_id} instead. This will be removed in the next
+    #   major version.
+    #
+    # @return [Integer, nil]
     attr_accessor :user_id
 
-    # @!attribute license_key
-    # @return [String] MaxMind license key that is used for authorization
+    # The MaxMind license key that is used for authorization.
+    #
+    # @return [String, nil]
     attr_accessor :license_key
 
-    # @yield [self] to accept configuration settings
+    # Yield self to accept configuration settings.
+    #
+    # @yield [self]
     def configure
       yield self
     end
 
-    # @return [Hash] current Minfraud configuration
+    # The current Minfraud configuration.
+    #
+    # @deprecated This will be removed in the next major version.
+    #
+    # @return [Hash]
     def configuration
       {
         user_id:     @user_id,

data/lib/minfraud/assessments.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Minfraud
   class Assessments
     include ::Minfraud::HTTPService
@@ -83,11 +85,13 @@ module Minfraud
     define :factors
 
     private
+
     # Creates a unified request body from components converted to JSON
     # @return [Hash] Request body
     def request_body
-      MAPPING.keys.inject({}) do |mem, e|
-        next mem unless value = send(e)
+      MAPPING.keys.reduce({}) do |mem, e|
+        next mem unless (value = send(e))
+
         mem.merge!(e.to_s => value.to_json)
       end
     end

data/lib/minfraud/components/account.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Minfraud
   module Components
     class Account < Base

data/lib/minfraud/components/addressable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Minfraud
   module Components
     class Addressable < Base
@@ -14,11 +16,11 @@ module Minfraud
       attr_accessor :company
 
       # @attribute address
-      # @return [String] The first line of the user’s billing / shipping address
+      # @return [String] The first line of the user's billing / shipping address
       attr_accessor :address
 
       # @attribute address_2
-      # @return [String] The second line of the user’s billing / shipping address
+      # @return [String] The second line of the user's billing / shipping address
       attr_accessor :address_2
 
       # @attribute city
@@ -26,23 +28,23 @@ module Minfraud
       attr_accessor :city
 
       # @attribute region
-      # @return [String] The ISO 3166-2 subdivision code for the user’s billing / shipping address
+      # @return [String] The ISO 3166-2 subdivision code for the user's billing / shipping address
       attr_accessor :region
 
       # @attribute country
-      # @return [String] The two character ISO 3166-1 alpha-2 country code of the user’s billing / shipping address
+      # @return [String] The two character ISO 3166-1 alpha-2 country code of the user's billing / shipping address
       attr_accessor :country
 
       # @attribute postal
-      # @return [String] The postal code of the user’s billing / shipping address
+      # @return [String] The postal code of the user's billing / shipping address
       attr_accessor :postal
 
       # @attribute phone_number
-      # @return [String] The phone number without the country code for the user’s billing / shipping address
+      # @return [String] The phone number without the country code for the user's billing / shipping address
       attr_accessor :phone_number
 
       # @attribute phone_country_code
-      # @return [String] The country code for phone number associated with the user’s billing / shipping address
+      # @return [String] The country code for phone number associated with the user's billing / shipping address
       attr_accessor :phone_country_code
 
       # Creates Minfraud::Components::Addressable instance