minfraud 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,15 @@
 ---
-SHA1:
-  metadata.gz: 6a55c03cbdb1487ae09c4e1e8b0286b53f49ae98
-  data.tar.gz: 436b76d31314d1971fd511cce43e05d1cf80f1f4
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    YThlNDg5YmIwNzY5NjIyZjEyMWE4ODQwNjY0NWQxMTZhOGI3ZTdiNQ==
+  data.tar.gz: !binary |-
+    ZGZlMWUwYTI3ZGExNTk0MWVlMWUyNTI5Mzc0OTgwNGFkZWNmMTgyZQ==
 SHA512:
-  metadata.gz: febcdcdfc8828f99424d485f041f621ef9763b2eca5f2b7a401b5ad54b2f1b312711d47c782cd8f986848fdac46a749e17621e88f86bb98e9e6693cde3d8980a
-  data.tar.gz: 28279d249f2cc2495e4223337900f90c875eb48e6a667a75c994a8dc8ff19a9d0512b1914eac748e60a8a16a0d0973ee179f77c77657b4dad1185fdd2199cb3b
+  metadata.gz: !binary |-
+    YmY2ZWE4MTZkOTBkYTc3MjkyZjZjNTNiZjFlNmU0YWQ3YWY5Y2IwOGFlZDYx
+    ZDVjMzMwMjRkZjY5YjJjNmNmZTBmZjdmMTEwMjYzNWU4ZGI0ZjMyOGFlMjhk
+    NWI2NjFhMTRjMjdhMjQ5OWQxMzU5ZWMzMzU0M2FhMzg2ZTNhODI=
+  data.tar.gz: !binary |-
+    NGMzZGE3YTBlNjRhN2Y3ZTM1NGEzYmI0ZjI5YTU4ZGM4MjRhZDBjYjZkMmVj
+    MWVjMTQ1YmM0YzAzMjRjYThlYzgwYmIyYmI1MTRmMzg2YjQ2MTEwNzg0MDA4
+    YTg4N2U2NzYyYmIzMDQ5MWJkZGRlMWFiOGUxNjQ3Y2Q3ZGJiOWE=

data/CHANGELOG.md

@@ -0,0 +1,5 @@
+# Minfraud Changelog
+
+## v1.0.2
+
+* Adds support for Ruby >= 1.9

data/lib/minfraud/assessments.rb

@@ -45,11 +45,10 @@ module Minfraud
 
     # @param  [Hash] params hash of parameters
     # @param  [Minfraud::Resolver] resolver resolver that maps params to components
-    # In case if params is a Hash of components it just assignes them to corresponding
-    # instance variables
+    # @note In case when params is a Hash of components it just assigns them to the corresponding instance variables
     # @return [Minfraud::Assessments] Assessments instance
     def initialize(params = {}, resolver = ::Minfraud::Resolver)
-      resolver.assign(context: self, params: params)
+      resolver.assign(self, params)
     end
 
     # @!macro [attach] define
@@ -59,7 +58,7 @@ module Minfraud
     #   @return [Minfraud::HTTPService::Response] Wrapped minFraud response
     def self.define(endpoint)
       define_method(endpoint) do
-        raw       = request.perform(verb: :post, endpoint: endpoint, body: request_body)
+        raw       = request.perform(verb: :post, endpoint: endpoint.to_s, body: request_body)
         response  = ::Minfraud::HTTPService::Response.new(
           status:  raw.status.to_i,
           body:    raw.body,
@@ -78,7 +77,10 @@ module Minfraud
     # Creates a unified request body from components converted to JSON
     # @return [Hash] Request body
     def request_body
-      MAPPING.keys.inject({}) { |mem, e| mem.merge!(e.to_s => send(e)&.to_json) }
+      MAPPING.keys.inject({}) do |mem, e|
+        next mem unless value = send(e)
+        mem.merge!(e.to_s => value.to_json)
+      end
     end
 
     # Creates memoized Minfraud::HTTPService::Request instance

data/lib/minfraud/components/addressable.rb

@@ -46,7 +46,7 @@ module Minfraud
       attr_accessor :phone_country_code
 
       # Creates Minfraud::Components::Addressable instance
-      # This class is used as a parent class for Billing and Shipping components
+      # @note This class is used as a parent class for Billing and Shipping components
       # @param  [Hash] params hash of parameters
       # @return [Minfraud::Components::Addressable] an Addressable instance
       def initialize(params = {})

data/lib/minfraud/components/base.rb

@@ -1,12 +1,22 @@
 module Minfraud
   module Components
-    # Note: This class is used as a parent class for all other components
-    # It defines a method which is used for basic JSON representation of PORO objects
+    # @note This class is used as a parent class for all other components
+    # @note It defines a method which is used for basic JSON representation of PORO objects
     class Base
       # @return [Hash] a JSON representation of component attributes
       def to_json
-        instance_variables.inject({}) { |mem, e| mem.merge!(e.to_s.gsub(/@/, '') => instance_variable_get(e).to_s) }
-          .delete_if { |_, v| v.empty? }
+        instance_variables.inject({}) { |mem, e| populate!(mem, e) }
+      end
+
+      private
+
+      # @note   This method may modify passed hash. Non-existing instance variables are ignored
+      # @param  [Hash] hash an accumulator
+      # @param  [Symbol] v_sym an instance variable symbol
+      # @return [Hash] a hash containing a JSON representation of instance variable name and it's value
+      def populate!(hash, v_sym)
+        return hash unless value = instance_variable_get(v_sym)
+        hash.merge!(v_sym.to_s.gsub(/@/, '') => value.to_s)
       end
     end
   end

data/lib/minfraud/components/event.rb

@@ -16,13 +16,7 @@ module Minfraud
       attr_accessor :time
 
       # @attribute type
-      # @return [String] The type of event being scored. The valid types are:
-      #   => account_creation
-      #   => account_login
-      #   => purchase
-      #   => recurring_purchase
-      #   => referral
-      #   => survey
+      # @return [String] The type of event being scored
       enum_accessor :type, [:account_creation, :account_login, :purchase, :recurring_purchase, :referral, :survey]
 
       # Creates Minfraud::Components::Event instance

data/lib/minfraud/components/shipping.rb

@@ -4,10 +4,6 @@ module Minfraud
       include ::Minfraud::Enum
       # @attribute delivery_speed
       # @return [String] The shipping delivery speed for the order. The valid values are:
-      #    => same_day
-      #    => overnight
-      #    => expedited
-      #    => standard
       enum_accessor :delivery_speed, [:same_day, :overnight, :expedited, :standard]
 
       # Creates Minfraud::Components::Shipping instance

data/lib/minfraud/enum.rb

@@ -25,7 +25,7 @@ module Minfraud
           define_method("#{attribute}") { instance_variable_get("@#{attribute}") }
           define_method "#{attribute}=" do |value|
             raise NotEnumValueError,  'Value is not permitted' if value && !self.class.mapping[attribute].include?(value.intern)
-            instance_variable_set("@#{attribute}", value&.intern)
+            instance_variable_set("@#{attribute}", value ? value.intern : nil)
           end
         end
       end

data/lib/minfraud/error_handler.rb

@@ -7,7 +7,7 @@ module Minfraud
       def inspect(response)
         return response if response.status == 200
 
-        raise *STATUS_CODES.fetch(response.code&.intern, [ServerError, 'Service not available'])
+        raise *STATUS_CODES.fetch(response.code, [ServerError, 'Server error'])
       end
 
       # A hash that maps status codes returned by minFraud with errors & messages

data/lib/minfraud/http_service/request.rb

@@ -14,7 +14,7 @@ module Minfraud
       # Creates Minfraud::HTTPService::Request instance
       # @param  [Hash] params hash of parameters
       # @return [Minfraud::HTTPService::Request] Request instance
-      def initialize(params)
+      def initialize(params = {})
         @middleware = params[:middleware]
         @server     = params[:server]
       end

data/lib/minfraud/http_service/response.rb

@@ -16,16 +16,16 @@ module Minfraud
       # Creates Minfraud::HTTPService::Response instance
       # @param  [Hash] params hash of parameters
       # @return [Minfraud::HTTPService::Response] Response instance
-      def initialize(params)
+      def initialize(params = {})
         @status  = params[:status]
         @body    = params[:body]
         @headers = params[:headers]
       end
 
       # Returns minFraud specific response code
-      # @return [String] minFraud specific request code
+      # @return [Symbol] minFraud specific request code
       def code
-        body.code if body.respond_to?(:code)
+        body.code.intern if body.respond_to?(:code) && body.code
       end
     end
   end

data/lib/minfraud/resolver.rb

@@ -4,8 +4,8 @@ module Minfraud
       # @param  [Object] context an object for variable assignment
       # @param  [Hash] params a hash of parameters
       # @return [Array] a list of supplied params
-      # Note: Raises RequestFormatError once unpermitted key is met
-      def assign(context:, params:)
+      # @note Raises RequestFormatError once unpermitted key is met
+      def assign(context, params)
         Array(params).each do |key, value|
           raise RequestFormatError, "#{key} does not belong to request document format" unless MAPPING[key]
 

data/lib/minfraud/version.rb

@@ -1,3 +1,3 @@
 module Minfraud
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

data/minfraud.gemspec

@@ -13,13 +13,16 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/kushniryb/minfraud-api-v2"
   spec.license       = "MIT"
 
+  spec.required_ruby_version = '>= 1.9'
+
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency 'faraday'
-  spec.add_runtime_dependency 'faraday_middleware'
+  spec.add_runtime_dependency 'faraday', '~> 0.9', '>= 0.9.1'
+  spec.add_runtime_dependency 'faraday_middleware', '~> 0.9', '>= 0.9.1'
+  spec.add_runtime_dependency 'hashie', '~> 3.0'
   spec.add_development_dependency "bundler", "~> 1.12"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"

metadata

@@ -1,83 +1,109 @@
 --- !ruby/object:Gem::Specification
 name: minfraud
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - kushnir.yb
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-10-05 00:00:00.000000000 Z
+date: 2016-10-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.9.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.9'
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.9.1
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.9'
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.9.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.9'
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.9.1
+- !ruby/object:Gem::Dependency
+  name: hashie
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.12'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.0'
 description: 
@@ -87,9 +113,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rspec"
-- ".travis.yml"
+- .gitignore
+- .rspec
+- .travis.yml
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -131,19 +158,18 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '1.9'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.6
+rubygems_version: 2.4.3
 signing_key: 
 specification_version: 4
 summary: Ruby interface to the MaxMind minFraud v2.0 API services
 test_files: []
-has_rdoc: