minfra-cli 1.11.0 → 1.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba7dd8c8775a7ecedd048d2a6e6288727f86791bb0e3c9a97df882d29d10ddd1
-  data.tar.gz: 5a416953d916aff78611c5dcca45300434a54abb172aad5a5ad4118b9cb3206e
+  metadata.gz: ca90567af36553b84c7a69020e85970c56591d65f7546d1c22c1969cc9bd58f3
+  data.tar.gz: 451949094ac8fe4a3bc502b10ad1f8924f2cb5688da1297594061ab4c4e4780d
 SHA512:
-  metadata.gz: 1a0ab85e07b00c652cf41b94cff07cc327801d55f19eefe97a0d7301a2e0a8262196df760785fc6ef7ccd3d56e44deed3441260a868d4916266cb143b8c9d68e
-  data.tar.gz: 36a5f383251c4e6ae0f583f99e08606f07c1c6df198c721718d5dea1b2b9f1fab4629c7b99ee5950dd18a823148226b10bea2e558bfb5ce02c08ce800be3f7a5
+  metadata.gz: 6007ef02b33c582bb9bd002cb4b22adda6dd4e5ec32cf7646beb9597ef03181b8944a463fe5db943c84d19c6ed50c8b324a5bb383cfa975b0f4301e1ffb214d5
+  data.tar.gz: 1908c4e6f95565dc3ebdf2bf371808021166997691c0fcb3514a89b2d47cf379d551b1f5f1934032cfe08afcc180f6f4d75b39d694c584d036f46a5f86aa8f05

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+# 1.12.1
+ * replaced all relevant system calls with new runners (fixed apply and
+   generic_secrets)
+# 1.12.0
+ * refactoring Runner
+ * adding runner type system (popen is default)
+ * adding HelmRunner, KubectlRunner
+ * adding support for infra::allow_insecure_k8s_connections
+ * easing active support requirement
+
 # 1.11.0
  * generating helm output with resolved vairables in "helm_expanded"
  * adding template_dir to templater to render whole directories

data/lib/minfra/cli/commands/kube.rb

@@ -15,7 +15,10 @@ module Minfra
 
       def dashboard(stack_name,env,deployment,cluster)
         stack = init(stack_name,env,deployment,cluster)
-        exec("k9s --kubeconfig #{kube_config_path} --context #{stack.cluster_name} --namespace #{stack_name} --command pod")
+        insecure_flag = l("infra::allow_insecure_k8s_connections") ? "--insecure-skip-tls-verify" : ""
+        cmd = "k9s #{insecure_flag} --kubeconfig #{kube_config_path} --context #{stack.cluster_name} --namespace #{stack_name} --command pod"
+        debug(cmd)
+        exec(cmd)
       end
 
       def restart
@@ -154,9 +157,7 @@ module Minfra
 
         extra_args = extra_args.join(' ')
 
-        cmd = "helm --kube-context #{cluster} rollback #{options[:stack]} #{extra_args}"
-        #puts cmd
-        run_cmd(cmd, :exec)
+        run_helm("--kube-context #{cluster} rollback #{options[:stack]} #{extra_args}")
       end
 
       def list
@@ -195,9 +196,9 @@ module Minfra
 
         cluster = stack.cluster_name
         if [resource, implicit_resource].include?('pod') && ['delete', 'describe', 'exec', 'logs', 'port-forward'].include?(subcommand)
-          cmd_get_pods = "kubectl --kubeconfig #{kube_config_path} --context #{cluster} --namespace #{options[:stack]} get pod -o jsonpath='{range .items[*]}{.metadata.name}{\"\\n\"}'"
+          cmd_get_pods = "--kubeconfig #{kube_config_path} --context #{cluster} --namespace #{options[:stack]} get pod -o jsonpath='{range .items[*]}{.metadata.name}{\"\\n\"}'"
 
-          pods_list = run_cmd(cmd_get_pods).split("\n")
+          pods_list = run_kubectl(cmd_get_pods).stdout_lines
 
           fuzzy_pod_name = args.shift
 
@@ -230,9 +231,8 @@ module Minfra
 
         extra_args = extra_args.join(' ')
 
-        cmd = "kubectl --kubeconfig #{kube_config_path} --context #{cluster} --namespace #{options[:stack]} #{subcommand} #{resource} #{pod_name} #{extra_args}"
-        # puts cmd
-        run_cmd(cmd, :exec)
+        cmd = "--kubeconfig #{kube_config_path} --context #{cluster} --namespace #{options[:stack]} #{subcommand} #{resource} #{pod_name} #{extra_args}"
+        KubeCtlRunner.run(cmd, runner: :exec)
       end
 
       private
@@ -252,13 +252,11 @@ module Minfra
       end
 
       def run_kubectl(cmd)
-        #        run(%{kubectl --kubeconfig #{kube_config_path} #{cmd}})
-        run(%{kubectl #{cmd}})
+        KubeCtlRunner.run(cmd, runner: :system)
       end
 
       def run_helm(cmd)
-#        run(%{helm --kubeconfig #{kube_config_path} --home #{helm_path} #{cmd}})
-        run(%{helm #{cmd}})
+        HelmRunner.run(cmd, runner: :system)
       end
 
       def helm_path

data/lib/minfra/cli/helm_runner.rb

@@ -0,0 +1,11 @@
+module Minfra
+  module Cli
+    class HelmRunner < Runner
+      def initialize(cmd, **args)
+        insecure_flag = l("infra::allow_insecure_k8s_connections") ? "--kube-insecure-skip-tls-verify" : ""
+        cmd = "helm #{insecure_flag} #{cmd}"
+        super(cmd, **args)
+      end
+    end
+  end
+end

data/lib/minfra/cli/kubectl_runner.rb

@@ -0,0 +1,11 @@
+module Minfra
+  module Cli
+    class KubeCtlRunner < Runner
+      def initialize(cmd, **args)
+        insecure_flag = l("infra::allow_insecure_k8s_connections") ? "--insecure-skip-tls-verify" : ""
+        cmd = "kubectl #{insecure_flag} #{cmd}"
+        super(cmd, **args)
+      end
+    end
+  end
+end

data/lib/minfra/cli/runner.rb

@@ -11,6 +11,8 @@ module Minfra
 
         attr_writer :status
 
+        attr_reader :stdout_lines
+        
         def initialize
           @stderr_lines = []
           @stdout_lines = []
@@ -58,18 +60,58 @@ module Minfra
         new(cmd, **args).run
       end
 
-      attr_reader :exit_on_error
+      attr_reader :exit_on_error, :runner, :cmd
 
-      def initialize(cmd, exit_on_error: true)
+      def initialize(cmd, exit_on_error: true, runner: :popen)
         @cmd = cmd
         @exit_on_error = exit_on_error
+        @runner = runner
       end
 
       def run
-        debug("running: #{@cmd}")
-        res = nil
+        debug("running (#{@runner}): #{@cmd}")
+        res=case @runner
+          when :system
+            run_system(Result.new)
+          when :popen  
+            run_threaded(Result.new)
+          when :exec
+            run_exec(Result.new)  
+          else
+            raise "unknown runner #{@runner}"  
+        end
+        
+        if res.error?
+          error "command failed: #{@cmd}"
+          debug  res.stdout
+          info  res.stderr
+        end
+        if exit_on_error && res.error?
+          info "command exiting on error (#{res.exitstatus})"
+          exit 1
+        end
+        res
+      end
+      
+      private
+
+      def run_exec(_res)
+        exec(@cmd)
+      end
+      # you don't get stderr .... yet
+      def run_system(res)
+        #https://stackoverflow.com/questions/6338908/ruby-difference-between-exec-system-and-x-or-backticks
+        begin
+          out=`#{@cmd}`
+          out.each_line do |line| res.add(line, :stdout) end 
+        rescue StandardError
+        end
+        res.status = $?
+        res
+      end
+      
+      def run_threaded(res)
         begin
-          res = Result.new
           # see: http://stackoverflow.com/a/1162850/83386
           # the whole implementation is problematic as we migth miss some output lines
           # Open4 might be a solution. Using Select might be a solution. Using Process.fork might be a solution....
@@ -91,18 +133,9 @@ module Minfra
           end
         rescue StandardError
         end
-
-        if res.error?
-          error "command failed: #{@cmd}"
-          debug  res.stdout
-          info  res.stderr
-        end
-        if exit_on_error && res.error?
-          info "command exiting on error (#{res.exitstatus})"
-          exit 1
-        end
         res
       end
+      
     end
   end
 end

data/lib/minfra/cli/version.rb

@@ -1,5 +1,5 @@
 module Minfra
   module Cli
-    VERSION = '1.11.0'.freeze
+    VERSION = '1.12.1'.freeze
   end
 end

data/lib/minfra/cli.rb

@@ -16,6 +16,8 @@ require_relative 'cli/command'
 require_relative 'cli/ask'
 require_relative 'cli/document'
 require_relative 'cli/runner'
+require_relative 'cli/helm_runner'
+require_relative 'cli/kubectl_runner'
 require_relative 'cli/plugins'
 
 require 'active_support'

data/lib/orchparty/kubernetes_application.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+
+require 'English'
 require 'erb'
 require 'erubis'
 require 'open3'
@@ -10,34 +13,32 @@ require 'active_support/core_ext'
 module Orchparty
   module Services
     class Context
-      include ::Minfra::Cli::Logging 
+      include ::Minfra::Cli::Logging
 
-      attr_accessor :cluster_name
-      attr_accessor :namespace
-      attr_accessor :dir_path
-      attr_accessor :app_config
-      attr_accessor :options
+      attr_accessor :cluster_name, :namespace, :dir_path, :app_config, :options
 
-      def initialize(cluster_name: , namespace:, file_path: , app_config:, out_io: STDOUT, app: )
+      def initialize(cluster_name:, namespace:, file_path:, app_config:, app:, out_io: $stdout)
         self.cluster_name = cluster_name
         self.namespace = namespace
         self.dir_path = file_path
         self.app_config = app_config
         @app = app
         @out_io = out_io
-        self.options=options
+        self.options = options
       end
 
-      def template(file_path, helm, flag: "-f ", fix_file_path: nil)
-        return "" unless file_path
+      def template(file_path, helm, flag: '-f ', fix_file_path: nil)
+        return '' unless file_path
+
         puts "Rendering: #{file_path}"
-        file_path = File.join(self.dir_path, file_path)
-        if(file_path.end_with?(".erb"))
+        file_path = File.join(dir_path, file_path)
+
+        if file_path.end_with?('.erb')
           helm.application = OpenStruct.new(cluster_name: cluster_name, namespace: namespace)
           template = Erubis::Eruby.new(File.read(file_path))
           template.filename = file_path
           yaml = template.result(helm.get_binding)
-          file = Tempfile.new("kube-deploy.yaml")
+          file = Tempfile.new('kube-deploy.yaml')
           file.write(yaml)
           file.close
           file_path = file.path
@@ -46,11 +47,11 @@ module Orchparty
       end
 
       def print_install(helm)
-        @out_io.puts "---"
-        @out_io.puts install_cmd(helm, value_path(helm))
-        @out_io.puts upgrade_cmd(helm, value_path(helm))
-        @out_io.puts "---"
-        @out_io.puts File.read(template(value_path(helm), helm, flag: "")) if value_path(helm)
+        @out_io.puts '---'
+        @out_io.puts install_cmd(helm, value_path(helm)).cmd
+        @out_io.puts upgrade_cmd(helm, value_path(helm)).cmd
+        @out_io.puts '---'
+        @out_io.puts File.read(template(value_path(helm), helm, flag: '')) if value_path(helm)
       end
 
       # On 05.02.2021 we have decided that it would be best to print both commands.
@@ -60,11 +61,11 @@ module Orchparty
       end
 
       def upgrade(helm)
-        @out_io.puts system(upgrade_cmd(helm))
+        @out_io.puts upgrade_cmd(helm).run.stdout
       end
 
       def install(helm)
-        @out_io.puts system(install_cmd(helm))
+        @out_io.puts install_cmd(helm).run.stdout
       end
     end
 
@@ -74,11 +75,15 @@ module Orchparty
       end
 
       def upgrade_cmd(helm, fix_file_path = nil)
-        "helm upgrade --namespace #{namespace} --kube-context #{cluster_name} --version #{helm.version} #{helm.name} #{helm.chart} #{template(value_path(helm), helm, fix_file_path: fix_file_path)}"
+        Minfra::Cli::HelmRunner.new("upgrade --namespace #{namespace} --kube-context #{cluster_name} --version #{helm.version} #{helm.name} #{helm.chart} #{template(
+          value_path(helm), helm, fix_file_path: fix_file_path
+        )}")
       end
 
       def install_cmd(helm, fix_file_path = nil)
-        "helm install --create-namespace --namespace #{namespace} --kube-context #{cluster_name} --version #{helm.version} #{helm.name} #{helm.chart} #{template(value_path(helm), helm, fix_file_path: fix_file_path)}"
+        Minfra::Cli::HelmRunner.new("install --create-namespace --namespace #{namespace} --kube-context #{cluster_name} --version #{helm.version} #{helm.name} #{helm.chart} #{template(
+          value_path(helm), helm, fix_file_path: fix_file_path
+        )}")
       end
     end
 
@@ -88,11 +93,15 @@ module Orchparty
       end
 
       def upgrade_cmd(apply, fix_file_path = nil)
-        "kubectl apply --namespace #{namespace} --context #{cluster_name} #{template(value_path(apply), apply, fix_file_path: fix_file_path)}"
+        Minfra::Cli::KubeCtlRunner.new("apply --namespace #{namespace} --context #{cluster_name} #{template(
+          value_path(apply), apply, fix_file_path: fix_file_path
+        )}")
       end
 
       def install_cmd(apply, fix_file_path = nil)
-        "kubectl apply --namespace #{namespace} --context #{cluster_name} #{template(value_path(apply), apply, fix_file_path: fix_file_path)}"
+        Minfra::Cli::KubeCtlRunner.new("apply --namespace #{namespace} --context #{cluster_name} #{template(
+          value_path(apply), apply, fix_file_path: fix_file_path
+        )}")
       end
     end
 
@@ -101,43 +110,51 @@ module Orchparty
         secret[:from_file]
       end
 
-      def upgrade_cmd(secret, fix_file_path=nil)
-        "kubectl --namespace #{namespace} --context #{cluster_name} create secret generic --dry-run -o yaml #{secret[:name]}  #{template(value_path(secret), secret, flag: "--from-file=", fix_file_path: fix_file_path)} | kubectl --context #{cluster_name} apply -f -"
+      def upgrade_cmd(secret, fix_file_path = nil)
+        Minfra::Cli::KubeCtlRunner.new("--namespace #{namespace} --context #{cluster_name} create secret generic --dry-run -o yaml #{secret[:name]}  #{template(
+          value_path(secret), secret, flag: '--from-file=', fix_file_path: fix_file_path
+        )} | #{apply_cmd(cluster_name).cmd}")
       end
 
-      def install_cmd(secret, fix_file_path=nil)
-        "kubectl --namespace #{namespace} --context #{cluster_name} create secret generic --dry-run -o yaml #{secret[:name]}  #{template(value_path(secret), secret, flag: "--from-file=", fix_file_path: fix_file_path)} | kubectl --context #{cluster_name} apply -f -"
+      def install_cmd(secret, fix_file_path = nil)
+        Minfra::Cli::KubeCtlRunner.new("--namespace #{namespace} --context #{cluster_name} create secret generic --dry-run -o yaml #{secret[:name]}  #{template(
+          value_path(secret), secret, flag: '--from-file=', fix_file_path: fix_file_path
+        )} | #{apply_cmd(cluster_name).cmd}")
+      end
+
+      def apply_cmd(cluster_name)
+        Minfra::Cli::KubeCtlRunner.new("--context #{cluster_name} apply -f -")
       end
     end
 
     class Label < Context
       def print_install(label)
-        @out_io.puts "---"
+        @out_io.puts '---'
         @out_io.puts install_cmd(label)
       end
 
       def print_upgrade(label)
-        @out_io.puts "---"
+        @out_io.puts '---'
         @out_io.puts upgrade_cmd(label)
       end
 
       def upgrade_cmd(label)
-        "kubectl --namespace #{namespace} --context #{cluster_name} label --overwrite #{label[:resource]} #{label[:name]} #{label["value"]}"
+        Minfra::Cli::KubeCtlRunner.new("--namespace #{namespace} --context #{cluster_name} label --overwrite #{label[:resource]} #{label[:name]} #{label['value']}")
       end
 
       def install_cmd(label)
-        "kubectl --namespace #{namespace} --context #{cluster_name} label --overwrite #{label[:resource]} #{label[:name]} #{label["value"]}"
+        Minfra::Cli::KubeCtlRunner.new("--namespace #{namespace} --context #{cluster_name} label --overwrite #{label[:resource]} #{label[:name]} #{label['value']}")
       end
     end
 
     class Wait < Context
       def print_install(wait)
-        @out_io.puts "---"
+        @out_io.puts '---'
         @out_io.puts wait.cmd
       end
 
       def print_upgrade(wait)
-        @out_io.puts "---"
+        @out_io.puts '---'
         @out_io.puts wait.cmd
       end
 
@@ -159,19 +176,19 @@ module Orchparty
         end
       end
 
-
       def print_install(chart)
-        
         build_chart(chart) do |chart_path|
-          cmd="helm template --namespace #{namespace} --debug --kube-context #{cluster_name} --output-dir #{chart_path.join('..','helm_expanded')}   #{chart.name} #{chart_path}"
+          cmd = "helm template --namespace #{namespace} --debug --kube-context #{cluster_name} --output-dir #{chart_path.join(
+            '..', 'helm_expanded'
+          )}   #{chart.name} #{chart_path}"
           @out_io.puts `$cmd`
           if system("#{cmd} > /dev/null")
-            info("helm template check: OK")
+
+            info('helm template check: OK')
           else
-            error("helm template check: FAIL")
-          end  
+            error('helm template check: FAIL')
+          end
         end
-        
       end
 
       def print_upgrade(chart)
@@ -181,52 +198,49 @@ module Orchparty
       def install(chart)
         info("Install: #{chart.name}")
         build_chart(chart) do |chart_path|
-          @out_io.puts system("helm install --create-namespace --namespace #{namespace} --kube-context #{cluster_name} #{chart.name} #{chart_path}")
+          res = Minfra::Cli::HelmRunner.new("install --create-namespace --namespace #{namespace} --kube-context #{cluster_name} #{chart.name} #{chart_path}").run
+          @out_io.puts res.stdout
         end
       end
 
       def upgrade(chart)
         info("Upgrade: #{chart}")
         build_chart(chart) do |chart_path|
-          @out_io.puts system("helm upgrade --namespace #{namespace} --kube-context #{cluster_name} #{chart.name} #{chart_path}")
+          res = Minfra::Cli::HelmRunner.new("upgrade --namespace #{namespace} --kube-context #{cluster_name} #{chart.name} #{chart_path}").run
+          @out_io.puts res.stdout
         end
       end
+
       private
-      
+
       def build_chart(chart)
-        
-        
         dir = @app.status_dir.join('helm') # duplication
-        
-        params = chart._services.map {|s| app_config.services[s.to_sym] }.map{|s| [s.name, s]}.to_h
-        run(templates_path: File.expand_path(chart.template, self.dir_path), params: params, output_chart_path: dir, chart: chart)
+
+        params = chart._services.map { |s| app_config.services[s.to_sym] }.map { |s| [s.name, s] }.to_h
+        run(templates_path: File.expand_path(chart.template, dir_path), params: params, output_chart_path: dir,
+            chart: chart)
         yield dir
       end
 
-
-
       # remember:
       # this is done for an app
       # that app can have multiple charts with multiple services!
-      
-      def run(templates_path:, params:, output_chart_path:, chart: )
 
-        
-        File.open(File.join(output_chart_path, 'values.yaml'),'a') do |helm_values|
+      def run(templates_path:, params:, output_chart_path:, chart:)
+        File.open(File.join(output_chart_path, 'values.yaml'), 'a') do |helm_values|
           params.each do |app_name, subparams|
             subparams[:chart] = chart
-            used_vars=generate_documents_from_erbs(
+            used_vars = generate_documents_from_erbs(
               templates_path: templates_path,
               app_name: app_name,
               params: subparams,
               output_chart_path: output_chart_path
             )
-            used_vars.each do |variable,value| 
+            used_vars.each do |variable, value|
               helm_values.puts "#{variable}: \"#{value}\""
             end
           end
         end
-        
       end
 
       def generate_documents_from_erbs(templates_path:, app_name:, params:, output_chart_path:)
@@ -236,13 +250,13 @@ module Orchparty
         end
 
         kind = params.fetch(:kind)
-        params._used_vars = {} #here we'll collect all used vars
+        params._used_vars = {} # here we'll collect all used vars
 
         Dir[File.join(templates_path, kind, '*.erb')].each do |template_path|
           info("Rendering Template: #{template_path}")
           template_name = File.basename(template_path, '.erb')
           output_path = File.join(output_chart_path, 'templates', "#{app_name}-#{template_name}")
-          
+
           template = Erubis::Eruby.new(File.read(template_path))
           template.filename = template_path
 
@@ -252,14 +266,13 @@ module Orchparty
           begin
             document = template.result(CleanBinding.new.get_binding(params))
           rescue Exception
-            error "#{template_path} has a problem: #{$!.inspect}"
+            error "#{template_path} has a problem: #{$ERROR_INFO.inspect}"
             raise
           end
           File.write(output_path, document)
         end
         params._used_vars
       end
-
     end
   end
 end
@@ -267,19 +280,16 @@ end
 class KubernetesApplication
   include Minfra::Cli::Logging
 
-  attr_accessor :cluster_name
-  attr_accessor :file_path
-  attr_accessor :namespace
-  attr_accessor :app_config
+  attr_accessor :cluster_name, :file_path, :namespace, :app_config
   attr_reader :status_dir
 
-  def initialize(app_config: [], namespace:, cluster_name:, file_name:, status_dir:, out_io: STDOUT)
-    self.file_path = Pathname.new(file_name).parent.expand_path #path of the stack
+  def initialize(namespace:, cluster_name:, file_name:, status_dir:, app_config: [], out_io: $stdout)
+    self.file_path = Pathname.new(file_name).parent.expand_path # path of the stack
     self.cluster_name = cluster_name
     self.namespace = namespace
     self.app_config = app_config
     @status_dir = status_dir
-    @out_io= out_io
+    @out_io = out_io
   end
 
   def install
@@ -295,17 +305,17 @@ class KubernetesApplication
   end
 
   private
+
   def prepare
-    
     output_chart_path = @status_dir.join('helm')
     output_chart_path.rmtree if output_chart_path.exist?
     output_chart_path.mkpath
-    templates_path = file_path.join('../../chart-templates').expand_path #don't ask. the whole concept of multiple charts in an app stinks...
-    
+    templates_path = file_path.join('../../chart-templates').expand_path # don't ask. the whole concept of multiple charts in an app stinks...
+
     generate_chart_yaml(
-          templates_path: templates_path,
-          output_chart_path: output_chart_path,
-          chart_name: namespace,
+      templates_path: templates_path,
+      output_chart_path: output_chart_path,
+      chart_name: namespace
     )
 
     info("generating base helm structure from: #{output_chart_path} from #{templates_path}")
@@ -313,26 +323,26 @@ class KubernetesApplication
 
     system("cp #{File.join(templates_path, 'values.yaml')} #{File.join(output_chart_path, 'values.yaml')}")
     system("cp #{File.join(templates_path, '.helmignore')} #{File.join(output_chart_path, '.helmignore')}")
-    system("cp #{File.join(templates_path, 'templates/_helpers.tpl')} #{File.join(output_chart_path, 'templates/_helpers.tpl')}")
-
+    system("cp #{File.join(templates_path,
+                           'templates/_helpers.tpl')} #{File.join(output_chart_path, 'templates/_helpers.tpl')}")
   end
 
-  def generate_chart_yaml(templates_path:, output_chart_path:, chart_name: )
+  def generate_chart_yaml(templates_path:, output_chart_path:, chart_name:)
     template_path = File.join(templates_path, 'Chart.yaml.erb')
     output_path = File.join(output_chart_path, 'Chart.yaml')
 
-    res=Minfra::Cli::Templater.read(template_path, params: {chart_name: chart_name})
+    res = Minfra::Cli::Templater.read(template_path, params: { chart_name: chart_name })
     File.write(output_path, res)
   end
-  
+
   def combine_charts(app_config)
     services = app_config._service_order.map(&:to_s)
     app_config._service_order.each do |name|
       current_service = app_config[:services][name]
-      if current_service._type == "chart"
-        current_service._services.each do |n|
-          services.delete n.to_s
-        end
+      next unless current_service._type == 'chart'
+
+      current_service._services.each do |n|
+        services.delete n.to_s
       end
     end
     services
@@ -344,14 +354,14 @@ class KubernetesApplication
     services.each do |name|
       service = app_config[:services][name]
       info "Service: #{name}(#{service._type}) #{method}"
-      deployable_class="::Orchparty::Services::#{service._type.classify}".constantize
-      deployable=deployable_class.new(cluster_name: cluster_name, 
-                     namespace: namespace, 
-                     file_path: file_path, 
-                     app_config: app_config, 
-                     out_io: @out_io, 
-                     app: self)
-                     
+      deployable_class = "::Orchparty::Services::#{service._type.classify}".constantize
+      deployable = deployable_class.new(cluster_name: cluster_name,
+                                        namespace: namespace,
+                                        file_path: file_path,
+                                        app_config: app_config,
+                                        out_io: @out_io,
+                                        app: self)
+
       deployable.send(method, service)
     end
   end

data/minfra-cli.gemspec

@@ -31,9 +31,10 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency "table_print", "1.5.6"
   spec.add_runtime_dependency "rest-client", "~>2.0"
   spec.add_runtime_dependency "hashie", "~>3.5"
-  spec.add_runtime_dependency "activesupport", "~> 6.1"
+  spec.add_runtime_dependency "activesupport", ">= 6.1"
   spec.add_runtime_dependency "erubis", "~> 2.7"
   spec.add_runtime_dependency "hiera", "3.9.0"
   spec.add_runtime_dependency "hiera-eyaml", "3.3.0"
   spec.add_runtime_dependency "hiera-eyaml-gpg", "0.7.4"
 end
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minfra-cli
 version: !ruby/object:Gem::Version
-  version: 1.11.0
+  version: 1.12.1
 platform: ruby
 authors:
 - Peter Schrammel
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-05-16 00:00:00.000000000 Z
+date: 2023-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -76,14 +76,14 @@ dependencies:
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '6.1'
 - !ruby/object:Gem::Dependency
@@ -185,7 +185,9 @@ files:
 - lib/minfra/cli/common.rb
 - lib/minfra/cli/config.rb
 - lib/minfra/cli/document.rb
+- lib/minfra/cli/helm_runner.rb
 - lib/minfra/cli/hook.rb
+- lib/minfra/cli/kubectl_runner.rb
 - lib/minfra/cli/logging.rb
 - lib/minfra/cli/main_command.rb
 - lib/minfra/cli/plugins.rb
@@ -237,7 +239,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.6
+rubygems_version: 3.3.7
 signing_key: 
 specification_version: 4
 summary: A cli framework for k8s based development and deployment.