minato_ruby_api_client 0.2.8 → 0.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 02fb9f5aacc6d902765edab876eaf8683524cf4e316c0904942cbc264e0752f4
-  data.tar.gz: ef183cfd8211a90cbce9a0a0ad289f3ffb14bdc3d265ed3e3ce1db6e6232a5dd
+  metadata.gz: 45411b504804ac12f92faecfe179060bdd00d565625671c8f6635b1b26ec66b0
+  data.tar.gz: 76665d77f7d0d036152d0389c7625185a0b244160803b8f614866fc1c6aacc78
 SHA512:
-  metadata.gz: 4ac4f87be5a401c6cb4cb69eae9e77119883304eb9bea5cc6a66966bc3906d63d11d1b1f1338c37d5d879ee8b5b58ac63aa8c931bda6ed16d51408f9f8823165
-  data.tar.gz: d45d5bdfc88e0ac4d53845f1c8afc2eba032a6255b10545253e4555cb53a153c617a0bdbcb5c2dc7b9dd9681b07f980639dd9af86a3e24bcdc97d519b164307d
+  metadata.gz: c9b8ba15364e4b92dc7d485da1b6d8dae44b66f53058a42ab8be4073aff5d8d954180da03b4a0b6c59d82141ea1a8b6403c1c9b27bd246f9207538f230a5e0d4
+  data.tar.gz: a5d9bde60aeaccfbfee2dfe6e71c3bab5bf01d81bb3e3f069a019614dd45429fe6f776f46ca259ccf907278c20aab44a3ee84b96e4054f6783c144dcc39d73eb

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    minato_ruby_api_client (0.2.8)
+    minato_ruby_api_client (0.2.9)
       faraday (>= 1.0, < 3.0)
       minato-trace (>= 0.2.0)
       minato_error_handler (>= 0.1.13)

data/lib/minato_ruby_api_client/api_client.rb

@@ -72,7 +72,7 @@ module MinatoRubyApiClient
         unless response.success?
           error = self.class.module_parent::ApiError.new(:status_code => response.status,
                               :res => response, :req => request)
-          error.caused_by = response.reason_phrase
+          error.caused_by = response.reason_phrase unless error.upstream_error?
 
           fail error
         end

data/lib/minato_ruby_api_client/api_error.rb

@@ -1,4 +1,5 @@
 require 'minato_error_handler'
+require 'json'
 
 module MinatoRubyApiClient
   class ApiError < MinatoErrorHandler::Errors::ExternalError
@@ -6,11 +7,54 @@ module MinatoRubyApiClient
 
     def initialize(res: nil, req: nil, status_code: 500)
       super(req: req, res: res)
+      @upstream_error = nil
       @status_code = status_code
+      extracted_error, extracted_status = extract_upstream_error(res)
+      @upstream_error = extracted_error
+      @status_code = extracted_status || status_code
     end
 
     def message
-      "An error occurred while communicating with the API."
+      upstream_field("message") || "An error occurred while communicating with the API."
     end
+
+    def code
+      upstream_field("code") || super
+    end
+
+    def details
+      upstream_field("details") || super
+    end
+
+    def caused_by
+      upstream_field("caused_by") || super
+    end
+
+    def upstream_error?
+      !@upstream_error.nil? && !@upstream_error.empty?
+    end
+
+    private
+
+      def extract_upstream_error(res)
+        return [nil, nil] unless res.respond_to?(:body)
+
+        body = res.body
+        return [nil, nil] if body.nil? || body.empty?
+
+        parsed = JSON.parse(body)
+        return [nil, nil] unless parsed.is_a?(Hash)
+
+        upstream = parsed["error"] || parsed
+        return [nil, nil] unless upstream.is_a?(Hash) && upstream["code"]
+
+        [upstream, upstream["status_code"]&.to_i]
+      rescue JSON::ParserError
+        [nil, nil]
+      end
+
+      def upstream_field(key)
+        @upstream_error&.[](key)
+      end
   end
 end

data/lib/minato_ruby_api_client/version.rb

@@ -1,3 +1,3 @@
 module MinatoRubyApiClient
-  VERSION = '0.2.8'
+  VERSION = '0.2.9'
 end

data/spec/api_error_spec.rb

@@ -0,0 +1,97 @@
+require 'spec_helper'
+
+describe MinatoRubyApiClient::ApiError do
+  def fake_response(body:, status: 422)
+    double("Faraday::Response", body: body, status: status)
+  end
+
+  let(:upstream_error_body) do
+    JSON.generate({
+      "error" => {
+        "code"        => "AccountSvc::Errors::AccountNotFound",
+        "message"     => "Account not found",
+        "status_code" => 404,
+        "details"     => { "account_id" => "abc-123" },
+        "caused_by"   => "Couldn't find Account with id=abc-123"
+      }
+    })
+  end
+
+  context "when the upstream response contains a Minato error payload" do
+    subject(:error) do
+      described_class.new(res: fake_response(body: upstream_error_body, status: 404))
+    end
+
+    it "propagates the upstream code" do
+      expect(error.code).to eq("AccountSvc::Errors::AccountNotFound")
+    end
+
+    it "propagates the upstream message" do
+      expect(error.message).to eq("Account not found")
+    end
+
+    it "propagates the upstream status_code" do
+      expect(error.status_code).to eq(404)
+    end
+
+    it "propagates the upstream details" do
+      expect(error.details).to eq({ "account_id" => "abc-123" })
+    end
+
+    it "propagates the upstream caused_by" do
+      expect(error.caused_by).to eq("Couldn't find Account with id=abc-123")
+    end
+  end
+
+  context "when the upstream response has no Minato error payload" do
+    subject(:error) do
+      described_class.new(res: fake_response(body: "Service Unavailable", status: 503), status_code: 503)
+    end
+
+    it "falls back to the default code (class name)" do
+      expect(error.code).to eq("MinatoRubyApiClient::ApiError")
+    end
+
+    it "falls back to the default message" do
+      expect(error.message).to eq("An error occurred while communicating with the API.")
+    end
+
+    it "uses the provided status_code" do
+      expect(error.status_code).to eq(503)
+    end
+  end
+
+  context "when the upstream response body is empty" do
+    subject(:error) do
+      described_class.new(res: fake_response(body: "", status: 500), status_code: 500)
+    end
+
+    it "falls back to default behavior" do
+      expect(error.code).to eq("MinatoRubyApiClient::ApiError")
+      expect(error.message).to eq("An error occurred while communicating with the API.")
+    end
+  end
+
+  context "when the upstream response body is invalid JSON" do
+    subject(:error) do
+      described_class.new(res: fake_response(body: "<html>error</html>", status: 500), status_code: 500)
+    end
+
+    it "falls back to default behavior without raising" do
+      expect(error.code).to eq("MinatoRubyApiClient::ApiError")
+      expect(error.message).to eq("An error occurred while communicating with the API.")
+    end
+  end
+
+  describe "#upstream_error?" do
+    it "returns true when the response contains a Minato error payload" do
+      error = described_class.new(res: fake_response(body: upstream_error_body, status: 404))
+      expect(error.upstream_error?).to be true
+    end
+
+    it "returns false when the response has no Minato error payload" do
+      error = described_class.new(res: fake_response(body: "", status: 503), status_code: 503)
+      expect(error.upstream_error?).to be false
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minato_ruby_api_client
 version: !ruby/object:Gem::Version
-  version: 0.2.8
+  version: 0.2.9
 platform: ruby
 authors:
 - Ferreri
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-03-18 00:00:00.000000000 Z
+date: 2026-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -99,6 +99,7 @@ files:
 - lib/minato_ruby_api_client/version.rb
 - minato_ruby_api_client.gemspec
 - spec/api_client_spec.rb
+- spec/api_error_spec.rb
 - spec/configuration_spec.rb
 - spec/minato_ruby_api_client_spec.rb
 - spec/spec_helper.rb
@@ -127,6 +128,7 @@ specification_version: 4
 summary: A Minato ruby HTTP Client
 test_files:
 - spec/api_client_spec.rb
+- spec/api_error_spec.rb
 - spec/configuration_spec.rb
 - spec/minato_ruby_api_client_spec.rb
 - spec/spec_helper.rb