milkfarm-onix 0.7.7 → 0.8.3

data/spec/product_identifier_spec.rb

@@ -1,15 +1,13 @@
 # coding: utf-8
 
-$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
-
-require 'onix'
+require File.dirname(__FILE__) + '/spec_helper.rb'
 
 context "ONIX::ProductIdentifier" do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
     file1    = File.join(data_path, "product_identifier.xml")
-    @doc = LibXML::XML::Document.file(file1)
+    @doc     = Nokogiri::XML::Document.parse(File.read(file1))
     @root = @doc.root
   end
 

data/spec/product_spec.rb

@@ -1,16 +1,13 @@
 # coding: utf-8
 
-$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
-
-require 'onix'
-require 'date'
+require File.dirname(__FILE__) + '/spec_helper.rb'
 
 context "ONIX::Product" do
 
   before(:each) do
     @data_path = File.join(File.dirname(__FILE__),"..","data")
     file1    = File.join(@data_path, "product.xml")
-    @doc = LibXML::XML::Document.file(file1)
+    @doc     = Nokogiri::XML::Document.parse(File.read(file1))
     @product_node = @doc.root
   end
 

data/spec/publisher_spec.rb

@@ -1,15 +1,13 @@
 # coding: utf-8
 
-$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
-
-require 'onix'
+require File.dirname(__FILE__) + '/spec_helper.rb'
 
 context "ONIX::Publisher" do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
     file1    = File.join(data_path, "publisher.xml")
-    @doc = LibXML::XML::Document.file(file1)
+    @doc     = Nokogiri::XML::Document.parse(File.read(file1))
     @root = @doc.root
   end
 

data/spec/reader_spec.rb

@@ -1,43 +1,36 @@
 # coding: utf-8
 
-$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
-
-require 'onix'
+require File.dirname(__FILE__) + '/spec_helper.rb'
 
 context "ONIX::Reader" do
 
   before(:each) do
-    data_path = File.join(File.dirname(__FILE__),"..","data")
-    @file1    = File.join(data_path, "9780194351898.xml")
-    @file2    = File.join(data_path, "two_products.xml")
-    @long_file   = File.join(data_path, "Bookwise_July_2008.xml")
-    @entity_file = File.join(data_path, "entities.xml")
-    @utf_16_file = File.join(data_path, "utf_16.xml")
-    @iso_8859_1_file = File.join(data_path, "iso_8859_1.xml")
+    @data_path = File.join(File.dirname(__FILE__),"..","data")
+    @file1    = File.join(@data_path, "9780194351898.xml")
+    @file2    = File.join(@data_path, "two_products.xml")
+    @long_file   = File.join(@data_path, "Bookwise_July_2008.xml")
+    @entity_file = File.join(@data_path, "entities.xml")
+    @utf_16_file = File.join(@data_path, "utf_16.xml")
+    @iso_8859_1_file = File.join(@data_path, "iso_8859_1.xml")
   end
 
   specify "should initialize with a filename" do
     reader = ONIX::Reader.new(@file1)
-    reader.instance_variable_get("@reader").should be_a_kind_of(LibXML::XML::Reader)
+    reader.instance_variable_get("@reader").should be_a_kind_of(Nokogiri::XML::Reader)
   end
 
   specify "should initialize with an IO object" do
     File.open(@file1,"rb") do |f|
       reader = ONIX::Reader.new(f)
-      reader.instance_variable_get("@reader").should be_a_kind_of(LibXML::XML::Reader)
+      reader.instance_variable_get("@reader").should be_a_kind_of(Nokogiri::XML::Reader)
     end
   end
 
-  # This is commented out as the code that I was using to read the ONIX version from the
-  # input was causing segfaults and other stability issues
-  specify "should provide access to various XML metadata from file"
-  #do
-  #  reader = ONIX::Reader.new(@file1)
-  #  reader.encoding.should eql("utf-8")
-  #  reader.xml_lang.should eql(nil)
-  #  reader.xml_version.should eql(1.0)
-  #  reader.version.should eql([2,1,0])
-  #end
+  specify "should provide access to various XML metadata from file" do
+    filename = File.join(@data_path, "reference_with_release_attrib.xml")
+    reader = ONIX::Reader.new(filename)
+    reader.release.should eql(BigDecimal.new("2.1"))
+  end
 
   specify "should provide access to the header in an ONIX file" do
     reader = ONIX::Reader.new(@file1)

data/spec/sales_restriction_spec.rb

@@ -1,15 +1,13 @@
 # coding: utf-8
 
-$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
-
-require 'onix'
+require File.dirname(__FILE__) + '/spec_helper.rb'
 
 context "ONIX::SalesRestriction" do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
     file1    = File.join(data_path, "sales_restriction.xml")
-    @doc = LibXML::XML::Document.file(file1)
+    @doc     = Nokogiri::XML::Document.parse(File.read(file1))
     @root = @doc.root
   end
 

data/spec/sender_identifier.rb

@@ -1,15 +1,13 @@
 # coding: utf-8
 
-$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
-
-require 'onix'
+require File.dirname(__FILE__) + '/spec_helper.rb'
 
 context "ONIX::SenderIdentifier" do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
     file1    = File.join(data_path, "sender_identifier.xml")
-    @doc = LibXML::XML::Document.file(file1)
+    @doc     = Nokogiri::XML::Document.parse(File.read(file1))
     @root = @doc.root
   end
 

data/spec/series_identifier_spec.rb

@@ -1,15 +1,13 @@
 # coding: utf-8
 
-$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
-
-require 'onix'
+require File.dirname(__FILE__) + '/spec_helper.rb'
 
 context "ONIX::SeriesIdentifier" do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
     file1    = File.join(data_path, "series_identifier.xml")
-    @doc = LibXML::XML::Document.file(file1)
+    @doc = Nokogiri::XML::Document.parse(File.read(file1))
     @root = @doc.root
   end
 
@@ -20,17 +18,17 @@ context "ONIX::SeriesIdentifier" do
 
   specify "should provide read access to first level attibutes" do
     series = ONIX::SeriesIdentifier.from_xml(@root.to_s)
-    
+
     series.series_id_type.should eql(1)
     series.id_value.should eql("10001")
   end
 
   specify "should provide write access to first level attibutes" do
     series = ONIX::SeriesIdentifier.new
-    
+
     series.series_id_type = 9
     series.to_xml.to_s.include?("<SeriesIDType>09</SeriesIDType>").should be_true
-    
+
     series.id_value = 999
     series.to_xml.to_s.include?("<IDValue>999</IDValue>").should be_true
   end

data/spec/series_spec.rb

@@ -1,15 +1,13 @@
 # coding: utf-8
 
-$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
-
-require 'onix'
+require File.dirname(__FILE__) + '/spec_helper.rb'
 
 context "ONIX::Series" do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
     file1    = File.join(data_path, "series.xml")
-    @doc = LibXML::XML::Document.file(file1)
+    @doc = Nokogiri::XML::Document.parse(File.read(file1))
     @root = @doc.root
   end
 
@@ -20,13 +18,13 @@ context "ONIX::Series" do
 
   specify "should provide read access to first level attibutes" do
     series = ONIX::Series.from_xml(@root.to_s)
-    
+
     series.title_of_series.should eql("Citizens and Their Governments")
   end
 
   specify "should provide write access to first level attibutes" do
     series = ONIX::Series.new
-    
+
     series.title_of_series = "Cool Science Careers"
     series.to_xml.to_s.include?("<TitleOfSeries>Cool Science Careers</TitleOfSeries>").should be_true
   end

data/spec/set_spec.rb

@@ -0,0 +1,32 @@
+# coding: utf-8
+
+require File.dirname(__FILE__) + '/spec_helper.rb'
+
+context "ONIX::Set" do
+
+  before(:each) do
+    data_path = File.join(File.dirname(__FILE__),"..","data")
+    file1    = File.join(data_path, "set.xml")
+    @doc = Nokogiri::XML::Document.parse(File.read(file1))
+    @root = @doc.root
+  end
+
+  specify "should correctly convert to a string" do
+    set = ONIX::Set.from_xml(@root.to_s)
+    set.to_xml.to_s[0,5].should eql("<Set>")
+  end
+
+  specify "should provide read access to first level attibutes" do
+    set = ONIX::Set.from_xml(@root.to_s)
+
+    set.title_of_set.should eql("Citizens and Their Governments")
+  end
+
+  specify "should provide write access to first level attibutes" do
+    set = ONIX::Set.new
+
+    set.title_of_set = "Cool Science Careers"
+    set.to_xml.to_s.include?("<TitleOfSet>Cool Science Careers</TitleOfSet>").should be_true
+  end
+
+end

data/spec/sl_product_spec.rb

@@ -1,48 +1,100 @@
 # coding: utf-8
 
-$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
-
-require 'onix'
+require File.dirname(__FILE__) + '/spec_helper.rb'
 require 'date'
 
 context "ONIX::SLProduct" do
 
   before(:each) do
     @data_path = File.join(File.dirname(__FILE__),"..","data")
-    file1 = File.join(@data_path, "sl_product.xml")
-    @doc = LibXML::XML::Document.file(file1)
+    file1    = File.join(@data_path, "product.xml")
+    @doc     = Nokogiri::XML::Document.parse(File.read(file1))
     @product_node = @doc.root
   end
 
-  specify "should provide read access to attibrutes" do
+  specify "should provide read access to attibutes" do
     @product = ONIX::Product.from_xml(@product_node.to_s)
-    @sl = ONIX::SLProduct.new(@product)
+    @sl     = ONIX::SLProduct.new(@product)
 
-    @sl.record_reference.should eql("10001")
-    @sl.notification_type.should eql(2)
-    @sl.number_of_pages.should eql(32)
-    @sl.publishing_status.should eql(2)
-    @sl.publication_date.should eql(Date.civil(2009,12,1))
-    @sl.copyright_year.should eql(2008)
+    @sl.record_reference.should eql("365-9780194351898")
+    @sl.notification_type.should eql(3)
+    @sl.product_form.should eql("BC")
+    @sl.number_of_pages.should eql(100)
+    @sl.bic_main_subject.should eql("EB")
+    @sl.publishing_status.should eql(4)
+    @sl.publication_date.should eql(Date.civil(1998,9,1))
+    @sl.pack_quantity.should eql(12)
   end
 
   specify "should provide write access to attibutes" do
-    apa = ONIX::SLProduct.new
+    sl = ONIX::SLProduct.new
+
+    sl.notification_type = 3
+    sl.to_xml.to_s.include?("<NotificationType>03</NotificationType>").should be_true
+
+    sl.record_reference = "365-9780194351898"
+    sl.to_xml.to_s.include?("<RecordReference>365-9780194351898</RecordReference>").should be_true
+
+    sl.product_form = "BC"
+    sl.to_xml.to_s.include?("<ProductForm>BC</ProductForm>").should be_true
+
+    sl.number_of_pages = 100
+    sl.to_xml.to_s.include?("<NumberOfPages>100</NumberOfPages>").should be_true
+
+    sl.bic_main_subject = "EB"
+    sl.to_xml.to_s.include?("<BICMainSubject>EB</BICMainSubject>").should be_true
+
+    sl.publishing_status = 4
+    sl.to_xml.to_s.include?("<PublishingStatus>04</PublishingStatus>").should be_true
 
-    apa.notification_type = 3
-    apa.to_xml.to_s.include?("<NotificationType>03</NotificationType>").should be_true
+    sl.publication_date = Date.civil(1998,9,1)
+    sl.to_xml.to_s.include?("<PublicationDate>19980901</PublicationDate>").should be_true
+
+    sl.pack_quantity = 12
+    sl.to_xml.to_s.include?("<PackQuantity>12</PackQuantity>").should be_true
+  end
+
+end
+
+context ONIX::SLProduct, "series method" do
+  specify "should set the nested series value on the underlying product class" do
+    sl = ONIX::SLProduct.new
+
+    sl.series = "Harry Potter"
+    sl.series = "Lemony Snicket"
+    sl.to_xml.to_s.include?("<TitleOfSeries>Harry Potter</TitleOfSeries>").should be_true
+    sl.to_xml.to_s.include?("<TitleOfSeries>Lemony Snicket</TitleOfSeries>").should be_true
+  end
+end
 
-    apa.record_reference = "999"
-    apa.to_xml.to_s.include?("<RecordReference>999</RecordReference>").should be_true
+context ONIX::SLProduct, "price method" do
+  before(:each) do
+    @data_path = File.join(File.dirname(__FILE__),"..","data")
+    file1    = File.join(@data_path, "usd.xml")
+    @doc     = Nokogiri::XML::Document.parse(File.read(file1))
+    @product_node = @doc.root
+  end
 
-    apa.number_of_pages = 100
-    apa.to_xml.to_s.include?("<NumberOfPages>100</NumberOfPages>").should be_true
+  specify "should return the first price in the file, regardless of type" do
+    @product = ONIX::Product.from_xml(@product_node.to_s)
+    @sl     = ONIX::SLProduct.new(@product)
 
-    apa.publishing_status = 4
-    apa.to_xml.to_s.include?("<PublishingStatus>04</PublishingStatus>").should be_true
+    @sl.price.should eql(BigDecimal.new("99.95"))
+  end
+end
 
-    apa.publication_date = Date.civil(1998,9,1)
-    apa.to_xml.to_s.include?("<PublicationDate>19980901</PublicationDate>").should be_true
+context ONIX::SLProduct, "rrp_exc_sales_tax method" do
+  before(:each) do
+    @data_path = File.join(File.dirname(__FILE__),"..","data")
+    file1    = File.join(@data_path, "usd.xml")
+    @doc     = Nokogiri::XML::Document.parse(File.read(file1))
+    @product_node = @doc.root
   end
 
+  specify "should return the first price in the file of type 1" do
+    @product = ONIX::Product.from_xml(@product_node.to_s)
+    @sl     = ONIX::SLProduct.new(@product)
+
+    @sl.rrp_exc_sales_tax.should eql(BigDecimal.new("99.95"))
+  end
 end

data/spec/spec_helper.rb

@@ -0,0 +1,8 @@
+# coding: utf-8
+
+require 'date'
+require 'stringio'
+require 'rubygems'
+gem "activesupport", "<= 2.9.9"
+$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
+require 'onix'

data/spec/stock_spec.rb

@@ -1,15 +1,13 @@
 # coding: utf-8
 
-$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
-
-require 'onix'
+require File.dirname(__FILE__) + '/spec_helper.rb'
 
 context "ONIX::Stock" do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
     file1    = File.join(data_path, "stock.xml")
-    @doc = LibXML::XML::Document.file(file1)
+    @doc     = Nokogiri::XML::Document.parse(File.read(file1))
     @root = @doc.root
   end
 

data/spec/subject_spec.rb

@@ -1,15 +1,13 @@
 # coding: utf-8
 
-$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
-
-require 'onix'
+require File.dirname(__FILE__) + '/spec_helper.rb'
 
 context "ONIX::Subject" do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
     file1    = File.join(data_path, "subject.xml")
-    @doc = LibXML::XML::Document.file(file1)
+    @doc     = Nokogiri::XML::Document.parse(File.read(file1))
     @root = @doc.root
   end
 

data/spec/supply_detail_spec.rb

@@ -1,15 +1,13 @@
 # coding: utf-8
 
-$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
-
-require 'onix'
+require File.dirname(__FILE__) + '/spec_helper.rb'
 
 context "ONIX::SupplyDetail" do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
     file1    = File.join(data_path, "supply_detail.xml")
-    @doc = LibXML::XML::Document.file(file1)
+    @doc     = Nokogiri::XML::Document.parse(File.read(file1))
     @root = @doc.root
   end