mikras_utils 0.4.3 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3ab95c37caacbe1ab7ed069d6d6fb83b6a234e1b64e5206e1a5382d5e7eb6507
-  data.tar.gz: a778c6dd04db370c1be6b6af571929dbadc2b5220148726c21da74527a84693a
+  metadata.gz: 46a6caa587baa5d73d1eee1af5a8cf764fc64e70be223f0b66aae6f1f41c6b91
+  data.tar.gz: a13096682ea8ec58b36b0154922b7e56fa914e51a756eda8a0f434106e8b1cc2
 SHA512:
-  metadata.gz: 84004bdb6c46d4f41a992fc5929d557704b886a975ba167011a2afd8e867cdf0787703a8cc12aa61443a4987b8b05a7a8c70595714bafcd81510cd37524c309d
-  data.tar.gz: 3bece44a7fba65f2db3a7016a9a9d26595c1e7d97b4c1b5759628977e23cd0db980307c6d73987dbb75bd74cc3f0184fd9cd7440d2c1d571573aa90df4af62d9
+  metadata.gz: ac6234c5bcdbc6b2bcf1301c8a6b2c23c4a71a43abaeb47e37c3908126c3d8bfd25bafa439d7ec59a3070f6f5b4706edafc454191a4725d46ab487dad0bf1686
+  data.tar.gz: 005a114875b9eedbbf2d87d20fa752d8fbde45fd18773bee8d7a7f16373e80d65f0d9a8b9546c3bff67b3c9f429a3119cef8d13e96dbaa916ca6bd19d3f6aa51

data/lib/mikras_utils/mkacl/analyzer.rb

@@ -28,8 +28,8 @@ module MkAcl
           and ref_schema_name = '#{spec.app_schema}'
       )
 
-      # Assign table references
       for child_table_name, child_table_uid, parent_table_name, parent_table_uid, parent_link_field in links
+        # Detect uncovered tables
         if !spec.key?(child_table_name)
           @uncovered_tables << child_table_name
           next
@@ -38,9 +38,11 @@ module MkAcl
           next
         end
 
+        # Find referenced table objects
         child_table = spec[child_table_name] or raise "Can't find table #{parent_table_name.inspect}"
         parent_table = spec[parent_table_name] or raise "Can't find referenced table #{parent_table_name.inspect}"
 
+        # Assign table references
         child_table.references[parent_table.name] = [parent_table, parent_link_field]
       end
 

data/lib/mikras_utils/mkacl/generators/seeds.rb

@@ -33,10 +33,13 @@ module MkAcl
             insert into acl_portal.acl_tables (
                 schema_name, table_name, domain,
                 parent_schema_name, parent_table_name, parent_link_field,
-                acl)
+                acl_link_fields, acl)
               values (
                 '#{app_schema}', '#{table}', #{conn.quote_value(table.domain)},
-                '#{table.parent && table.app_schema}', '#{table.parent}', '#{table.parent_link_field}',
+                #{PgConn.quote_value(table.parent && table.app_schema)},
+                #{PgConn.quote_value(table.parent)},
+                #{PgConn.quote_value(table.parent_link_field)},
+                #{PgConn.quote_value(table.references.values.map(&:last), elem_type: 'text')},
                 #{table.acl || 'false'})
               returning id as "table_id"
             \\gset

data/lib/mikras_utils/mkacl/spec.rb

@@ -47,14 +47,14 @@ module MkAcl
     attr_reader :spec
     forward_to :@spec, :app_schema, :acl_schema
 
-    # Hash from referenced table name to a tuple of the table object and the
-    # link field.  Initialized by the analyzer
-    attr_accessor :references
-
     # Table name and uid
     attr_reader :name
     attr_reader :uid # SCHEMA.TABLE name
 
+    # Hash from referenced table name to a tuple of the table object and the
+    # link field. Initialized by the analyzer
+    attr_accessor :references
+
     # Parent domain table. Initialized by the analyzer
     attr_accessor :parent
 
@@ -91,6 +91,7 @@ module MkAcl
       @uid = "#{app_schema}.#{@name}"
       @record_name = Prick::Inflector.singularize(@name)
       @parent_name = parent_name
+      @parent_link_fields = []
       @domain = domain
       @acl = acl
       @actions = {}
@@ -108,7 +109,7 @@ module MkAcl
       indent {
         puts "domain: #{domain}" if domain
         puts "parent: #{parent}" if parent
-        puts "references: [#{references.values.map(&:first).map(&:name).join(' ')}]"
+        puts "references: [#{references.values.map { |k,v| "#{v}->#{k.name}" }.join(' ')}]"
         for action_name in %w(insert select update delete)
           actions[action_name]&.dump
         end
@@ -166,11 +167,11 @@ module MkAcl
 
     attr_reader :action
     forward_to :action, :table, :name
-    attr_accessor :roles
-    attr_accessor :filter # Goes into the postgres policy
-    attr_accessor :assert # Goes into the postgres trigger
-    attr_accessor :fields # Only used for insert and update
-    attr_accessor :tables # Only used for attach
+    attr_accessor :roles # Roles that this rule applies to
+    attr_accessor :filter # Goes into the postgres policy, may be nil
+    attr_accessor :assert # Goes into the postgres trigger, may be nil
+    attr_accessor :fields # Only used for insert and update, nil otherwise
+    attr_accessor :tables # Only used for attach, nil otherwise
     attr_reader :ordinal
 
     # admin, internal, etc.
@@ -183,8 +184,10 @@ module MkAcl
       @action = action
       @ordinal = ordinal
       @roles = []
-      @fields = []
-      @tables = []
+      @filter = nil
+      @assert = nil
+      @fields = %w(insert update).include?(action.name) ? [] : nil
+      @tables = %w(attach).include?(action.name) ? [] : nil
 
       action.send :attach_rule, self
     end
@@ -193,8 +196,8 @@ module MkAcl
       puts "roles: [#{roles.join(' ')}]"
       puts "filter: #{filter}" if filter
       puts "assert: #{assert}" if assert
-      puts "fields: [#{fields.join(' ')}]" if !fields.empty?
-      puts "tables: [#{tables.join(' ')}]" if !tables.empty?
+      puts "fields: [#{fields.join(' ')}]" if fields && !fields.empty?
+      puts "tables: [#{tables.join(' ')}]" if tables && !tables.empty?
       puts "ordinal: #{ordinal}"
     end
   end

data/lib/mikras_utils/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MikrasUtils
-  VERSION = "0.4.3"
+  VERSION = "0.5.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mikras_utils
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.5.0
 platform: ruby
 authors:
 - Claus Rasmussen
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-01-08 00:00:00.000000000 Z
+date: 2025-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pg_conn