mihari 5.7.0 → 5.7.1

data/lib/mihari/web/endpoints/rules.rb

@@ -7,6 +7,113 @@ module Mihari
       # Rule API endpoint
       #
       class Rules < Grape::API
+        class RuleSearcher < Mihari::Service
+          class ResultValue
+            # @return [Array<Mihari::Models::Rule>]
+            attr_reader :rules
+
+            # @return [Integer]
+            attr_reader :total
+
+            # @return [Mihari::Structs::Filters::Rule::SearchFilterWithPagination]
+            attr_reader :filter
+
+            #
+            # @param [Array<Mihari::Models::Rule>] rules
+            # @param [Integer] total
+            # @param [Mihari::Structs::Filters::Rule::SearchFilterWithPagination] filter
+            #
+            def initialize(rules:, total:, filter:)
+              @rules = rules
+              @total = total
+              @filter = filter
+            end
+          end
+
+          #
+          # @params [Hash]
+          #
+          # @return [ResultValue]
+          #
+          def call(params)
+            filter = params.to_h.to_snake_keys
+
+            # normalize keys
+            filter["tag_name"] = filter["tag"]
+            # symbolize hash keys
+            filter = filter.to_h.symbolize_keys
+
+            search_filter_with_pagination = Mihari::Structs::Filters::Rule::SearchFilterWithPagination.new(**filter)
+            rules = Mihari::Models::Rule.search(search_filter_with_pagination)
+            total = Mihari::Models::Rule.count(search_filter_with_pagination.without_pagination)
+
+            ResultValue.new(rules: rules, total: total, filter: filter)
+          end
+        end
+
+        class RuleGetter < Service
+          #
+          # @params [String] id
+          #
+          # @return [Mihari::Models::Rule]
+          #
+          def call(id)
+            Mihari::Models::Rule.find id
+          end
+        end
+
+        class RuleRunner < Service
+          #
+          # @param [String] id
+          #
+          def call(id)
+            rule = Mihari::Rule.from_model(Mihari::Models::Rule.find(id))
+            rule.call
+          end
+        end
+
+        class RuleCreator < Service
+          #
+          # @params [String]
+          #
+          # @return [Mihari::Models::Rule]
+          #
+          def call(yaml)
+            rule = Rule.from_yaml(yaml)
+
+            found = Mihari::Models::Rule.find_by_id(rule.id)
+            error!({ message: "ID:#{rule.id} is already registered" }, 400) unless found.nil?
+
+            rule.model.save
+            rule
+          end
+        end
+
+        class RuleUpdater < Service
+          #
+          # @params [String] id
+          # @params [String] yaml
+          #
+          # @return [Mihari::Models::Rule]
+          #
+          def call(id:, yaml:)
+            Mihari::Models::Rule.find(id)
+
+            rule = Rule.from_yaml(yaml)
+            rule.model.save
+            rule
+          end
+        end
+
+        class RuleDestroyer < Service
+          #
+          # @param [String] id
+          #
+          def call(id)
+            Mihari::Models::Rule.find(id).destroy
+          end
+        end
+
         namespace :rules do
           desc "Get Rule IDs", {
             is_array: true,
@@ -27,33 +134,21 @@ module Mihari
           params do
             optional :page, type: Integer, default: 1
             optional :limit, type: Integer, default: 10
-
             optional :title, type: String
             optional :description, type: String
             optional :tag, type: String
-
             optional :fromAt, type: DateTime
             optional :toAt, type: DateTime
           end
           get "/" do
-            filter = params.to_h.to_snake_keys
-
-            # normalize keys
-            filter["tag_name"] = filter["tag"]
-            # symbolize hash keys
-            filter = filter.to_h.symbolize_keys
-
-            search_filter_with_pagenation = Structs::Filters::Rule::SearchFilterWithPagination.new(**filter)
-            rules = Mihari::Models::Rule.search(search_filter_with_pagenation)
-            total = Mihari::Models::Rule.count(search_filter_with_pagenation.without_pagination)
-
-            present(
-              { rules: rules,
-                total: total,
-                current_page: filter[:page].to_i,
-                page_size: filter[:limit].to_i },
-              with: Entities::RulesWithPagination
-            )
+            value = RuleSearcher.call(params.to_h)
+            present({
+              rules: value.rules,
+              total: value.total,
+              current_page: value.filter[:page].to_i,
+              page_size: value.filter[:limit].to_i
+            },
+              with: Entities::RulesWithPagination)
           end
 
           desc "Get a rule", {
@@ -65,23 +160,16 @@ module Mihari
             requires :id, type: String
           end
           get "/:id" do
-            extend Dry::Monads[:result, :try]
-
-            id = params["id"].to_s
-
-            result = Try do
-              Mihari::Models::Rule.find(id)
-            end.to_result
-
+            id = params[:id].to_s
+            result = RuleGetter.result(params[:id].to_s)
             return present(result.value!, with: Entities::Rule) if result.success?
 
             failure = result.failure
             case failure
             when ActiveRecord::RecordNotFound
               error!({ message: "ID:#{id} is not found" }, 404)
-            else
-              raise failure
             end
+            raise failure
           end
 
           desc "Run a rule", {
@@ -92,24 +180,19 @@ module Mihari
             requires :id, type: String
           end
           get "/:id/run" do
-            extend Dry::Monads[:result, :try]
-
-            id = params["id"].to_s
-
-            result = Try { Rule.from_model(Mihari::Models::Rule.find(id)) }.to_result
+            id = params[:id].to_s
+            result = RuleRunner.result(id)
             if result.success?
-              result.value!.analyzer.run
               status 201
-              return present({ message: "ID:#{id} is ran successfully" }, with: Entities::Message)
+              return present({ message: "ID:#{id}} ran successfully" }, with: Entities::Message)
             end
 
             failure = result.failure
             case failure
             when ActiveRecord::RecordNotFound
               error!({ message: "ID:#{id} is not found" }, 404)
-            else
-              raise failure
             end
+            raise failure
           end
 
           desc "Create a rule", {
@@ -120,22 +203,7 @@ module Mihari
             requires :yaml, type: String, documentation: { param_type: "body" }
           end
           post "/" do
-            extend Dry::Monads[:result, :try]
-
-            yaml = params[:yaml]
-            result = Try { Rule.from_yaml(yaml) }.to_result.bind do |rule|
-              Try do
-                found = Mihari::Models::Rule.find_by_id(rule.id)
-                error!({ message: "ID:#{rule.id} is already registered" }, 400) unless found.nil?
-                rule
-              end.to_result
-            end.bind do |rule|
-              Try do
-                rule.model.save
-                rule
-              end.to_result
-            end
-
+            result = RuleCreator.result(params[:yaml])
             if result.success?
               status 201
               return present(result.value!.model, with: Entities::Rule)
@@ -146,10 +214,9 @@ module Mihari
             when Psych::SyntaxError
               error!({ message: failure.message }, 400)
             when ValidationError
-              error!({ message: "Data format is invalid", details: failure.errors.to_h }, 400)
-            else
-              raise failure
+              error!({ message: "Rule format is invalid", details: failure.errors.to_h }, 400)
             end
+            raise failure
           end
 
           desc "Update a rule", {
@@ -161,22 +228,8 @@ module Mihari
             requires :yaml, type: String, documentation: { param_type: "body" }
           end
           put "/" do
-            extend Dry::Monads[:result, :try]
-
-            id = params[:id]
-            yaml = params[:yaml]
-
-            result = Try do
-              Mihari::Models::Rule.find(id)
-            end.to_result.bind do |_|
-              Try { Rule.from_yaml(yaml) }.to_result
-            end.bind do |rule|
-              Try do
-                rule.model.save
-                rule
-              end.to_result
-            end
-
+            id = params[:id].to_s
+            result = RuleUpdater.result(id: id, yaml: params[:yaml].to_s)
             if result.success?
               status 201
               return present(result.value!.model, with: Entities::Rule)
@@ -189,10 +242,9 @@ module Mihari
             when Psych::SyntaxError
               error!({ message: failure.message }, 400)
             when ValidationError
-              error!({ message: "Data format is invalid", details: failure.errors.to_h }, 400)
-            else
-              raise failure
+              error!({ message: "Rule format is invalid", details: failure.errors.to_h }, 400)
             end
+            raise failure
           end
 
           desc "Delete a rule", {
@@ -204,15 +256,8 @@ module Mihari
             requires :id, type: String
           end
           delete "/:id" do
-            extend Dry::Monads[:result, :try]
-
-            id = params["id"].to_s
-
-            result = Try do
-              rule = Mihari::Models::Rule.find(id)
-              rule.destroy
-            end.to_result
-
+            id = params[:id].to_s
+            result = RuleDestroyer.result(id)
             if result.success?
               status 204
               return present({ message: "ID:#{id} is deleted" }, with: Entities::Message)
@@ -222,9 +267,8 @@ module Mihari
             case failure
             when ActiveRecord::RecordNotFound
               error!({ message: "ID:#{id} is not found" }, 404)
-            else
-              raise failure
             end
+            raise failure
           end
         end
       end

data/lib/mihari/web/endpoints/tags.rb

@@ -7,6 +7,15 @@ module Mihari
       # Tag API endpoint
       #
       class Tags < Grape::API
+        class TagDestroyer < Service
+          #
+          # @param [Integer] id
+          #
+          def call(id)
+            Mihari::Models::Tag.find(id).destroy
+          end
+        end
+
         namespace :tags do
           desc "Get tags", {
             is_array: true,
@@ -24,17 +33,11 @@ module Mihari
             summary: "Delete a tag"
           }
           params do
-            requires :name, type: String
+            requires :id, type: Integer
           end
-          delete "/:name" do
-            extend Dry::Monads[:result, :try]
-
-            name = params[:name].to_s
-
-            result = Try do
-              Mihari::Models::Tag.where(name: name).destroy_all
-            end.to_result
-
+          delete "/:id" do
+            id = params[:id].to_i
+            result = TagDestroyer.result(id)
             if result.success?
               status 204
               return present({ message: "" }, with: Entities::Message)
@@ -43,10 +46,9 @@ module Mihari
             failure = result.failure
             case failure
             when ActiveRecord::RecordNotFound
-              error!({ message: "Name:#{name} is not found" }, 404)
-            else
-              raise failure
+              error!({ message: "ID:#{id} is not found" }, 404)
             end
+            raise failure
           end
         end
       end