migration_investigation 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 91513fab4ee07b15ace6022637aac1c4a6b0d63c
-  data.tar.gz: 678ac5207077c480991cbf8434c782dad0723d51
+  metadata.gz: 698aa3dfb32aa648d5a042ce6f82180fa661658e
+  data.tar.gz: be6eb8f95205d6268a85f7ea3079d392ba421b68
 SHA512:
-  metadata.gz: 8e932ec123891349b920a8bd9b6d0f7c54eea89e0fd5bc39900635bb7beda5bac25f0bede1f84524e00bed31e51c38f446b60c740ad77f0c706c3f2b4822cc2f
-  data.tar.gz: ab1cc4ed15336aae4d5ef5a5409f5f873690db37e5e9b6467272867d691c8da11889ff8786099eae9ca639779c9280dc159445faacb4e5624caa40553d932d5f
+  metadata.gz: 46bbd693ef9b2729cba74692597475368dd399c31e8a84380f1b7aaf2375a2cd998a032b314afec08c1d568dec2efb12582ca64e5aa770191f87b98118421f26
+  data.tar.gz: d9ad4ea08aaf11ab13f864a90b70aa26de8600122559fa512b73ae4b95dbf28df995b5a219f87821254d7958d5a2c7929e25a39df512428bb641640282539f48

data/README.md

@@ -22,7 +22,7 @@ Or install it yourself as:
 
 The gem is very simple:
 
-  $ MigrationInvestigation.pending_migrations? "staging", "abc123"
+    $ MigrationInvestigation.pending_migrations? "staging", "abc123"
 
 Where `staging` is the name of the tag, and `abc123` is the SHA you're about to deploy.
 You can also pass nil for the SHA you're about to deploy and it will assume you're deloying `HEAD`.
@@ -30,7 +30,7 @@ You can also pass nil for the SHA you're about to deploy and it will assume you'
 If you'd also like to check additional files or directories, say seed data, you can pass in a third
 parameter:
 
-  $ MigrationInvestigation.pending_migrations? "staging", "abc123", additional_paths: ["db/seed.rb", "app/foo.txt"]
+    $ MigrationInvestigation.pending_migrations? "staging", "abc123", additional_paths: ["db/seed.rb", "app/foo.txt"]
 
 ## Contributing
 

data/lib/migration_investigation/version.rb

@@ -1,3 +1,3 @@
 module MigrationInvestigation
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/migration_investigation.rb

@@ -3,23 +3,28 @@ require "migration_investigation/version"
 module MigrationInvestigation
   class << self
     def pending_migrations?(stage, new_sha, options={})
-      interesting_paths = options.fetch(:additional_paths, [])
-      interesting_paths = [interesting_paths] unless interesting_paths.is_a?(Array)
-      interesting_paths << "db/migrate/"
-      old_sha = get_latest_sha stage
-      change_count = get_change_count old_sha, new_sha, interesting_paths
-      change_count != 0
+      old_sha = latest_stage_sha stage
+      return true if old_sha.nil?
+
+      change_count(old_sha, new_sha, build_interesting_paths(options)) != 0
     end
 
     private
 
-    def get_latest_sha(stage)
-      AutoTagger::Base.new({}).refs_for_stage(stage).last.sha
+    def latest_stage_sha(stage)
+      latest_tag = AutoTagger::Base.new({}).refs_for_stage(stage).last
+      latest_tag.sha if latest_tag
     end
 
-    def get_change_count(old_sha, new_sha, interesting_paths)
+    def change_count(old_sha, new_sha, interesting_paths)
       changes = `git diff --name-only #{old_sha} #{new_sha} #{interesting_paths.join(" ")} | wc -l`
       changes.to_i
     end
+
+    def build_interesting_paths(options)
+      interesting_paths = ["db/migrate/"]
+      interesting_paths << options.fetch(:additional_paths, [])
+      interesting_paths.flatten
+    end
   end
 end

data/spec/migration_investigation_spec.rb

@@ -5,55 +5,65 @@ describe MigrationInvestigation do
     let(:stage) { "stage" }
     let(:new_sha) { "abc123" }
 
-    let(:refs) { [ref1, ref2] }
-    let(:ref1) { double(:ref1) }
-    let(:ref2) { double(:ref2, sha: old_sha) }
-    let(:old_sha) { "cba321" }
-
     before do
       auto_tagger = double(:auto_tagger)
       allow(AutoTagger::Base).to receive(:new).with({}).and_return(auto_tagger)
       allow(auto_tagger).to receive(:refs_for_stage).with(stage).and_return(refs)
     end
 
-    context "when no additional paths are passed in" do
-      subject { MigrationInvestigation.pending_migrations? stage, new_sha }
+    context "when there are refs for the given stage" do
+      let(:refs) { [ref1, ref2] }
+      let(:ref1) { double(:ref1) }
+      let(:ref2) { double(:ref2, sha: old_sha) }
+      let(:old_sha) { "cba321" }
 
-      before do
-        allow(MigrationInvestigation).to receive(:`).with("git diff --name-only #{old_sha} #{new_sha} db/migrate/ | wc -l").and_return(git_diff)
-      end
+      context "when no additional paths are passed in" do
+        subject { MigrationInvestigation.pending_migrations? stage, new_sha }
 
-      context "when there are migrations changed between the last tag for the given change, and the new SHA" do
-        let(:git_diff) { "       3\n" }
+        before do
+          allow(MigrationInvestigation).to receive(:`).with("git diff --name-only #{old_sha} #{new_sha} db/migrate/ | wc -l").and_return(git_diff)
+        end
 
-        it { is_expected.to be_truthy }
-      end
+        context "when there are migrations changed between the last tag for the given change, and the new SHA" do
+          let(:git_diff) { "       3\n" }
 
-      context "when there are no migrations changes between the last tag for the given change, and the new SHA" do
-        let(:git_diff) { "       0\n" }
+          it { is_expected.to be_truthy }
+        end
 
-        it { is_expected.to be_falsy }
+        context "when there are no migrations changes between the last tag for the given change, and the new SHA" do
+          let(:git_diff) { "       0\n" }
+
+          it { is_expected.to be_falsy }
+        end
       end
-    end
 
-    context "when additional paths are passed in" do
-      subject { MigrationInvestigation.pending_migrations? stage, new_sha, additional_paths: ["app/foo.rb"]  }
+      context "when additional paths are passed in" do
+        subject { MigrationInvestigation.pending_migrations? stage, new_sha, additional_paths: ["app/foo.rb"]  }
 
-      before do
-        allow(MigrationInvestigation).to receive(:`).with("git diff --name-only #{old_sha} #{new_sha} app/foo.rb db/migrate/ | wc -l").and_return(git_diff)
-      end
+        before do
+          allow(MigrationInvestigation).to receive(:`).with("git diff --name-only #{old_sha} #{new_sha} db/migrate/ app/foo.rb | wc -l").and_return(git_diff)
+        end
 
-      context "when there are changes between the last tag for the given change, and the new SHA" do
-        let(:git_diff) { "       3\n" }
+        context "when there are changes between the last tag for the given change, and the new SHA" do
+          let(:git_diff) { "       3\n" }
 
-        it { is_expected.to be_truthy }
-      end
+          it { is_expected.to be_truthy }
+        end
 
-      context "when there are no changes between the last tag for the given change, and the new SHA" do
-        let(:git_diff) { "       0\n" }
+        context "when there are no changes between the last tag for the given change, and the new SHA" do
+          let(:git_diff) { "       0\n" }
 
-        it { is_expected.to be_falsy }
+          it { is_expected.to be_falsy }
+        end
       end
     end
+
+    context "when there are no refs for the given stage" do
+      subject { MigrationInvestigation.pending_migrations? stage, new_sha }
+
+      let(:refs) { [] }
+
+      it { is_expected.to be_truthy }
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: migration_investigation
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Brent Wheeldon