mighty_grid 0.6.0 → 0.6.1

data/spec/lib/base_spec.rb

@@ -1,7 +1,8 @@
 require 'spec_helper'
 
 describe MightyGrid::Base do
-  
+  DIRECTIONS = ['asc', 'desc']
+
   before(:all) do
     @controller = ActionView::TestCase::TestController.new
 
@@ -9,7 +10,7 @@ describe MightyGrid::Base do
       page: 1,
       per_page: 15,
       name: 'grid',
-      :include => nil,
+      include: nil,
       joins: nil,
       conditions: nil,
       group: nil
@@ -41,93 +42,69 @@ describe MightyGrid::Base do
     end
 
     context 'with custom' do
-      before(:all){ @controller.params = {'grid' => {page: 5, per_page: 30, name: 'grid2'}} }
+      before(:all) { @controller.params = { 'grid' => { page: 5, per_page: 30, name: 'grid2' } } }
       subject { MightyGrid::Base.new(User, @controller) }
       its(:params) { should == @controller.params }
       its(:mg_params) { should == @default_options.merge(page: 5, per_page: 30, name: 'grid2') }
-      after(:all){ @controller.params = {} }
+      after(:all) { @controller.params = {} }
     end
 
     context 'with bad options' do
-      it { expect{MightyGrid::Base.new(User, @controller, bad_option: 123)}.to raise_error(ArgumentError) }
+      it { expect { MightyGrid::Base.new(User, @controller, bad_option: 123) }.to raise_error(ArgumentError) }
     end
   end
 
   describe '#get_current_grid_param' do
-    before(:all){ @controller.params = {'grid'=>{per_page: 30}} }
+    before(:all) { @controller.params = { 'grid' => { per_page: 30 } } }
     subject { MightyGrid::Base.new(User, @controller).get_current_grid_param(:per_page) }
     it { should == 30 }
-    after(:all){ @controller.params = {} }
+    after(:all) { @controller.params = {} }
   end
 
   describe '#current_order_direction' do
-    context 'with ASC controller param' do
-      before(:all){ @controller.params = {'grid'=>{'order_direction' => 'asc'}} }
-      subject { MightyGrid::Base.new(User, @controller) }
-      its(:current_order_direction) { should == 'asc' }
-      after(:all){ @controller.params = {} }
-    end
-
-    context 'with DESC controller param' do
-      before(:all){ @controller.params = {'grid'=>{'order_direction' => 'desc'}} }
-      subject { MightyGrid::Base.new(User, @controller) }
-      its(:current_order_direction) { should == 'desc' }
-      after(:all){ @controller.params = {} }
-    end
-
-    context 'with BAD controller param' do
-      before(:all){ @controller.params = {'grid'=>{'order_direction' => 'bad'}} }
-      subject { MightyGrid::Base.new(User, @controller) }
-      its(:current_order_direction) { should == nil }
-      after(:all){ @controller.params = {} }
+    (DIRECTIONS + ['bad']).each do |direction|
+      context "with #{ direction.upcase } controller param" do
+        before(:all) { @controller.params = { 'grid' => { 'order_direction' => direction } } }
+        subject { MightyGrid::Base.new(User, @controller) }
+        its(:current_order_direction) { should == (direction.in?(DIRECTIONS) ? direction : nil) }
+        after(:all) { @controller.params = {} }
+      end
     end
   end
 
   describe '#another_order_direction' do
-    context 'with ASC controller param' do
-      before(:all){ @controller.params = {'grid'=>{'order_direction' => 'asc'}} }
-      subject { MightyGrid::Base.new(User, @controller) }
-      its(:another_order_direction) { should == 'desc' }
-      after(:all){ @controller.params = {} }
-    end
-
-    context 'with DESC controller param' do
-      before(:all){ @controller.params = {'grid'=>{'order_direction' => 'desc'}} }
-      subject { MightyGrid::Base.new(User, @controller) }
-      its(:another_order_direction) { should == 'asc' }
-      after(:all){ @controller.params = {} }
-    end
-
-    context 'with BAD controller param' do
-      before(:all){ @controller.params = {'grid'=>{'order_direction' => 'bad'}} }
-      subject { MightyGrid::Base.new(User, @controller) }
-      its(:another_order_direction) { should == 'asc' }
-      after(:all){ @controller.params = {} }
+    (DIRECTIONS + ['bad']).each do |direction|
+      context "with #{ direction.upcase } controller param" do
+        before(:all) { @controller.params = { 'grid' => { 'order_direction' => direction } } }
+        subject { MightyGrid::Base.new(User, @controller) }
+        its(:another_order_direction) { should == (direction == 'asc' ? 'desc' : 'asc') }
+        after(:all) { @controller.params = {} }
+      end
     end
   end
 
   describe '#order_params' do
-    before(:all){ @controller.params = {'grid'=>{'order' => 'name', 'order_direction' => 'asc'}} }
+    before(:all) { @controller.params = { 'grid' => { 'order' => 'name', 'order_direction' => 'asc' } } }
     subject { MightyGrid::Base.new(User, @controller) }
     context 'with current order attribute' do
-      it { subject.order_params(:name).should == {'grid'=>{order: 'name', order_direction: 'desc'}} }
+      it { subject.order_params(:name).should == { 'grid' => { order: 'name', order_direction: 'desc' } } }
     end
     context 'with other order attribute' do
-      it { subject.order_params(:description).should == {'grid'=>{order: 'description', order_direction: 'asc'}} }
+      it { subject.order_params(:description).should == { 'grid' => { order: 'description', order_direction: 'asc' } } }
     end
-    after(:all){ @controller.params = {} }
+    after(:all) { @controller.params = {} }
   end
 
   describe '#like_operator' do
     subject { MightyGrid::Base.new(User, @controller) }
     context "when DB is #{ENV['DB']}" do
       case ENV['DB']
-        when 'postgresql'
-          it{ subject.like_operator.should == 'ILIKE' }
-        when 'sqlite', 'mysql'
-          it{ subject.like_operator.should == 'LIKE' }
+      when 'postgresql'
+        it { subject.like_operator.should == 'ILIKE' }
+      when 'sqlite', 'mysql'
+        it { subject.like_operator.should == 'LIKE' }
       end
     end
   end
 
-end
+end

data/spec/lib/column_spec.rb

@@ -5,7 +5,7 @@ describe MightyGrid::Column do
   describe '#new' do
     describe 'with attribute' do
       context 'without options' do
-        subject { MightyGrid::Column.new({attribute: :name}) }
+        subject { MightyGrid::Column.new(attribute: :name) }
         context 'parameters' do
           its(:attribute) { should == :name }
           its(:render_value) { should == :name }
@@ -16,30 +16,30 @@ describe MightyGrid::Column do
       end
 
       context 'with html option' do
-        let(:options) { {html: {class: 'column'}} }
-        subject { MightyGrid::Column.new({attribute: :name}.merge(options)) }
+        let(:options) { { html: { class: 'column' } } }
+        subject { MightyGrid::Column.new({ attribute: :name }.merge(options)) }
         its(:options) { should == options }
         its(:attrs) { should == options[:html] }
       end
 
       context 'with title option' do
-        let(:options) { {title: 'Name'} }
-        subject { MightyGrid::Column.new({attribute: :name}.merge(options)) }
+        let(:options) { { title: 'Name' } }
+        subject { MightyGrid::Column.new({ attribute: :name }.merge(options)) }
         its(:options) { should == options }
         its(:title) { should == options[:title] }
       end
 
       context 'with th_html option' do
-        let(:options) { {th_html: {class: 'active'}} }
-        subject { MightyGrid::Column.new({attribute: :name}.merge(options)) }
+        let(:options) { { th_html: { class: 'active' } } }
+        subject { MightyGrid::Column.new({ attribute: :name }.merge(options)) }
         its(:options) { should == options }
-        its(:th_attrs) { should == {class: 'active'} }
+        its(:th_attrs) { should == { class: 'active' } }
       end
     end
 
     describe 'with block' do
       context 'without options' do
-        subject { MightyGrid::Column.new {:test} }
+        subject { MightyGrid::Column.new { :test } }
         context 'parameters' do
           its(:attribute) { should == nil }
           its(:title) { should == '' }
@@ -52,21 +52,21 @@ describe MightyGrid::Column do
   end
 
   describe '.render' do
-    let(:user){ User.create(name: 'user name') }
+    let(:user) { User.create(name: 'user name') }
 
     describe 'with attribute' do
-      subject(:column){ MightyGrid::Column.new({attribute: :name}) }
+      subject(:column) { MightyGrid::Column.new(attribute: :name) }
       it 'should return attribute value' do
         column.render(user).should == user[:name]
       end
     end
 
     describe 'with block' do
-      subject(:column){ MightyGrid::Column.new { "#{user.name} 1" } }
+      subject(:column) { MightyGrid::Column.new { "#{user.name} 1" } }
       it 'should return attribute value' do
         column.render(user).should == "#{user[:name]} 1"
       end
     end
   end
 
-end
+end

data/spec/lib/generators/install_generator_spec.rb

@@ -1,21 +1,21 @@
 require 'spec_helper'
 
-require "generator_spec"
+require 'generator_spec'
 
 describe MightyGrid::Generators::InstallGenerator do
-  destination File.expand_path("../../tmp", __FILE__)
+  destination File.expand_path('../../tmp', __FILE__)
 
   before(:all) do
     prepare_destination
     run_generator
   end
 
-  it "creates config initializer" do
-    assert_file "config/initializers/mighty_grid_config.rb"
+  it 'creates config initializer' do
+    assert_file 'config/initializers/mighty_grid_config.rb'
   end
 
-  it "creates locale file" do
-    assert_file "config/locales/mighty_grid.en.yml"
+  it 'creates locale file' do
+    assert_file 'config/locales/mighty_grid.en.yml'
   end
 
-end
+end

data/spec/spec_helper.rb

@@ -10,18 +10,20 @@ end
 require 'bundler/setup'
 Bundler.require
 
+require 'capybara/rspec'
+
 require 'coveralls'
 Coveralls.wear!
 
-require "codeclimate-test-reporter"
+require 'codeclimate-test-reporter'
 CodeClimate::TestReporter.start
 
 if defined? Rails
-  require 'fake_app/rails_app'
+  require File.expand_path("../dummy/config/environment.rb",  __FILE__)
   require 'rspec-rails'
 end
 
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
 RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true

data/spec/support/capybara.rb

@@ -4,7 +4,3 @@ require 'capybara/dsl'
 RSpec.configure do |config|
   config.include Capybara::DSL
 end
-
-Capybara.configure do |config|
-  config.run_server = false
-end

data/spec/support/database_cleaner.rb

@@ -10,8 +10,4 @@ RSpec.configure do |config|
   config.after :each do
     DatabaseCleaner.clean
   end
-
-  config.after :suite do
-    CreateAllTables.down
-  end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mighty_grid
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - jurrick
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-29 00:00:00.000000000 Z
+date: 2014-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -106,6 +106,7 @@ files:
 - config/locales/en.yml
 - features/filtering.feature
 - features/step_definitions/steps.rb
+- features/support/capybara.rb
 - features/support/database_cleaner.rb
 - features/support/env.rb
 - features/support/paths.rb
@@ -129,11 +130,51 @@ files:
 - lib/mighty_grid/version.rb
 - mighty_grid.gemspec
 - spec/config_spec.rb
-- spec/fake_app/config/database.yml.example
-- spec/fake_app/models/active_record.rb
-- spec/fake_app/models/config.rb
-- spec/fake_app/rails_app.rb
-- spec/fake_app/views/index.html.erb
+- spec/dummy/Rakefile
+- spec/dummy/app/assets/images/.keep
+- spec/dummy/app/assets/javascripts/application.js
+- spec/dummy/app/assets/stylesheets/application.css
+- spec/dummy/app/controllers/application_controller.rb
+- spec/dummy/app/controllers/concerns/.keep
+- spec/dummy/app/controllers/users_controller.rb
+- spec/dummy/app/helpers/application_helper.rb
+- spec/dummy/app/mailers/.keep
+- spec/dummy/app/models/.keep
+- spec/dummy/app/models/company.rb
+- spec/dummy/app/models/concerns/.keep
+- spec/dummy/app/models/user.rb
+- spec/dummy/app/views/layouts/application.html.erb
+- spec/dummy/app/views/users/index.html
+- spec/dummy/bin/bundle
+- spec/dummy/bin/rails
+- spec/dummy/bin/rake
+- spec/dummy/config.ru
+- spec/dummy/config/application.rb
+- spec/dummy/config/boot.rb
+- spec/dummy/config/database.yml.travis
+- spec/dummy/config/environment.rb
+- spec/dummy/config/environments/development.rb
+- spec/dummy/config/environments/production.rb
+- spec/dummy/config/environments/test.rb
+- spec/dummy/config/initializers/backtrace_silencers.rb
+- spec/dummy/config/initializers/cookies_serializer.rb
+- spec/dummy/config/initializers/filter_parameter_logging.rb
+- spec/dummy/config/initializers/inflections.rb
+- spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/secret_token.rb
+- spec/dummy/config/initializers/session_store.rb
+- spec/dummy/config/initializers/wrap_parameters.rb
+- spec/dummy/config/locales/en.yml
+- spec/dummy/config/routes.rb
+- spec/dummy/config/secrets.yml
+- spec/dummy/db/migrate/20140727125647_create_users.rb
+- spec/dummy/db/migrate/20140727141742_create_companies.rb
+- spec/dummy/db/schema.rb
+- spec/dummy/lib/assets/.keep
+- spec/dummy/public/404.html
+- spec/dummy/public/422.html
+- spec/dummy/public/500.html
+- spec/dummy/public/favicon.ico
 - spec/lib/base_spec.rb
 - spec/lib/column_spec.rb
 - spec/lib/generators/install_generator_spec.rb
@@ -169,15 +210,56 @@ summary: Flexible grid for Rails
 test_files:
 - features/filtering.feature
 - features/step_definitions/steps.rb
+- features/support/capybara.rb
 - features/support/database_cleaner.rb
 - features/support/env.rb
 - features/support/paths.rb
 - spec/config_spec.rb
-- spec/fake_app/config/database.yml.example
-- spec/fake_app/models/active_record.rb
-- spec/fake_app/models/config.rb
-- spec/fake_app/rails_app.rb
-- spec/fake_app/views/index.html.erb
+- spec/dummy/Rakefile
+- spec/dummy/app/assets/images/.keep
+- spec/dummy/app/assets/javascripts/application.js
+- spec/dummy/app/assets/stylesheets/application.css
+- spec/dummy/app/controllers/application_controller.rb
+- spec/dummy/app/controllers/concerns/.keep
+- spec/dummy/app/controllers/users_controller.rb
+- spec/dummy/app/helpers/application_helper.rb
+- spec/dummy/app/mailers/.keep
+- spec/dummy/app/models/.keep
+- spec/dummy/app/models/company.rb
+- spec/dummy/app/models/concerns/.keep
+- spec/dummy/app/models/user.rb
+- spec/dummy/app/views/layouts/application.html.erb
+- spec/dummy/app/views/users/index.html
+- spec/dummy/bin/bundle
+- spec/dummy/bin/rails
+- spec/dummy/bin/rake
+- spec/dummy/config.ru
+- spec/dummy/config/application.rb
+- spec/dummy/config/boot.rb
+- spec/dummy/config/database.yml.travis
+- spec/dummy/config/environment.rb
+- spec/dummy/config/environments/development.rb
+- spec/dummy/config/environments/production.rb
+- spec/dummy/config/environments/test.rb
+- spec/dummy/config/initializers/backtrace_silencers.rb
+- spec/dummy/config/initializers/cookies_serializer.rb
+- spec/dummy/config/initializers/filter_parameter_logging.rb
+- spec/dummy/config/initializers/inflections.rb
+- spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/secret_token.rb
+- spec/dummy/config/initializers/session_store.rb
+- spec/dummy/config/initializers/wrap_parameters.rb
+- spec/dummy/config/locales/en.yml
+- spec/dummy/config/routes.rb
+- spec/dummy/config/secrets.yml
+- spec/dummy/db/migrate/20140727125647_create_users.rb
+- spec/dummy/db/migrate/20140727141742_create_companies.rb
+- spec/dummy/db/schema.rb
+- spec/dummy/lib/assets/.keep
+- spec/dummy/public/404.html
+- spec/dummy/public/422.html
+- spec/dummy/public/500.html
+- spec/dummy/public/favicon.ico
 - spec/lib/base_spec.rb
 - spec/lib/column_spec.rb
 - spec/lib/generators/install_generator_spec.rb

data/spec/fake_app/config/database.yml.example

@@ -1,14 +0,0 @@
-sqlite: 
-  adapter: sqlite3
-  database: ':memory:'
-  timeout: 500
-
-mysql:
-  adapter: mysql2
-  database: 'mg_test'
-  username: root
-
-postgresql:
-  adapter: postgresql
-  database: 'mg_test'
-  username: postgres

data/spec/fake_app/models/active_record.rb

@@ -1,25 +0,0 @@
-# MODELS
-class User < ActiveRecord::Base
-  belongs_to :company
-end
-
-class Company < ActiveRecord::Base
-  has_many :users
-end
-
-# MIGRATIONS
-class CreateAllTables < ActiveRecord::Migration
-  def self.up
-    create_table(:users) { |t| t.string :name; t.string :role; t.integer :company_id; t.boolean :is_banned, default: false, null: false }
-    create_table(:companies) { |t| t.string :name; }
-  end
-
-  def self.down
-    drop_table :users
-    drop_table :companies
-  end
-end
-
-CreateAllTables.down if User.table_exists? || Company.table_exists?
-ActiveRecord::Migration.verbose = false
-CreateAllTables.up

data/spec/fake_app/models/config.rb

@@ -1,5 +0,0 @@
-configs = YAML.load_file('spec/fake_app/config/database.yml')
-ActiveRecord::Base.configurations = configs
-
-db_name = ENV['DB'] || 'sqlite'
-ActiveRecord::Base.establish_connection(db_name)

data/spec/fake_app/rails_app.rb

@@ -1,39 +0,0 @@
-require 'action_controller/railtie'
-require 'action_view/railtie'
-
-require 'capybara/rspec'
-
-require_relative 'models/config'
-
-app = Class.new(Rails::Application)
-app.config.secret_token = '7295e7f2718c940f459e5062f575cd92'
-app.config.session_store :cookie_store, :key => '_myapp_session'
-app.config.active_support.deprecation = :log
-app.config.eager_load = false
-
-# Rais.root
-app.config.root = File.dirname(__FILE__)
-Rails.backtrace_cleaner.remove_silencers!
-app.initialize!
-
-# ROUTES
-app.routes.draw do
-  resources :users
-end
-
-# MODELS
-require_relative 'models/active_record'
-
-# CONTROLLERS
-class ApplicationController < ActionController::Base; end
-class UsersController < ApplicationController
-  def index
-    @users_grid = init_grid(User)
-    render 'spec/fake_app/views/index', layout: false
-  end
-end
-
-# HELPERS
-Object.const_set(:ApplicationHelper, Module.new)
-
-Capybara.app = app