miga-base 1.3.13.2 → 1.3.13.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7452e6019471294f9f1b21ef675ff65a4b582eb51df3f0d59c4ee8a084f79540
-  data.tar.gz: 1fb9ba522229fa36265c9f5b261c57c44f98e0d31275acd7903c0e4e79f9791a
+  metadata.gz: 278d0637c00542b14f71285b198201a37a287aecef2392bcf77d915c0be9bd52
+  data.tar.gz: 97012a85b2e4f1baf6e5ded3ec8a454d3dbbf76e556b42eff1b216c0f7735a7a
 SHA512:
-  metadata.gz: 6519c3bdcf8ce9bfb252a023f9a0dc19ab6534e44f21e8db3199148ae7c2d9588848e18739111b6d444287cf0c6e383ace2b75f77de5bef5da55ea7b7979450e
-  data.tar.gz: cb8b25241a73c301c8ceef0c2e08286348047df7a47576a46687444c89d7716f057c87cb5bfa9ed9016a44bcc63aeb5ed96cac1bb46442fe3b574a9923254b69
+  metadata.gz: dfae6fff930fcfef0517988855007fb62b65106cc52d6857dc7f384a8f4d967f5c6d0084809607921529649cc5237f6adc1c95a6e0f80604c4201bbc9539666e
+  data.tar.gz: 5d825d4f6e0da2a47b4b287b494a4609cadc76bea390b415db9c7a8c18320a442022eaf801384ec43afd8424739d53e86ba2b2dfd67dd775d5f03adc2b8f1699

data/lib/miga/cli/action/doctor/base.rb

@@ -12,8 +12,7 @@ module MiGA::Cli::Action::Doctor::Base
   # list, and therefore the databases need to be cleaned.
   # This is a subtask of +check_dist+
   def check_dist_eval(cli, p, res)
-    notok = {}
-    fix = {}
+    y = { notok: Set.new, fix: Set.new }
     Zlib::GzipReader.open(res.file_path(:matrix)) do |fh|
       lineno = 0
       fh.each_line do |ln|
@@ -23,16 +22,11 @@ module MiGA::Cli::Action::Doctor::Base
         names = [r[0], r[1]]
         next unless names.any? { |i| p.dataset(i).nil? }
 
-        names.each do |i|
-          if p.dataset(i).nil? || !p.dataset(i).active?
-            notok[i] = true
-          else
-            fix[i] = true
-          end
-        end
+        names.each { |i| y[p.dataset(i)&.active? ? :fix : :notok] << i }
       end
     end
-    [notok.keys, fix.keys]
+    # The code below is more readable than `y.values.map(&:to_a)`
+    [y[:notok].to_a, y[:fix].to_a]
   end
 
   ##
@@ -43,8 +37,8 @@ module MiGA::Cli::Action::Doctor::Base
     return if fix.empty?
 
     cli.say("- Fixing #{fix.size} datasets")
-    fix.each do |d_n|
-      cli.say "  > Fixing #{d_n}."
+    fix.each_with_index do |d_n, k|
+      cli.advance('  > Fixing', k + 1, fix.size, false)
       p.dataset(d_n).cleanup_distances!
     end
   end

data/lib/miga/dataset/result.rb

@@ -97,15 +97,14 @@ module MiGA::Dataset::Result
 
   ##
   # Clean-up all the stored distances, removing values for datasets no longer in
-  # the project as reference datasets.
-  def cleanup_distances!
+  # the project as reference datasets. All metrics are processed unless +metric+
+  # is passed (Array[Symbol], including :haai, :aai, :ani)
+  def cleanup_distances!(metrics = %i[haai aai ani])
     return if get_result(:distances).nil?
 
     require 'miga/sqlite'
-    ref = project.datasets.select(&:ref?).select(&:active?).map(&:name)
-    %i[haai aai ani].each do |metric|
-      cleanup_distances_by_metric!(ref, metric)
-    end
+    ref = project.dataset_ref_active.map(&:name)
+    metrics.each { |metric| cleanup_distances_by_metric!(ref, metric) }
   end
 
   private

data/lib/miga/project/dataset.rb

@@ -31,6 +31,22 @@ module MiGA::Project::Dataset
     @dataset_names_set ||= Set.new(dataset_names)
   end
 
+  ##
+  # Cache for the special set of datasets which are both reference and
+  # active, returned as an Array. Use carefully, as it doesn't get
+  # recalculated upon dataset (in)activation once loaded. To force
+  # recalculating, use +dataset_ref_active!+
+  def dataset_ref_active
+    @dataset_ref_active ||= dataset_ref_active!
+  end
+
+  ##
+  # Force recalculation of +dataset_ref_active+ and returns the Array
+  # of MiGA::Dataset objects
+  def dataset_ref_active!
+    @dataset_ref_active = datasets.select(&:ref?).select(&:active?)
+  end
+
   ##
   # Returns MiGA::Dataset
   def dataset(name)
@@ -60,6 +76,7 @@ module MiGA::Project::Dataset
       @metadata[:datasets] << name
       @dataset_names_hash[name] = true if @dataset_names_hash
       @dataset_names_set << name if @dataset_names_set
+      @dataset_ref_active = nil
       save
       if d.ref? && d.active?
         recalculate_tasks("Reference dataset added: #{d.name}")
@@ -75,6 +92,9 @@ module MiGA::Project::Dataset
     d = dataset(name)
     return nil if d.nil?
 
+    @dataset_names_hash = nil
+    @dataset_names_set  = nil
+    @dataset_ref_active = nil
     self.metadata[:datasets].delete(name)
     save
     if d.ref? && d.active?

data/lib/miga/remote_dataset/download.rb

@@ -186,7 +186,6 @@ class MiGA::RemoteDataset
     # Looks for the entry +id+ in +dbfrom+, and returns the linked
     # identifier in +db+ (or nil).
     def ncbi_map(id, dbfrom, db)
-      attempts = 0
       doc = download(:ncbi_map, dbfrom, id, :json, nil, db: db)
       return if doc.empty?
 

data/lib/miga/version.rb

@@ -12,7 +12,7 @@ module MiGA
   # - String indicating release status:
   #   - rc* release candidate, not released as gem
   #   - [0-9]+ stable release, released as gem
-  VERSION = [1.3, 13, 2].freeze
+  VERSION = [1.3, 13, 3].freeze
 
   ##
   # Nickname for the current major.minor version.
@@ -20,7 +20,7 @@ module MiGA
 
   ##
   # Date of the current gem relese.
-  VERSION_DATE = Date.new(2024, 3, 15)
+  VERSION_DATE = Date.new(2024, 3, 18)
 
   ##
   # References of MiGA

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: miga-base
 version: !ruby/object:Gem::Version
-  version: 1.3.13.2
+  version: 1.3.13.3
 platform: ruby
 authors:
 - Luis M. Rodriguez-R
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-03-15 00:00:00.000000000 Z
+date: 2024-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: daemons