mifiel 1.1.2 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6b81aa9ae009760bdbf21c71d2af638956d898e7
-  data.tar.gz: 7b62d15b2abe554804ba41b5eaf9d13fe2a06199
+  metadata.gz: 36fb92b3ebd8ee48db492aa83ef01ab696f0f8c3
+  data.tar.gz: d5d3473df052bc3156a68dc16f819ae4cc186623
 SHA512:
-  metadata.gz: 4aa349459b1752a1e682cd4dc8c959dede12e95b519cda0497b1d6c4cc381b1000c9eb7bf147e983ab6d6166c97ddcfa3638d261ab998352526042d5bcc0bb95
-  data.tar.gz: 484c3f9becf2180f30e3bc11c105ba79e72c764c2ac07632897c6333b52b731c598bd5e566914bfd0ba18e513609322fce3c1d1f6bf45c221f9f99fd508ecefd
+  metadata.gz: 73fe847fb0de5584e33f4e936d823ad23296baa4fc8254431e4febc1e2b2951be9cb439d5c0fa24f0bc20142adaef0fcfb6725f26b669e0f083d44adee21df2d
+  data.tar.gz: 4876287da937bc6db321c1b2cc0714c1f84674d484d89fbadf355f3a19f8897f81a7d68f0cda9a4d53015b507716549a440cfb8a66aef57f15e20504e71af4fe

data/.travis.yml

@@ -11,4 +11,5 @@ notifications:
     on_failure: always
 script:
 - mkdir ./tmp/
+- bundle exec rubocop
 - bundle exec rspec spec

data/lib/mifiel.rb

@@ -1,4 +1,4 @@
-require 'active_rest_client'
+require 'flexirest'
 
 module Mifiel
   require 'mifiel/errors'

data/lib/mifiel/base.rb

@@ -1,12 +1,12 @@
 require 'rest-client'
 
 module Mifiel
-  class Base < ActiveRestClient::Base
+  class Base < Flexirest::Base
     after_request :rescue_errors
 
     def rescue_errors(_name, response)
       if (400..499).cover?(response.status)
-        result = JSON.load(response.body)
+        result = JSON.parse(response.body)
         message = result['errors'] || [result['error']]
         raise BadRequestError, message.to_a.join(', ')
       elsif (500..599).cover?(response.status)

data/lib/mifiel/certificate.rb

@@ -15,7 +15,7 @@ module Mifiel
         ssl_version: 'SSLv23'
       )
       req = ApiAuth.sign!(rest_request, Mifiel.config.app_id, Mifiel.config.app_secret)
-      JSON.load(req.execute)
+      Mifiel::Certificate.new(JSON.parse(req.execute))
     end
   end
 end

data/lib/mifiel/config.rb

@@ -27,9 +27,9 @@ module Mifiel
       private
 
         def set_api_auth_credentials
-          ActiveRestClient::Base.base_url = base_url
-          ActiveRestClient::Base.api_auth_credentials(app_id, app_secret)
-          ActiveRestClient::Base.request_body_type = :json
+          Flexirest::Base.base_url = base_url
+          Flexirest::Base.api_auth_credentials(app_id, app_secret)
+          Flexirest::Base.request_body_type = :json
         end
     end
 

data/lib/mifiel/document.rb

@@ -7,7 +7,13 @@ module Mifiel
     put :save, '/documents/:id'
     delete :delete, '/documents/:id'
 
-    def self.create(signatories:, file: nil, hash: nil, name: nil, callback_url: nil)
+    # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
+    def self.create(args)
+      signatories = args[:signatories]
+      file = args[:file]
+      hash = args[:hash]
+      name = args[:name]
+      callback_url = args[:callback_url]
       raise ArgumentError, 'Either file or hash must be provided' if !file && !hash
       raise ArgumentError, 'Only one of file or hash must be provided' if file && hash
       payload = {
@@ -17,9 +23,11 @@ module Mifiel
         original_hash: hash,
         name: name
       }
+      payload = args.merge(payload)
       response = process_request('/documents', :post, payload)
-      JSON.load(response)
+      Mifiel::Document.new(JSON.parse(response))
     end
+    # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
 
     def request_signature(email, cc: nil)
       params = { email: email }

data/lib/mifiel/version.rb

@@ -1,3 +1,3 @@
 module Mifiel
-  VERSION = '1.1.2'.freeze
+  VERSION = '1.1.3'.freeze
 end

data/mifiel.gemspec

@@ -3,6 +3,7 @@ lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'mifiel/version'
 
+# rubocop:disable Metrics/BlockLength
 Gem::Specification.new do |spec|
   spec.name          = 'mifiel'
   spec.version       = Mifiel::VERSION
@@ -19,10 +20,14 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '~> 2.1'
 
   spec.add_runtime_dependency 'rest-client',        '~> 1.7'
-  spec.add_runtime_dependency 'json',               '~> 1.8'
-  spec.add_runtime_dependency 'api-auth',           '~> 1.4'
-  spec.add_runtime_dependency 'activesupport',      '~> 4.2.7'
-  spec.add_runtime_dependency 'active_rest_client', '~> 1.2'
+  spec.add_runtime_dependency 'json',               '> 0'
+  spec.add_runtime_dependency 'api-auth',           '> 1.4'
+  if Gem::Version.new(RUBY_VERSION) > Gem::Version.new('2.2.2')
+    spec.add_runtime_dependency 'activesupport'
+  else
+    spec.add_runtime_dependency 'activesupport', '~> 4.2.7'
+  end
+  spec.add_runtime_dependency 'flexirest'
 
   spec.add_development_dependency 'bundler',    '~> 1.6'
   spec.add_development_dependency 'rake',       '~> 10.0'

data/spec/mifiel/certificate_spec.rb

@@ -6,7 +6,7 @@ describe Mifiel::Certificate do
       )
     end
 
-    it { expect(certificate).to be_a(Hash) }
+    it { expect(certificate).to be_a(Mifiel::Certificate) }
   end
 
 end

data/spec/mifiel/document_spec.rb

@@ -15,7 +15,7 @@ describe Mifiel::Document do
         )
       end
 
-      it { expect(document).to be_a(Hash) }
+      it { expect(document).to be_a(Mifiel::Document) }
     end
   end
 
@@ -23,8 +23,8 @@ describe Mifiel::Document do
     let!(:document) { Mifiel::Document.all.first }
 
     describe '#save_file' do
-      let!(:path) {'tmp/the-file.pdf' }
-      before { File.unlink(path) if File.exist?(path)}
+      let!(:path) { 'tmp/the-file.pdf' }
+      before { File.unlink(path) if File.exist?(path) }
 
       it 'should get the file' do
         document.save_file(path)
@@ -33,8 +33,8 @@ describe Mifiel::Document do
     end
 
     describe '#save_file_signed' do
-      let!(:path) {'tmp/the-file-signed.pdf' }
-      before { File.unlink(path) if File.exist?(path)}
+      let!(:path) { 'tmp/the-file-signed.pdf' }
+      before { File.unlink(path) if File.exist?(path) }
 
       it 'should get the file' do
         document.save_file_signed(path)
@@ -43,8 +43,8 @@ describe Mifiel::Document do
     end
 
     describe '#save_xml' do
-      let!(:path) {'tmp/the-xml.xml' }
-      before { File.unlink(path) if File.exist?(path)}
+      let!(:path) { 'tmp/the-xml.xml' }
+      before { File.unlink(path) if File.exist?(path) }
 
       it 'should get the file' do
         document.save_xml(path)

data/spec/support/fake_mifiel.rb

@@ -1,5 +1,5 @@
 require 'sinatra/base'
-
+# rubocop:disable Metrics/ClassLength
 class FakeMifiel < Sinatra::Base
   get '/api/v1/keys' do
     content_type :json

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mifiel
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.1.3
 platform: ruby
 authors:
 - Genaro Madrid
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-08 00:00:00.000000000 Z
+date: 2016-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -28,28 +28,28 @@ dependencies:
   name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: api-auth
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
         version: '1.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
         version: '1.4'
 - !ruby/object:Gem::Dependency
@@ -67,19 +67,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 4.2.7
 - !ruby/object:Gem::Dependency
-  name: active_rest_client
+  name: flexirest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement