midwire_common 0.1.12 → 0.1.13

data/midwire_common.gemspec

@@ -1,27 +1,27 @@
-# -*- encoding: utf-8 -*-
+# coding: utf-8
 require File.expand_path('../lib/midwire_common/version', __FILE__)
 
-Gem::Specification.new do |gem|
-  gem.authors       = ["Chris Blackburn"]
-  gem.email         = ["chris@midwiretech.com"]
-  gem.description   = %q{A useful Ruby library for the Midwire development team}
-  gem.summary       = %q{Midwire Ruby Library}
-  gem.homepage      = "https://github.com/midwire/midwire_common"
+Gem::Specification.new do |spec|
+  spec.name          = 'midwire_common'
+  spec.version       = MidwireCommon::VERSION
+  spec.authors       = ['Chris Blackburn']
+  spec.email         = ['chris@midwiretech.com']
+  spec.description   = 'A useful Ruby library for the Midwire development team'
+  spec.summary       = 'Midwire Ruby Library'
+  spec.homepage      = 'https://github.com/midwire/midwire_common'
 
-  gem.files         = `git ls-files`.split($\)
-  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
-  gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-  gem.name          = "midwire_common"
-  gem.require_paths = ["lib"]
-  gem.version       = MidwireCommon::VERSION
+  spec.files         = `git ls-files -z`.split("\x0")
+  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.require_paths = ['lib']
 
-  gem.add_development_dependency "rspec"
-  gem.add_development_dependency "simplecov"
-  gem.add_development_dependency "guard"
-  gem.add_development_dependency "guard-bundler"
-  gem.add_development_dependency "guard-rspec"
-  gem.add_development_dependency "guard-rubocop"
-  gem.add_development_dependency "pry"
-  gem.add_development_dependency "rake"
-  gem.add_development_dependency "rubocop"
+  spec.add_development_dependency 'rspec', '~> 2.14'
+  spec.add_development_dependency 'simplecov', '~> 0.7'
+  spec.add_development_dependency 'guard', '~> 2.11'
+  spec.add_development_dependency 'guard-bundler', '~> 2.1'
+  spec.add_development_dependency 'guard-rspec', '~> 4.5'
+  spec.add_development_dependency 'guard-rubocop', '~> 1.2'
+  spec.add_development_dependency 'pry', '~> 0.10'
+  spec.add_development_dependency 'rake', '~> 10.1'
+  spec.add_development_dependency 'rubocop', '~> 0.28'
 end

data/spec/lib/midwire_common/array_spec.rb

@@ -1,42 +1,62 @@
 require 'spec_helper'
 
 describe Array do
-  it "counts occurrences of an element" do
-    [1,2,2,3,3,3].count_occurrences.should == {1=>1, 2=>2, 3=>3}
-    ['asdf','asdf','qwer','asdf'].count_occurrences.should == {'asdf'=>3, 'qwer'=>1}
+  it 'counts occurrences of an element' do
+    [1, 2, 2, 3, 3, 3].count_occurrences.should eq(1 => 1, 2 => 2, 3 => 3)
+    %w(asdf asdf qwer asdf).count_occurrences.should == {
+      'asdf' => 3,
+      'qwer' => 1
+    }
   end
 
-  it "randomizes the order of an array" do
-    myarray = [1,2,3,4,5,6,7,8,9,'0']
-    myarray.randomize.should_not == myarray
+  it 'randomizes the order of an array' do
+    myarray = [1, 2, 3, 4, 5, 6, 7, 8, 9, '0']
+    myarray.randomize.should_not eq(myarray)
     myarray.randomize!
-    myarray.should_not == [1,2,3,4,5,6,7,8,9,'0']
+    myarray.should_not == [1, 2, 3, 4, 5, 6, 7, 8, 9, '0']
   end
 
-  it "sorts elements case insensitive" do
+  it 'sorts elements case insensitive' do
     myarray = %w(zebra ghost Zebra cat Cat)
-    myarray.sort_case_insensitive.should == ["Cat", "cat", "ghost", "Zebra", "zebra"]
+    myarray.sort_case_insensitive.should eq(%w(Cat cat ghost Zebra zebra))
   end
 
-  it "can process first and last entries differently than others" do
+  it 'can process first and last entries differently than others' do
     text = ''
-    ["KU", "K-State", "MU"].each_with_first_last(
-      lambda {|team| text += "#{team} came first in the NCAA basketball tournament.\n"},
-      lambda {|team| text += "#{team} did not come first or last in the final four.\n"},
-      lambda {|team| text += "#{team} came last in the final four this year.\n"}
+    ['KU', 'K-State', 'MU'].each_with_first_last(
+      lambda do |team|
+        text += "#{team} came first in the NCAA basketball tournament.\n"
+      end,
+      lambda do |team|
+        text += "#{team} did not come first or last in the final four.\n"
+      end,
+      lambda do |team|
+        text += "#{team} came last in the final four this year.\n"
+      end
     )
-    text.should == "KU came first in the NCAA basketball tournament.\nK-State did not come first or last in the final four.\nMU came last in the final four this year.\n"
+    text.should == <<-string.here_with_pipe("\n")
+      |KU came first in the NCAA basketball tournament.
+      |K-State did not come first or last in the final four.
+      |MU came last in the final four this year.
+      |
+    string
   end
 
-  it "can binary search for elements" do
+  it 'can binary search for elements' do
     a = %w(a b c)
-    a.bsearch('a').should == 0
-    a.bsearch('b').should == 1
-    a.bsearch('c').should == 2
+    a.bsearch('a').should eq(0)
+    a.bsearch('b').should eq(1)
+    a.bsearch('c').should eq(2)
   end
 
-  it "can superjoin elements" do
-    [1,2,3].superjoin(["->","+","<-"]).should == "->1+2+3<-"
-    [[1,2],[2,3]].superjoin( %w{<table><tr> </tr><tr> </tr></table>}, %w{<td> </td><td> </td>} ).should == "<table><tr><td>1</td><td>2</td></tr><tr><td>2</td><td>3</td></tr></table>"
+  # rubocop:disable Metrics/LineLength
+  it 'can superjoin elements' do
+    [1, 2, 3].superjoin(['->', '+', '<-']).should eq('->1+2+3<-')
+    [[1, 2], [2, 3]].superjoin(
+      %w(<table><tr> </tr><tr> </tr></table>), %w(<td> </td><td> </td>)
+    ).should eq(
+      '<table><tr><td>1</td><td>2</td></tr><tr><td>2</td><td>3</td></tr></table>'
+    )
   end
+  # rubocop:enable Metrics/LineLength
 end

data/spec/lib/midwire_common/data_file_cache_spec.rb

@@ -1,40 +1,39 @@
 require 'spec_helper'
 
 describe MidwireCommon::DataFileCache do
-  let(:cache_dir) {'/tmp/.cache_dir'}
-  let(:filename) {"data_file_cache"}
-  let(:filepath) {"#{cache_dir}/#{filename}"}
-  let(:data) {'this is my data'}
+  let(:cache_dir) { '/tmp/.cache_dir' }
+  let(:filename) { 'data_file_cache' }
+  let(:filepath) { "#{cache_dir}/#{filename}" }
+  let(:data) { 'this is my data' }
 
   before(:each) do
     @cache = MidwireCommon::DataFileCache.new("#{cache_dir}/#{filename}")
   end
 
-  it "creates a directory for the cache file" do
-    File.exists?(cache_dir).should be_true
+  it 'creates a directory for the cache file' do
+    File.exist?(cache_dir).should eq(true)
   end
 
-  it "caches data" do
+  it 'caches data' do
     @cache.put(data)
-    File.exists?(filepath).should be_true
+    File.exist?(filepath).should eq(true)
     x = File.read(filepath)
     x.should == data
   end
 
-  it "determines the age of the cached data" do
+  it 'determines the age of the cached data' do
     tm = @cache.age
-    (tm > 0).should be_true
+    (tm > 0).should eq(true)
   end
 
-  it "retrieves cached data" do
+  it 'retrieves cached data' do
     dta = @cache.get
     dta.should == data
   end
 
-  it "prepends the filename with cache dir" do
+  it 'prepends the filename with cache dir' do
     testfile = 'testfile'
     nf = @cache.send(:normalize_filename, testfile)
     nf.should == "#{cache_dir}/#{testfile}"
   end
-
 end

data/spec/lib/midwire_common/enumerable_spec.rb

@@ -1,8 +1,9 @@
 require 'spec_helper'
 
 describe Enumerable do
-  it "can sort by frequency of occurrences" do
-    [1,2,3,3,3,3,2].sort_by_frequency.should == [3, 3, 3, 3, 2, 2, 1]
-    %w(a b c d e f a f f b f a).sort_by_frequency.should == ["f", "f", "f", "f", "a", "a", "a", "b", "b", "c", "d", "e"]
+  it 'can sort by frequency of occurrences' do
+    [1, 2, 3, 3, 3, 3, 2].sort_by_frequency.should eq([3, 3, 3, 3, 2, 2, 1])
+    %w(a b c d e f a f f b f a).sort_by_frequency
+      .should eq(%w(f f f f a a a b b c d e))
   end
 end

data/spec/lib/midwire_common/file/stat_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 
 describe File::Stat do
-  it "knows on which devise it resides" do
-    s = File::Stat.device_name("/tmp")
+  it 'knows on which devise it resides' do
+    s = File::Stat.device_name('/tmp')
     s.should_not be_nil
   end
 end

data/spec/lib/midwire_common/fixnum_spec.rb

@@ -1,15 +1,15 @@
 require 'spec_helper'
 
 describe Fixnum do
-  it "knows if it is odd or even" do
-    777.is_odd?.should be_true
-    776.is_odd?.should be_false
+  it 'knows if it is odd or even' do
+    777.odd?.should eq(true)
+    776.odd?.should eq(false)
 
-    777.is_even?.should be_false
-    776.is_even?.should be_true
+    777.even?.should eq(false)
+    776.even?.should eq(true)
   end
 
-  it "can format itself with commas" do
-    8729928827.commify.should == "8,729,928,827"
+  it 'can format itself with commas' do
+    8_729_928_827.commify.should == '8,729,928,827'
   end
-end
+end

data/spec/lib/midwire_common/float_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 
 describe Float do
-  it "can format itself with commas" do
-    8729928827.0.commify.should == "8,729,928,827.0"
-    8729928827.20332002.commify.should == "8,729,928,827.20332"
+  it 'can format itself with commas' do
+    8_729_928_827.0.commify.should eq('8,729,928,827.0')
+    8_729_928_827.20332002.commify.should eq('8,729,928,827.20332')
   end
 end

data/spec/lib/midwire_common/hash_spec.rb

@@ -1,40 +1,84 @@
 require 'spec_helper'
 
+# rubocop:disable Lint/Void
 describe Hash do
-  it "greps key/value pairs using a regular expression" do
-    h = {a: "this is a test", 'b' => 'this is not the answer'}
-    h.grep(/a test/).should == [[:a, "this is a test"]]
-    h.grep(/b/).should == [['b', "this is not the answer"]]
-    h.grep(/^this/).should == [[:a, "this is a test"], ["b", "this is not the answer"]]
+  it 'greps key/value pairs using a regular expression' do
+    h = { a: 'this is a test', 'b' => 'this is not the answer' }
+    h.grep(/a test/).should == [[:a, 'this is a test']]
+    h.grep(/b/).should == [['b', 'this is not the answer']]
+    h.grep(/^this/).should == [
+      [:a, 'this is a test'], ['b', 'this is not the answer']
+    ]
   end
 
-  it "returns elements with certain keys filtered out" do
-    {a: 1, b: 2, c: 3}.except(:a).should == {b: 2, c: 3}
+  it 'returns elements with certain keys filtered out' do
+    { a: 1, b: 2, c: 3 }.except(:a).should == { b: 2, c: 3 }
   end
 
-  it "returns elements for discretely passed keys" do
-    {a: 1, b: 2, c: 3}.only(:a).should == {a: 1}
+  it 'returns elements for discretely passed keys' do
+    { a: 1, b: 2, c: 3 }.only(:a).should == { a: 1 }
   end
 
-  it "pops an element off of the stack" do
-    h = {a: 1, b: 2, c: 3}
-    h.pop(:a).should == {a: 1}
-    h.should == {b: 2, c: 3}
+  it 'pops an element off of the stack' do
+    h = { a: 1, b: 2, c: 3 }
+    h.pop(:a).should == { a: 1 }
+    h.should == { b: 2, c: 3 }
   end
 
-  it "returns a query string" do
-    { a: 1, b: 2, c: 3}.to_query_string.should == "a=1&b=2&c=3"
+  it 'returns a query string' do
+    { a: 1, b: 2, c: 3 }.to_query_string.should == 'a=1&b=2&c=3'
   end
 
-  it "symbolizes its keys" do
-    h = {'a'=>1, 'b'=>2, 'c'=>3}
-    h.symbolize_keys.should == {a: 1, b: 2, c: 3}
+  it 'symbolizes its keys' do
+    h = { 'a' => 1, 'b' => 2, 'c' => 3 }
+    h.symbolize_keys.should == { a: 1, b: 2, c: 3 }
     h.symbolize_keys!
-    h.should == {a: 1, b: 2, c: 3}
+    h.should == { a: 1, b: 2, c: 3 }
   end
 
-  it "recursively symbolizes its keys" do
-    h = {'a'=>1, 'b'=>{'a'=>1, 'b'=>2, 'c'=>{'a'=>1, 'b'=>2, 'c'=>3}}, 'c'=>3}
-    h.recursively_symbolize_keys!.should == {a: 1, b: {a: 1, b: 2, c: {a: 1, b: 2, c: 3}}, c: 3}
+  it 'recursively symbolizes its keys' do
+    h = {
+      'a' => 1,
+      'b' => {
+        'a' => 1,
+        'b' => 2,
+        'c' => {
+          'a' => 1,
+          'b' => 2,
+          'c' => 3
+        }
+      },
+      'c' => 3
+    }
+    h.recursively_symbolize_keys!.should == {
+      a: 1, b: { a: 1, b: 2, c: { a: 1, b: 2, c: 3 } }, c: 3
+    }
+  end
+
+  context 'diff methods' do
+    let(:h1_keys) { { 'a' => 1, 'b' => 2, 'c' => 3 } }
+    let(:h2_keys) { { 'a' => 1, 'b' => 2, 'd' => 3 } }
+
+    let(:h1_keys_nested) { { 'a' => 1, 'b' => 2, { 'x' => 99 } => 3 } }
+    let(:h2_keys_nested) { { 'a' => 1, 'b' => 2, { 'x' => 99 } => 4 } }
+
+    let(:h1_values) { { 'a' => 1, 'b' => 2, 'c' => 3 } }
+    let(:h2_values) { { 'a' => 1, 'b' => 2, 'c' => 4 } }
+
+    context '.diff' do
+      it 'reports different keys' do
+        h1_keys.diff(h2_keys).should == { 'c' => [3, nil], 'd' => [nil, 3] }
+      end
+
+      it 'reports different values' do
+        h1_values.diff(h2_values).should == { 'c' => [3, nil], 'c' => [3, 4] }
+      end
+
+      it 'reports different keys even with nested hashes' do
+        h1_keys_nested.diff(h2_keys_nested).should ==
+          { { 'x' => 99 } => [3, 4] }
+      end
+    end
   end
 end
+# rubocop:enable Lint/Void

data/spec/lib/midwire_common/string_spec.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-# encoding: ascii-8bit
+# rubocop:disable Metrics/LineLength
 require 'spec_helper'
 
 describe String do
@@ -44,7 +44,7 @@ describe String do
     end
 
     it "'trim' removes whitespace from both sides of the string" do
-      " \t \t a test is coming \t \t ".trim.should == "a test is coming"
+      " \t \t a test is coming \t \t ".trim.should == 'a test is coming'
     end
 
     it "'trim!' removes whitespace from both sides of the string" do
@@ -74,7 +74,7 @@ describe String do
     end
 
     it 'here_with_pipe - with no space delimeter' do
-      html = <<-STOP.here_with_pipe("")
+      html = <<-STOP.here_with_pipe('')
         |<!-- Begin: comment  -->
         |<script type="text/javascript">
         |</script>
@@ -101,7 +101,6 @@ describe String do
     end
 
     it 'shortens itself with elipses at the end' do
-      #
       s = 'this is my very long string which I will eventually shorten with the enhanced String class that we are now testing.'
       short = s.shorten
       expect(short).to eq('this is my very long string...')
@@ -132,43 +131,44 @@ describe String do
 
   context 'characterization' do
     it 'knows if it is alpha-numeric or not' do
-      'abcd-9191'.is_alpha_numeric?.should be_false
-      'abcd.9191'.is_alpha_numeric?.should be_false
-      'abcd91910'.is_alpha_numeric?.should be_true
-      'abcd_9191'.is_alpha_numeric?.should be_false
-      'abcd 9191'.is_alpha_numeric?.should be_false
+      'abcd-9191'.alpha_numeric?.should eq(false)
+      'abcd.9191'.alpha_numeric?.should eq(false)
+      'abcd91910'.alpha_numeric?.should eq(true)
+      'abcd_9191'.alpha_numeric?.should eq(false)
+      'abcd 9191'.alpha_numeric?.should eq(false)
     end
 
     it 'knows if it is an email address or not' do
-      'abcd_9191'.is_email_address?.should be_false
-      'abcd@9191'.is_email_address?.should be_false
-      'abcd@9191.poop'.is_email_address?.should be_false
-      'abcd@9191.info'.is_email_address?.should be_true
-      'abcd-asdf@9191.com'.is_email_address?.should be_true
-      'abcd_asdf@9191.com'.is_email_address?.should be_true
-      'abcd.asdf@9191.com'.is_email_address?.should be_true
+      'abcd_9191'.email_address?.should eq(false)
+      'abcd@9191'.email_address?.should eq(false)
+      'abcd@9191.poop'.email_address?.should eq(false)
+      'abcd@9191.info'.email_address?.should eq(true)
+      'abcd-asdf@9191.com'.email_address?.should eq(true)
+      'abcd_asdf@9191.com'.email_address?.should eq(true)
+      'abcd.asdf@9191.com'.email_address?.should eq(true)
     end
 
     it 'knows if it is a zipcode or not' do
-      '13922-2356'.is_zipcode?.should be_true
-      '13922.2343'.is_zipcode?.should be_false
-      '13922 2342'.is_zipcode?.should be_false
-      'ABSSD'.is_zipcode?.should be_false
-      'i3323'.is_zipcode?.should be_false
-      '13922'.is_zipcode?.should be_true
+      '13922-2356'.zipcode?.should eq(true)
+      '13922.2343'.zipcode?.should eq(false)
+      '13922 2342'.zipcode?.should eq(false)
+      'ABSSD'.zipcode?.should eq(false)
+      'i3323'.zipcode?.should eq(false)
+      '13922'.zipcode?.should eq(true)
     end
 
     it 'knows if it is numeric or not' do
-      '12341'.is_numeric?.should be_true
-      '12341.23'.is_numeric?.should be_true
-      '12341.00000000000000023'.is_numeric?.should be_true
-      '0.12341'.is_numeric?.should be_true
-      '0x2E'.is_numeric?.should be_true
-      ' 0.12341'.is_numeric?.should be_true
-      ' 0.12341 '.is_numeric?.should be_true
-      '.12341'.is_numeric?.should be_true
-      ' 12341.'.is_numeric?.should be_false
-      ' 12341.  '.is_numeric?.should be_false
+      '12341'.numeric?.should eq(true)
+      '12341.23'.numeric?.should eq(true)
+      '12341.00000000000000023'.numeric?.should eq(true)
+      '0.12341'.numeric?.should eq(true)
+      '0x2E'.numeric?.should eq(true)
+      ' 0.12341'.numeric?.should eq(true)
+      ' 0.12341 '.numeric?.should eq(true)
+      '.12341'.numeric?.should eq(true)
+      ' 12341.'.numeric?.should eq(false)
+      ' 12341.  '.numeric?.should eq(false)
     end
   end
 end
+# rubocop:enable Metrics/LineLength