midilib 3.0.1 → 3.1.0

data/lib/midilib/info.rb

@@ -1,7 +1,7 @@
 module MIDI
   VERSION_MAJOR = 3
-  VERSION_MINOR = 0
-  VERSION_TWEAK = 1
+  VERSION_MINOR = 1
+  VERSION_TWEAK = 0
   Version = "#{VERSION_MAJOR}.#{VERSION_MINOR}.#{VERSION_TWEAK}"
   Copyright = 'Copyright (c) 2003-2022 by Jim Menard <jim@jimmenard.com>'
 end

data/lib/midilib/io/seqreader.rb

@@ -81,16 +81,29 @@ module MIDI
       def note_off(chan, note, vel)
         # Find note on, create note off, connect the two, and remove
         # note on from pending list.
+
+        corresp_note_on = nil
+
         @pending.each_with_index do |on, i|
           next unless on.note == note && on.channel == chan
 
-          make_note_off(on, vel)
           @pending.delete_at(i)
-          return
+          corresp_note_on = on
+          break
         end
-        if $DEBUG
-          warn "note off with no earlier note on (ch #{chan}, note" +
-               " #{note}, vel #{vel})"
+
+        if corresp_note_on
+          make_note_off(corresp_note_on, vel)
+        else
+          # When a corresponding note on is missing,
+          # keep note off as input with lefting on/off attr to nil.
+          off = NoteOff.new(chan, note, vel, @curr_ticks)
+          @track.events << off
+
+          if $DEBUG
+            warn "note off with no earlier note on (ch #{chan}, note" +
+              " #{note}, vel #{vel})"
+          end
         end
       end
 

data/test/test_io.rb

@@ -101,17 +101,30 @@ class IOTester < Test::Unit::TestCase
     assert_equal(MIDI::GM_PATCH_NAMES[0], seq.tracks[1].instrument)
   end
 
-  def test_preserve_meta_deltas
+  def test_preserve_deltas_in_some_situations
     out_seq = MIDI::Sequence.new
     out_track = MIDI::Track.new(out_seq)
     out_seq.tracks << out_track
     out_track.events << MIDI::Tempo.new(MIDI::Tempo.bpm_to_mpq(120))
+
+    # 1) The meta events with non-zero delta time
     # Normally copyright and sequence name events are at time 0, but non-zero
     # start times are allowed.
-    out_track.events << MIDI::MetaEvent.new(MIDI::META_COPYRIGHT, '(C) 1950 Donald Duck', 100)
-    out_track.events << MIDI::MetaEvent.new(MIDI::META_SEQ_NAME, 'Quack, Track 1', 200)
-    out_track.events << MIDI::NoteOn.new(0, 64, 127, 0)
-    out_track.events << MIDI::NoteOff.new(0, 64, 127, 100)
+    begin
+      out_track.events << MIDI::MetaEvent.new(MIDI::META_COPYRIGHT, '(C) 1950 Donald Duck', 100)
+      out_track.events << MIDI::MetaEvent.new(MIDI::META_SEQ_NAME, 'Quack, Track 1', 200)
+      out_track.events << MIDI::NoteOn.new(0, 64, 127, 0)
+      out_track.events << MIDI::NoteOff.new(0, 64, 127, 100)
+    end
+
+    # 2) The unusual note off event with non-zero delta time
+    begin
+      out_track.events << MIDI::NoteOff.new(0, 65, 127, 120)
+      out_track.events << MIDI::NoteOn.new(0, 65, 127, 0)
+      # Add note off (which will be complemented at #end_track if missing) for later comparison.
+      out_track.events << MIDI::NoteOff.new(0, 65, 127, 230)
+    end
+
     File.open('/tmp/midilib_test.mid', 'wb') { |file| out_seq.write(file) }
 
     # Although start times are not written out to the MIDI file, we

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: midilib
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 3.1.0
 platform: ruby
 authors:
 - Jim Menard
@@ -35,6 +35,90 @@ files:
 - examples/split.rb
 - examples/strings.rb
 - examples/transpose.rb
+- html/MIDI.html
+- html/MIDI/ActiveSense.html
+- html/MIDI/ChannelEvent.html
+- html/MIDI/ChannelPressure.html
+- html/MIDI/Clock.html
+- html/MIDI/Continue.html
+- html/MIDI/Controller.html
+- html/MIDI/Event.html
+- html/MIDI/IO.html
+- html/MIDI/IO/MIDIFile.html
+- html/MIDI/IO/SeqReader.html
+- html/MIDI/IO/SeqWriter.html
+- html/MIDI/KeySig.html
+- html/MIDI/Marker.html
+- html/MIDI/Measure.html
+- html/MIDI/Measures.html
+- html/MIDI/MetaEvent.html
+- html/MIDI/NoteEvent.html
+- html/MIDI/NoteOff.html
+- html/MIDI/NoteOn.html
+- html/MIDI/PitchBend.html
+- html/MIDI/PolyPressure.html
+- html/MIDI/ProgramChange.html
+- html/MIDI/Realtime.html
+- html/MIDI/Sequence.html
+- html/MIDI/SongPointer.html
+- html/MIDI/SongSelect.html
+- html/MIDI/Start.html
+- html/MIDI/Stop.html
+- html/MIDI/SystemCommon.html
+- html/MIDI/SystemExclusive.html
+- html/MIDI/SystemReset.html
+- html/MIDI/Tempo.html
+- html/MIDI/TimeSig.html
+- html/MIDI/Track.html
+- html/MIDI/TuneRequest.html
+- html/MIDI/Utils.html
+- html/Object.html
+- html/README_rdoc.html
+- html/TODO_rdoc.html
+- html/created.rid
+- html/css/fonts.css
+- html/css/rdoc.css
+- html/fonts/Lato-Light.ttf
+- html/fonts/Lato-LightItalic.ttf
+- html/fonts/Lato-Regular.ttf
+- html/fonts/Lato-RegularItalic.ttf
+- html/fonts/SourceCodePro-Bold.ttf
+- html/fonts/SourceCodePro-Regular.ttf
+- html/images/add.png
+- html/images/arrow_up.png
+- html/images/brick.png
+- html/images/brick_link.png
+- html/images/bug.png
+- html/images/bullet_black.png
+- html/images/bullet_toggle_minus.png
+- html/images/bullet_toggle_plus.png
+- html/images/date.png
+- html/images/delete.png
+- html/images/find.png
+- html/images/loadingAnimation.gif
+- html/images/macFFBgHack.png
+- html/images/package.png
+- html/images/page_green.png
+- html/images/page_white_text.png
+- html/images/page_white_width.png
+- html/images/plugin.png
+- html/images/ruby.png
+- html/images/tag_blue.png
+- html/images/tag_green.png
+- html/images/transparent.png
+- html/images/wrench.png
+- html/images/wrench_orange.png
+- html/images/zoom.png
+- html/index.html
+- html/js/darkfish.js
+- html/js/navigation.js
+- html/js/navigation.js.gz
+- html/js/search.js
+- html/js/search_index.js
+- html/js/search_index.js.gz
+- html/js/searcher.js
+- html/js/searcher.js.gz
+- html/table_of_contents.html
 - install.rb
 - lib/midilib.rb
 - lib/midilib/consts.rb