midget_jobs 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46487fe4dd4186446042dabb5302257cb50c53e06364cc31d829407fcf15dabe
-  data.tar.gz: e28b11bf2e2aef9f47a8cdcedc5f734643ffab3288e7ca8111179f13b6a971cd
+  metadata.gz: '0381bb924f700b2ab31f3bcee872560499d312666ddac89221f592b9fde9af19'
+  data.tar.gz: f3c51ee3b9950148ec5b4c0803dea0380945c5e34a5672cceb37e52c8ff881b5
 SHA512:
-  metadata.gz: e5874e3d1766aa00e307a679d5692b22cdcdb54eda928be07068c24838cbbda7b2da026c0494ca3cc2ec22deb6f08e1851fe2fc0ef979f8cd571187cba42fc80
-  data.tar.gz: 0bdf9bc6dbe7f94fd8a44490901113e9df106b4d978a9db16ebbb6a983a5cbc76060ec0091dda1e65a54a2e545649fd324e177d01c005fe9cfc10b208b49689b
+  metadata.gz: c37ac71de44ca971da13aae9b8a2a17e2b7777904ca0a8fa777c495a2c5d3a1d7276b3b447937e01b734bb45b9caaf34fbd12961731cfa6f36f9e01849768781
+  data.tar.gz: 5f3f5b3e68a5b3876cf8df4f3b652c8cf64d60361eaa55ec57fd6a9d2e3b755051b0810019e83cdb7fe31bc76d90937c7662fe17fed2d04c69d5c77a32276031

data/.rubocop.yml

@@ -0,0 +1,67 @@
+# all the cops that are enabled in the default
+# https://github.com/bbatsov/rubocop/blob/master/config/enabled.yml
+# https://github.com/bbatsov/rubocop/blob/master/config/default.yml
+
+require: rubocop-performance
+require: rubocop-rails
+
+AllCops:
+  TargetRubyVersion: 2.6
+  Include:
+    - '**/Rakefile'
+    - '**/config.ru'
+  Exclude:
+    - 'db/**/*'
+    - 'config/**/*'
+    - 'script/**/*'
+    - !ruby/regexp /old_and_unused\.rb$/
+
+Layout/LineLength:
+  Max: 160
+
+Metrics/MethodLength:
+  CountComments: false  # count full line comments?
+  Max: 12
+
+Metrics/AbcSize:
+  Max: 20
+
+Style/AndOr:
+  Enabled: false
+
+Documentation:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  # Checks the style of children definitions at classes and modules.
+  #
+  # Basically there are two different styles:
+  #
+  # `nested` - have each child on a separate line
+  #   class Foo
+  #     class Bar
+  #     end
+  #   end
+  #
+  # `compact` - combine definitions as much as possible
+  #   class Foo::Bar
+  #   end
+  #
+  # The compact style is only forced, for classes / modules with one child.
+  EnforcedStyle: nested
+  SupportedStyles:
+    - nested
+    - compact
+  Enabled: false
+
+CaseIndentation:
+  # Valid values are: case, end
+  EnforcedStyle: case
+  IndentOneStep: true
+
+# Prefer `has_?` style for Hash methods
+Style/PreferredHashMethods:
+  EnforcedStyle: verbose
+
+Rails:
+  Enabled: true

data/Gemfile

@@ -12,4 +12,5 @@ group :test do
   gem 'activerecord'
   gem 'pg'
   gem 'activesupport'
+  gem 'simplecov', require: false
 end

data/db/migrate/20191022104513_create_midget_jobs.rb

@@ -10,5 +10,6 @@ class CreateMidgetJobs < ActiveRecord::Migration[6.0]
       t.timestamps
     end
     add_index :midget_jobs, :queue
+    add_index :midget_jobs, :runner
   end
 end

data/lib/generators/midget_jobs/templates/midget_job_initializer.rb

@@ -1,6 +1,6 @@
 Rails.application.config.active_job.queue_adapter = :midget_job
 Rails.application.config.x.midget_jobs.at_once = 4
-Rails.application.config.x.midget_jobs.runner = Rails.application.class.parent_name
+Rails.application.config.x.midget_jobs.runner = Rails.application.class.module_parent_name
 
 if Rails.const_defined?('Server') || $0.include?('puma')
   Rails.application.config.after_initialize do

data/lib/midget_jobs/version.rb

@@ -1,3 +1,3 @@
 module MidgetJobs
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/lib/models/concerns/postgres_notifications_listener.rb

@@ -2,22 +2,20 @@
 
 module PostgresNotificationsListener
   def listen_notifications
-    Rails.logger.info "#{self.name} listening_job started"
+    Rails.logger.info "#{name} listening_job started"
     Thread.new do
-      Rails.logger.info "#{self.name} listening_job running on #{self.name.pluralize.underscore}_notices"
-      self.connection.execute "LISTEN #{self.name.pluralize.underscore}_notices"
+      Rails.logger.info "#{name} listening_job running on #{name.pluralize.underscore}_notices"
+      connection.execute "LISTEN #{name.pluralize.underscore}_notices"
       loop do
-        begin
-          Rails.logger.info "#{self.name} listening_job wait_for_notify"
-          self.connection.raw_connection.wait_for_notify do |event, pid, payload|
-            data = JSON.parse payload, symbolize_names: true
-            Rails.logger.info "postgres #{event.inspect}, pid: #{pid.inspect}, data: #{data.inspect}"
-            process_notification(data)
-          end
-        rescue StandardError => error
-          Rails.logger.error "-------------Ex #{self.name} listening_job wait_for_notify #{error}----------------"
-          retry
+        Rails.logger.info "#{name} listening_job wait_for_notify"
+        connection.raw_connection.wait_for_notify do |event, pid, payload|
+          data = JSON.parse payload, symbolize_names: true
+          Rails.logger.info "postgres #{event.inspect}, pid: #{pid.inspect}, data: #{data.inspect}"
+          process_notification(data)
         end
+      rescue StandardError => e
+        Rails.logger.error "-----------Ex #{name} listening_job wait_for_notify #{e}-retrying!------------"
+        retry
       end
     end.abort_on_exception = true
   end

data/midget_job.gemspec

@@ -29,6 +29,6 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rake", ">= 12.3.3"
   spec.add_development_dependency "minitest", "~> 5.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: midget_jobs
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - josefchmel
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-12-19 00:00:00.000000000 Z
+date: 2020-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,16 +28,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -60,6 +60,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile