midget_jobs 0.1.6 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cbadd5ec1b0ac85a4b21c554c986c3b879d465d5259c845d643742d3dafd8197
-  data.tar.gz: '0834f8b2be247632dc702641b19800b1a0d4aeb2bcf6e8d51a959f705a2850ab'
+  metadata.gz: b3e3afb7822a9f252d8442f20d7bf89f80e23cb0d782cff7b53427803c67ff5c
+  data.tar.gz: bf1d546693adaa2c2349b220d4677bad7c7def45ad2b2fda835e0f83247dd036
 SHA512:
-  metadata.gz: f772366031db01f604822d3ad1acba4c95b2d3ac8ca23b3662807755c4cc8ea69806b2a5516e3610555e1e5ad52a4dd6947984c34734a38943a50e1d8354e2d2
-  data.tar.gz: 34a59c524980dc5fc8c76d9f24709324069133237977f1be3f86b2ba1482d65089cb12856c210d0e6aed62f8cfa2bb3ea5373e15ecbd53bcb3e398cd99603883
+  metadata.gz: cdadf27c542f6fbef5d84067b54acbb871d95bfc4f319e480705ef73687553918cc2c008c7b5feef565521fdb91b6dce7f442081d076382f19ceb167fae61dd2
+  data.tar.gz: dd99f425b0939821dc2cd00d9cce0fd8fce80b0c064cb007732b8cb4e2e583e1bab3d8372a48e0b55e7118ccb2c8a381eb00e2afc13c675e6e2bf5716ad9bf57

data/.rubocop.yml

@@ -0,0 +1,67 @@
+# all the cops that are enabled in the default
+# https://github.com/bbatsov/rubocop/blob/master/config/enabled.yml
+# https://github.com/bbatsov/rubocop/blob/master/config/default.yml
+
+require: rubocop-performance
+require: rubocop-rails
+
+AllCops:
+  TargetRubyVersion: 2.6
+  Include:
+    - '**/Rakefile'
+    - '**/config.ru'
+  Exclude:
+    - 'db/**/*'
+    - 'config/**/*'
+    - 'script/**/*'
+    - !ruby/regexp /old_and_unused\.rb$/
+
+Layout/LineLength:
+  Max: 160
+
+Metrics/MethodLength:
+  CountComments: false  # count full line comments?
+  Max: 12
+
+Metrics/AbcSize:
+  Max: 20
+
+Style/AndOr:
+  Enabled: false
+
+Documentation:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  # Checks the style of children definitions at classes and modules.
+  #
+  # Basically there are two different styles:
+  #
+  # `nested` - have each child on a separate line
+  #   class Foo
+  #     class Bar
+  #     end
+  #   end
+  #
+  # `compact` - combine definitions as much as possible
+  #   class Foo::Bar
+  #   end
+  #
+  # The compact style is only forced, for classes / modules with one child.
+  EnforcedStyle: nested
+  SupportedStyles:
+    - nested
+    - compact
+  Enabled: false
+
+CaseIndentation:
+  # Valid values are: case, end
+  EnforcedStyle: case
+  IndentOneStep: true
+
+# Prefer `has_?` style for Hash methods
+Style/PreferredHashMethods:
+  EnforcedStyle: verbose
+
+Rails:
+  Enabled: true

data/Gemfile

@@ -12,4 +12,5 @@ group :test do
   gem 'activerecord'
   gem 'pg'
   gem 'activesupport'
+  gem 'simplecov', require: false
 end

data/README.md

@@ -3,6 +3,15 @@
 MidgetJobs is simple implementation of background jobs for [Ruby on Rails](https://rubyonrails.org). I does not meant to be used without it.
 It is connected to [ActiveJob](https://github.com/rails/rails/tree/master/activejob) and [PostgreSQL](https://www.postgresql.org) using its triggers, notifications and listening.
 
+## Update from 0.1.7 to 0.2.0
+There is new column **runner** in **midget_jobs** table!
+It is used to recognise who will run particular job (if there are multiple application over one database)
+
+I added new configuration to Initializer. Add this to your config/initializers/midget_jobs.rb
+```Rails.application.config.x.midget_jobs.runner = Rails.application.class.parent_name```
+
+Please create migration with generator
+```rails generate migration AddRunnerToMidgetJob runner:string:index``` 
 
 ## Installation
 
@@ -21,6 +30,24 @@ Then run
     $ rails generate midget_jobs:install
     
 This generator creates an initializer file at config/initializers and migrations to db/migrate
+
+#### With Puma's multiple workers on production
+
+In file `config/initializers/midget_jobs.rb` disable start with puma:
+
+    ...
+    if Rails.const_defined?('Server')# || $0.include?('puma')
+
+In file `config/puma/production.rb` update `on_worker_boot do` block as:
+
+    ...
+    on_worker_boot do
+      ActiveRecord::Base.establish_connection if defined?(ActiveRecord)
+      Rails.logger.debug 'on_worker_boot starting jobs'
+    
+      MidgetJobs.initialize_workers
+      ...
+    end
       
 ## Usage
 

data/db/migrate/20191022104513_create_midget_jobs.rb

@@ -5,9 +5,11 @@ class CreateMidgetJobs < ActiveRecord::Migration[6.0]
       t.string :queue
       t.jsonb :serialized
       t.datetime :run_at
+      t.string :runner
 
       t.timestamps
     end
     add_index :midget_jobs, :queue
+    add_index :midget_jobs, :runner
   end
 end

data/lib/generators/midget_jobs/templates/create_midget_jobs.rb

@@ -5,9 +5,11 @@ class CreateMidgetJobs < ActiveRecord::Migration[6.0]
       t.string :queue
       t.jsonb :serialized
       t.datetime :run_at
+      t.string :runner
 
       t.timestamps
     end
     add_index :midget_jobs, :queue
+    add_index :midget_jobs, :runner
   end
 end

data/lib/generators/midget_jobs/templates/midget_job_initializer.rb

@@ -1,5 +1,6 @@
 Rails.application.config.active_job.queue_adapter = :midget_job
 Rails.application.config.x.midget_jobs.at_once = 4
+Rails.application.config.x.midget_jobs.runner = Rails.application.class.module_parent_name
 
 if Rails.const_defined?('Server') || $0.include?('puma')
   Rails.application.config.after_initialize do

data/lib/midget_jobs/version.rb

@@ -1,3 +1,3 @@
 module MidgetJobs
-  VERSION = "0.1.6"
+  VERSION = "0.2.4"
 end

data/lib/models/concerns/postgres_notifications_listener.rb

@@ -2,22 +2,31 @@
 
 module PostgresNotificationsListener
   def listen_notifications
-    Rails.logger.info "#{self.name} listening_job started"
+    Rails.logger.info "#{name} listening_job started"
     Thread.new do
-      Rails.logger.info "#{self.name} listening_job running on #{self.name.pluralize.underscore}_notices"
-      self.connection.execute "LISTEN #{self.name.pluralize.underscore}_notices"
+      Rails.logger.info "#{name} listening_job running on #{name.pluralize.underscore}_notices"
+      connection.execute "LISTEN #{name.pluralize.underscore}_notices"
+      exception_counter ||= 0
       loop do
-        begin
-          Rails.logger.info "#{self.name} listening_job wait_for_notify"
-          self.connection.raw_connection.wait_for_notify do |event, pid, payload|
-            data = JSON.parse payload, symbolize_names: true
-            Rails.logger.info "postgres #{event.inspect}, pid: #{pid.inspect}, data: #{data.inspect}"
-            process_notification(data)
-          end
-        rescue StandardError => error
-          Rails.logger.error "-------------Ex #{self.name} listening_job wait_for_notify #{error}----------------"
-          retry
+        Rails.logger.info "#{name} listening_job wait_for_notify"
+        connection.raw_connection.wait_for_notify do |event, pid, payload|
+          data = JSON.parse payload, symbolize_names: true
+          Rails.logger.info "postgres #{event.inspect}, pid: #{pid.inspect}, data: #{data.inspect}"
+          process_notification(data)
         end
+        exception_counter = 0
+      rescue PG::ConnectionBad => e
+        exception_counter += 1
+        Rails.logger.error "#{name} listening_job wait_for_notify lost connection #{e.inspect} retry #{exception_counter}th time!"
+        Rails.logger.error "Reestablish AR connection..."
+        ActiveRecord::Base.connection.verify!
+        sleep 0.1
+        (exception_counter < 3) ? retry : raise(e)
+      rescue StandardError => e
+        exception_counter += 1
+        Rails.logger.error "#{name} listening_job wait_for_notify exception #{e.inspect} retry #{exception_counter}th time!"
+        sleep 0.1
+        (exception_counter < 3) ? retry : raise(e)
       end
     end.abort_on_exception = true
   end

data/lib/models/midget_job.rb

@@ -3,6 +3,8 @@ require 'models/concerns/postgres_notifications_listener'
 class MidgetJob < ActiveRecord::Base
   extend PostgresNotificationsListener
 
+  default_scope { where(runner: Rails.configuration.x.midget_jobs.runner) }
+
   scope :for_processing, -> { where('run_at < ?', Time.current) }
 
   validates :job_id, :queue, :serialized, :run_at, presence: true
@@ -16,7 +18,7 @@ class MidgetJob < ActiveRecord::Base
       rescue => detail
         Rails.logger.error detail.cause
       end
-    end
+    end.abort_on_exception = true
   end
 
   def self.process_notification(hash_data)

data/midget_job.gemspec

@@ -29,6 +29,6 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rake", ">= 12.3.3"
   spec.add_development_dependency "minitest", "~> 5.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: midget_jobs
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.2.4
 platform: ruby
 authors:
 - josefchmel
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-12-18 00:00:00.000000000 Z
+date: 2020-07-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,16 +28,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -60,6 +60,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile