middleman-sprockets 4.0.0.rc.1 → 4.0.0.rc.2

data/features/step_definitions/builder_steps.rb

@@ -0,0 +1,8 @@
+Given /^a built app$/ do
+  step %Q{I run `middleman build --verbose`}
+end
+
+Given /^a successfully built app$/ do
+  step %Q{a built app}
+  step %Q{was successfully built}
+end

data/features/step_definitions/server_steps.rb

@@ -1,3 +1,23 @@
 Given /^wait a second$/ do
   sleep(1)
 end
+
+Given /^binding.pry/ do
+  binding.pry
+end
+
+Given /^the file "([^\"]*)" content is changed to\:$/ do |name, content|
+  step %Q{a file named "#{name}" with:}, content
+  sleep 1
+  system "touch #{File.join(ENV['MM_ROOT'], name)}"
+end
+
+Then /^sprockets paths should include "([^\"]*)"$/ do |path|
+  sprockets = @server_inst.extensions[:sprockets].environment
+  expect( sprockets.paths ).to include File.join(ENV['MM_ROOT'], path)
+end
+
+Then /^sprockets paths should include gem path "([^\"]*)"/ do |path|
+  sprockets = @server_inst.extensions[:sprockets].environment
+  expect( sprockets.paths ).to include File.join(PROJECT_ROOT_PATH, 'fixtures', 'gems', path)
+end

data/features/support/env.rb

@@ -15,4 +15,3 @@ require "middleman-core"
 require "middleman-core/step_definitions"
 require File.join(PROJECT_ROOT_PATH, 'lib', 'middleman-sprockets')
 require "erubis"
-

data/features/{asset_hash.feature → test_cases/asset_hash.feature}

@@ -1,4 +1,6 @@
 Feature: Assets get a file hash appended to their URL and references to them are updated
+
+  @asset_hash
   Scenario: Hashed-asset files are produced, and HTML, CSS, and JavaScript gets rewritten to reference the new files
     Given a successfully built app at "asset-hash-app"
     When I cd to "build"
@@ -18,7 +20,7 @@ Feature: Assets get a file hash appended to their URL and references to them are
       | images/100px.gif |
       | javascripts/application.js |
       | stylesheets/site.css |
-      
+
     And the file "javascripts/application-df677242.js" should contain "img.src = '/images/100px-5fd6fb90.jpg'"
     And the file "stylesheets/site-2f4798cc.css" should contain 'background-image: url(../images/100px-5fd6fb90.jpg)'
     And the file "index.html" should contain 'href="stylesheets/site-2f4798cc.css"'
@@ -30,43 +32,46 @@ Feature: Assets get a file hash appended to their URL and references to them are
     And the file "other/index.html" should contain 'href="../stylesheets/site-2f4798cc.css"'
     And the file "other/index.html" should contain 'src="../javascripts/application-df677242.js"'
     And the file "other/index.html" should contain 'src="../images/100px-5fd6fb90.jpg"'
-    
+
+  @asset_hash
   Scenario: Hashed assets work in preview server
     Given the Server is running at "asset-hash-app"
     When I go to "/"
-    Then I should see 'href="stylesheets/site-b7f4d02f.css"'
-    Then I should see 'href="stylesheets/jquery-mobile-05f64032.css"'
+    Then I should see 'href="stylesheets/site-2f4798cc.css"'
+    Then I should see 'href="stylesheets/jquery-mobile-08069726.css"'
     And I should see 'src="javascripts/application-df677242.js"'
     And I should see 'src="images/100px-5fd6fb90.jpg"'
     When I go to "/subdir/"
-    Then I should see 'href="../stylesheets/site-b7f4d02f.css"'
+    Then I should see 'href="../stylesheets/site-2f4798cc.css"'
     And I should see 'src="../javascripts/application-df677242.js"'
     And I should see 'src="../images/100px-5fd6fb90.jpg"'
     When I go to "/other/"
-    Then I should see 'href="../stylesheets/site-b7f4d02f.css"'
+    Then I should see 'href="../stylesheets/site-2f4798cc.css"'
     And I should see 'src="../javascripts/application-df677242.js"'
     And I should see 'src="../images/100px-5fd6fb90.jpg"'
     When I go to "/javascripts/application-df677242.js"
     Then I should see "img.src = '/images/100px-5fd6fb90.jpg'"
-    When I go to "/stylesheets/site-b7f4d02f.css"
-    Then I should see 'background-image: url("../images/100px-5fd6fb90.jpg")'
-    When I go to "/stylesheets/jquery-mobile-05f64032.css"
-    Then I should see 'background-image: url("../images/jquery-mobile/icons-18-white-1681b2cc.png")'
+    When I go to "/stylesheets/site-2f4798cc.css"
+    Then I should see 'background-image: url(../images/100px-5fd6fb90.jpg)'
+    When I go to "/stylesheets/jquery-mobile-08069726.css"
+    Then I should see 'background-image: url(../assets/jquery-mobile/icons-png/action-white-06d3eb76.png)'
 
-  Scenario: Enabling an asset host still produces hashed files and references  
+  @asset_hash
+  Scenario: Enabling an asset host still produces hashed files and references
     Given the Server is running at "asset-hash-host-app"
     When I go to "/"
-    Then I should see 'href="http://middlemanapp.com/stylesheets/site-1fdf4fb5.css"'
+    Then I should see 'href="http://middlemanapp.com/stylesheets/site-a15e24a3.css"'
     And I should see 'src="http://middlemanapp.com/images/100px-5fd6fb90.jpg"'
     When I go to "/subdir/"
-    Then I should see 'href="http://middlemanapp.com/stylesheets/site-1fdf4fb5.css"'
+    Then I should see 'href="http://middlemanapp.com/stylesheets/site-a15e24a3.css"'
     And I should see 'src="http://middlemanapp.com/images/100px-5fd6fb90.jpg"'
     When I go to "/other/"
-    Then I should see 'href="http://middlemanapp.com/stylesheets/site-1fdf4fb5.css"'
+    Then I should see 'href="http://middlemanapp.com/stylesheets/site-a15e24a3.css"'
     And I should see 'src="http://middlemanapp.com/images/100px-5fd6fb90.jpg"'
-    When I go to "/stylesheets/site-1fdf4fb5.css"
-    Then I should see 'background-image: url("http://middlemanapp.com/images/100px-5fd6fb90.jpg")'
+    When I go to "/stylesheets/site-a15e24a3.css"
+    Then I should see 'background-image: url(http://middlemanapp.com/images/100px-5fd6fb90.jpg)'
 
+  @asset_hash
   Scenario: The asset hash should change when a SASS partial changes
     Given the Server is running at "asset-hash-app"
     And the file "source/stylesheets/_partial.sass" has the contents
@@ -75,7 +80,7 @@ Feature: Assets get a file hash appended to their URL and references to them are
         font-size: 14px
       """
     When I go to "/partials/"
-    Then I should see 'href="../stylesheets/uses_partials-a48be509.css'
+    Then I should see 'href="../stylesheets/uses_partials-423a00f7.css'
     And wait a second
     And the file "source/stylesheets/_partial.sass" has the contents
       """
@@ -85,6 +90,7 @@ Feature: Assets get a file hash appended to their URL and references to them are
     When I go to "/partials/"
     Then I should see 'href="../stylesheets/uses_partials-e8c3d4eb.css'
 
+  @asset_hash
   Scenario: The asset hash should change when a Javascript partial changes
     Given the Server is running at "asset-hash-app"
     And the file "source/javascripts/sprockets_sub.js" has the contents
@@ -92,8 +98,8 @@ Feature: Assets get a file hash appended to their URL and references to them are
       function sprockets_sub_function() { }
       """
     When I go to "/partials/"
-    Then I should see 'src="../javascripts/sprockets_base-0252a861.js'
-    When I go to "/javascripts/sprockets_base-0252a861.js"
+    Then I should see 'src="../javascripts/sprockets_base-b80703b7.js'
+    When I go to "/javascripts/sprockets_base-b80703b7.js"
     Then I should see "sprockets_sub_function"
     And wait a second
     And the file "source/javascripts/sprockets_sub.js" has the contents
@@ -101,6 +107,6 @@ Feature: Assets get a file hash appended to their URL and references to them are
       function sprockets_sub2_function() { }
       """
     When I go to "/partials/"
-    Then I should see 'src="../javascripts/sprockets_base-5121d891.js'
-    When I go to "/javascripts/sprockets_base-5121d891.js"
-    Then I should see "sprockets_sub2_function"
+    Then I should see 'src="../javascripts/sprockets_base-f624ef94.js'
+    When I go to "/javascripts/sprockets_base-f624ef94.js"
+    Then I should see "sprockets_sub2_function"

data/features/test_cases/exception_response.feature

@@ -0,0 +1,31 @@
+Feature: Exception response for assets
+  It's usefull when running preview server to have assets include an exception response instead of just returning a 500. These exceptions shouldn't be caught during build though so they will show up in the output.
+
+  Background:
+    Given a fixture app "base-app"
+    And a file named "config.rb" with:
+      """
+      activate :sprockets
+      """
+    And a file named "source/stylesheets/site.css.scss" with:
+      """
+      body { color: $missing-variable; }
+      """
+    And a file named "source/javascripts/site.js.coffee" with:
+      """
+      bad:
+      """
+
+  Scenario: Preview server displays an exception in the language it was generated
+    Given the Server is running
+
+    When going to "/stylesheets/site.css" should not raise an exception
+    And I should see 'Error: Undefined variable: "$missing-variable"'
+
+    When going to "/javascripts/site.js" should not raise an exception
+    And I should see 'throw Error("ExecJS::RuntimeError: SyntaxError:'
+
+
+  Scenario: Exceptions are raised during build
+    Given a built app
+    Then the exit status should be 1

data/features/test_cases/excluded_file_extensions.feature

@@ -0,0 +1,39 @@
+Feature: Files with unhandled file extensions are ignored
+  We should be able to handle having files in one of the sprockets directories that sprockets can't process without blowing up.
+
+  Background:
+    Given a fixture app "base-app"
+
+
+  Scenario: Dotfiles in js_dir are handled by middleman only
+    Given a file named "source/library/js/.jslintrc" with:
+      """
+      {"bitwise":true}
+      """
+    And the Server is running
+
+    When I go to "/library/js/.jslintrc"
+    Then I should see '{"bitwise":true}'
+
+
+  Scenario: Files that output as HTML in js_dir aren't handled by Sprockets
+    Given a file named "source/library/js/index.html.erb" with:
+      """
+      <h1><%= current_resource.url %></h1>
+      """
+    And the Server is running
+
+    When I go to "/library/js"
+    Then I should see "<h1>/library/js/</h1>"
+
+
+  Scenario: Files with Tilt templates, but not supported by sprockets, are handled properly
+    Given a file named "source/library/js/index.js.haml" with:
+      """
+      :plain
+        alert('why haml?');
+      """
+    And the Server is running
+
+    When I go to "/library/js/index.js"
+    Then I should see "alert('why haml?');"

data/features/test_cases/file_not_found.feature

@@ -0,0 +1,31 @@
+Feature: Throw sane error when Sprockets doesn't find an asset
+
+  Background:
+    Given a fixture app "base-app"
+    And a file named "config.rb" with:
+      """
+      activate :sprockets
+
+      # trick to ensure sprockets has no paths to
+      # lookup assets
+      ready do
+        sprockets.clear_paths
+      end
+      """
+    And a file named "source/stylesheets/main.css.scss" with:
+      """
+      body { content: 'main'; }
+      """
+    And a file named "source/javascripts/main.js.coffee" with:
+      """
+      console.log 'main'
+      """
+
+  Scenario: When a file is removed, a FileNotFound is caught
+    Given the Server is running
+
+    When I go to "/stylesheets/main.css"
+    Then I should see "Sprockets::FileNotFound: stylesheets/main.css"
+
+    When I go to "/javascripts/main.js"
+    Then I should see "Sprockets::FileNotFound: javascripts/main.js"

data/features/test_cases/ignore_directive_is_respected.feature

@@ -0,0 +1,90 @@
+Feature: Files that match ignore directives are not built
+
+  Scenario: Sprockets asset that matches an ignore isn't built # but does link assets
+    Given a fixture app "base-app"
+    And a file named "config.rb" with:
+      """
+      activate :sprockets
+      ignore "javascripts/vendor/*"
+      """
+    And a file named "source/javascripts/vendor/site.js" with:
+      """
+      console.log('vendor/site.js');
+      """
+    And a file named "source/javascripts/site.js" with:
+      """
+      //= require 'vendor/site'
+      """
+    And the Server is running
+
+    When I go to "/javascripts/vendor/site.js"
+    Then the status code should be "404"
+
+    When I go to "/javascripts/site.js"
+    Then the status code should be "200"
+    And I should see "console.log('vendor/site.js');"
+
+    And a built app
+    Then the following files should not exist:
+      | build/javascripts/vendor/site.js |
+    Then the following files should exist:
+      | build/javascripts/site.js |
+
+  Scenario: Sprockets assets that are ignored are processed for links
+    Given a fixture app "base-app"
+    And a file named "config.rb" with:
+      """
+      activate :sprockets
+      sprockets.append_path File.join(root, 'vendor')
+      ignore "javascripts/manifest.js"
+      """
+    And a file named "vendor/linked.js" with:
+      """
+      console.log('vendor/linked.js');
+      """
+    And a file named "source/javascripts/manifest.js" with:
+      """
+      //= link 'linked'
+      """
+    And the Server is running
+
+    When I go to "/javascripts/manifest.js"
+    Then the status code should be "404"
+
+    When I go to "/assets/linked.js"
+    Then the status code should be "200"
+    And I should see "console.log('vendor/linked.js');"
+
+    And a built app
+    Then the following files should not exist:
+      | build/javascripts/manifest.js |
+    Then the following files should exist:
+      | build/assets/linked.js |
+
+
+  Scenario: Linked assets that match don't build
+    Given a fixture app "base-app"
+    And a file named "config.rb" with:
+      """
+      activate :sprockets
+      sprockets.append_path File.join(root, 'vendor')
+      ignore "assets/vendor/*"
+      """
+    And a file named "vendor/vendor/site.js" with:
+      """
+      console.log('vendor/site.js');
+      """
+    And a file named "source/javascripts/manifest.js" with:
+      """
+      //= link 'vendor/site'
+      """
+    And the Server is running
+
+    When I go to "/assets/vendor/site.js"
+    Then the status code should be "404"
+
+    And a built app
+    Then the following files should exist:
+      | build/javascripts/manifest.js |
+    Then the following files should not exist:
+      | build/assets/vendor/site.js |

data/features/test_cases/imported_asset_extensions.feature

@@ -0,0 +1,77 @@
+Feature: Imported assets are built with the correct extensions
+
+  Background:
+    Given a fixture app "base-app"
+    And a file named "config.rb" with:
+      """
+      activate :sprockets
+      sprockets.append_path File.join(root, 'vendor')
+      """
+    And a file named "vendor/fonts/webfont-vendor.svg" with:
+      """
+      """
+    And a file named "vendor/fonts/webfont-vendor.svg.gz" with:
+      """
+      """
+    And a file named "vendor/fonts/webfont-vendor.ttf.gz" with:
+      """
+      """
+    And a file named "source/fonts/webfont-source.svg" with:
+      """
+      """
+    And a file named "source/fonts/webfont-source.svg.gz" with:
+      """
+      """
+    And a file named "source/fonts/webfont-source.ttf.gz" with:
+      """
+      """
+    And a file named "vendor/images/drawing-vendor.svg" with:
+      """
+      """
+    And a file named "source/images/drawing-source.svg" with:
+      """
+      """
+    And a file named "vendor/images/extensions-source.svg.gz" with:
+      """
+      """
+    And a file named "vendor/images/extensions-source.min.js" with:
+      """
+      """
+    And a file named "vendor/images/extensions-source.asdf.asdf.min.js.asdf" with:
+      """
+      """
+
+
+  Scenario: Assets built by being linked are built with the right extension
+    Given a file named "source/stylesheets/manifest.css" with:
+      """
+      //= link 'fonts/webfont-vendor.svg'
+      //= link 'fonts/webfont-vendor.svg.gz'
+      //= link 'fonts/webfont-vendor.ttf.gz'
+      //= link 'images/drawing-vendor.svg'
+      //= link 'images/extensions-source.svg.gz'
+      //= link 'images/extensions-source.min.js'
+      //= link 'images/extensions-source.asdf.asdf.min.js.asdf'
+      """
+    And a successfully built app
+
+    When I cd to "build"
+    Then the following files should exist:
+      | assets/fonts/webfont-vendor.svg |
+      | assets/fonts/webfont-vendor.svg.gz |
+      | assets/fonts/webfont-vendor.ttf.gz |
+      | assets/images/drawing-vendor.svg |
+      | assets/images/extensions-source.svg.gz |
+      | assets/images/extensions-source.min.js |
+      | assets/images/extensions-source.asdf.asdf.min.js.asdf |
+
+  Scenario: Assets in source don't have their extensions mangled
+    Given a successfully built app
+
+    When I cd to "build"
+    Then the following files should exist:
+      | fonts/webfont-source.svg |
+      | fonts/webfont-source.svg.gz |
+      | fonts/webfont-source.ttf.gz |
+      | images/drawing-source.svg |
+

data/features/test_cases/jst.feature

@@ -0,0 +1,36 @@
+Feature: Sprockets JST & EJS
+
+  Background:
+    Given a fixture app "base-app"
+    And a file named "config.rb" with:
+      """
+      activate :sprockets
+      """
+    And a file named "source/javascripts/templates.js" with:
+      """
+      //= require_tree "./_templates"
+      """
+    And a file named "source/javascripts/_templates/test.jst.ejs" with:
+      """
+      <%= 'hello' %>
+      """
+    And a file named "source/javascripts/_templates/test2.jst.eco" with:
+      """
+      <%= 'world' %>
+      """
+
+  Scenario: Serving .ejs & .eco
+    Given the Server is running
+
+    When I go to "/javascripts/templates.js"
+    Then I should see '["_templates/test"] = function'
+    And I should see '["_templates/test2"] = function'
+
+
+  Scenario: Building .ejs & .eco
+    Given a successfully built app
+
+    When I cd to "build"
+    Then a file named "javascripts/templates.js" should exist
+    And the file "javascripts/templates.js" should contain '["_templates/test"] = function'
+    And the file "javascripts/templates.js" should contain '["_templates/test2"] = function'