mida 0.2.0 → 0.3.0

data/spec/itemprop_spec.rb

@@ -1,10 +1,11 @@
-require_relative 'spec_helper'
-require_relative '../lib/mida'
+require 'spec_helper'
+require 'mida/itemprop'
 
 
 describe Mida::Itemprop, 'when parsing an element without an itemprop attribute' do
   before do
-    @element = mock_element('span')
+    html = '<span>Lorry</span>'
+    @element = Nokogiri(html).children.first
   end
 
   it '#parse should return an empty Hash' do
@@ -14,7 +15,8 @@ end
 
 describe Mida::Itemprop, 'when parsing an element with one itemprop name' do
   before do
-    @element = mock_element('span', {'itemprop' => 'reviewer'}, 'Lorry Woodman')
+    html = '<span itemprop="reviewer">Lorry Woodman</span>'
+    @element = Nokogiri(html).children.first
   end
 
   it '#parse should return a Hash with the correct name/value pair' do
@@ -26,8 +28,7 @@ describe Mida::Itemprop, "when parsing an element who's inner text contains\
   non microdata elements" do
   before do
     html = '<span itemprop="reviewer">Lorry <em>Woodman</em></span>'
-    doc = Nokogiri(html)
-    @itemprop = doc.search('./*').first
+    @itemprop = Nokogiri(html).children.first
   end
 
   it '#parse should return a Hash with the correct name/value pair' do
@@ -37,45 +38,35 @@ end
 
 describe Mida::Itemprop, 'when parsing an itemscope element that has a relative url' do
   before do
-
-    # The first_name element
-    fn = mock_element('span', {'itemprop' => 'first_name'}, 'Lorry')
-
-    # The last_name element
-    ln = mock_element('span', {'itemprop' => 'last_name'}, 'Woodman')
-
-    # The url.  This is important to check whether the page_url is passed onto Item
-    url = mock_element('a', {'itemprop' => 'url', 'href' => 'home/LorryWoodman'})
-
-    # The surrounding reviewer itemscope element
-    @itemscope_el = mock_element('div', {'itemprop' => 'reviewer',
-                                         'itemtype' => 'person',
-                                         'itemscope' =>true}, nil, [fn,ln,url])
+    html = html_wrap <<-EOS
+      <div itemprop="reviewer" itemtype="person" itemscope>
+        <a itemprop="url" href="home/LorryWoodman">
+        </a>
+      </div>
+    EOS
+
+    itemprop = Nokogiri(html).search('//*[@itemscope]')
+    @properties = Mida::Itemprop.parse(itemprop, "http://example.com")
   end
 
-  it '#parse should return a Hash with the correct name/value pair' do
-    property = Mida::Itemprop.parse(@itemscope_el, "http://example.com")
-    property.size.should == 1
-    reviewer = property['reviewer']
-    reviewer.type.should == 'person'
-    reviewer.properties.should == {
-      'first_name' => ['Lorry'],
-      'last_name' => ['Woodman'],
-      'url' => ['http://example.com/home/LorryWoodman']
-    }
+  it 'should create an absolute url' do
+    url = @properties['reviewer'].properties['url']
+    url.should == ['http://example.com/home/LorryWoodman']
   end
 end
 
 describe Mida::Itemprop, 'when parsing an element with multiple itemprop names' do
   before do
-    @element = mock_element('span', {'itemprop' => 'reviewer friend person'}, 'the property text')
+    html = '<span itemprop="reviewer friend person">some text</span>'
+    itemprop = Nokogiri(html).children.first
+    @properties = Mida::Itemprop.parse(itemprop)
   end
 
-  it '#parse should return a Hash with the name/value pairs' do
-    Mida::Itemprop.parse(@element).should == {
-      'reviewer' => 'the property text',
-      'friend' => 'the property text',
-      'person' => 'the property text'
+  it 'it should return a Hash with the each of the itemprop names as keys' do
+    @properties.should == {
+      'reviewer' => 'some text',
+      'friend' => 'some text',
+      'person' => 'some text'
     }
   end
 end
@@ -97,7 +88,8 @@ describe Mida::Itemprop, 'when parsing an element with non text content url valu
     it 'should return nothing for relative urls' do
       url = 'register/index.html'
       URL_ELEMENTS.each do |tag, attr|
-        element = mock_element(tag, {'itemprop' => 'url', attr => url})
+        html = html_wrap %Q{<#{tag} itemprop="url" #{attr}="#{url}">The url</#{tag}>}
+        element = Nokogiri(html).search('//*[@itemprop]').first
         Mida::Itemprop.parse(element).should == {'url' => ''}
       end
     end
@@ -111,7 +103,8 @@ describe Mida::Itemprop, 'when parsing an element with non text content url valu
 
       urls.each do |url|
         URL_ELEMENTS.each do |tag, attr|
-          element = mock_element(tag, {'itemprop' => 'url', attr => url})
+          html = html_wrap %Q{<#{tag} itemprop="url" #{attr}="#{url}">The url</#{tag}>}
+          element = Nokogiri(html).search('//*[@itemprop]').first
           Mida::Itemprop.parse(element).should == {'url' => url}
         end
       end
@@ -126,7 +119,8 @@ describe Mida::Itemprop, 'when parsing an element with non text content url valu
     it 'should return the absolute url for relative urls' do
       url = 'register/index.html'
       URL_ELEMENTS.each do |tag, attr|
-        element = mock_element(tag, {'itemprop' => 'url', attr => url})
+        html = html_wrap %Q{<#{tag} itemprop="url" #{attr}="#{url}">The url</#{tag}>}
+        element = Nokogiri(html).search('//*[@itemprop]').first
         Mida::Itemprop.parse(element, @page_url).should ==
           {'url' => 'http://example.com/test/register/index.html'}
       end
@@ -141,7 +135,8 @@ describe Mida::Itemprop, 'when parsing an element with non text content url valu
 
       urls.each do |url|
         URL_ELEMENTS.each do |tag, attr|
-          element = mock_element(tag, {'itemprop' => 'url', attr => url})
+          html = html_wrap %Q{<#{tag} itemprop="url" #{attr}="#{url}">The url</#{tag}>}
+          element = Nokogiri(html).search('//*[@itemprop]').first
           Mida::Itemprop.parse(element, @page_url).should == {'url' => url}
         end
       end
@@ -152,14 +147,14 @@ end
 
 describe Mida::Itemprop, 'when parsing an element with non text content non url values' do
   it 'should get values from a meta content attribute' do
-    element = mock_element('meta', {'itemprop' => 'reviewer',
-                                    'content' => 'Lorry Woodman'})
+    html = html_wrap %q{<meta itemprop="reviewer" content="Lorry Woodman"/>}
+    element = Nokogiri(html).search('//*[@itemprop]').first
     Mida::Itemprop.parse(element).should == {'reviewer' => 'Lorry Woodman'}
   end
 
   it 'should get time from an time datatime attribute' do
-    element = mock_element('time', {'itemprop' => 'dtreviewed',
-                                    'datetime' => '2011-04-04'})
-    Mida::Itemprop.parse(element).should == {'dtreviewed' => '2011-04-04'}
+    html = html_wrap %q{<time itemprop="dtreviewed" datetime="2011-05-04"/>}
+    element = Nokogiri(html).search('//*[@itemprop]').first
+    Mida::Itemprop.parse(element).should == {'dtreviewed' => '2011-05-04'}
   end
 end

data/spec/itemscope_spec.rb

@@ -0,0 +1,287 @@
+require 'spec_helper'
+require 'mida'
+
+describe Mida::Itemscope, 'when initialized with an itemscope_node containing just itemprops' do
+  before do
+    html = <<-EOS
+      <div itemprop="reviewer" itemscope>
+        <span itemprop="first_name">Lorry </span>
+        <span itemprop="last_name">Woodman</span>
+      </div>
+    EOS
+    doc = Nokogiri(html).children.first
+    @itemscope = Mida::Itemscope.new(doc)
+  end
+
+  it '#properties should return the correct name/value pairs' do
+    @itemscope.properties.should == {
+      'first_name' => ['Lorry'],
+      'last_name' => ['Woodman']
+    }
+  end
+end
+
+
+describe Mida::Itemscope, 'when initialized with an itemscope_node not containing an itemtype' do
+  before do
+    html = <<-EOS
+      <div itemprop="reviewer" itemscope>
+        <span itemprop="first_name">Lorry </span>
+        <span itemprop="last_name">Woodman</span>
+      </div>
+    EOS
+    doc = Nokogiri(html).children.first
+    @itemscope = Mida::Itemscope.new(doc)
+  end
+
+  it '#type should return nil' do
+    @itemscope.type.should == nil
+  end
+end
+
+describe Mida::Itemscope, 'when initialized with an itemscope_node containing an itemtype' do
+  before do
+    html = <<-EOS
+      <div itemtype="person" itemprop="reviewer" itemscope>
+        <span itemprop="first_name">Lorry </span>
+        <span itemprop="last_name">Woodman</span>
+      </div>
+    EOS
+    doc = Nokogiri(html).children.first
+    @itemscope = Mida::Itemscope.new(doc)
+  end
+
+  it '#type should return nil' do
+    @itemscope.type.should == "person"
+  end
+end
+
+describe Mida::Itemscope, 'when initialized with an itemscope containing an itemprop with a relative url' do
+  before do
+    html = <<-EOS
+      <div itemscope>
+        <a itemprop="url" href="home/lorry">Lorry</a>
+      </div>
+    EOS
+    @doc = Nokogiri(html).children.first
+  end
+
+  context 'and the page url is not passed' do
+    before do
+      @itemscope = Mida::Itemscope.new(@doc)
+    end
+
+    it 'should return the url as an absolute url' do
+      @itemscope.properties['url'].should == ['']
+    end
+  end
+
+  context 'and the page url is passed' do
+    before do
+      @itemscope = Mida::Itemscope.new(@doc, "http://example.com")
+    end
+
+    it 'should return the url as an absolute url' do
+      @itemscope.properties['url'].should == ['http://example.com/home/lorry']
+    end
+  end
+
+end
+
+describe Mida::Itemscope, 'when initialized with an itemscope containing itemprops surrounded by a non microdata element' do
+  before do
+    html = <<-EOS
+      <div itemprop="reviewer" itemtype="person" itemscope>
+        <span itemprop="first_name">Lorry</span>
+        <span><span itemprop="last_name">Woodman</span></span>
+      </div>
+    EOS
+    doc = Nokogiri(html).children.first
+    @itemscope = Mida::Itemscope.new(doc)
+  end
+
+  it '#properties should return the correct name/value pairs' do
+    @itemscope.properties.should == {
+      'first_name' => ['Lorry'],
+      'last_name' => ['Woodman']
+    }
+  end
+
+end
+
+describe Mida::Itemscope, "when initialized with an itemscope containing itemprops
+  who's inner text is surrounded by non-microdata elements" do
+  before do
+    html = <<-EOS
+      <div itemscope>
+        <span itemprop="reviewer">Lorry <em>Woodman</em></span>
+      </div>'
+    EOS
+    doc = Nokogiri(html).children.first
+    @itemscope = Mida::Itemscope.new(doc)
+  end
+
+  it '#properties should return the correct name/value pairs' do
+    @itemscope.properties.should == {
+      'reviewer' => ['Lorry Woodman']
+    }
+  end
+
+end
+
+describe Mida::Itemscope, "when initialized with an itemscope containing an itemprop
+  nested within another itemprop" do
+  before do
+    html = <<-EOS
+      <div itemscope>
+        <span itemprop="description">The animal is a <span itemprop="colour">green</span> parrot.</span>
+      </div>
+    EOS
+    doc = Nokogiri(html).children.first
+    @itemscope = Mida::Itemscope.new(doc)
+  end
+
+  it '#properties should return both properties' do
+    @itemscope.properties.should == {
+      'description' => ['The animal is a green parrot.'],
+      'colour' => ['green']
+    }
+  end
+
+end
+
+describe Mida::Itemscope, 'when initialized with an itemscope containing itemprops with the same name' do
+  before do
+    strawberry_html = <<-EOS
+      <div itemprop="flavour" itemtype="icecream-type" itemscope>
+        <span itemprop="fruit">Strawberry</span>
+        <span itemprop="style">Homemade</span>
+      </div>
+    EOS
+    html = html_wrap <<-EOS
+      <div itemtype="icecreams" itemscope>
+        <span itemprop="flavour">Lemon Sorbet</span>
+        <span itemprop="flavour">Apricot Sorbet</span>
+        #{strawberry_html}
+      </div>
+    EOS
+    doc = Nokogiri(html).search('//*[@itemscope]').first
+    strawberry_doc = Nokogiri(html_wrap(strawberry_html))
+    strawberry_doc = strawberry_doc.search('//*[@itemscope]').first
+    @itemscope = Mida::Itemscope.new(doc)
+    @strawberry_itemscope = Mida::Itemscope.new(strawberry_doc)
+  end
+
+  it '#properties should return the correct name/value pairs' do
+    @itemscope.properties.should == {
+      'flavour' => [
+        'Lemon Sorbet',
+        'Apricot Sorbet',
+        @strawberry_itemscope
+      ]
+    }
+  end
+
+end
+
+describe Mida::Itemscope, 'when initialized with an itemscope containing itemrefs' do
+
+  before do
+    empty_band_html = <<-EOS
+      <div id="b" itemprop="band" itemscope itemref="c">
+      </div>
+      <div id="c">
+        <span itemprop="band_name">Jazz Band</span>
+        <span itemprop="band_size">12</span>
+      </div>
+    EOS
+    html = html_wrap <<-EOS
+      <div itemscope itemref="a b">
+        <span itemprop="age">30</span>
+      </div>
+      <div>
+        <p id="a"><span itemprop="name">Amanda</span></p>
+      </div>
+      #{empty_band_html}
+    EOS
+
+    doc = Nokogiri(html).search('//*[@itemscope]').first
+    empty_band_doc = Nokogiri(html_wrap(empty_band_html))
+    empty_band_doc = empty_band_doc.search('//*[@itemscope]').first
+    @itemscope = Mida::Itemscope.new(doc)
+    @empty_band_itemscope = Mida::Itemscope.new(empty_band_doc)
+  end
+
+  it '#properties should return the correct name/value pairs' do
+    @itemscope.properties.should == {
+      'age' => ['30'],
+      'name' => ['Amanda'],
+      'band' => [@empty_band_itemscope]
+    }
+  end
+
+end
+
+describe Mida::Itemscope, 'when initialized with an itemscope containing an itemid' do
+
+  before do
+    html = html_wrap <<-EOS
+      <div itemtype="book" itemscope itemid="urn:isbn:978-1-849510-50-9">
+        <span itemprop="title">Hacking Vim 7.2</span>
+        <span itemprop="author">Kim Schulz</span>
+      </div>
+    EOS
+
+    doc = Nokogiri(html).search('//*[@itemscope]').first
+    @itemscope = Mida::Itemscope.new(doc)
+  end
+
+  it '#id should return the correct id' do
+    @itemscope.id.should == 'urn:isbn:978-1-849510-50-9'
+  end
+
+end
+
+describe Mida::Itemscope, 'when initialized with an itemscope containing itemscopes as properties nested two deep' do
+  before do
+    reviewer_html = <<-EOS
+      <div itemprop="reviewer" itemtype="person" itemscope>
+        <span itemprop="first_name">Lorry</span>
+        <span itemprop="last_name">Woodman</span>
+        <div itemprop="represents" itemtype="organization" itemscope>
+          <span itemprop="name">Acme</span>
+        </div>
+      </div>
+    EOS
+    html = html_wrap <<-EOS
+      <div itemtype="review" itemscope>
+        <span itemprop="item_name">Acme Anvil</span>
+        <span itemprop="rating">5</span>
+        #{reviewer_html}
+      </div>
+    EOS
+
+    doc = Nokogiri(html).search('//*[@itemscope]').first
+    reviewer_doc = Nokogiri(html_wrap(reviewer_html))
+    reviewer_doc = reviewer_doc.search('//*[@itemscope]').first
+    @itemscope = Mida::Itemscope.new(doc)
+    @reviewer_itemscope = Mida::Itemscope.new(reviewer_doc)
+  end
+
+  it '#type should return the correct type' do
+    @itemscope.type.should == 'review'
+  end
+
+  it '#id should return the correct id' do
+    @itemscope.id.should == nil
+  end
+
+  it '#properties should return the correct name/value pairs' do
+    @itemscope.properties.should == {
+      'item_name' => ['Acme Anvil'],
+      'rating' => ['5'],
+      'reviewer' => [@reviewer_itemscope]
+    }
+  end
+
+end

data/spec/propertydesc_spec.rb

@@ -0,0 +1,56 @@
+require 'spec_helper'
+require 'mida/propertydesc'
+
+describe Mida::PropertyDesc, 'when initialized without a block' do
+  before do
+    @propertyDesc = Mida::PropertyDesc.new(3)
+  end
+
+  it '#to_h[:num] should equal num passed' do
+    @propertyDesc.to_h[:num].should == 3
+  end
+
+  it '#to_h[:types] should equal DataType::Text' do
+    @propertyDesc.to_h[:types].should == [Mida::DataType::Text]
+  end
+end
+
+describe Mida::PropertyDesc, 'when initialized with a block with no specified types' do
+  before do
+    @propertyDesc = Mida::PropertyDesc.new(3) {}
+  end
+
+  it '#to_h[:types] should equal DataType::Text' do
+    @propertyDesc.to_h[:types].should == [Mida::DataType::Text]
+  end
+end
+
+describe Mida::PropertyDesc, 'when initialized with a block that specifies types with extract()' do
+  before do
+    @propertyDesc = Mida::PropertyDesc.new(3) { extract String, Array}
+  end
+
+  it '#to_h[:types] should equal [String, Array]' do
+    @propertyDesc.to_h[:types].should == [String, Array]
+  end
+end
+
+describe Mida::PropertyDesc, 'when initialized with a block that specifies types with types()' do
+  before do
+    @propertyDesc = nil
+    @error = last_stderr do
+      @propertyDesc = Mida::PropertyDesc.new(3) { types String, Array}
+    end
+  end
+
+  it 'should warn on initialization if types() is used in the block' do
+    @error.should eq("[DEPRECATION] Mida::PropertyDesc#types is deprecated.  "+
+      "Please use Mida::PropertyDesc#extract instead."
+    )
+  end
+
+  it '#to_h[:types] should equal [String, Array]' do
+    @propertyDesc.to_h[:types].should == [String, Array]
+  end
+
+end