microwave 1.0.4 → 11.400.2

data/spec/unit/provider/package_spec.rb

@@ -346,11 +346,13 @@ describe Chef::Provider::Package do
       Chef::Cookbook::FileVendor.on_create { |manifest| Chef::Cookbook::FileSystemFileVendor.new(manifest, @cookbook_repo) }
 
       @node = Chef::Node.new
-      @cookbook_collection = Chef::CookbookCollection.new(Chef::CookbookLoader.new(@cookbook_repo))
+      cl = Chef::CookbookLoader.new(@cookbook_repo)
+      cl.load_cookbooks
+      @cookbook_collection = Chef::CookbookCollection.new(cl)
       @run_context = Chef::RunContext.new(@node, @cookbook_collection, @events)
 
-      @node[:platform] = 'PLATFORM: just testing'
-      @node[:platform_version] = 'PLATFORM VERSION: just testing'
+      @node.automatic_attrs[:platform] = 'PLATFORM: just testing'
+      @node.automatic_attrs[:platform_version] = 'PLATFORM VERSION: just testing'
 
       @new_resource.response_file('java.response')
       @new_resource.cookbook_name = 'java'
@@ -386,8 +388,8 @@ describe Chef::Provider::Package do
 
     describe "when installing the preseed file to the cache location" do
       before do
-        @node[:platform] = :just_testing
-        @node[:platform_version] = :just_testing
+        @node.automatic_attrs[:platform] = :just_testing
+        @node.automatic_attrs[:platform_version] = :just_testing
 
         @response_file_destination = Dir.tmpdir + '/preseed--java--java-6.seed'
 

data/spec/unit/provider/registry_key_spec.rb

@@ -0,0 +1,269 @@
+#
+# Author:: Lamont Granquist (lamont@opscode.com)
+# Copyright:: Copyright (c) 2012 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+describe Chef::Provider::RegistryKey do
+
+  let(:testval1) { { :name => "one", :type => :string, :data => "1" } }
+  let(:testval1_wrong_type) { { :name => "one", :type => :multi_string, :data => "1" } }
+  let(:testval1_wrong_data) { { :name => "one", :type => :string, :data => "2" } }
+  let(:testval2) { { :name => "two", :type => :string, :data => "2" } }
+  let(:testkey1) { 'HKLM\Software\Opscode\Testing' }
+
+  before(:each) do
+    @node = Chef::Node.new
+    @events = Chef::EventDispatch::Dispatcher.new
+    @run_context = Chef::RunContext.new(@node, {}, @events)
+
+    @new_resource = Chef::Resource::RegistryKey.new("windows is fun", @run_context)
+    @new_resource.key testkey1
+    @new_resource.values( testval1 )
+    @new_resource.recursive false
+
+    @provider = Chef::Provider::RegistryKey.new(@new_resource, @run_context)
+
+    @provider.stub!(:running_on_windows!).and_return(true)
+    @double_registry = double(Chef::Win32::Registry)
+    @provider.stub!(:registry).and_return(@double_registry)
+  end
+
+  describe "when first created" do
+  end
+
+  describe "executing load_current_resource" do
+    describe "when the key exists" do
+      before(:each) do
+        @double_registry.should_receive(:key_exists?).with(testkey1).and_return(true)
+        @double_registry.should_receive(:get_values).with(testkey1).and_return( testval2 )
+        @provider.load_current_resource
+      end
+
+      it "should set the key of the current resource to the key of the new resource" do
+        @provider.current_resource.key.should == @new_resource.key
+      end
+
+      it "should set the architecture of the current resource to the architecture of the new resource" do
+        @provider.current_resource.architecture.should == @new_resource.architecture
+      end
+
+      it "should set the recursive flag of the current resource to the recursive flag of the new resource" do
+        @provider.current_resource.recursive.should == @new_resource.recursive
+      end
+
+      it "should set the values of the current resource to the values it got from the registry" do
+        @provider.current_resource.values.should == [ testval2 ]
+      end
+    end
+
+    describe "when the key does not exist" do
+      before(:each) do
+        @double_registry.should_receive(:key_exists?).with(testkey1).and_return(false)
+        @provider.load_current_resource
+      end
+
+      it "should set the values in the current resource to empty array" do
+        @provider.current_resource.values.should == []
+      end
+    end
+  end
+
+  describe "action_create" do
+    context "when the key exists" do
+      before(:each) do
+        @double_registry.should_receive(:key_exists?).twice.with(testkey1).and_return(true)
+      end
+      it "should do nothing if the key and the value both exist" do
+        @double_registry.should_receive(:get_values).with(testkey1).and_return( testval1 )
+        @double_registry.should_not_receive(:set_value)
+        @provider.load_current_resource
+        @provider.action_create
+      end
+      it "should create the value if the key exists but the value does not" do
+        @double_registry.should_receive(:get_values).with(testkey1).and_return( testval2 )
+        @double_registry.should_receive(:set_value).with(testkey1, testval1)
+        @provider.load_current_resource
+        @provider.action_create
+      end
+      it "should set the value if the key exists but the data does not match" do
+        @double_registry.should_receive(:get_values).with(testkey1).and_return( testval1_wrong_data )
+        @double_registry.should_receive(:set_value).with(testkey1, testval1)
+        @provider.load_current_resource
+        @provider.action_create
+      end
+      it "should set the value if the key exists but the type does not match" do
+        @double_registry.should_receive(:get_values).with(testkey1).and_return( testval1_wrong_type )
+        @double_registry.should_receive(:set_value).with(testkey1, testval1)
+        @provider.load_current_resource
+        @provider.action_create
+      end
+    end
+    context "when the key exists and the values in the new resource are empty" do
+      it "when a value is in the key, it should do nothing" do
+        @provider.new_resource.values([])
+        @double_registry.should_receive(:key_exists?).twice.with(testkey1).and_return(true)
+        @double_registry.should_receive(:get_values).with(testkey1).and_return( testval1 )
+        @double_registry.should_not_receive(:create_key)
+        @double_registry.should_not_receive(:set_value)
+        @provider.load_current_resource
+        @provider.action_create
+      end
+      it "when no value is in the key, it should do nothing" do
+        @provider.new_resource.values([])
+        @double_registry.should_receive(:key_exists?).twice.with(testkey1).and_return(true)
+        @double_registry.should_receive(:get_values).with(testkey1).and_return( nil )
+        @double_registry.should_not_receive(:create_key)
+        @double_registry.should_not_receive(:set_value)
+        @provider.load_current_resource
+        @provider.action_create
+      end
+    end
+    context "when the key does not exist" do
+      before(:each) do
+        @double_registry.should_receive(:key_exists?).twice.with(testkey1).and_return(false)
+      end
+      it "should create the key and the value" do
+        @double_registry.should_receive(:create_key).with(testkey1, false)
+        @double_registry.should_receive(:set_value).with(testkey1, testval1)
+        @provider.load_current_resource
+        @provider.action_create
+      end
+    end
+    context "when the key does not exist and the values in the new resource are empty" do
+      it "should create the key" do
+        @new_resource.values([])
+        @double_registry.should_receive(:key_exists?).twice.with(testkey1).and_return(false)
+        @double_registry.should_receive(:create_key).with(testkey1, false)
+        @double_registry.should_not_receive(:set_value)
+        @provider.load_current_resource
+        @provider.action_create
+      end
+    end
+  end
+
+  describe "action_create_if_missing" do
+    context "when the key exists" do
+      before(:each) do
+        @double_registry.should_receive(:key_exists?).twice.with(testkey1).and_return(true)
+      end
+      it "should do nothing if the key and the value both exist" do
+        @double_registry.should_receive(:get_values).with(testkey1).and_return( testval1 )
+        @double_registry.should_not_receive(:set_value)
+        @provider.load_current_resource
+        @provider.action_create_if_missing
+      end
+      it "should create the value if the key exists but the value does not" do
+        @double_registry.should_receive(:get_values).with(testkey1).and_return( testval2 )
+        @double_registry.should_receive(:set_value).with(testkey1, testval1)
+        @provider.load_current_resource
+        @provider.action_create_if_missing
+      end
+      it "should not set the value if the key exists but the data does not match" do
+        @double_registry.should_receive(:get_values).with(testkey1).and_return( testval1_wrong_data )
+        @double_registry.should_not_receive(:set_value)
+        @provider.load_current_resource
+        @provider.action_create_if_missing
+      end
+      it "should not set the value if the key exists but the type does not match" do
+        @double_registry.should_receive(:get_values).with(testkey1).and_return( testval1_wrong_type )
+        @double_registry.should_not_receive(:set_value)
+        @provider.load_current_resource
+        @provider.action_create_if_missing
+      end
+    end
+    context "when the key does not exist" do
+      before(:each) do
+        @double_registry.should_receive(:key_exists?).twice.with(testkey1).and_return(false)
+      end
+      it "should create the key and the value" do
+        @double_registry.should_receive(:create_key).with(testkey1, false)
+        @double_registry.should_receive(:set_value).with(testkey1, testval1)
+        @provider.load_current_resource
+        @provider.action_create_if_missing
+      end
+    end
+  end
+
+  describe "action_delete" do
+    context "when the key exists" do
+      before(:each) do
+        @double_registry.should_receive(:key_exists?).twice.with(testkey1).and_return(true)
+      end
+      it "deletes the value when the value exists" do
+        @double_registry.should_receive(:get_values).with(testkey1).and_return( testval1 )
+        @double_registry.should_receive(:delete_value).with(testkey1, testval1)
+        @provider.load_current_resource
+        @provider.action_delete
+      end
+      it "deletes the value when the value exists, but the type is wrong" do
+        @double_registry.should_receive(:get_values).with(testkey1).and_return( testval1_wrong_type )
+        @double_registry.should_receive(:delete_value).with(testkey1, testval1)
+        @provider.load_current_resource
+        @provider.action_delete
+      end
+      it "deletes the value when the value exists, but the data is wrong" do
+        @double_registry.should_receive(:get_values).with(testkey1).and_return( testval1_wrong_data )
+        @double_registry.should_receive(:delete_value).with(testkey1, testval1)
+        @provider.load_current_resource
+        @provider.action_delete
+      end
+      it "does not delete the value when the value does not exist" do
+        @double_registry.should_receive(:get_values).with(testkey1).and_return( testval2 )
+        @double_registry.should_not_receive(:delete_value)
+        @provider.load_current_resource
+        @provider.action_delete
+      end
+    end
+    context "when the key does not exist" do
+      before(:each) do
+        @double_registry.should_receive(:key_exists?).twice.with(testkey1).and_return(false)
+      end
+      it "does nothing" do
+        @double_registry.should_not_receive(:delete_value)
+        @provider.load_current_resource
+        @provider.action_delete
+      end
+    end
+  end
+
+  describe "action_delete_key" do
+    context "when the key exists" do
+      before(:each) do
+        @double_registry.should_receive(:key_exists?).twice.with(testkey1).and_return(true)
+      end
+      it "deletes the key" do
+        @double_registry.should_receive(:get_values).with(testkey1).and_return( testval1 )
+        @double_registry.should_receive(:delete_key).with(testkey1, false)
+        @provider.load_current_resource
+        @provider.action_delete_key
+      end
+    end
+    context "when the key does not exist" do
+      before(:each) do
+        @double_registry.should_receive(:key_exists?).twice.with(testkey1).and_return(false)
+      end
+      it "does nothing" do
+        @double_registry.should_not_receive(:delete_key)
+        @provider.load_current_resource
+        @provider.action_delete_key
+      end
+    end
+  end
+
+end
+

data/spec/unit/provider/remote_directory_spec.rb

@@ -32,7 +32,7 @@ describe Chef::Provider::RemoteDirectory do
     #to not have this line. Only affects updating state fields.
     Chef::Provider::CookbookFile.any_instance.stub(:update_new_file_state)
 
-    @resource = Chef::Resource::RemoteDirectory.new("/tmp/tafty")
+    @resource = Chef::Resource::RemoteDirectory.new(File.join(Dir.tmpdir, "tafty"))
     # in CHEF_SPEC_DATA/cookbooks/openldap/files/default/remotedir
     @resource.source "remotedir"
     @resource.cookbook('openldap')
@@ -41,7 +41,9 @@ describe Chef::Provider::RemoteDirectory do
     Chef::Cookbook::FileVendor.on_create { |manifest| Chef::Cookbook::FileSystemFileVendor.new(manifest, @cookbook_repo) }
 
     @node = Chef::Node.new
-    @cookbook_collection = Chef::CookbookCollection.new(Chef::CookbookLoader.new(@cookbook_repo))
+    cl = Chef::CookbookLoader.new(@cookbook_repo)
+    cl.load_cookbooks
+    @cookbook_collection = Chef::CookbookCollection.new(cl)
 
     @events = Chef::EventDispatch::Dispatcher.new
     @run_context = Chef::RunContext.new(@node, @cookbook_collection, @events)
@@ -50,6 +52,21 @@ describe Chef::Provider::RemoteDirectory do
     @provider.current_resource = @resource.clone
   end
 
+  describe "when the contents of the directory changed on the first run and not on the second run" do
+    before do
+      @resource_second_run = @resource.clone
+      @provider_second_run = Chef::Provider::RemoteDirectory.new(@resource_second_run, @run_context)
+      @provider.run_action(:create)
+      @provider_second_run.run_action(:create)
+    end
+    it "identifies that the state has changed the after first run" do
+      @provider_second_run.new_resource.updated_by_last_action? == true 
+    end
+    it "identifies that the state has not changed after the second run" do
+      @provider_second_run.new_resource.updated_by_last_action? == false 
+    end
+  end
+
   describe "when access control is configured on the resource" do
     before do
       @resource.mode  "0750"
@@ -65,8 +82,8 @@ describe Chef::Provider::RemoteDirectory do
     end
 
     it "configures access control on intermediate directorys" do
-      directory_resource = @provider.send(:resource_for_directory, "/tmp/intermediate_dir")
-      directory_resource.path.should  == "/tmp/intermediate_dir"
+      directory_resource = @provider.send(:resource_for_directory, File.join(Dir.tmpdir, "intermediate_dir"))
+      directory_resource.path.should  == File.join(Dir.tmpdir, "intermediate_dir")
       directory_resource.mode.should  == "0750"
       directory_resource.group.should == "wheel"
       directory_resource.owner.should == "root"
@@ -89,8 +106,8 @@ describe Chef::Provider::RemoteDirectory do
 
   describe "when creating the remote directory" do
     before do
-      @node[:platform] = :just_testing
-      @node[:platform_version] = :just_testing
+      @node.automatic_attrs[:platform] = :just_testing
+      @node.automatic_attrs[:platform_version] = :just_testing
 
       @destination_dir = Dir.mktmpdir << "/remote_directory_test"
       @resource.path(@destination_dir)
@@ -164,7 +181,7 @@ describe Chef::Provider::RemoteDirectory do
         ::File.exist?(@destination_dir + '/a/multiply/nested/directory/qux.txt').should be_false
       end
 
-      it "removes directory symlinks properly" do
+      it "removes directory symlinks properly", :not_supported_on_win2k3 do
         symlinked_dir_path = @destination_dir + '/symlinked_dir'
         @provider.action = :create
         @provider.run_action

data/spec/unit/provider/remote_file_spec.rb

@@ -79,6 +79,42 @@ describe Chef::Provider::RemoteFile, "action_create" do
       end
     end
 
+    shared_examples_for "source specified with multiple URIs" do
+      it "should try to download the next URI when the first one fails" do
+        @rest.should_receive(:streaming_request).with("http://foo", {}).once.and_raise(SocketError)
+        @rest.should_receive(:streaming_request).with("http://bar", {}).once.and_return(@tempfile)
+        @provider.run_action(:create)
+      end
+
+      it "should raise an exception when all the URIs fail" do
+        @rest.should_receive(:streaming_request).with("http://foo", {}).once.and_raise(SocketError)
+        @rest.should_receive(:streaming_request).with("http://bar", {}).once.and_raise(SocketError)
+        lambda { @provider.run_action(:create) }.should raise_error(SocketError)
+      end
+
+      it "should download from only one URI when the first one works" do
+        @rest.should_receive(:streaming_request).once.and_return(@tempfile)
+        @provider.run_action(:create)
+      end
+
+    end
+
+    describe "and the source specifies multiple URIs using multiple arguments" do
+      it_should_behave_like "source specified with multiple URIs"
+
+      before(:each) do
+        @resource.source("http://foo", "http://bar")
+      end
+    end
+
+    describe "and the source specifies multiple URIs using an array" do
+      it_should_behave_like "source specified with multiple URIs"
+
+      before(:each) do
+        @resource.source([ "http://foo", "http://bar" ])
+      end
+    end
+
     describe "and the resource specifies a checksum" do
 
       describe "and the existing file matches the checksum exactly" do

data/spec/unit/provider/route_spec.rb

@@ -51,7 +51,7 @@ describe Chef::Provider::Route do
   describe Chef::Provider::Route, "load_current_resource" do
     context "on linux" do
       before do
-        @node[:os] = 'linux'
+        @node.automatic_attrs[:os] = 'linux'
         routing_table = "Iface	Destination	Gateway 	Flags	RefCnt	Use	Metric	Mask		MTU	Window	IRTT\n" +
                         "eth0	0064A8C0	0984A8C0	0003	0	0	0	00FFFFFF	0	0	0\n"
         route_file = StringIO.new(routing_table)
@@ -198,20 +198,18 @@ describe Chef::Provider::Route do
   describe Chef::Provider::Route, "generate_config method" do
     %w[ centos redhat fedora ].each do |platform|
       it "should write a route file on #{platform} platform" do
-        @node[:platform] = platform
+        @node.automatic_attrs[:platform] = platform
 
         route_file = StringIO.new
         File.should_receive(:new).with("/etc/sysconfig/network-scripts/route-eth0", "w").and_return(route_file)
         #Chef::Log.should_receive(:debug).with("route[10.0.0.10] writing route.eth0\n10.0.0.10 via 10.0.0.9\n")
         @run_context.resource_collection << @new_resource
-
         @provider.generate_config
-        @provider.converge
       end
     end
 
     it "should put all routes for a device in a route config file" do
-      @node[:platform] = 'centos'
+      @node.automatic_attrs[:platform] = 'centos'
 
       route_file = StringIO.new
       File.should_receive(:new).and_return(route_file)
@@ -220,7 +218,6 @@ describe Chef::Provider::Route do
       @run_context.resource_collection << Chef::Resource::Route.new('192.168.3.0/24 via 192.168.0.1')
 
       @provider.generate_config
-      @provider.converge
       route_file.string.split("\n").should have(3).items
       route_file.string.should match(/^192.168.1.0\/24 via 192.168.0.1$/)
       route_file.string.should match(/^192.168.2.0\/24 via 192.168.0.1$/)