miasma 0.3.2 → 0.3.4

data/lib/miasma/specs/orchestration_abstract.rb

@@ -1,43 +1,39 @@
-require 'timeout'
+require "timeout"
 
-MIASMA_ORCHESTRATION_ABSTRACT = ->{
+MIASMA_ORCHESTRATION_ABSTRACT = -> {
 
   # Required `let`s:
   # * orchestration: orchestration API
   # * build_args: stack build arguments [Smash]
 
   describe Miasma::Models::Orchestration, :vcr do
-
-    it 'should provide #stacks collection' do
+    it "should provide #stacks collection" do
       orchestration.stacks.must_be_kind_of Miasma::Models::Orchestration::Stacks
     end
 
     describe Miasma::Models::Orchestration::Stacks do
-
-      it 'should provide instance class used within collection' do
+      it "should provide instance class used within collection" do
         orchestration.stacks.model.must_equal Miasma::Models::Orchestration::Stack
       end
 
-      it 'should build new instance for collection' do
+      it "should build new instance for collection" do
         instance = orchestration.stacks.build
         instance.must_be_kind_of Miasma::Models::Orchestration::Stack
       end
 
-      it 'should provide #all stacks' do
+      it "should provide #all stacks" do
         orchestration.stacks.all.must_be_kind_of Array
       end
-
     end
 
     describe Miasma::Models::Orchestration::Stacks do
-
       before do
-        unless($miasma_stack)
-          VCR.use_cassette('Miasma_Models_Orchestration_Global/GLOBAL_orchestration_stack_create') do
+        unless $miasma_stack
+          VCR.use_cassette("Miasma_Models_Orchestration_Global/GLOBAL_orchestration_stack_create") do
             @stack = orchestration.stacks.build(build_args)
             @stack.save
             Timeout.timeout(500) do
-              until(@stack.state == :create_complete)
+              until @stack.state == :create_complete
                 miasma_spec_sleep
                 @stack.reload
               end
@@ -47,7 +43,7 @@ MIASMA_ORCHESTRATION_ABSTRACT = ->{
             $miasma_stack = @stack
           end
           Kernel.at_exit do
-            VCR.use_cassette('Miasma_Models_Compute_Global/GLOBAL_orchestration_stack_destroy') do
+            VCR.use_cassette("Miasma_Models_Compute_Global/GLOBAL_orchestration_stack_destroy") do
               $miasma_stack.destroy
             end
           end
@@ -57,55 +53,50 @@ MIASMA_ORCHESTRATION_ABSTRACT = ->{
         @stack.reload
       end
 
-      let(:stack){ @stack }
-
-      describe 'collection' do
+      let(:stack) { @stack }
 
-        it 'should include stack' do
-          orchestration.stacks.all.detect{|s| s.id == stack.id}.wont_be_nil
+      describe "collection" do
+        it "should include stack" do
+          orchestration.stacks.all.detect { |s| s.id == stack.id }.wont_be_nil
           orchestration.stacks.get(stack.id).wont_be_nil
         end
-
       end
 
-      describe 'instance methods' do
-
-        it 'should have a name' do
+      describe "instance methods" do
+        it "should have a name" do
           stack.name.must_equal build_args[:name]
         end
 
-        it 'should be in :create_complete state' do
+        it "should be in :create_complete state" do
           stack.state.must_equal :create_complete
         end
 
-        it 'should have a status' do
+        it "should have a status" do
           stack.status.must_be_kind_of String
         end
 
-        it 'should have a creation time' do
+        it "should have a creation time" do
           stack.created.must_be_kind_of Time
         end
 
-        it 'should have parameters used for creation' do
+        it "should have parameters used for creation" do
           stack.parameters.to_smash.must_equal build_args[:parameters].to_smash
         end
 
-        it 'should include the templated used for creation' do
+        it "should include the templated used for creation" do
           stack.template.to_smash.must_equal build_args[:template].to_smash
         end
-
       end
-
     end
 
-    describe 'instance lifecycle' do
-      it 'should create new stack, reload details and destroy stack' do
-        stack = orchestration.stacks.build(build_args.merge(:name => 'miasma-test-stack-2'))
+    describe "instance lifecycle" do
+      it "should create new stack, reload details and destroy stack" do
+        stack = orchestration.stacks.build(build_args.merge(:name => "miasma-test-stack-2"))
         stack.save
         stack.id.wont_be_nil
         stack.state.must_equal :create_in_progress
         orchestration.stacks.reload.get(stack.id).wont_be_nil
-        until(stack.state == :create_complete)
+        until stack.state == :create_complete
           miasma_spec_sleep
           stack.reload
         end
@@ -113,15 +104,13 @@ MIASMA_ORCHESTRATION_ABSTRACT = ->{
         stack.destroy
         [:delete_in_progress, :delete_complete].must_include stack.state
         Timeout.timeout(500) do
-          until(stack.state == :delete_complete)
+          until stack.state == :delete_complete
             miasma_spec_sleep
             stack.reload
           end
         end
         stack.state.must_equal :delete_complete
       end
-
     end
-
   end
 }

data/lib/miasma/specs/storage_abstract.rb

@@ -1,43 +1,39 @@
-require 'open-uri'
+require "open-uri"
 
-MIASMA_STORAGE_ABSTRACT = ->{
+MIASMA_STORAGE_ABSTRACT = -> {
 
   # Required `let`s:
   # * storage: storage API
 
   describe Miasma::Models::Storage, :vcr do
-
-    it 'should provide #buckets collection' do
+    it "should provide #buckets collection" do
       storage.buckets.must_be_kind_of Miasma::Models::Storage::Buckets
     end
 
     describe Miasma::Models::Storage::Buckets do
-
-      it 'should provide instance class used within collection' do
+      it "should provide instance class used within collection" do
         storage.buckets.model.must_equal Miasma::Models::Storage::Bucket
       end
 
-      it 'should build new instance for collection' do
+      it "should build new instance for collection" do
         storage.buckets.build.must_be_kind_of Miasma::Models::Storage::Bucket
       end
 
-      it 'should provide #all buckets' do
+      it "should provide #all buckets" do
         storage.buckets.all.must_be_kind_of Array
       end
-
     end
 
     describe Miasma::Models::Storage::Bucket do
-
-      it 'should act like a bucket' do
-        bucket = storage.buckets.build(:name => 'miasma-test-bucket-010')
+      it "should act like a bucket" do
+        bucket = storage.buckets.build(:name => "miasma-test-bucket-010")
         bucket.save
         bucket.reload
 
         # should include the bucket
-        storage.buckets.reload.get('miasma-test-bucket-010').wont_be_nil
+        storage.buckets.reload.get("miasma-test-bucket-010").wont_be_nil
         # should have a name
-        bucket.name.must_equal 'miasma-test-bucket-010'
+        bucket.name.must_equal "miasma-test-bucket-010"
         # should have a #files collection
         bucket.files.must_be_kind_of Miasma::Models::Storage::Files
         #should provide #all files
@@ -47,15 +43,15 @@ MIASMA_STORAGE_ABSTRACT = ->{
         # should build new instance for collection
         bucket.files.build.must_be_kind_of Miasma::Models::Storage::File
 
-        file_content = 'blahblahblah'
+        file_content = "blahblahblah"
         file = bucket.files.build
-        file.name = 'miasma-test-file'
+        file.name = "miasma-test-file"
         file.body = file_content
         file.save
         file.reload
 
         # should have a name
-        file.name.must_equal 'miasma-test-file'
+        file.name.must_equal "miasma-test-file"
         # should have a size
         file.size.must_equal file_content.size
         # should have an updated timestamp
@@ -67,9 +63,9 @@ MIASMA_STORAGE_ABSTRACT = ->{
         file.body.readpartial(Miasma::Models::Storage::READ_BODY_CHUNK_SIZE).must_equal file_content
         file.destroy
 
-        big_file_content = '*' * Miasma::Models::Storage::MAX_BODY_SIZE_FOR_STRINGIFY
+        big_file_content = "*" * Miasma::Models::Storage::MAX_BODY_SIZE_FOR_STRINGIFY
         big_file = bucket.files.build
-        big_file.name = 'miasma-test-file-big'
+        big_file.name = "miasma-test-file-big"
         big_file.body = big_file_content
         big_file.save
         big_file.reload
@@ -82,14 +78,14 @@ MIASMA_STORAGE_ABSTRACT = ->{
         content.must_equal big_file_content
         big_file.destroy
 
-        require 'tempfile'
-        local_io_file = Tempfile.new('miasma-storage-test')
-        big_io_content = '*' * (Miasma::Models::Storage::MAX_BODY_SIZE_FOR_STRINGIFY * 1.3)
+        require "tempfile"
+        local_io_file = Tempfile.new("miasma-storage-test")
+        big_io_content = "*" * (Miasma::Models::Storage::MAX_BODY_SIZE_FOR_STRINGIFY * 1.3)
         local_io_file.write big_io_content
         local_io_file.flush
         local_io_file.rewind
         remote_file = bucket.files.build
-        remote_file.name = 'miasma-test-io-object-010'
+        remote_file.name = "miasma-test-io-object-010"
         remote_file.body = local_io_file
         remote_file.save
         remote_file.reload
@@ -98,16 +94,14 @@ MIASMA_STORAGE_ABSTRACT = ->{
         remote_file.size.must_equal local_io_file.size
         # should provide streaming body
         remote_file.body.must_respond_to :readpartial
-        content = ''
-        while(chunk = remote_file.body.readpartial(1024))
+        content = ""
+        while chunk = remote_file.body.readpartial(1024)
           content << chunk
         end
         content.must_equal big_io_content
         remote_file.destroy
         bucket.destroy
       end
-
     end
-
   end
 }

data/lib/miasma/types.rb

@@ -1,13 +1,11 @@
-require 'miasma'
+require "miasma"
 
 module Miasma
   module Types
-
-    autoload :Api, 'miasma/types/api'
-    autoload :Collection, 'miasma/types/collection'
-    autoload :Model, 'miasma/types/model'
-    autoload :ThinModel, 'miasma/types/thin_model'
-    autoload :Data, 'miasma/types/data'
-
+    autoload :Api, "miasma/types/api"
+    autoload :Collection, "miasma/types/collection"
+    autoload :Model, "miasma/types/model"
+    autoload :ThinModel, "miasma/types/thin_model"
+    autoload :Data, "miasma/types/data"
   end
 end

data/lib/miasma/types/api.rb

@@ -1,4 +1,4 @@
-require 'miasma'
+require "miasma"
 
 module Miasma
   module Types
@@ -7,9 +7,9 @@ module Miasma
     class Api
 
       # HTTP request methods that are allowed retry
-      VALID_REQUEST_RETRY_METHODS=[:get, :head]
+      VALID_REQUEST_RETRY_METHODS = [:get, :head]
       # Maximum allowed HTTP request retries (for non-HTTP related errors)
-      MAX_REQUEST_RETRIES=5
+      MAX_REQUEST_RETRIES = 5
 
       include Miasma::Utils::Lazy
       include Miasma::Utils::Memoization
@@ -22,7 +22,7 @@ module Miasma
       # @return [self]
       def initialize(creds)
         custom_setup(creds)
-        if(creds.is_a?(Hash))
+        if creds.is_a?(Hash)
           load_data(creds)
         else
           raise TypeError.new "Expecting `credentials` to be of type `Hash`. Received: `#{creds.class}`"
@@ -51,7 +51,7 @@ module Miasma
 
       # @return [Symbol] name of provider
       def provider
-        Utils.snake(self.class.to_s.split('::').last).to_sym
+        Utils.snake(self.class.to_s.split("::").last).to_sym
       end
 
       # Connect to the remote API
@@ -71,7 +71,7 @@ module Miasma
             Smash.new(
               :type => type,
               :provider => provider,
-              :credentials => attributes
+              :credentials => attributes,
             )
           )
         end
@@ -79,12 +79,12 @@ module Miasma
 
       # @return [HTTP]
       def connection
-        HTTP.headers('User-Agent' => "miasma/v#{Miasma::VERSION}")
+        HTTP.headers("User-Agent" => "miasma/v#{Miasma::VERSION}")
       end
 
       # @return [String] url endpoint
       def endpoint
-        'http://api.example.com'
+        "http://api.example.com"
       end
 
       # Perform request to remote API
@@ -98,9 +98,9 @@ module Miasma
       # @raises [Error::ApiError::RequestError]
       def request(args)
         args = args.to_smash
-        http_method = args.fetch(:method, 'get').to_s.downcase.to_sym
-        unless(HTTP::Request::METHODS.include?(http_method))
-          raise ArgumentError.new 'Invalid request method provided!'
+        http_method = args.fetch(:method, "get").to_s.downcase.to_sym
+        unless HTTP::Request::METHODS.include?(http_method)
+          raise ArgumentError.new "Invalid request method provided!"
         end
         request_args = [].tap do |ary|
           _endpoint = args.delete(:endpoint) || endpoint
@@ -114,7 +114,7 @@ module Miasma
           end
           ary.push(options) unless options.empty?
         end
-        if(args[:headers])
+        if args[:headers]
           _connection = connection.headers(args[:headers])
           args.delete(:headers)
         else
@@ -122,7 +122,7 @@ module Miasma
         end
         result = retryable_request(http_method) do
           res = make_request(_connection, http_method, request_args)
-          unless([args.fetch(:expects, 200)].flatten.compact.map(&:to_i).include?(res.code))
+          unless [args.fetch(:expects, 200)].flatten.compact.map(&:to_i).include?(res.code)
             raise Error::ApiError::RequestError.new(res.reason, :response => res)
           end
           res
@@ -145,7 +145,7 @@ module Miasma
           :ui => data[:retry_ui],
           :auto_run => false,
           &block
-        ).run!{|e| perform_request_retry(e) }
+        ).run! { |e| perform_request_retry(e) }
       end
 
       # Determine if request type is allowed to be retried
@@ -182,28 +182,27 @@ module Miasma
       # @param result [HTTP::Response]
       # @param extract_body [TrueClass, FalseClass] automatically extract body
       # @return [Smash]
-      def format_response(result, extract_body=true)
-        extracted_headers = Smash[result.headers.map{|k,v| [Utils.snake(k), v]}]
-        if(extract_body)
+      def format_response(result, extract_body = true)
+        extracted_headers = Smash[result.headers.map { |k, v| [Utils.snake(k), v] }]
+        if extract_body
           body_content = result.body.to_s
-          body_content.encode!('UTF-8', 'binary',
-            :invalid => :replace,
-            :undef => :replace,
-            :replace => ''
-          )
-          if(extracted_headers[:content_type].to_s.include?('json'))
+          body_content.encode!("UTF-8", "binary",
+                               :invalid => :replace,
+                               :undef => :replace,
+                               :replace => "")
+          if extracted_headers[:content_type].to_s.include?("json")
             extracted_body = from_json(body_content) || body_content
-          elsif(extracted_headers[:content_type].to_s.include?('xml'))
+          elsif extracted_headers[:content_type].to_s.include?("xml")
             extracted_body = from_xml(body_content) || body_content
           else
             extracted_body = from_json(body_content) ||
-              from_xml(body_content) ||
-              body_content
+                             from_xml(body_content) ||
+                             body_content
           end
         end
-        unless(extracted_body)
+        unless extracted_body
           # @note if body is over 100KB, do not extract
-          if(extracted_headers[:content_length].to_i < 102400)
+          if extracted_headers[:content_length].to_i < 102400
             extracted_body = result.body.to_s
           else
             extracted_body = result.body
@@ -212,7 +211,7 @@ module Miasma
         Smash.new(
           :response => result,
           :headers => extracted_headers,
-          :body => extracted_body
+          :body => extracted_body,
         )
       end
 
@@ -239,8 +238,6 @@ module Miasma
           nil
         end
       end
-
     end
-
   end
 end

data/lib/miasma/types/collection.rb

@@ -1,11 +1,10 @@
-require 'miasma'
+require "miasma"
 
 module Miasma
   module Types
 
     # Base collection
     class Collection
-
       include Utils::Memoization
       include Utils::ApiMethoding
 
@@ -47,7 +46,7 @@ module Miasma
       # @return [Array<Model>]
       # @todo need to add helper to deep sort args, convert to string
       #   and hash to use as memoization key
-      def filter(args={})
+      def filter(args = {})
         key = "filter_#{args.to_smash.checksum}"
         memoize(key) do
           perform_filter(args)
@@ -58,7 +57,7 @@ module Miasma
       #
       # @param args [Hash] creation options
       # @return [Model]
-      def build(args={})
+      def build(args = {})
         instance = self.model.new(self.api)
         args.each do |m_name, m_value|
           m_name = "#{m_name}="
@@ -78,7 +77,7 @@ module Miasma
       # @return [self]
       def from_json(json)
         loaded = MultiJson.load(json)
-        unless(loaded.is_a?(Array))
+        unless loaded.is_a?(Array)
           raise TypeError.new "Expecting type `Array` but received `#{loaded.class}`"
         end
         unmemoize(:collection)
@@ -102,7 +101,7 @@ module Miasma
       # @param ident [String, Symbol] model identifier
       # @return [Model, NilClass]
       def perform_get(ident)
-        if(m_name = api_method_for(:get))
+        if m_name = api_method_for(:get)
           api.send(m_name, ident)
         else
           all.detect do |obj|
@@ -114,7 +113,7 @@ module Miasma
 
       # @return [Array<Model>]
       def perform_population
-        if(m_name = api_method_for(:all))
+        if m_name = api_method_for(:all)
           api.send(m_name)
         else
           raise NotImplementedError
@@ -123,10 +122,10 @@ module Miasma
 
       # @return [Array<Model>]
       def perform_filter(args)
-        if(m_name = api_method_for(:filter))
+        if m_name = api_method_for(:filter)
           api.send(m_name, args)
         else
-          if(args[:prefix])
+          if args[:prefix]
             all.find_all do |item|
               item.name.start_with?(args[:prefix])
             end
@@ -135,7 +134,6 @@ module Miasma
           end
         end
       end
-
     end
   end
 end