metric_fu 4.7.3 → 4.7.4

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZjM3MzJkYjE2Yzc0NzFhMGUzNWM0NDhkOWQ5MGEzNWQzMWMxMTBlOQ==
+    ZGM5Njc5OTJhMzVlNzcwMTEzODAwM2I4MDdlNmQzYWVkMmFiNzI4NA==
   data.tar.gz: !binary |-
-    ZDIzMzBmYjZhOTQyMWM2OTIxMTI3ZjUxNTQzMjNiNWU1MGM2OThkZA==
+    N2NhZjJmMmMyN2RhZGQxYWNjYmE3MzI1OGUzNWNmNjFlNDVkOGE5ZA==
 SHA512:
   metadata.gz: !binary |-
-    MDNkMTYzNjBlMGE4NGM0ZmU5OWQ2YmNkNGQ0YjVlYTE5YmM0ZjE1NGVhZmMx
-    YTQ2YzU5MjdlNTA5MDEwOGFiZDBhZTExNzJjNzU0MDM3OGY3YmNiYTJlMjJl
-    NjkzMTNmY2ZjNTlhOGI2ZDI1YzQ5ZjZiYTVkM2U5NzIwN2I3Yjc=
+    ODhhMmQ5ZDg2MWVlNjY0YjNlM2M4MTU4NjM5YzE3ZWZhYTgwNDQ5YjIyMjU0
+    ZjNlYjk5MTY0NzY3MzFiZTI1MTU2YzA2OGI1YTVjMGFmYTkyYjcxMTMyMTQ0
+    NTQyZmVlMWNlMjA4OGE5OWM2OWE0Yzc3ZjNiZmIwYzgyZmU2OWE=
   data.tar.gz: !binary |-
-    NTg4ZDMwOTQwODJiNjI5NGIzMzY5ODMyNzZlNDUwOTdjZDk5MDFlNmJlOTM1
-    ZDcxNTlhNWY1NDE0OWY5MzVhYjUyMWY4MzEyYjQyMmU4ZGM2ZWM2MWQzYjQ3
-    NmFmMjYwOTZlYzM3ODY3OTllY2M0NDA5NzFhM2VkYTliMzIxNWY=
+    MjkzNzhkMDFmNjMyYzRmODA4NzNmOTE0NGViZTVjZTgzM2QxZGJiYjQ5Yzlk
+    MmMwYjU3ZGZhYmJhNTRmNzgwMjg4MzJhMTg4ZDBiZDMyNWViZDFiMDRlMzAx
+    ODk0MGVmMzA5N2EwODI3MTVlODdjOWM1MDEwNGYwNjg1MjQ2ZmU=

data/.metrics

@@ -4,14 +4,13 @@
 #
 # MetricFu::Configuration.run do |config|
 #
-#   Configure Metrics
+#   # Configure Metrics
 #
-#   To configure individual metrics...
+#   # To configure individual metrics...
 #
 #   config.configure_metric(:rcov) do |rcov|
-#     rcov.enabled = true
-#     coverage_file = File.expand_path("coverage/rcov/rcov.txt", Dir.pwd)
-#     rcov.external = coverage_file
+#     rcov.coverage_file = MetricFu.run_path.join("coverage/rcov/rcov.txt")
+#     rcov.enable
 #     rcov.activate
 #   end
 #
@@ -29,7 +28,7 @@
 #     churn.start_date = '6 months ago'
 #   end
 #
-#   Or, to configure a group of metrics...
+#   # Or, to configure a group of metrics...
 #   config.configure_metrics.each do |metric|
 #     if [:churn, :flay, :flog].include?(metric.name)
 #       metric.enabled = true
@@ -39,31 +38,31 @@
 #   end
 #
 #
-#   Configure Formatters
+#   # Configure Formatters
 #
-#   By default, metric_fu will use the built-in html formatter
-#   to generate HTML reports for each metric with pretty graphs.
+#   # By default, metric_fu will use the built-in html formatter
+#   # to generate HTML reports for each metric with pretty graphs.
 
-#   To configure different formatter(s) or output ...
+#   # To configure different formatter(s) or output ...
 #
 #   config.configure_formatter(:html)
 #   config.configure_formatter(:yaml, "customreport.yml")
 #   config.configure_formatter(MyCustomFormatter)
 #
-#   MetricFu will attempt to require a custom formatter by
-#   fully qualified name based on ruby search path,
-#   but you may find that you need to add a require above.
+#   # MetricFu will attempt to require a custom formatter by
+#   # fully qualified name based on ruby search path,
+#   # but you may find that you need to add a require above.
 #
-#   For instance, to require a formatter in your app's lib directory, add the
-#   following line to the top of this file.
-#   require './lib/my_custom_formatter.rb'
+#   # For instance, to require a formatter in your app's lib directory, add the
+#   # following line to the top of this file.
+#   # require './lib/my_custom_formatter.rb'
 #
 #
-#   Configure Graph Engine
+#   # Configure Graph Engine
 #
-#   By default, metric_fu uses the bluff graph engine.
-#   To configure a different graph engine...
+#   # By default, metric_fu uses the bluff graph engine.
+#   # To configure a different graph engine...
 #
-#   config.configure_graph_engine(:gchart)
+#   # config.configure_graph_engine(:gchart)
 #
 # end

data/.travis.yml

@@ -5,16 +5,16 @@ cache: bundler
 gemfile:
   - gemfiles/Gemfile.travis
 before_install:
-  - gem install bundler -v '= 1.5.1'
+  - gem install bundler
 # env:
 #   - "rack=1.3.4"
 rvm:
   - 2.1.0
   - 2.0.0
   - 1.9.3
-  # - 1.9.2 # code_metric 0.1.0 requires ruby 1.9.3 or greater
-  - jruby-19mode # JRuby in 1.9 mode
-  - rbx
+  - 1.9.2
+  - jruby
+  - rbx-2
 matrix:
   allow_failures:
-    - rvm: rbx
+    - rvm: rbx-2

data/CONTRIBUTORS

@@ -34,34 +34,36 @@ Extrovert
 KAKUTANI Shintaro
 Andrew Timberlake
 Guilherme Souza
+Przemysław Dąbek
 carlost
 David Barri
 Beau Fabry
 Chris Mason
 Andrew Selder
-Mark Wilden
 iain
+Mark Wilden
 Lars E. Hoeg
 Eric Wollesen
 Adam Bair
 Jinzhu
-Diego Carrion
-Martin Gotink
 Matthew Van Horn
-saltracer
+Martin Gotink
+Diego Carrion
 benlovell
-khall
+saltracer
 ff-cviradiya
-Todd A. Jacobs
+khall
 Stefan Huber
+Todd A. Jacobs
+jayzes
+Scyllinice
 Hans Hasselberg
 Bitdeli Chef
-Scyllinice
-jayzes
 Matthew Gordon
-Joel Nimety
+Chris Ian Fiel
 factorylabs
+Paul Elliott
 Greg Allen
+Joel Nimety
 Mike Ball
-Chris Ian Fiel
-Paul Elliott
+Guilherme Simões

data/DEV.md

@@ -0,0 +1,56 @@
+## Contracted Interfaces
+
+```ruby
+MetricFu.run_dir #=> Dir.pwd
+MetricFu.run_dir = some_path
+MetricFu.run_path #=> Pathname(Dir.pwd)
+MetricFu.root_dir
+MetricFu.load_user_configuration
+MetricFu.loader.loaded_files
+MetricFu.lib_require(base = '',&block)
+MetricFu.lib_dir #=> metric_fu/lib
+MetricFu.metrics_require(&block)
+MetricFu.metrics_dir #=> metric_fu/lib/metrics
+MetricFu.formatter_require(&block)
+MetricFu.formatter_dir #=> metric_fu/lib/formatter
+MetricFu.reporting_require(&block)
+MetricFu.reporting_dir #=> metric_fu/lib/reporting
+MetricFu.logging_require(&block)
+MetricFu.logging_dir   #=> metric_fu/lib/logging
+MetricFu.errors_require(&block)
+MetricFu.errors_dir    #=> metric_fu/lib/errors
+MetricFu.data_structures_require(&block)
+MetricFu.data_structures_dir #=> metric_fu/lib/data_structures
+MetricFu.tasks_require(&block)
+MetricFu.tasks_dir           #=> metric_fu/lib/tasks
+
+MetricFu.configuration #=> MetricFu::Configuration.new
+MetricFu.configuration.configure_metrics # for each metric, yield to block or runs enable, activate 
+metric = MetricFu.configuration.configure_metric(:flog)
+metric.run_options #=> metric.default_run_options.merge(metric.configured_run_options)
+metric.enable
+metric.enabled = true
+metric.activate
+metric.activated = true
+metric.name #=> :flog
+```
+
+## Testing
+
+`bundle exec rspec`
+
+## Forking
+
+## Issues / Pull Requests
+
+* see [CONTRIBUTING](CONTRIBUTING.md)
+
+## Building
+
+`rake build` or `rake install`
+
+## Releasing
+
+1. Update lib/metric_fu/version.rb
+2. Update HISTORY.md
+3. `rake release`

data/HISTORY.md

@@ -4,13 +4,21 @@ Each change should fall into categories that would affect whether the release is
 
 As such, a _Feature_ would map to either major or minor. A _bug fix_ to a patch.  And _misc_ is either minor or patch, the difference being kind of fuzzy for the purposes of history.  Adding tests would be patch level.
 
-### Master [changes](https://github.com/metricfu/metric_fu/compare/v4.7.3...master)
+### Master [changes](https://github.com/metricfu/metric_fu/compare/v4.7.4...master)
 
 * Breaking Changes
 * Features
 * Fixes
 * Misc
 
+### [4.7.4 / 2014-02-16](https://github.com/metricfu/metric_fu/compare/v4.7.3...v4.7.4)
+
+* Fixes
+  * Reek no longer crashes when reporting no warnings (Michael Stark, #199)
+  * Prevent Roodi non-metric output from ending up in the results (Martin Gotink #202)
+  * Coverage file is only read in when the specified external file exists. (Benjamin Fleischer, #156)
+  * Metrics are configured to default values before the user config is loaded (Benjamin Fleischer, #156, #78)
+
 ### [4.7.3 / 2014-02-09](https://github.com/metricfu/metric_fu/compare/v4.7.2...v4.7.3)
 
 * Fixes

data/README.md

@@ -122,8 +122,8 @@ in your .metrics file add the below to run pre-generated metrics
 ```ruby
 MetricFu::Configuration.run do |config|
   config.configure_metric(:rcov) do |rcov|
-    rcov.enabled = true
-    rcov.external = File.expand_path("coverage/rcov/rcov.txt", Dir.pwd)
+    rcov.coverage_file = MetricFu.run_path.join("coverage/rcov/rcov.txt")
+    rcov.enable
     rcov.activate
   end
 end
@@ -164,13 +164,16 @@ SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
 SimpleCov.start
 ```
 
+Additionally, the `coverage_file` path must be specified as above
+and must exist.
+
 ## Compatibility
 
 * It is currently testing on MRI (>= 1.9.3), JRuby (19 mode), and Rubinius (19 mode). Ruby 1.8 is no longer supported.
 
 * For 1.8.7 support, see version 3.0.0 for partial support, or 2.1.3.7.18.1 (where [Semantic Versioning](http://semver.org/) goes to die)
 
-* MetricFu  no longer runs any of the analyzed code. For code coverage, You may still use rcov metrics as documented below
+* MetricFu  no longer runs any of the analyzed code. For code coverage, You may still use rcov metrics as documented above
 
 * The Cane, Flog, and Rails Best Practices metrics are disabled when Ripper is not available
 

data/checksum/metric_fu-4.7.3.gem.sha512

@@ -0,0 +1 @@
+9a3c76074181ca4ec770f1a52f652268e44af10648cf82cb641672d2075d92133751ad275ad1ba417c473ba8095d872df762eb379e2e48fd38ce1db06b4ea1e7

data/gemfiles/Gemfile.travis

@@ -3,14 +3,8 @@ source 'https://rubygems.org'
 #to use, from the app root run
 # export BUNDLE_GEMFILE=$PWD/gemfiles/Gemfile.travis
 # when done, unset BUNDLE_GEMFILE
-# for 1.9.2 support because of https://github.com/railsbp/rails_best_practices/blob/master/rails_best_practices.gemspec
-
-platforms :rbx do
-  gem 'racc'
-  gem 'rubysl', '~> 2.0'
-  gem 'psych'
-end
 
+# for 1.9.2 support because of https://github.com/railsbp/rails_best_practices/blob/master/rails_best_practices.gemspec
 gem 'activesupport', '~> 3.2'
 
 eval_gemfile File.expand_path('../../Gemfile', __FILE__)

data/lib/metric_fu/configuration.rb

@@ -96,16 +96,20 @@ module MetricFu
       yield MetricFu.configuration
     end
 
-    def configure_metric(name)
+    def self.configure_metric(name)
       yield MetricFu::Metric.get_metric(name)
     end
 
+    def configure_metric(name, &block)
+      self.class.configure_metric(name, &block)
+    end
+
     def configure_metrics
       MetricFu::Io::FileSystem.set_directories
       MetricFu::Metric.metrics.each do |metric|
         if block_given?
           yield metric
-        elsif !metric_manually_configured?(metric)
+        else
           metric.enabled = false
           metric.enable
         end
@@ -113,14 +117,6 @@ module MetricFu
       end
     end
 
-    # TODO: Remove this method.  If we run configure_metrics
-    #   and it disabled rcov, we shouldn't have to worry here
-    #   that rcov is a special case that can only be enabled
-    #   manually
-    def metric_manually_configured?(metric)
-      [:rcov].include?(metric.name)
-    end
-
     # TODO: Reconsider method name/behavior, as it really adds a formatter
     def configure_formatter(format, output = nil)
       @formatters << MetricFu::Formatter.class_for(format).new(output: output)

data/lib/metric_fu/loader.rb

@@ -81,6 +81,7 @@ module MetricFu
 
       Dir.glob(File.join(MetricFu.metrics_dir, '**/init.rb')).each{|init_file|require(init_file)}
 
+      MetricFu.configuration.configure_metrics
       load_user_configuration
 
       MetricFu.lib_require       { 'reporter' }

data/lib/metric_fu/metrics/rcov/init.rb

@@ -6,11 +6,16 @@ module MetricFu
     end
 
     def default_run_options
-      { :environment => 'test',
-                    :test_files =>  Dir['{spec,test}/**/*_{spec,test}.rb'],
-                    :rcov_opts => rcov_opts,
-                    :external => nil
-                  }
+      {
+        :environment => 'test',
+        :test_files =>  Dir['{spec,test}/**/*_{spec,test}.rb'],
+        :rcov_opts => rcov_opts,
+        :external  => nil,
+      }
+    end
+
+    def coverage_file=(coverage_file)
+      configured_run_options.update(:external => coverage_file)
     end
 
     def has_graph?
@@ -18,13 +23,26 @@ module MetricFu
     end
 
     def enable
-      MetricFu.configuration.mf_debug("rcov is not available. See README")
+      if external_coverage_file?
+        super
+      else
+        mf_debug("RCov is not available. See README")
+      end
     end
 
     def activate
       super
     end
 
+    def external_coverage_file?
+      if coverage_file = run_options[:external]
+        File.exist?(coverage_file) ||
+          mf_log("Configured RCov file #{coverage_file.inspect} does not exist")
+      else
+        false
+      end
+    end
+
     private
 
     def rcov_opts

data/lib/metric_fu/metrics/rcov/rcov.rb

@@ -1,5 +1,6 @@
 MetricFu.lib_require { 'utility' }
 MetricFu.lib_require { 'calculate' }
+MetricFu.data_structures_require { 'line_numbers' }
 
 module MetricFu
 
@@ -45,6 +46,7 @@ module MetricFu
     end
 
     def default_command
+      require 'rake'
       reset_output_location
       test_files = FileList[*options[:test_files]].join(' ')
       rcov_opts = options[:rcov_opts].join(' ')
@@ -144,8 +146,9 @@ module MetricFu
       end
     end
 
+    # We never run rcov anymore
     def run_rcov?
-      !(options[:external])
+      false
     end
 
     def load_output
@@ -153,17 +156,13 @@ module MetricFu
     end
 
     def output_file
-      if run_rcov?
-        default_output_file
-      else
-        options.fetch(:external)
-      end
+      options.fetch(:external)
     end
 
+    # Only used if run_rcov? is true
     def default_output_file
-      File.join(metric_directory, 'rcov.txt')
+      output_file || File.join(metric_directory, 'rcov.txt')
     end
 
-
   end
 end

data/lib/metric_fu/metrics/reek/reek.rb

@@ -23,6 +23,7 @@ module MetricFu
     def analyze
       @matches = @output.chomp.split("\n\n").map{|m| m.split("\n") }
       @matches = @matches.map do |match|
+        break {} if zero_warnings?(match)
         file_path = match.shift.split(' -- ').first
         file_path = file_path.gsub('"', ' ').strip
         code_smells = match.map do |smell|
@@ -115,5 +116,8 @@ module MetricFu
       '-n'
     end
 
+    def zero_warnings?(match)
+      match.last == "0 total warnings"
+    end
   end
 end

data/lib/metric_fu/metrics/roodi/roodi.rb

@@ -17,7 +17,7 @@ module MetricFu
       @output = MetricFu::Utility.strip_escape_codes(@output)
       @matches = @output.chomp.split("\n").map{|m| m.split(" - ") }
       total = @matches.pop
-      @matches.reject! {|array| array.empty? }
+      @matches.reject! {|array| array.size < 2 }
       @matches.map! do |match|
         file, line = match[0].split(':')
         problem = match[1]

data/lib/metric_fu/run.rb

@@ -1,4 +1,3 @@
-MetricFu.configure
 module MetricFu
   class Run
     def initialize
@@ -45,12 +44,10 @@ module MetricFu
       end
     end
     def configure_metric(metric, metric_options)
-      MetricFu::Configuration.run do |config|
-        config.configure_metric(metric) do |metric|
-          metric_options.each do |option, value|
-            mf_log "Setting #{metric} option #{option} to #{value}"
-            metric.public_send("#{option}=", value)
-          end
+      MetricFu::Configuration.configure_metric(metric) do |metric|
+        metric_options.each do |option, value|
+          mf_log "Setting #{metric} option #{option} to #{value}"
+          metric.public_send("#{option}=", value)
         end
       end
     end

data/lib/metric_fu/version.rb

@@ -1,3 +1,3 @@
 module MetricFu
-  VERSION = '4.7.3'
+  VERSION = '4.7.4'
 end

data/spec/metric_fu/configuration_spec.rb

@@ -212,6 +212,7 @@ describe MetricFu::Configuration do
         load_metric 'rcov'
         expect(MetricFu::Metric.get_metric(:rcov).run_options).to eq(
                 { :environment => 'test',
+                            :external => nil,
                             :test_files =>  Dir['{spec,test}/**/*_{spec,test}.rb'],
                             :rcov_opts => [
                               "--sort coverage",
@@ -223,7 +224,7 @@ describe MetricFu::Configuration do
                               '--include-file "\Aapp,\Alib"',
                               "-Ispec"
                             ],
-                            :external => nil}
+                            }
         )
       end
 

data/spec/metric_fu/metrics/rcov/rcov_grapher_spec.rb

@@ -1,4 +1,5 @@
 require "spec_helper"
+MetricFu.metrics_require { 'rcov/rcov_grapher' }
 
 describe RcovGrapher do
   before :each do

data/spec/metric_fu/metrics/reek/reek_spec.rb

@@ -15,8 +15,16 @@ describe MetricFu::ReekGenerator do
 
   #TODO review tested output
   describe "analyze method" do
+
     before :each do
-      @lines = <<-HERE
+      MetricFu::Configuration.run {}
+      allow(File).to receive(:directory?).and_return(true)
+      @reek = MetricFu::ReekGenerator.new
+    end
+
+    context "with reek warnings" do
+      before :each do
+        @lines = <<-HERE
 "app/controllers/activity_reports_controller.rb" -- 4 warnings:
 ActivityReportsController#authorize_user calls current_user.primary_site_ids multiple times (Duplication)
 ActivityReportsController#authorize_user calls params[id] multiple times (Duplication)
@@ -32,43 +40,55 @@ LinkTargetsController#authorize_user calls current_user.role multiple times (Dup
 "app/controllers/newline_controller.rb" -- 1 warnings:
 NewlineController#some_method calls current_user.<< "new line\n" multiple times (Duplication)
       HERE
-      MetricFu::Configuration.run {}
-      allow(File).to receive(:directory?).and_return(true)
-      reek = MetricFu::ReekGenerator.new
-      reek.instance_variable_set(:@output, @lines)
-      @matches = reek.analyze
+        @reek.instance_variable_set(:@output, @lines)
+        @matches = @reek.analyze
+      end
+
+      it "should find the code smell's method name" do
+        smell = @matches.first[:code_smells].first
+        expect(smell[:method]).to eq("ActivityReportsController#authorize_user")
+      end
+
+      it "should find the code smell's type" do
+        smell = @matches[1][:code_smells].first
+        expect(smell[:type]).to eq("Nested Iterators")
+      end
+
+      it "should find the code smell's message" do
+        smell = @matches[1][:code_smells].first
+        expect(smell[:message]).to eq("is nested")
+      end
+
+      it "should find the code smell's type" do
+        smell = @matches.first
+        expect(smell[:file_path]).to eq("app/controllers/activity_reports_controller.rb")
+      end
+
+      it "should NOT insert nil smells into the array when there's a newline in the method call" do
+        expect(@matches.last[:code_smells]).to eq(@matches.last[:code_smells].compact)
+        expect(@matches.last).to eq({:file_path=>"app/controllers/newline_controller.rb",
+                                  :code_smells=>[{:type=>"Duplication",
+                                                    :method=>"\"",
+                                                    :message=>"multiple times"}]})
+        # Note: hopefully a temporary solution until I figure out how to deal with newlines in the method call more effectively -Jake 5/11/2009
+      end
     end
 
-    it "should find the code smell's method name" do
-      smell = @matches.first[:code_smells].first
-      expect(smell[:method]).to eq("ActivityReportsController#authorize_user")
-    end
+    context "without reek warnings" do
+      before :each do
+        @lines = <<-HERE
 
-    it "should find the code smell's type" do
-      smell = @matches[1][:code_smells].first
-      expect(smell[:type]).to eq("Nested Iterators")
-    end
-
-    it "should find the code smell's message" do
-      smell = @matches[1][:code_smells].first
-      expect(smell[:message]).to eq("is nested")
-    end
-
-    it "should find the code smell's type" do
-      smell = @matches.first
-      expect(smell[:file_path]).to eq("app/controllers/activity_reports_controller.rb")
-    end
+0 total warnings
+      HERE
+        @reek.instance_variable_set(:@output, @lines)
+        @matches = @reek.analyze
+      end
 
-    it "should NOT insert nil smells into the array when there's a newline in the method call" do
-      expect(@matches.last[:code_smells]).to eq(@matches.last[:code_smells].compact)
-      expect(@matches.last).to eq({:file_path=>"app/controllers/newline_controller.rb",
-                                :code_smells=>[{:type=>"Duplication",
-                                                  :method=>"\"",
-                                                  :message=>"multiple times"}]})
-      # Note: hopefully a temporary solution until I figure out how to deal with newlines in the method call more effectively -Jake 5/11/2009
+      it "returns empty analysis" do
+        expect(@matches).to eq({})
+      end
     end
   end
-
 end
 
 describe MetricFu::ReekGenerator do

data/spec/metric_fu/metrics/roodi/roodi_spec.rb

@@ -18,4 +18,65 @@ describe MetricFu::RoodiGenerator do
       roodi.emit
     end
   end
+
+  describe "analyze" do
+    context "when it has multiple failures" do
+      before :each do
+        lines = <<-HERE
+
+Running Roodi checks
+./app/models/some_model.rb:14 - Found = in conditional.  It should probably be an ==
+lib/some_file.rb:53 - Rescue block should not be empty.
+
+Checked 65 files
+        HERE
+
+        roodi = MetricFu::RoodiGenerator.new
+        roodi.instance_variable_set(:@output, lines)
+        @matches = roodi.analyze
+      end
+
+      it "should find all problems" do
+        problem_count = @matches[:problems].size
+        expect(problem_count).to eq(2)
+      end
+
+      it "should find the file of the problem" do
+        problem = @matches[:problems].first
+        expect(problem[:file]).to eq("./app/models/some_model.rb")
+      end
+
+      it "should find the line of the problem" do
+        problem = @matches[:problems].first
+        expect(problem[:line]).to eq("14")
+      end
+
+      it "should find the description of the problem" do
+        problem = @matches[:problems].first
+        expect(problem[:problem]).to eq("Found = in conditional.  It should probably be an ==")
+      end
+    end
+  end
+
+  context "when it has no failures" do
+    before :each do
+      lines = <<-HERE
+
+Running Roodi checks
+
+Checked 42 files
+Found 0 errors.
+
+      HERE
+
+      roodi = MetricFu::RoodiGenerator.new
+      roodi.instance_variable_set(:@output, lines)
+      @matches = roodi.analyze
+    end
+
+    it "should have no problems" do
+      problem_count = @matches[:problems].size
+      expect(problem_count).to eq(0)
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: metric_fu
 version: !ruby/object:Gem::Version
-  version: 4.7.3
+  version: 4.7.4
 platform: ruby
 authors:
 - Jake Scruggs
@@ -49,7 +49,7 @@ cert_chain:
   dWphdUtxcjhoS0RMdTRLK3F1Q0dqWC82TEw2CldPTno5dlQ2aDA1M2tIWllN
   cmQ0R3MvTmRhQTR0SlN4cmhabFhkYWpBbS8wdkFPekxJcVVISFFrM1IwdGY3
   YVkKZC93PQotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg==
-date: 2014-02-09 00:00:00.000000000 Z
+date: 2014-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flay
@@ -309,6 +309,7 @@ files:
 - AUTHORS
 - CONTRIBUTING.md
 - CONTRIBUTORS
+- DEV.md
 - Gemfile
 - Gemfile.devtools
 - Guardfile
@@ -342,6 +343,7 @@ files:
 - checksum/metric_fu-4.7.0.gem.sha512
 - checksum/metric_fu-4.7.1.gem.sha512
 - checksum/metric_fu-4.7.2.gem.sha512
+- checksum/metric_fu-4.7.3.gem.sha512
 - config/roodi_config.yml
 - gem_tasks/build.rake
 - gemfiles/Gemfile.travis