metric_fu 4.6.0 → 4.7.0

data/spec/metric_fu/metrics/cane/cane_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+MetricFu.metrics_require { 'cane/cane' }
 
 describe CaneGenerator do
   describe "emit method" do
@@ -6,49 +7,49 @@ describe CaneGenerator do
     it "should execute cane command" do
       options = {}
       @cane = MetricFu::CaneGenerator.new(options)
-      @cane.should_receive(:run!).with("")
+      expect(@cane).to receive(:run!).with("")
       output = @cane.emit
     end
 
     it "should use abc max option" do
       options = {abc_max: 20}
       @cane = MetricFu::CaneGenerator.new(options)
-      @cane.should_receive(:run!).with(" --abc-max 20")
+      expect(@cane).to receive(:run!).with(" --abc-max 20")
       output = @cane.emit
     end
 
     it "should use style max line length option" do
       options = {line_length: 100}
       @cane = MetricFu::CaneGenerator.new(options)
-      @cane.should_receive(:run!).with(" --style-measure 100")
+      expect(@cane).to receive(:run!).with(" --style-measure 100")
       output = @cane.emit
     end
 
     it "should use no-doc if specified" do
       options = {no_doc: 'y'}
       @cane = MetricFu::CaneGenerator.new(options)
-      @cane.should_receive(:run!).with(" --no-doc")
+      expect(@cane).to receive(:run!).with(" --no-doc")
       output = @cane.emit
     end
 
     it "should include doc violations if no_doc != 'y'" do
       options = {no_doc: 'n'}
       @cane = MetricFu::CaneGenerator.new(options)
-      @cane.should_receive(:run!).with("")
+      expect(@cane).to receive(:run!).with("")
       output = @cane.emit
     end
 
     it "should use no-readme if specified" do
       options = {no_readme: 'y'}
       @cane = MetricFu::CaneGenerator.new(options)
-      @cane.should_receive(:run!).with(" --no-readme")
+      expect(@cane).to receive(:run!).with(" --no-readme")
       output = @cane.emit
     end
 
     it "should include README violations if no_readme != 'y'" do
       options = {no_readme: 'n'}
       @cane = MetricFu::CaneGenerator.new(options)
-      @cane.should_receive(:run!).with("")
+      expect(@cane).to receive(:run!).with("")
       output = @cane.emit
     end
   end
@@ -56,7 +57,7 @@ describe CaneGenerator do
   describe "parse cane empty output" do
     before :each do
       # MetricFu::Configuration.run {}
-      File.stub(:directory?).and_return(true)
+      allow(File).to receive(:directory?).and_return(true)
       options = {}
       @cane = MetricFu::CaneGenerator.new(options)
       @cane.instance_variable_set(:@output, '')
@@ -66,7 +67,7 @@ describe CaneGenerator do
 
       it "should find total violations" do
         @cane.analyze
-        @cane.total_violations.should == 0
+        expect(@cane.total_violations).to eq(0)
       end
     end
   end
@@ -75,7 +76,7 @@ describe CaneGenerator do
     before :each do
       lines = sample_cane_output
       MetricFu::Configuration.run {}
-      File.stub(:directory?).and_return(true)
+      allow(File).to receive(:directory?).and_return(true)
       @cane = MetricFu::CaneGenerator.new('base_dir')
       @cane.instance_variable_set(:@output, lines)
     end
@@ -84,69 +85,69 @@ describe CaneGenerator do
 
       it "should find total violations" do
         @cane.analyze
-        @cane.total_violations.should == 6
+        expect(@cane.total_violations).to eq(6)
       end
 
       it "should extract abc complexity violations" do
         @cane.analyze
-        @cane.violations[:abc_complexity].should == [
+        expect(@cane.violations[:abc_complexity]).to eq([
           {file: 'lib/abc/foo.rb', method: 'Abc::Foo#method', complexity: '11'},
           {file: 'lib/abc/bar.rb', method: 'Abc::Bar#method', complexity: '22'}
-        ]
+        ])
       end
 
       it "should extract line style violations" do
         @cane.analyze
-        @cane.violations[:line_style].should == [
+        expect(@cane.violations[:line_style]).to eq([
           {line: 'lib/line/foo.rb:1', description: 'Line is >80 characters (135)'},
           {line: 'lib/line/bar.rb:2', description: 'Line contains trailing whitespace'}
-        ]
+        ])
       end
 
       it "should extract comment violations" do
         @cane.analyze
-        @cane.violations[:comment].should == [
+        expect(@cane.violations[:comment]).to eq([
           {line: 'lib/comments/foo.rb:1', class_name: 'Foo'},
           {line: 'lib/comments/bar.rb:2', class_name: 'Bar'}
-        ]
+        ])
       end
 
       it "should extract no readme violations if present" do
         @cane.analyze
-        @cane.violations[:documentation].should == [
+        expect(@cane.violations[:documentation]).to eq([
           {description: 'No README found'},
-        ]
+        ])
       end
 
       it "should extract unknown violations in others category" do
         @cane.analyze
-        @cane.violations[:others].should == [
+        expect(@cane.violations[:others]).to eq([
           {description: 'Misc issue 1'},
           {description: 'Misc issue 2'}
-        ]
+        ])
       end
     end
 
     describe "to_h method" do
       it "should have total violations" do
         @cane.analyze
-        @cane.to_h[:cane][:total_violations].should == 6
+        expect(@cane.to_h[:cane][:total_violations]).to eq(6)
       end
 
       it  "should have violations by category" do
         @cane.analyze
-        @cane.to_h[:cane][:violations][:abc_complexity].should == [
+        expect(@cane.to_h[:cane][:violations][:abc_complexity]).to eq([
           {file: 'lib/abc/foo.rb', method: 'Abc::Foo#method', complexity: '11'},
           {file: 'lib/abc/bar.rb', method: 'Abc::Bar#method', complexity: '22'}
-        ]
-        @cane.to_h[:cane][:violations][:line_style].should == [
+        ])
+        expect(@cane.to_h[:cane][:violations][:line_style]).to eq([
           {line: 'lib/line/foo.rb:1', description: 'Line is >80 characters (135)'},
           {line: 'lib/line/bar.rb:2', description: 'Line contains trailing whitespace'}
-        ]
-        @cane.to_h[:cane][:violations][:comment].should == [
+        ])
+        expect(@cane.to_h[:cane][:violations][:comment]).to eq([
           {line: 'lib/comments/foo.rb:1', class_name: 'Foo'},
           {line: 'lib/comments/bar.rb:2', class_name: 'Bar'}
-        ]
+        ])
       end
     end
   end

data/spec/metric_fu/metrics/churn/churn_spec.rb

@@ -1,57 +1,34 @@
 require "spec_helper"
+MetricFu.metrics_require { 'churn/churn' }
 
 describe MetricFu::ChurnGenerator do
 
   # TODO extract yaml
-  let(:churn_yaml) { "--- \n:churn: \n  :changed_files: \n  - spec/graphs/flog_grapher_spec.rb\n  - spec/base/graph_spec.rb\n  - lib/templates/awesome/layout.html.erb\n  - lib/graphs/rcov_grapher.rb\n  - lib/base/base_template.rb\n  - spec/graphs/grapher_spec.rb\n  - lib/templates/awesome/flog.html.erb\n  - lib/templates/awesome/flay.html.erb\n  - lib/graphs/roodi_grapher.rb\n  - lib/graphs/reek_grapher.rb\n  - HISTORY\n  - spec/graphs/roodi_grapher_spec.rb\n  - lib/generators/rcov.rb\n  - spec/graphs/engines/gchart_spec.rb\n  - spec/graphs/rcov_grapher_spec.rb\n  - lib/templates/javascripts/excanvas.js\n  - lib/templates/javascripts/bluff-min.js\n  - spec/graphs/reek_grapher_spec.rb\n" }
+  let(:churn_hash) { YAML::load("--- \n:churn: \n  :changed_files: \n  - spec/graphs/flog_grapher_spec.rb\n  - spec/base/graph_spec.rb\n  - lib/templates/awesome/layout.html.erb\n  - lib/graphs/rcov_grapher.rb\n  - lib/base/base_template.rb\n  - spec/graphs/grapher_spec.rb\n  - lib/templates/awesome/flog.html.erb\n  - lib/templates/awesome/flay.html.erb\n  - lib/graphs/roodi_grapher.rb\n  - lib/graphs/reek_grapher.rb\n  - HISTORY\n  - spec/graphs/roodi_grapher_spec.rb\n  - lib/generators/rcov.rb\n  - spec/graphs/engines/gchart_spec.rb\n  - spec/graphs/rcov_grapher_spec.rb\n  - lib/templates/javascripts/excanvas.js\n  - lib/templates/javascripts/bluff-min.js\n  - spec/graphs/reek_grapher_spec.rb\n") }
 
   let(:config_setup) {
     ENV['CC_BUILD_ARTIFACTS'] = nil
     MetricFu.configure.reset
   }
 
-  describe "new method" do
-    before :each do
-      config_setup
-    end
-
-    it "initializes with yaml option" do
-      churn = MetricFu::ChurnGenerator.new
-      churn.send(:build_churn_options).should == "--yaml"
-    end
-
-    it "initializes with given minimum_churn_count option" do
-      churn = MetricFu::ChurnGenerator.new( { :minimum_churn_count => 5 })
-      churn.send(:build_churn_options).should == "--yaml --minimum_churn_count=5"
-    end
-  end
-
-
   describe "analyze method" do
     before :each do
       config_setup
       @changes = {"lib/generators/flog.rb" => 2, "lib/metric_fu.rb" => 3}
     end
 
-    it "should be empty on error text" do
-      churn = MetricFu::ChurnGenerator.new
-      churn.instance_variable_set(:@output, "Churning requires a subversion or git repo")
-      result = churn.analyze
-      result.should == {:churn => {}}
-    end
-
     it "should be empty on error no output captured" do
       churn = MetricFu::ChurnGenerator.new
       churn.instance_variable_set(:@output, nil)
       result = churn.analyze
-      result.should == {:churn => {}}
+      expect(result).to eq({:churn => {}})
     end
 
     it "should return yaml results" do
       churn = MetricFu::ChurnGenerator.new
-      churn.instance_variable_set(:@output, churn_yaml)
+      churn.instance_variable_set(:@output, churn_hash)
       result = churn.analyze
-      result.should == {:churn => {:changed_files => ["spec/graphs/flog_grapher_spec.rb", "spec/base/graph_spec.rb", "lib/templates/awesome/layout.html.erb", "lib/graphs/rcov_grapher.rb", "lib/base/base_template.rb", "spec/graphs/grapher_spec.rb", "lib/templates/awesome/flog.html.erb", "lib/templates/awesome/flay.html.erb", "lib/graphs/roodi_grapher.rb", "lib/graphs/reek_grapher.rb", "HISTORY", "spec/graphs/roodi_grapher_spec.rb", "lib/generators/rcov.rb", "spec/graphs/engines/gchart_spec.rb", "spec/graphs/rcov_grapher_spec.rb", "lib/templates/javascripts/excanvas.js", "lib/templates/javascripts/bluff-min.js", "spec/graphs/reek_grapher_spec.rb"]}}
+      expect(result).to eq({:churn => {:changed_files => ["spec/graphs/flog_grapher_spec.rb", "spec/base/graph_spec.rb", "lib/templates/awesome/layout.html.erb", "lib/graphs/rcov_grapher.rb", "lib/base/base_template.rb", "spec/graphs/grapher_spec.rb", "lib/templates/awesome/flog.html.erb", "lib/templates/awesome/flay.html.erb", "lib/graphs/roodi_grapher.rb", "lib/graphs/reek_grapher.rb", "HISTORY", "spec/graphs/roodi_grapher_spec.rb", "lib/generators/rcov.rb", "spec/graphs/engines/gchart_spec.rb", "spec/graphs/rcov_grapher_spec.rb", "lib/templates/javascripts/excanvas.js", "lib/templates/javascripts/bluff-min.js", "spec/graphs/reek_grapher_spec.rb"]}})
     end
 
   end
@@ -65,7 +42,7 @@ describe MetricFu::ChurnGenerator do
     it "should put the changes into a hash" do
       churn = MetricFu::ChurnGenerator.new
       churn.instance_variable_set(:@churn, {:churn => 'results'})
-      churn.to_h[:churn].should == "results"
+      expect(churn.to_h[:churn]).to eq("results")
     end
   end
 
@@ -77,15 +54,15 @@ describe MetricFu::ChurnGenerator do
     end
 
     it "returns churn output" do
-      @churn.stub(:churn_code).and_return("  master\n#{churn_yaml}")
+      allow(@churn).to receive(:run).and_return(churn_hash)
       result = @churn.emit
-      result.should == churn_yaml
+      expect(result).to eq(churn_hash)
     end
 
     it "returns nil, when churn result is not yaml" do
-      @churn.stub(:churn_code).and_return("  master\n")
+      allow(@churn).to receive(:run).and_return(nil)
       result = @churn.emit
-      result.should be nil
+      expect(result).to be nil
     end
   end
 end

data/spec/metric_fu/metrics/flay/flay_grapher_spec.rb

@@ -1,4 +1,5 @@
 require "spec_helper"
+MetricFu.metrics_require { 'flay/flay_grapher' }
 
 describe FlayGrapher do
   before :each do
@@ -7,14 +8,14 @@ describe FlayGrapher do
   end
 
   it "should respond to flay_score and labels" do
-    @flay_grapher.should respond_to(:flay_score)
-    @flay_grapher.should respond_to(:labels)
+    expect(@flay_grapher).to respond_to(:flay_score)
+    expect(@flay_grapher).to respond_to(:labels)
   end
 
   describe "responding to #initialize" do
     it "should initialise flay_score and labels" do
-      @flay_grapher.flay_score.should == []
-      @flay_grapher.labels.should == {}
+      expect(@flay_grapher.flay_score).to eq([])
+      expect(@flay_grapher.labels).to eq({})
     end
   end
 
@@ -26,12 +27,12 @@ describe FlayGrapher do
       end
 
       it "should not push to flay_score" do
-        @flay_grapher.flay_score.should_not_receive(:push)
+        expect(@flay_grapher.flay_score).not_to receive(:push)
         @flay_grapher.get_metrics(@metrics, @date)
       end
 
       it "should not update labels with the date" do
-        @flay_grapher.labels.should_not_receive(:update)
+        expect(@flay_grapher.labels).not_to receive(:update)
         @flay_grapher.get_metrics(@metrics, @date)
       end
     end
@@ -43,12 +44,12 @@ describe FlayGrapher do
       end
 
       it "should push to flay_score" do
-        @flay_grapher.flay_score.should_receive(:push).with(476)
+        expect(@flay_grapher.flay_score).to receive(:push).with(476)
         @flay_grapher.get_metrics(@metrics, @date)
       end
 
       it "should update labels with the date" do
-        @flay_grapher.labels.should_receive(:update).with({ 0 => "1/2" })
+        expect(@flay_grapher.labels).to receive(:update).with({ 0 => "1/2" })
         @flay_grapher.get_metrics(@metrics, @date)
       end
     end

data/spec/metric_fu/metrics/flay/flay_spec.rb

@@ -1,22 +1,23 @@
 require "spec_helper"
+MetricFu.metrics_require { 'flay/flay' }
 
 describe MetricFu::FlayGenerator do
   describe "emit method" do
     it "should look at the dirs" do
       options = { :dirs_to_flay => ['app', 'lib'], :filetypes => ['rb']  }
-      File.stub(:directory?).and_return(true)
+      allow(File).to receive(:directory?).and_return(true)
       @flay = MetricFu::FlayGenerator.new(options)
 
-      @flay.should_receive(:run!).with(" app lib")
+      expect(@flay).to receive(:run!).with(" app lib")
       output = @flay.emit
     end
 
     it "should limit flay scores by the minimum_score" do
       options = { :dirs_to_flay => [], :minimum_score => 99 }
-      File.stub(:directory?).and_return(true)
+      allow(File).to receive(:directory?).and_return(true)
       @flay = MetricFu::FlayGenerator.new(options)
 
-      @flay.should_receive(:run!).with("--mass 99  ")
+      expect(@flay).to receive(:run!).with("--mass 99  ")
       output = @flay.emit
     end
   end
@@ -38,13 +39,13 @@ Total score (lower is better) = 246
   app/controllers/primary_sites_controller.rb:89
       HERE
       MetricFu::Configuration.run {}
-      File.stub(:directory?).and_return(true)
+      allow(File).to receive(:directory?).and_return(true)
       @flay = MetricFu::FlayGenerator.new('base_dir')
       @flay.instance_variable_set(:@output, lines)
     end
 
     it "should analyze and return matches" do
-      @flay.analyze.should == [ ["Total score (lower is better) = 246"],
+      expect(@flay.analyze).to eq([ ["Total score (lower is better) = 246"],
                                 ["\n1) IDENTICAL code found in :or (mass*2 = 68)",
                                   "app/controllers/link_targets_controller.rb:57",
                                   "app/controllers/primary_sites_controller.rb:138"],
@@ -52,7 +53,7 @@ Total score (lower is better) = 246
                                   "app/controllers/primary_sites_controller.rb:75",
                                   "app/controllers/primary_sites_controller.rb:76",
                                   "app/controllers/primary_sites_controller.rb:88",
-                                  "app/controllers/primary_sites_controller.rb:89"] ]
+                                  "app/controllers/primary_sites_controller.rb:89"] ])
     end
   end
 
@@ -82,24 +83,24 @@ Total score (lower is better) = 246
                     "app/controllers/bookmarklet_integration_controller.rb:17"]]
 
       MetricFu::Configuration.run {}
-      File.stub(:directory?).and_return(true)
+      allow(File).to receive(:directory?).and_return(true)
       flay = MetricFu::FlayGenerator.new('base_dir')
       flay.instance_variable_set(:@matches, lines)
       @results = flay.to_h
     end
 
     it "should find the total_score" do
-      @results[:flay][:total_score].should == '284'
+      expect(@results[:flay][:total_score]).to eq('284')
     end
 
     it "should have 6 matches" do
-      @results[:flay][:matches].size.should == 6
+      expect(@results[:flay][:matches].size).to eq(6)
     end
 
     it "should capture info for match" do
-      @results[:flay][:matches].first[:reason].should =~ /IDENTICAL/
-      @results[:flay][:matches].first[:matches].first[:name].should =~ /link_targets_controller/
-      @results[:flay][:matches].first[:matches].first[:line].should == "57"
+      expect(@results[:flay][:matches].first[:reason]).to match(/IDENTICAL/)
+      expect(@results[:flay][:matches].first[:matches].first[:name]).to match(/link_targets_controller/)
+      expect(@results[:flay][:matches].first[:matches].first[:line]).to eq("57")
     end
   end
 end

data/spec/metric_fu/metrics/flog/flog_grapher_spec.rb

@@ -1,4 +1,5 @@
 require "spec_helper"
+MetricFu.metrics_require { 'flog/flog_grapher' }
 
 describe MetricFu::FlogGrapher do
   before :each do
@@ -8,16 +9,16 @@ describe MetricFu::FlogGrapher do
   end
 
   it "should respond to flog_total, flog_average and labels" do
-    @flog_grapher.should respond_to(:flog_average)
-    @flog_grapher.should respond_to(:labels)
-    @flog_grapher.should respond_to(:top_five_percent_average)
+    expect(@flog_grapher).to respond_to(:flog_average)
+    expect(@flog_grapher).to respond_to(:labels)
+    expect(@flog_grapher).to respond_to(:top_five_percent_average)
   end
 
   describe "responding to #initialize" do
     it "should initialize top_five_percent_average, flog_average and labels" do
-      @flog_grapher.flog_average.should == []
-      @flog_grapher.labels.should == {}
-      @flog_grapher.top_five_percent_average.should == []
+      expect(@flog_grapher.flog_average).to eq([])
+      expect(@flog_grapher.labels).to eq({})
+      expect(@flog_grapher.top_five_percent_average).to eq([])
     end
   end
 
@@ -36,12 +37,12 @@ describe MetricFu::FlogGrapher do
 
     it "should push to top_five_percent_average" do
       average = (99.0 + 98.0 + 97.0 + 96.0 + 95.0) / 5.0
-      @flog_grapher.top_five_percent_average.should_receive(:push).with(average)
+      expect(@flog_grapher.top_five_percent_average).to receive(:push).with(average)
       @flog_grapher.get_metrics(@metrics, @date)
     end
 
     it "should push 9.9 to flog_average" do
-      @flog_grapher.flog_average.should_receive(:push).with(7.7)
+      expect(@flog_grapher.flog_average).to receive(:push).with(7.7)
       @flog_grapher.get_metrics(@metrics, @date)
     end
 
@@ -52,17 +53,17 @@ describe MetricFu::FlogGrapher do
       end
 
       it "should not push to top_five_percent_average" do
-        @flog_grapher.top_five_percent_average.should_not_receive(:push)
+        expect(@flog_grapher.top_five_percent_average).not_to receive(:push)
         @flog_grapher.get_metrics(@metrics, @date)
       end
 
       it "should not push to flog_average" do
-        @flog_grapher.flog_average.should_not_receive(:push)
+        expect(@flog_grapher.flog_average).not_to receive(:push)
         @flog_grapher.get_metrics(@metrics, @date)
       end
 
       it "should not update labels with the date" do
-        @flog_grapher.labels.should_not_receive(:update)
+        expect(@flog_grapher.labels).not_to receive(:update)
         @flog_grapher.get_metrics(@metrics, @date)
       end
     end
@@ -75,17 +76,17 @@ describe MetricFu::FlogGrapher do
 
       it "should push to top_five_percent_average" do
         average = (73.6 + 68.5 + 66.1 + 46.6 + 44.8 + 44.1 + 41.2 + 36.0) / 8.0
-        @flog_grapher.top_five_percent_average.should_receive(:push).with(average)
+        expect(@flog_grapher.top_five_percent_average).to receive(:push).with(average)
         @flog_grapher.get_metrics(@metrics, @date)
       end
 
       it "should push to flog_average" do
-        @flog_grapher.flog_average.should_receive(:push).with(9.9)
+        expect(@flog_grapher.flog_average).to receive(:push).with(9.9)
         @flog_grapher.get_metrics(@metrics, @date)
       end
 
       it "should update labels with the date" do
-        @flog_grapher.labels.should_receive(:update).with({ 0 => "1/2" })
+        expect(@flog_grapher.labels).to receive(:update).with({ 0 => "1/2" })
         @flog_grapher.get_metrics(@metrics, @date)
       end
     end
@@ -100,7 +101,7 @@ describe MetricFu::FlogGrapher do
 
     it "should push to top_five_percent_average" do
       average = (73.6 + 68.5 + 66.1 + 46.6 + 44.8 + 44.1 + 41.2 + 36.0) / 8.0
-      @flog_grapher.top_five_percent_average.should_receive(:push).with(average)
+      expect(@flog_grapher.top_five_percent_average).to receive(:push).with(average)
       @flog_grapher.get_metrics(@metrics, @date)
     end
   end