metric_fu 4.4.4 → 4.5.1

data/spec/metric_fu/formatter/html_spec.rb

@@ -76,7 +76,7 @@ describe MetricFu::Formatter::HTML do
 
       it "can open the results in the browser" do
         formatter = MetricFu::Formatter::HTML.new
-        formatter.should_receive(:system).with("open #{Pathname.pwd.join(directory('output_directory')).join('index.html')}")
+        formatter.should_receive(:system).with("open #{MetricFu.run_path.join(directory('output_directory')).join('index.html')}")
         formatter.finish
         formatter.display_results
       end
@@ -127,7 +127,7 @@ describe MetricFu::Formatter::HTML do
 
       it "can open the results in the browser from the custom output directory" do
         formatter = MetricFu::Formatter::HTML.new(output: @output)
-        path = Pathname.pwd.join("#{directory('base_directory')}/#{@output}/index.html")
+        path = MetricFu.run_path.join("#{directory('base_directory')}/#{@output}/index.html")
         formatter.should_receive(:system).with("open #{path}")
         formatter.finish
         formatter.display_results

data/spec/metric_fu/gem_version_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+MetricFu.lib_require { 'gem_version' }
+
+describe MetricFu::GemVersion do
+
+  it 'has a list of gem deps' do
+    gem_version = MetricFu::GemVersion.new
+    gem_deps = gem_version.gem_runtime_dependencies.map(&:name)
+    MetricFu::Metric.metrics.reject{|metric| metric.name == :hotspots || metric.name == :stats}.map(&:name).map(&:to_s).each do |metric_name|
+      expect(gem_deps).to include(metric_name)
+    end
+  end
+
+end

data/spec/metric_fu/loader_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+describe MetricFu do
+
+  it "loads the .metrics file" do
+    # Global only for testing that this file gets loaded
+    $metric_file_loaded = false
+    MetricFu.loader.load_user_configuration
+    $metric_file_loaded.should be_true
+  end
+
+end

data/spec/metric_fu/metrics/base_template_spec.rb

@@ -1,4 +1,5 @@
 require "spec_helper"
+require 'tempfile'
 require 'erb'
 
 describe MetricFu::Template do
@@ -22,22 +23,23 @@ describe MetricFu::Template do
 
     before(:each) do
       @section = double('section')
-      @template.should_receive(:template).
-                with(@section).and_return(@section)
     end
 
     describe 'if the template exists' do
       it 'should return true' do
-        File.should_receive(:exist?).with(@section).and_return(true)
-        result = @template.send(:template_exists?, @section)
-        result.should be_true
+        Tempfile.open('file') do |file|
+          @template.should_receive(:template).with(@section).and_return(file.path)
+          result = @template.send(:template_exists?,@section)
+          result.should be_true
+        end
       end
     end
 
     describe 'if the template does not exist' do
       it 'should return false' do
-        File.should_receive(:exist?).with(@section).and_return(false)
-        result = @template.send(:template_exists?, @section)
+        path = 'path'
+        @template.should_receive(:template).with(@section).and_return(path)
+        result = @template.send(:template_exists?,@section)
         result.should be_false
       end
     end

data/spec/metric_fu/metrics/cane/cane_spec.rb

@@ -6,49 +6,49 @@ describe CaneGenerator do
     it "should execute cane command" do
       options = {}
       @cane = MetricFu::CaneGenerator.new(options)
-      @cane.should_receive(:`).with("mf-cane")
+      @cane.should_receive(:run!).with("")
       output = @cane.emit
     end
 
     it "should use abc max option" do
       options = {abc_max: 20}
       @cane = MetricFu::CaneGenerator.new(options)
-      @cane.should_receive(:`).with("mf-cane --abc-max 20")
+      @cane.should_receive(:run!).with(" --abc-max 20")
       output = @cane.emit
     end
 
     it "should use style max line length option" do
       options = {line_length: 100}
       @cane = MetricFu::CaneGenerator.new(options)
-      @cane.should_receive(:`).with("mf-cane --style-measure 100")
+      @cane.should_receive(:run!).with(" --style-measure 100")
       output = @cane.emit
     end
 
     it "should use no-doc if specified" do
       options = {no_doc: 'y'}
       @cane = MetricFu::CaneGenerator.new(options)
-      @cane.should_receive(:`).with("mf-cane --no-doc")
+      @cane.should_receive(:run!).with(" --no-doc")
       output = @cane.emit
     end
 
     it "should include doc violations if no_doc != 'y'" do
       options = {no_doc: 'n'}
       @cane = MetricFu::CaneGenerator.new(options)
-      @cane.should_receive(:`).with("mf-cane")
+      @cane.should_receive(:run!).with("")
       output = @cane.emit
     end
 
     it "should use no-readme if specified" do
       options = {no_readme: 'y'}
       @cane = MetricFu::CaneGenerator.new(options)
-      @cane.should_receive(:`).with("mf-cane --no-readme")
+      @cane.should_receive(:run!).with(" --no-readme")
       output = @cane.emit
     end
 
     it "should include README violations if no_readme != 'y'" do
       options = {no_readme: 'n'}
       @cane = MetricFu::CaneGenerator.new(options)
-      @cane.should_receive(:`).with("mf-cane")
+      @cane.should_receive(:run!).with("")
       output = @cane.emit
     end
   end

data/spec/metric_fu/metrics/churn/churn_spec.rb

@@ -2,12 +2,12 @@ require "spec_helper"
 
 describe MetricFu::ChurnGenerator do
 
+  # TODO extract yaml
   let(:churn_yaml) { "--- \n:churn: \n  :changed_files: \n  - spec/graphs/flog_grapher_spec.rb\n  - spec/base/graph_spec.rb\n  - lib/templates/awesome/layout.html.erb\n  - lib/graphs/rcov_grapher.rb\n  - lib/base/base_template.rb\n  - spec/graphs/grapher_spec.rb\n  - lib/templates/awesome/flog.html.erb\n  - lib/templates/awesome/flay.html.erb\n  - lib/graphs/roodi_grapher.rb\n  - lib/graphs/reek_grapher.rb\n  - HISTORY\n  - spec/graphs/roodi_grapher_spec.rb\n  - lib/generators/rcov.rb\n  - spec/graphs/engines/gchart_spec.rb\n  - spec/graphs/rcov_grapher_spec.rb\n  - lib/templates/javascripts/excanvas.js\n  - lib/templates/javascripts/bluff-min.js\n  - spec/graphs/reek_grapher_spec.rb\n" }
 
   let(:config_setup) {
     ENV['CC_BUILD_ARTIFACTS'] = nil
     MetricFu.configure.reset
-    File.stub(:directory?).and_return(true)
   }
 
   describe "new method" do

data/spec/metric_fu/metrics/flay/flay_grapher_spec.rb

@@ -21,7 +21,7 @@ describe FlayGrapher do
   describe "responding to #get_metrics" do
     context "when metrics were not generated" do
       before(:each) do
-        @metrics = YAML::load(File.open("#{resources_path}/yml/metric_missing.yml"))
+        @metrics = FIXTURE.load_metric("metric_missing.yml")
         @date = "1/2"
       end
 
@@ -38,7 +38,7 @@ describe FlayGrapher do
 
     context "when metrics have been generated" do
       before(:each) do
-        @metrics = YAML::load(File.open("#{resources_path}/yml/20090630.yml"))
+        @metrics = FIXTURE.load_metric("20090630.yml")
         @date = "1/2"
       end
 

data/spec/metric_fu/metrics/flay/flay_spec.rb

@@ -7,7 +7,7 @@ describe MetricFu::FlayGenerator do
       File.stub(:directory?).and_return(true)
       @flay = MetricFu::FlayGenerator.new(options)
 
-      @flay.should_receive(:`).with("mf-flay  app lib")
+      @flay.should_receive(:run!).with(" app lib")
       output = @flay.emit
     end
 
@@ -16,7 +16,7 @@ describe MetricFu::FlayGenerator do
       File.stub(:directory?).and_return(true)
       @flay = MetricFu::FlayGenerator.new(options)
 
-      @flay.should_receive(:`).with("mf-flay --mass 99  ")
+      @flay.should_receive(:run!).with("--mass 99  ")
       output = @flay.emit
     end
   end

data/spec/metric_fu/metrics/flog/flog_grapher_spec.rb

@@ -47,7 +47,7 @@ describe MetricFu::FlogGrapher do
 
     context "when metrics were not generated" do
       before(:each) do
-        @metrics = metric_data('metric_missing.yml')
+        @metrics = FIXTURE.load_metric('metric_missing.yml')
         @date = "1/2"
       end
 
@@ -69,7 +69,7 @@ describe MetricFu::FlogGrapher do
 
     context "when metrics have been generated" do
       before(:each) do
-        @metrics = metric_data('20090630.yml')
+        @metrics = FIXTURE.load_metric('20090630.yml')
         @date = "1/2"
       end
 
@@ -93,7 +93,7 @@ describe MetricFu::FlogGrapher do
 
   describe "responding to #get_metrics with legacy data" do
     before(:each) do
-      @metrics = YAML::load(File.open("#{resources_path}/yml/20090630.yml"))
+      @metrics = FIXTURE.load_metric("20090630.yml")
 
       @date = "1/2"
     end

data/spec/metric_fu/metrics/generator_spec.rb

@@ -43,25 +43,6 @@ describe MetricFu::Generator do
     end
   end
 
-  describe '@concrete_class should have hook methods for '\
-           +'[before|after]_[emit|analyze|to_h]' do
-
-    %w[emit analyze].each do |meth|
-
-      it "should respond to #before_#{meth}" do
-        @concrete_class.respond_to?("before_#{meth}".to_sym).should be_true
-      end
-
-      it "should respond to #after_#{meth}" do
-        @concrete_class.respond_to?("after_#{meth}".to_sym).should be_true
-      end
-    end
-
-    it "should respond to #before_to_h" do
-      @concrete_class.respond_to?("before_to_h".to_sym).should be_true
-    end
-  end
-
   describe "#generate_result" do
     it 'should  raise an error when calling #emit' do
       @abstract_class = MetricFu::Generator.new
@@ -82,25 +63,10 @@ describe MetricFu::Generator do
   describe "#generate_result (in a concrete class)" do
 
     %w[emit analyze].each do |meth|
-      it "should call #before_#{meth}" do
-        @concrete_class.should_receive("before_#{meth}")
-        @concrete_class.generate_result
-      end
-
       it "should call ##{meth}" do
         @concrete_class.should_receive("#{meth}")
         @concrete_class.generate_result
       end
-
-      it "should call #after_#{meth}" do
-        @concrete_class.should_receive("after_#{meth}")
-        @concrete_class.generate_result
-      end
-    end
-
-    it "should call #before_to_h" do
-      @concrete_class.should_receive("before_to_h")
-      @concrete_class.generate_result
     end
 
     it "should call #to_h" do
@@ -128,7 +94,7 @@ describe MetricFu::Generator do
         @paths.each do |path|
           @container.file(path)
         end
-        @old_dir = Dir.pwd
+        @old_dir = MetricFu.run_dir
         Dir.chdir(@container)
       end
 

data/spec/metric_fu/metrics/graph_spec.rb

@@ -1,4 +1,5 @@
 require "spec_helper"
+MetricFu.metrics_require { 'graph' }
 
 describe MetricFu do
 
@@ -15,30 +16,12 @@ describe MetricFu::Graph do
     @graph = MetricFu::Graph.new
   end
 
-  describe "responding to #add with gchart enabled" do
-    it 'should instantiate a grapher and push it to graphers' do
-      @graph.graphers.should_receive(:push).with(an_instance_of(RcovGchartGrapher))
-      @graph.add("rcov", 'gchart')
-    end
-  end
-
-  describe "responding to #add with gchart enabled" do
-    it 'should instantiate a grapher and push it to graphers' do
-      @graph.graphers.should_receive(:push).with(an_instance_of(RcovGchartGrapher))
-      @graph.add("rcov", 'gchart')
-    end
-  end
-
   describe "setting the date on the graph" do
-    next if breaks_when?(MetricFu.configuration.rubinius?)
-    before(:each) do
-      @graph.stub(:mf_log)
-    end
 
     it "should set the date once for one data point" do
-      Dir.should_receive(:[]).and_return(["metric_fu/tmp/_data/20101105.yml"])
-      File.should_receive(:join)
-      File.should_receive(:open).and_return("Metrics")
+      metric_file = "metric_fu/tmp/_data/20101105.yml"
+      MetricFu::Utility.should_receive(:glob).and_return([metric_file].sort)
+      MetricFu::Utility.should_receive(:load_yaml).with(metric_file).and_return("Metrics")
       double_grapher = double
       double_grapher.should_receive(:get_metrics).with("Metrics", "11/5")
       double_grapher.should_receive(:graph!)
@@ -48,9 +31,9 @@ describe MetricFu::Graph do
     end
 
     it "should set the date when the data directory isn't in the default place" do
-      Dir.should_receive(:[]).and_return(["/some/kind/of/weird/directory/somebody/configured/_data/20101105.yml"])
-      File.should_receive(:join)
-      File.should_receive(:open).and_return("Metrics")
+      metric_file = "/some/kind/of/weird/directory/somebody/configured/_data/20101105.yml"
+      MetricFu::Utility.should_receive(:glob).and_return([metric_file].sort)
+      MetricFu::Utility.should_receive(:load_yaml).with(metric_file).and_return("Metrics")
       double_grapher = double
       double_grapher.should_receive(:get_metrics).with("Metrics", "11/5")
       double_grapher.should_receive(:graph!)

data/spec/metric_fu/metrics/hotspots/analysis/analyzed_problems_spec.rb

@@ -26,7 +26,7 @@ describe MetricFu::HotspotAnalyzedProblems do
   context "with several types of data" do
 
     before do
-      @result_hash = metric_data('hotspots/several_metrics.yml')
+      @result_hash = HOTSPOT_DATA["several_metrics.yml"]
       @analyzed_problems = analyzed_problems(@result_hash)
       @worst_items = @analyzed_problems.worst_items
     end
@@ -81,7 +81,7 @@ describe MetricFu::HotspotAnalyzedProblems do
   context "with Saikuro data" do
 
     before do
-      @result_hash = metric_data('hotspots/saikuro.yml')
+      @result_hash = HOTSPOT_DATA["saikuro.yml"]
       @analyzed_problems = analyzed_problems(@result_hash)
       @worst_items = @analyzed_problems.worst_items
     end

data/spec/metric_fu/metrics/hotspots/analysis/analyzer_tables_spec.rb

@@ -25,7 +25,7 @@ describe MetricFu::AnalyzerTables do
   context "with Stats data" do
 
     before do
-      @result_hash = metric_data('hotspots/stats.yml')
+      @result_hash = HOTSPOT_DATA["stats.yml"]
       @table = analyzer_table(@result_hash).table
     end
 
@@ -49,7 +49,7 @@ describe MetricFu::AnalyzerTables do
   context "with three different path representations of file (from Saikuro, Flog, and Reek)" do
 
     before do
-      @result_hash = metric_data('hotspots/three_metrics_on_same_file.yml')
+      @result_hash = HOTSPOT_DATA["three_metrics_on_same_file.yml"]
       @table = analyzer_table(@result_hash).table
     end
 

data/spec/metric_fu/metrics/hotspots/analysis/rankings_spec.rb

@@ -29,13 +29,13 @@ describe MetricFu::HotspotRankings do
       rankings(result_hash).worst_files.should == expected
     end
     def result_hash
-      @result_hash ||= metric_data('hotspots/several_metrics.yml')
+      @result_hash ||= HOTSPOT_DATA["several_metrics.yml"]
     end
   end
   context "with Reek data" do
 
     before do
-      @result_hash = metric_data('hotspots/reek.yml')
+      @result_hash = HOTSPOT_DATA["reek.yml"]
     end
 
     it "gives worst method" do
@@ -54,7 +54,7 @@ describe MetricFu::HotspotRankings do
   context "with Saikuro data" do
 
     before do
-      @result_hash = metric_data('hotspots/saikuro.yml')
+      @result_hash = HOTSPOT_DATA["saikuro.yml"]
     end
 
     it "gives worst method" do
@@ -69,7 +69,7 @@ describe MetricFu::HotspotRankings do
   context "with Flog data" do
 
     before do
-      @result_hash = metric_data('hotspots/flog.yml')
+      @result_hash = HOTSPOT_DATA["flog.yml"]
     end
 
     it "gives worst method" do
@@ -89,7 +89,7 @@ describe MetricFu::HotspotRankings do
   context "with Roodi data" do
 
     before do
-      @result_hash = metric_data('hotspots/roodi.yml')
+      @result_hash = HOTSPOT_DATA["roodi.yml"]
     end
 
     it "gives worst file" do

data/spec/metric_fu/metrics/hotspots/hotspots_spec.rb

@@ -1,12 +1,11 @@
 require "spec_helper"
 
 describe MetricFu::HotspotsGenerator do
-
   describe "analyze method" do
     before :each do
       MetricFu::Configuration.run {}
       File.stub(:directory?).and_return(true)
-      @yaml = metric_data('hotspots/generator.yml')
+      @yaml = HOTSPOT_DATA["generator.yml"]
     end
 
     it "should be empty on error" do
@@ -21,7 +20,7 @@ describe MetricFu::HotspotsGenerator do
       hotspots = MetricFu::HotspotsGenerator.new
       hotspots.analyze
       result = hotspots.to_h[:hotspots]
-      expected = metric_data('hotspots/generator_analysis.yml')
+      expected = HOTSPOT_DATA["generator_analysis.yml"]
       # ensure expected granularities
       expect(result.keys).to eq(expected.keys)
 

data/spec/metric_fu/metrics/rails_best_practices/rails_best_practices_grapher_spec.rb

@@ -21,7 +21,7 @@ describe RailsBestPracticesGrapher do
   describe "responding to #get_metrics" do
     context "when metrics were not generated" do
       before(:each) do
-        @metrics = YAML::load(File.open("#{resources_path}/yml/metric_missing.yml"))
+        @metrics = FIXTURE.load_metric("metric_missing.yml")
         @date = "01022003"
       end
 
@@ -38,7 +38,7 @@ describe RailsBestPracticesGrapher do
 
     context "when metrics have been generated" do
       before(:each) do
-        @metrics = YAML::load(File.open("#{resources_path}/yml/20090630.yml"))
+        @metrics = FIXTURE.load_metric("20090630.yml")
         @date = "01022003"
       end