metric_fu 4.4.1 → 4.4.2

data/spec/metric_fu/metrics/saikuro/saikuro_spec.rb

@@ -1,10 +1,10 @@
 require "spec_helper"
 
-describe Saikuro do
+describe MetricFu::SaikuroGenerator do
   describe "to_h method" do
     before :all do
       options = {}
-      saikuro = MetricFu::Saikuro.new(options)
+      saikuro = MetricFu::SaikuroGenerator.new(options)
       def saikuro.metric_directory
         "#{resources_path}/saikuro"
       end
@@ -38,7 +38,7 @@ describe Saikuro do
   describe "per_file_info method" do
     before :all do
       options = {}
-      @saikuro = MetricFu::Saikuro.new(options)
+      @saikuro = MetricFu::SaikuroGenerator.new(options)
       def @saikuro.metric_directory
         "#{resources_path}/saikuro"
       end
@@ -52,11 +52,11 @@ describe Saikuro do
     end
   end
 
-  describe Saikuro::SFile do
+  describe MetricFu::SaikuroScratchFile do
     describe "getting elements from a Saikuro result file" do
      it "should parse nested START/END sections" do
        path = "#{resources_path}/saikuro_sfiles/thing.rb_cyclo.html"
-        sfile = Saikuro::SFile.new path
+        sfile = MetricFu::SaikuroScratchFile.new path
        sfile.elements.map { |e| e.complexity }.sort.should eql(["0","0","2"])
       end
     end

data/spec/metric_fu/reporting/graphs/engines/gchart_spec.rb

@@ -1,4 +1,5 @@
 require "spec_helper"
+require 'googlecharts'
 
 describe MetricFu::Grapher do
   describe "require_graphing_gem" do

data/spec/resources/yml/hotspots/generator.yml

@@ -0,0 +1,47 @@
+--- 
+:reek: 
+  :matches: 
+  - :file_path: lib/client/client.rb:42
+    :code_smells: 
+    - :type: Large Class
+      :message: has at least 27 methods
+      :method: Devver::Client
+    - :type: Long Method
+      :message: has approx 6 statements
+      :method: Devver::Client#client_requested_sync
+:flog: 
+  :method_containers: 
+  - :highest_score: 61.5870319141946
+    :path: /lib/client/client.rb
+    :methods: 
+      Client#client_requested_sync: 
+        :path: /lib/client/client.rb:42
+        :score: 37.9270319141946
+        :operators: 
+          :+: 1.70000000000001
+          :/: 1.80000000000001
+          :method_at_line: 1.90000000000001
+          :puts: 1.70000000000001
+          :assignment: 33.0000000000001
+          :in_method?: 1.70000000000001
+          :message: 1.70000000000001
+          :branch: 12.6
+          :<<: 3.40000000000001
+          :each: 1.50000000000001
+          :lit_fixnum: 1.45
+          :raise: 1.80000000000001
+          :each_pair: 1.3
+          :*: 1.60000000000001
+          :to_f: 2.00000000000001
+          :each_with_index: 3.00000000000001
+          :[]: 22.3000000000001
+          :new: 1.60000000000001
+    :average_score: 11.1209009055421
+    :total_score: 1817.6
+    :name: Client#client_requested_sync
+:churn: 
+  :changes: 
+  - :file_path: lib/client/client.rb
+    :times_changed: 54
+  - :file_path: lib/client/foo.rb
+    :times_changed: 52

data/spec/resources/yml/hotspots/generator_analysis.yml

@@ -0,0 +1,53 @@
+---
+files:
+- location:
+    class_name:
+    method_name:
+    file_path: lib/client/client.rb:42
+    file_name: lib/client/client.rb
+    line_number: '42'
+    hash_key: '["lib/client/client.rb:42", nil, nil]'
+  details:
+    flog: complexity is 37.9
+    reek: found 2 code smells
+- location:
+    class_name:
+    method_name:
+    file_path: lib/client/client.rb
+    file_name: lib/client/client.rb
+    line_number:
+    hash_key: '["lib/client/client.rb", nil, nil]'
+  details:
+    churn: detected high level of churn (changed 54 times)
+- location:
+    class_name:
+    method_name:
+    file_path: lib/client/foo.rb
+    file_name: lib/client/foo.rb
+    line_number:
+    hash_key: '["lib/client/foo.rb", nil, nil]'
+  details:
+    churn: detected high level of churn (changed 52 times)
+classes:
+- location:
+    class_name: Client
+    method_name:
+    file_path: lib/client/client.rb:42
+    file_name: lib/client/client.rb
+    line_number: '42'
+    hash_key: '["lib/client/client.rb:42", "Client", nil]'
+  details:
+    flog: complexity is 37.9
+    reek: found 2 code smells
+methods:
+- location:
+    class_name: Client
+    method_name: Client#client_requested_sync
+    file_path: lib/client/client.rb:42
+    file_name: lib/client/client.rb
+    line_number: '42'
+    hash_key: '["lib/client/client.rb:42", "Client", "Client#client_requested_sync"]'
+    simple_method_name: '#client_requested_sync'
+  details:
+    flog: complexity is 37.9
+    reek: found 1 code smells

data/spec/run_spec.rb

@@ -1,5 +1,4 @@
 require 'spec_helper'
-require 'fakefs/safe'
 require 'metric_fu/cli/client'
 
 describe MetricFu do

data/spec/support/helper_methods.rb

@@ -16,7 +16,17 @@ end
 def read_resource(path_in_resources)
   File.read("#{resources_path}/#{path_in_resources}")
 end
+
 def metric_data(path_in_resources)
   metric_path = read_resource("yml/#{path_in_resources}")
   YAML.load( metric_path )
 end
+
+def resources_path
+  "#{MetricFu.root_dir}/spec/resources"
+  # directory(name)
+end
+
+def compare_paths(path1, path2)
+  File.join(MetricFu.root_dir, path1).should == File.join(MetricFu.root_dir, path2)
+end

data/spec/support/suite.rb

@@ -1,9 +1,7 @@
-
-def compare_paths(path1, path2)
-  File.join(MetricFu.root_dir, path1).should == File.join(MetricFu.root_dir, path2)
+def directory(name)
+  MetricFu::Io::FileSystem.directory(name)
 end
 
-
 # TODO these directories shouldn't be written in the first place
 def cleanup_test_files
   FileUtils.rm_rf(Dir["#{MetricFu.root_dir}/foo"])
@@ -12,17 +10,18 @@ rescue => e
   mf_debug "Failed cleaning up test files #{e.inspect}"
 end
 
-
-def resources_path
-  "#{MetricFu.root_dir}/spec/resources"
-end
-
-def directory(name)
-  MetricFu::Io::FileSystem.directory(name)
+# fakefs doesn't seem to work reliably on non-mri rubies
+def using_fake_filesystem
+  return false unless MetricFu.configuration.mri?
+  require 'fakefs/safe'
+  true
+rescue NameError, LoadError
+  warn "Fake filesystem not available"
+  false
 end
 
 def setup_fs
-  if !MetricFu.configuration.rubinius? # fakefs doesn't seem to work on rubinius...
+  if using_fake_filesystem
     FakeFS.activate!
     FakeFS::FileSystem.clone('lib')
     FakeFS::FileSystem.clone('.metrics')
@@ -41,11 +40,11 @@ def setup_fs
 end
 
 def cleanup_fs
-  if !MetricFu.configuration.rubinius?
+  if using_fake_filesystem
     FakeFS::FileSystem.clear
     FakeFS.deactivate!
   else
-    # Not ideal, but workaround for rubinius...
+    # Not ideal, but workaround for non-mri rubies
     FileUtils.rm_rf("#{directory('base_directory')}/report.yml")
     FileUtils.rm_rf(Dir.glob("#{directory('output_directory')}/*.html"))
     FileUtils.rm_rf(Dir.glob("#{directory('output_directory')}/*.js"))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: metric_fu
 version: !ruby/object:Gem::Version
-  version: 4.4.1
+  version: 4.4.2
 platform: ruby
 authors:
 - Jake Scruggs
@@ -19,13 +19,13 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-30 00:00:00.000000000 Z
+date: 2013-09-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flay
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 2.0.1
     - - ~>
@@ -35,7 +35,7 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 2.0.1
     - - ~>
@@ -59,7 +59,7 @@ dependencies:
   name: flog
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 4.1.1
     - - ~>
@@ -69,7 +69,7 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 4.1.1
     - - ~>
@@ -79,7 +79,7 @@ dependencies:
   name: reek
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.3.3
     - - ~>
@@ -89,7 +89,7 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.3.3
     - - ~>
@@ -99,7 +99,7 @@ dependencies:
   name: cane
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 2.5.2
     - - ~>
@@ -109,7 +109,7 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 2.5.2
     - - ~>
@@ -119,7 +119,7 @@ dependencies:
   name: rails_best_practices
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.14.3
     - - ~>
@@ -129,7 +129,7 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.14.3
     - - ~>
@@ -139,14 +139,14 @@ dependencies:
   name: metric_fu-Saikuro
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.1.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.1.1.0
 - !ruby/object:Gem::Dependency
@@ -181,56 +181,56 @@ dependencies:
   name: redcard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: coderay
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bluff
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Code metrics from Flog, Flay, Saikuro, Churn, Reek, Roodi, Code Statistics,
@@ -258,6 +258,7 @@ files:
 - .yardopts
 - AUTHORS
 - CONTRIBUTING.md
+- CONTRIBUTORS
 - Gemfile
 - HISTORY.md
 - MIT-LICENSE
@@ -277,6 +278,7 @@ files:
 - checksum/metric_fu-4.3.0.gem.sha512
 - checksum/metric_fu-4.3.1.gem.sha512
 - checksum/metric_fu-4.4.0.gem.sha512
+- checksum/metric_fu-4.4.1.gem.sha512
 - config/roodi_config.yml
 - gem_tasks/build.rake
 - gemfiles/Gemfile.travis
@@ -288,6 +290,7 @@ files:
 - lib/metric_fu/constantize.rb
 - lib/metric_fu/data_structures/line_numbers.rb
 - lib/metric_fu/data_structures/location.rb
+- lib/metric_fu/data_structures/sexp_node.rb
 - lib/metric_fu/environment.rb
 - lib/metric_fu/errors/analysis_error.rb
 - lib/metric_fu/formatter.rb
@@ -332,6 +335,7 @@ files:
 - lib/metric_fu/metrics/hotspots/analysis/grouping.rb
 - lib/metric_fu/metrics/hotspots/analysis/groupings.rb
 - lib/metric_fu/metrics/hotspots/analysis/problems.rb
+- lib/metric_fu/metrics/hotspots/analysis/ranked_problem_location.rb
 - lib/metric_fu/metrics/hotspots/analysis/ranking.rb
 - lib/metric_fu/metrics/hotspots/analysis/rankings.rb
 - lib/metric_fu/metrics/hotspots/analysis/record.rb
@@ -370,8 +374,10 @@ files:
 - lib/metric_fu/metrics/roodi/roodi_hotspot.rb
 - lib/metric_fu/metrics/roodi/template_awesome/roodi.html.erb
 - lib/metric_fu/metrics/saikuro/init.rb
+- lib/metric_fu/metrics/saikuro/parsing_element.rb
 - lib/metric_fu/metrics/saikuro/saikuro.rb
 - lib/metric_fu/metrics/saikuro/saikuro_hotspot.rb
+- lib/metric_fu/metrics/saikuro/scratch_file.rb
 - lib/metric_fu/metrics/saikuro/template_awesome/saikuro.html.erb
 - lib/metric_fu/metrics/stats/init.rb
 - lib/metric_fu/metrics/stats/stats.rb
@@ -455,6 +461,8 @@ files:
 - spec/resources/saikuro_sfiles/thing.rb_cyclo.html
 - spec/resources/yml/20090630.yml
 - spec/resources/yml/hotspots/flog.yml
+- spec/resources/yml/hotspots/generator.yml
+- spec/resources/yml/hotspots/generator_analysis.yml
 - spec/resources/yml/hotspots/reek.yml
 - spec/resources/yml/hotspots/roodi.yml
 - spec/resources/yml/hotspots/saikuro.yml
@@ -480,17 +488,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: 1.9.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
 rubyforge_project: metric_fu
-rubygems_version: 2.0.3
+rubygems_version: 2.0.8
 signing_key: 
 specification_version: 4
 summary: A fistful of code metrics, with awesome templates and graphs
@@ -545,6 +553,8 @@ test_files:
 - spec/resources/saikuro_sfiles/thing.rb_cyclo.html
 - spec/resources/yml/20090630.yml
 - spec/resources/yml/hotspots/flog.yml
+- spec/resources/yml/hotspots/generator.yml
+- spec/resources/yml/hotspots/generator_analysis.yml
 - spec/resources/yml/hotspots/reek.yml
 - spec/resources/yml/hotspots/roodi.yml
 - spec/resources/yml/hotspots/saikuro.yml