metric_fu 4.12.0 → 4.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 17c8fa2540d144f89979c7f5586a71c3889a29f5
-  data.tar.gz: 23514588a8ce5ab8ebea208c91874c220db2a1fc
+SHA256:
+  metadata.gz: 8ff6ebbe956db6bea6a6c659009c6b6d82cfd55bb307bab83fef44c84bc5ab62
+  data.tar.gz: f6c2186a24106cdaedebb726b1d6105bfa78133fa0634680312a432b1c6a6e4e
 SHA512:
-  metadata.gz: 81f84088449c69e96c1e3830e3d938e0cef39d6e81b68c69699924f71d6e012d3b4ef055d19df66ba067a59c202f2fd5f33bfafefae1b4817f678596f79ac232
-  data.tar.gz: 3da37a9252de3c65890b68c5593b9cab45fdaf86a1b36f995c2a3f609787c22382810ab7d5eb3210c1275823eceeef937e2b6111baa52afb0925b823d059f485
+  metadata.gz: 727a55955630636b8c5a6e47e88a985f45fd33c1f5e5242a5cea410704b2eb9d4caf802a2a06f49b9f333ffc89be4792a73d322eb64e5f8d31505e677dd37c5a
+  data.tar.gz: 3f8687c5f52822478f00a675ece026125113898c2229fe3be251453d9b4cb4b27fdaa76b4ea85b9b9735339dce5e489c842379cf4dede48083013db028f89395

data/.gitignore

@@ -20,3 +20,9 @@ tmp
 *.swp
 tags
 .idea
+
+# rvm
+.ruby-version
+.ruby-gemset
+
+.overcommit.yml

data/.travis.yml

@@ -1,4 +1,3 @@
-sudo: false
 language: ruby
 bundler_args: --path vendor/bundle --jobs=3 --retry=3
 script: bundle exec rspec
@@ -9,14 +8,11 @@ before_install:
   - bundle config --local without local_development yard guard
 rvm:
   # 2.1, not 2.1.0 until fixed https://github.com/travis-ci/travis-ci/issues/2220
-  - 2.2
-  - 2.1
-  - 2.0.0
-  - 1.9.2
-  - 1.9.3
+  - 2.5
+  - 2.6
+  - 2.7
   - jruby
-  - "rbx-2"
 matrix:
   allow_failures:
-    - rvm: rbx-2
+    - rvm: jruby
   fast_finish: true

data/CONTRIBUTORS

@@ -21,6 +21,7 @@ jscruggs
 David Chelimsky
 adrien
 Jay Zeschin
+Greg Allen
 Alex Rothenberg
 calveto
 Avdi Grimm
@@ -36,8 +37,8 @@ unknown
 Micah Geisel
 Extrovert
 Ben Turner
-KAKUTANI Shintaro
 Andrew Timberlake
+KAKUTANI Shintaro
 Guilherme Souza
 Przemysław Dąbek
 carlost
@@ -60,17 +61,16 @@ ff-cviradiya
 khall
 Stefan Huber
 Todd A. Jacobs
-René Föhring
+jayzes
+Hans Hasselberg
 Scyllinice
 Bitdeli Chef
-Hans Hasselberg
-jayzes
+René Föhring
 Matthew Gordon
 factorylabs
 Mike Ball
-Mike Szyndel
-Chris Ian Fiel
-Greg Allen
-Paul Elliott
 Guilherme Simões
+Paul Elliott
 Joel Nimety
+Chris Ian Fiel
+Mike Szyndel

data/Gemfile

@@ -1,23 +1,48 @@
 # encoding: utf-8
 source "https://rubygems.org"
 
-if RUBY_VERSION == "1.9.2"
+if RUBY_VERSION >= '1.9.3'
+  gem "rubocop", platforms: :mri, groups: [:test, :local_development]
+  gem "activesupport", "~> 4.2"
+
+  if RUBY_VERSION > '2.3'
+    gem "json", ">= 2.0"
+  else
+    gem "json", "~> 1.7"
+  end
+  if RUBY_VERSION =~ /^2\.0\..*/
+    gem "unparser", "0.2.4"
+  elsif RUBY_VERSION =~ /^1\.9\.3.*/
+    gem "unparser", "0.2.4"
+    gem "json_pure", "2.0.1"
+    gem "mime-types", "2.99.3"
+    gem "rest-client", "1.8.0"
+    gem "addressable", "2.4.0"
+    gem "ffi", "1.9.14" # windows support
+  end
+elsif RUBY_VERSION =~ /^1\.9\.2.*/
   # because of https://github.com/railsbp/rails_best_practices/blob/master/rails_best_practices.gemspec
   gem "activesupport", "~> 3.2"
   # because of https://github.com/troessner/reek/issues/334
   gem "reek", "~> 1.4.0"
   # rbp -> as -> i18n
-  gem 'i18n', '0.6.11'
+  gem "i18n", "0.6.11"
   gem "parallel", "= 1.3.3" # 1.3.4 disallows 1.9.2
-else
-  gem "rubocop", platforms: :mri, groups: [:test, :local_development]
+  gem "unparser", "0.1.5"
+  gem "json_pure", "2.0.1"
+  gem "mime-types", "2.99.3"
+  gem "rest-client", "1.8.0"
+  gem "json", "~> 1.7"
+  gem "addressable", "2.4.0"
+  gem "rainbow", "2.1.0"
+  gem "ffi", "1.9.14" # windows support
 end
 
 gemspec path: File.expand_path("..", __FILE__)
 
 platform :jruby do
   group :jruby do
-    gem "jruby-openssl", "~> 0.8.5"
+    gem "jruby-openssl", "~> 0.9.17"
   end
 end
 
@@ -31,20 +56,3 @@ group :development do
   gem "rake",  "~> 10.1.0"
   gem "yard",  "~> 0.8.7", group: :yard
 end
-
-group :guard do
-  gem "guard",         "~> 1.8.1"
-  gem "guard-bundler", "~> 1.0.0"
-  gem "guard-rspec"
-
-  # file system change event handling
-  gem "listen",     "~> 1.3.0"
-  gem "rb-fchange", "~> 0.0.6", require: false
-  gem "rb-fsevent", "~> 0.9.3", require: false
-  gem "rb-inotify", "~> 0.9.0", require: false
-
-  # notification handling
-  gem "libnotify",               "~> 0.8.0", require: false
-  gem "rb-notifu",               "~> 0.0.4", require: false
-  gem "terminal-notifier-guard", "~> 1.5.3", require: false
-end

data/HISTORY.md

@@ -4,13 +4,29 @@ Each change should fall into categories that would affect whether the release is
 
 As such, a _Feature_ would map to either major (breaking change) or minor. A _bug fix_ to a patch.  And _misc_ is either minor or patch, the difference being kind of fuzzy for the purposes of history.  Adding tests would be patch level.
 
-### Master [changes](https://github.com/metricfu/metric_fu/compare/v4.12.0...master)
+### [Unreleased](https://github.com/metricfu/metric_fu/compare/v4.13.0...master)
 
 * Breaking Changes
 * Features
 * Fixes
 * Misc
 
+### [4.13.0](https://github.com/metricfu/metric_fu/compare/v4.12.0...v4.13.0)
+
+* Features
+  * Setup CI pipeline on AppVeyor and fixed specs. (Rasmus Bergholdt, #285, fixes #284)
+  * Upgraded roodi to v5.0.0 (Jonathan Keam, #287)
+  * Updated jruby-openssl and removed unused rb-notifu gem (Jonathan Keam, #290)
+* Fixes
+  * Rails best practices options (Noah S-W, #264, #263)
+  * Fix deprecation warnings for Dir.exists? (Jared Szechy, #269)
+  * Fix specs (Luciano Sousa, #270)
+  * Fixed broken dependencies (Jonathan Keam, #279)
+  * FlogCli.flog must receive an expanded list of files (Rasmus Bergholdt, #282, fixes #273)
+  * Fix test warnings (Jonathan Keam, #289, addresses #288)
+* Misc
+  * Add a Gitter chat badge to README.md (#259)
+
 ### [4.12.0](https://github.com/metricfu/metric_fu/compare/v4.11.4...v4.12.0)
 
 * Features

data/README.md

@@ -1,9 +1,15 @@
-# MetricFu [![Gem Version](https://badge.fury.io/rb/metric_fu.png)](http://badge.fury.io/rb/metric_fu) [![Build Status](https://travis-ci.org/metricfu/metric_fu.png?branch=master)](http://travis-ci.org/metricfu/metric_fu)
+# MetricFu [![Gem Version](https://badge.fury.io/rb/metric_fu.svg)](http://badge.fury.io/rb/metric_fu) [![Build Status](https://travis-ci.org/metricfu/metric_fu.svg?branch=master)](http://travis-ci.org/metricfu/metric_fu)
 
-[![Code Climate](https://codeclimate.com/github/metricfu/metric_fu.png)](https://codeclimate.com/github/metricfu/metric_fu) [![Inline docs](http://inch-ci.org/github/metricfu/metric_fu.png)](http://inch-ci.org/github/metricfu/metric_fu) [![Dependency Status](https://gemnasium.com/metricfu/metric_fu.png)](https://gemnasium.com/metricfu/metric_fu)
+[![Join the chat at https://gitter.im/metricfu/metric_fu](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/metricfu/metric_fu?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
+
+[![Code Climate](https://codeclimate.com/github/metricfu/metric_fu.svg)](https://codeclimate.com/github/metricfu/metric_fu) [![Inline docs](http://inch-ci.org/github/metricfu/metric_fu.svg)](http://inch-ci.org/github/metricfu/metric_fu)
 
 [Rdoc](http://rdoc.info/github/metricfu/metric_fu/)
 
+## Maintenance
+
+MetricFu needs maintainers.  If you are up for helping out, please left a note in [issue 280]( https://github.com/metricfu/metric_fu/issues/280).  MetricFu is free and open source code that belongs to everyone.  Benjamin (@bf4) hasn't been working on MetricFu for a while, which is a great opportunity for you to step up!
+
 ## Installation
 
     gem install metric_fu
@@ -47,7 +53,6 @@ See:
 
 ## Documentation
 
-
 MetricFu will attempt to load configuration data from a
 `.metrics` file, if present in your repository root.
 
@@ -87,9 +92,67 @@ MetricFu.configuration.configure_metrics.each do |metric|
 end
 ```
 
-## Formatters
+### Rails Best Practices
+
+```ruby
+MetricFu::Configuration.run do |config|
+  config.configure_metric(:rails_best_practices) do |rbp|
+    rbp.silent = true
+    rbp.exclude = ["config/chef"]
+  end
+end
+```
+
+### Coverage Metrics
+
+```ruby
+MetricFu::Configuration.run do |config|
+  config.configure_metric(:rcov) do |rcov|
+    rcov.coverage_file = MetricFu.run_path.join("coverage/rcov/rcov.txt")
+    rcov.enable
+    rcov.activate
+  end
+end
+```
+
+If you want metric_fu to actually run rcov itself (1.8 only), don't specify an external file to read from
+
+#### Rcov metrics with Ruby 1.8
+
+To generate the same metrics metric_fu has been generating run from the root of your project before running metric_fu
+
+```shell
+RAILS_ENV=test rcov $(ruby -e "puts Dir['{spec,test}/**/*_{spec,test}.rb'].join(' ')") --sort coverage --no-html --text-coverage --no-color --profile --exclude-only '.*' --include-file "\Aapp,\Alib" -Ispec > coverage/rcov/rcov.txt
+```
+
+#### Simplecov metrics with Ruby 1.9 and 2.0
+
+Add to your Gemfile or otherwise install
+
+```ruby
+gem 'simplecov'
+```
+
+Modify your [spec_helper](https://github.com/metricfu/metric_fu/blob/master/spec/spec_helper.rb) as per the SimpleCov docs and run your tests before running metric_fu
+
+```ruby
+#in your spec_helper
+require 'simplecov'
+require 'metric_fu/metrics/rcov/simplecov_formatter'
+SimpleCov.formatter = SimpleCov::Formatter::MetricFu
+# or
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+  SimpleCov::Formatter::HTMLFormatter,
+  SimpleCov::Formatter::MetricFu
+  ]
+SimpleCov.start
+```
+
+Additionally, the `coverage_file` path must be specified as above and must exist.
 
-### Built-in Formatters
+### Formatters
+
+#### Built-in Formatters
 
 By default, metric_fu will use the built-in html formatter to generate HTML reports for each metric with pretty graphs.
 
@@ -125,7 +188,7 @@ MetricFu::Configuration.run do |config|
 end
 ```
 
-### Custom Formatters
+#### Custom Formatters
 
 You can customize metric_fu's output format with a custom formatter.
 
@@ -161,7 +224,7 @@ your .metrics configuration file.
 
 For instance, to require a formatter in your app's lib directory `require './lib/my_custom_formatter.rb'`
 
-##  Configure Graph Engine
+###  Configure Graph Engine
 
 By default, MetricFu uses the Bluff (JavaScript) graph engine.
 
@@ -178,56 +241,6 @@ MetricFu.configuration.configure_graph_engine(:highcharts)
 Notice: There was previously a :gchart option.
 It was not properly deprecated in the 4.x series.
 
-### Using Coverage Metrics
-
-in your .metrics file add the below to run pre-generated metrics
-
-```ruby
-MetricFu::Configuration.run do |config|
-  config.configure_metric(:rcov) do |rcov|
-    rcov.coverage_file = MetricFu.run_path.join("coverage/rcov/rcov.txt")
-    rcov.enable
-    rcov.activate
-  end
-end
-```
-
-If you want metric_fu to actually run rcov itself (1.8 only), don't specify an external file to read from
-
-#### Rcov metrics with Ruby 1.8
-
-To generate the same metrics metric_fu has been generating run from the root of your project before running metric_fu
-
-```shell
-RAILS_ENV=test rcov $(ruby -e "puts Dir['{spec,test}/**/*_{spec,test}.rb'].join(' ')") --sort coverage --no-html --text-coverage --no-color --profile --exclude-only '.*' --include-file "\Aapp,\Alib" -Ispec > coverage/rcov/rcov.txt
-```
-
-#### Simplecov metrics with Ruby 1.9 and 2.0
-
-Add to your Gemfile or otherwise install
-
-```ruby
-gem 'simplecov'
-```
-
-Modify your [spec_helper](https://github.com/metricfu/metric_fu/blob/master/spec/spec_helper.rb) as per the SimpleCov docs and run your tests before running metric_fu
-
-```ruby
-#in your spec_helper
-require 'simplecov'
-require 'metric_fu/metrics/rcov/simplecov_formatter'
-SimpleCov.formatter = SimpleCov::Formatter::MetricFu
-# or
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
-  SimpleCov::Formatter::HTMLFormatter,
-  SimpleCov::Formatter::MetricFu
-  ]
-SimpleCov.start
-```
-
-Additionally, the `coverage_file` path must be specified as above
-and must exist.
-
 ## Common problems / debugging
 
 - ['ArgumentError; message invalid byte sequence in US-ASCII'](https://github.com/metricfu/metric_fu/issues/215) may be caused by having a default external encoding that is not UTF-8. You can see this in the output of `metric_fu --debug`

data/appveyor.yml

@@ -0,0 +1,34 @@
+version: '{build}'
+image:
+  - Visual Studio 2019
+
+skip_tags: true
+
+environment:
+  matrix:
+    - RUBY_VERSION: 25
+    - RUBY_VERSION: 25-x64
+    - RUBY_VERSION: 26
+    - RUBY_VERSION: 26-x64
+    - RUBY_VERSION: 27
+    - RUBY_VERSION: 27-x64
+
+install:
+  - set PATH=C:\Ruby%RUBY_VERSION%\bin;%PATH%
+  - gem install bundler
+  - bundle config force_ruby_platform true
+  - bundle install --path=vendor/bundle --retry=3 --jobs=3
+
+cache:
+  - vendor/bundle
+
+build: off
+
+before_test:
+  - ruby -v
+  - gem -v
+  - bundle -v
+
+test_script:
+  - bundle exec rspec
+  - bundle exec ruby -Ilib bin/metric_fu --no-open

data/checksum/metric_fu-4.12.0.gem.sha512

@@ -0,0 +1 @@
+5af713f345549aa574af94d5790ec5360d61aa9ff9dce867da339f5a86e1d2d39c23d025434dd98fc04e0912b6a6da64f271663242a5aa75cbf15cac1c9c73e1

data/checksum/metric_fu-4.13.0.gem.sha512

@@ -0,0 +1 @@
+e57d3944216f0d2f9ff06ddabae68cc240510df5a3b346739d866c9dc9e86d5bc7e341efd13f5bc34f5d06bdb90cf455a4491dfc65d2f197bc0ca616ea911f7c

data/lib/metric_fu.rb

@@ -20,6 +20,15 @@ module MetricFu
     "MetricFu"
   end
 
+  def with_run_dir(dir, &block)
+    old_dir = run_dir
+    self.run_dir = dir
+
+    block.call
+
+    self.run_dir = old_dir
+  end
+
   def run_dir
     @run_dir ||= Dir.pwd
   end

data/lib/metric_fu/gem_version.rb

@@ -12,7 +12,7 @@ module MetricFu
     REQUIREMENT_LIST = /(?<qr1>["'])(?<req1>#{REQUIREMENT})\k<qr1>(?:[ \t]*,[ \t]*(?<qr2>["'])(?<req2>#{REQUIREMENT})\k<qr2>)?/
     REQUIREMENTS = /(?:#{REQUIREMENT_LIST}|\[[ \t]*#{REQUIREMENT_LIST}[ \t]*\])/
     COMMENT = /(#[^\n]*)?/
-    ADD_DEPENDENCY_CALL = /^[ \t]*\w+\.add(?<type>_runtime|_development)?_dependency\(?[ \t]*#{QUOTED_GEM_NAME}(?:[ \t]*,[ \t]*#{REQUIREMENTS})?[ \t]*\)?[ \t]*#{COMMENT}$/
+    ADD_DEPENDENCY_CALL = /^[ \t]*\w+\.add(?<type>_runtime|_development)?_dependency\(?[ \t]*#{QUOTED_GEM_NAME}(.freeze)?(?:[ \t]*,[ \t]*#{REQUIREMENTS})?[ \t]*\)?[ \t]*#{COMMENT}$/
 
     def initialize
       @gem_spec = File.open(gemspec, "rb") { |f| f.readlines }

data/lib/metric_fu/generator.rb

@@ -124,7 +124,7 @@ module MetricFu
     end
 
     def self.not_implemented
-      raise <<-EOF
+      raise NotImplementedError.new <<-EOF
         Required method #{caller[0]} not implemented in #{__FILE__}.
         This method must be implemented by a concrete class descending
         from Generator.  See generator class documentation for more

data/lib/metric_fu/io.rb

@@ -59,7 +59,7 @@ module MetricFu
 
       # Add the 'app' directory if we're running within rails.
       def set_code_dirs
-        @directories["code_dirs"] = %w(app lib).select { |dir| Dir.exists?(dir) }
+        @directories["code_dirs"] = %w(app lib).select { |dir| Dir.exist?(dir) }
       end
     end
 

data/lib/metric_fu/metrics/flog/generator.rb

@@ -13,7 +13,7 @@ module MetricFu
         options[:continue] ? "--continue" : nil,
       ].compact
       @flogger = FlogCLI.new parse_options
-      @flogger.flog *options[:dirs_to_flog]
+      @flogger.flog *files_to_flog
     end
 
     def analyze
@@ -51,6 +51,18 @@ module MetricFu
         end
       end
     end
+
+    private
+
+    def files_to_flog
+      options[:dirs_to_flog].flatten.map do |p|
+        if File.directory? p then
+          Dir[File.join(p, '**/*.{rb,rake}')]
+        else
+          p
+        end
+      end.flatten
+    end
   end
 
   class MethodContainer

data/lib/metric_fu/metrics/hotspots/analysis/ranked_problem_location.rb

@@ -12,18 +12,10 @@ module MetricFu
     def to_hash
       {
         "location" => location.to_hash,
-        "details" =>  stringify_keys(problems),
+        "details" =>  MetricFu::Utility.stringify_keys(problems),
       }
     end
 
-    def stringify_keys(hash)
-      result = {}
-      hash.each do |key, value|
-        result[key.to_s] = value
-      end
-      result
-    end
-
     # @todo redo as item,value, options = {}
     # Note that the other option for 'details' is :detailed (this isn't
     # at all clear from this method itself

data/lib/metric_fu/metrics/rails_best_practices/generator.rb

@@ -4,10 +4,14 @@ module MetricFu
       :rails_best_practices
     end
 
+    def initialize(options = {})
+      super(MetricFu::Utility.stringify_keys(options))
+    end
+
     def emit
       mf_debug "** Rails Best Practices"
       path = "."
-      analyzer = ::RailsBestPractices::Analyzer.new(path,  "silent" => true)
+      analyzer = ::RailsBestPractices::Analyzer.new(path, options)
       analyzer.analyze
       @output = analyzer.errors
     end

data/lib/metric_fu/metrics/rails_best_practices/metric.rb

@@ -5,7 +5,10 @@ module MetricFu
     end
 
     def default_run_options
-      {}
+      {
+        silent: true,
+        exclude: []
+      }
     end
 
     def has_graph?

data/lib/metric_fu/metrics/reek/generator.rb

@@ -15,11 +15,13 @@ module MetricFu
     end
 
     def run!(files, config_files)
-      examiner.new(files, config_files)
+      files.map do |file|
+        examiner.new(File.new(file), filter_by_smells: config_files)
+      end
     end
 
     def analyze
-      @matches = @output.smells.group_by(&:source).collect do |file_path, smells|
+      @matches = @output.flat_map(&:smells).group_by(&:source).collect do |file_path, smells|
         { file_path: file_path,
           code_smells: analyze_smells(smells) }
       end

data/lib/metric_fu/templates/metrics_template.rb

@@ -24,6 +24,7 @@ module MetricFu
     end
 
     def html_filename(file)
+      require "digest"
       file = Digest::SHA1.hexdigest(file)[0..29]
       "#{file.gsub(%r{/}, '_')}.html"
     end

data/lib/metric_fu/utility.rb

@@ -19,6 +19,14 @@ module MetricFu
       end
     end
 
+    def stringify_keys(hash)
+      result = {}
+      hash.each do |key, value|
+        result[key.to_s] = value
+      end
+      result
+    end
+
     def strip_escape_codes(text)
       text.gsub(ESCAPE_CODES_PATTERN, "")
     end

data/lib/metric_fu/version.rb

@@ -1,7 +1,7 @@
 module MetricFu
   class Version
     MAJOR = "4"
-    MINOR = "12"
+    MINOR = "13"
     PATCH = "0"
     PRE   = ""
   end

data/metric_fu.gemspec

@@ -19,7 +19,6 @@ Gem::Specification.new do |s|
     s.signing_key = File.join(Gem.user_home, ".ssh", "gem-private_key.pem")
   end
 
-  s.rubyforge_project           = "metric_fu"
   s.license                     = "MIT"
   s.platform                    = Gem::Platform::RUBY
   s.version                     = MetricFu::VERSION
@@ -34,22 +33,20 @@ Gem::Specification.new do |s|
   s.files                       = files
   s.test_files                  = test_files
   s.executables                 = executables
-  s.default_executable          = "metric_fu"
   s.require_paths               = ["lib"]
 
-  s.has_rdoc                    = true
   s.extra_rdoc_files            = ["HISTORY.md", "CONTRIBUTING.md", "TODO.md", "MIT-LICENSE"]
   s.rdoc_options                = ["--main", "README.md"]
 
   # metric dependencies
   s.add_runtime_dependency "flay",                  [">= 2.0.1",  "~> 2.1"]
-  s.add_runtime_dependency "churn",                 ["~> 0.0.35"]
+  s.add_runtime_dependency "churn",                 [">= 1.0.2",  "~> 1.0"]
   s.add_runtime_dependency "flog",                  [">= 4.1.1",  "~> 4.1"]
-  s.add_runtime_dependency "reek",                  [">= 1.3.4",  "< 3.0"]
+  s.add_runtime_dependency "reek",                  [">= 5.4.0"]
   s.add_runtime_dependency "cane",                  [">= 2.5.2",  "~> 2.5"]
   s.add_runtime_dependency "rails_best_practices",  [">= 1.14.3", "~> 1.14"]
   s.add_runtime_dependency "metric_fu-Saikuro",     [">= 1.1.3",  "~> 1.1"]
-  s.add_runtime_dependency "roodi",                 ["~> 3.1"]
+  s.add_runtime_dependency "roodi",                 ["~> 5.0.0"]
   s.add_runtime_dependency "code_metrics",          ["~> 0.1"]
 
   # other dependencies
@@ -67,5 +64,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency "test_construct"
   # ensure we have a JSON parser
   s.add_development_dependency "json"
-  s.add_development_dependency "simplecov", "~> 0.9"
+  s.add_development_dependency "simplecov", "< 0.18"
 end

data/spec/metric_fu/generator_spec.rb

@@ -42,19 +42,19 @@ describe MetricFu::Generator do
   end
 
   describe "#generate_result" do
-    it "should  raise an error when calling #emit" do
+    it "should raise an error when calling #emit" do
       @abstract_class = MetricFu::Generator.new
-      expect { @abstract_class.generate_result }.to raise_error
+      expect { @abstract_class.generate_result }.to raise_error NotImplementedError
     end
 
     it "should call #analyze" do
       @abstract_class = MetricFu::Generator.new
-      expect { @abstract_class.generate_result }.to raise_error
+      expect { @abstract_class.generate_result }.to raise_error NotImplementedError
     end
 
     it "should call #to_h" do
       @abstract_class = MetricFu::Generator.new
-      expect { @abstract_class.generate_result }.to raise_error
+      expect { @abstract_class.generate_result }.to raise_error NotImplementedError
     end
   end
 

data/spec/metric_fu/loader_spec.rb

@@ -4,7 +4,10 @@ describe MetricFu do
   it "loads the .metrics file" do
     # Global only for testing that this file gets loaded
     $metric_file_loaded = false
-    MetricFu.loader.load_user_configuration
+    MetricFu.with_run_dir "spec/support" do
+      MetricFu.loader.load_user_configuration
+    end
+
     expect($metric_file_loaded).to be_truthy
   end
 end

data/spec/metric_fu/metrics/flog/generator_spec.rb

@@ -14,7 +14,8 @@ describe MetricFu::FlogGenerator do
     it "should look for files and flog them" do
       expect(FlogCLI).to receive(:parse_options).with(["--all", "--continue"]).and_return("options")
       expect(FlogCLI).to receive(:new).with("options").and_return(flogger = double("flogger"))
-      expect(flogger).to receive(:flog).with("lib")
+      files_to_flog = Dir[File.join('lib', '**/*.{rb,rake}')]
+      expect(flogger).to receive(:flog).with(*files_to_flog)
       @flog.emit
     end
   end

data/spec/metric_fu/metrics/rails_best_practices/configuration_spec.rb

@@ -20,9 +20,21 @@ describe MetricFu::Configuration, "for rails_best_practices" do
         end
       end
 
-      it "should set @rails_best_practices to {}" do
+      it "should default @rails_best_practices to { :silent => true }" do
         load_metric "rails_best_practices"
-        expect(MetricFu::Metric.get_metric(:rails_best_practices).run_options).to eql({})
+        rbp = MetricFu::MetricRailsBestPractices.new
+        expect(rbp.run_options).to eq(exclude: [], silent: true)
+      end
+
+      it "can configure @rails_best_practices 'exclude' using the sugar" do
+        load_metric "rails_best_practices"
+        rbp = MetricFu::Metric.get_metric(:rails_best_practices)
+        rbp.exclude = ["config/chef"]
+        expect(rbp.run_options).to eq(
+                                     exclude: ["config/chef"],
+                                     silent: true
+                                   )
+
       end
     end
 

data/spec/metric_fu/metrics/reek/generator_spec.rb

@@ -1,4 +1,5 @@
 require "spec_helper"
+
 MetricFu.metrics_require { "reek/generator" }
 
 describe MetricFu::ReekGenerator do
@@ -7,7 +8,7 @@ describe MetricFu::ReekGenerator do
     let(:files_to_analyze) { ["lib/foo.rb", "lib/bar.rb"] }
     let(:reek) { MetricFu::ReekGenerator.new(options) }
 
-    before :each do
+    before(:each) do
       allow(reek).to receive(:files_to_analyze).and_return(files_to_analyze)
     end
 
@@ -42,8 +43,8 @@ describe MetricFu::ReekGenerator do
     before :each do
       MetricFu::Configuration.run {}
       allow(File).to receive(:directory?).and_return(true)
-      @reek = MetricFu::ReekGenerator.new
-      @examiner = @reek.send(:examiner)
+      @generator = MetricFu::ReekGenerator.new
+      @examiner = @generator.send(:examiner)
       @smell_warning = Reek.const_defined?(:SmellWarning) ? Reek.const_get(:SmellWarning) : Reek.const_get(:Smells).const_get(:SmellWarning)
       if @smell_warning.instance_methods.include?(:subclass)
         @smell_warning.send(:alias_method, :smell_type, :subclass)
@@ -99,9 +100,11 @@ describe MetricFu::ReekGenerator do
                             smell_type: "Duplication",
                             lines: [6, 9])
         ]
-        @lines = instance_double(@examiner, smells: @smells)
-        @reek.instance_variable_set(:@output, @lines)
-        @matches = @reek.analyze
+        @examiners = [
+          instance_double(Reek::Examiner, smells: @smells)
+        ]
+        @generator.instance_variable_set(:@output, @examiners)
+        @matches = @generator.analyze
       end
 
       it "should find the code smell's line numbers" do
@@ -143,9 +146,11 @@ describe MetricFu::ReekGenerator do
                    subclass: "Duplication",
                    lines: [2, 4]),
         ]
-        @lines = instance_double(@examiner, smells: @smells)
-        @reek.instance_variable_set(:@output, @lines)
-        @matches = @reek.analyze
+        @examiners = [
+          instance_double(Reek::Examiner, smells: @smells)
+        ]
+        @generator.instance_variable_set(:@output, @examiners)
+        @matches = @generator.analyze
       end
 
       it "uses the subclass field to find the smell type" do
@@ -154,11 +159,40 @@ describe MetricFu::ReekGenerator do
       end
     end
 
+    context "with real output, not mocked nor doubled" do
+      let(:result) do
+        {
+          file_path: "spec/support/samples/reek/alfa.rb",
+          code_smells: [
+            {
+              lines: [1],
+              message: "has unused parameter 'echo'",
+              method: "foo",
+              type: "UnusedParameters"
+            }
+          ]
+        }
+      end
+
+      it "returns real data" do
+        MetricFu.with_run_dir File.expand_path("../../..", __FILE__) do
+          @generator = MetricFu::ReekGenerator.new(dirs_to_reek: ["spec/support/samples"])
+          @generator.emit
+
+          @matches = @generator.analyze
+
+          expect(@matches.first).to eq(result)
+        end
+      end
+    end
+
     context "without reek warnings" do
       before :each do
-        @lines = instance_double(@examiner, smells: [])
-        @reek.instance_variable_set(:@output, @lines)
-        @matches = @reek.analyze
+        @examiners = [
+          instance_double(Reek::Examiner, smells: [])
+        ]
+        @generator.instance_variable_set(:@output, @examiners)
+        @matches = @generator.analyze
       end
 
       it "returns empty analysis" do

data/spec/metric_fu/templates/template_spec.rb

@@ -178,7 +178,7 @@ describe MetricFu::Template do
       it "returns a link with that absolute path" do
         name = "/some/file.rb"
         result = @template.send(:link_to_filename, name)
-        expect(result).to eq("<a href='file:///some/file.rb'>/some/file.rb</a>")
+        expect(result).to match("<a href='file://(.:)?/some/file.rb'>/some/file.rb</a>")
       end
     end
 

data/spec/metric_fu_spec.rb

@@ -2,8 +2,27 @@
 require "spec_helper"
 
 describe MetricFu do
+  before do
+    MetricFu.run_dir = Dir.pwd
+    MetricFu.report_name = nil
+  end
+
+  describe ".with_run_dir" do
+    it "temporarily uses a specified `run_dir`" do
+      expect(MetricFu.run_dir).to eq(Dir.pwd)
+
+      MetricFu.with_run_dir "spec/dummy" do
+        expect(MetricFu.run_dir).to eq("spec/dummy")
+      end
+
+      expect(MetricFu.run_dir).to eq(Dir.pwd)
+    end
+  end
+
   specify "the default report_name is the run directory base name" do
-    expect(MetricFu.report_name).to eq("dummy")
+    MetricFu.with_run_dir "spec/support" do
+      expect(MetricFu.report_name).to eq("support")
+    end
   end
 
   specify "the user can set the report_name" do

data/spec/spec_helper.rb

@@ -36,19 +36,11 @@ RSpec.configure do |config|
   # :each every describe block
   # :all every it block
 
-  def run_dir
-    File.expand_path("dummy", File.dirname(__FILE__))
-  end
-
-  config.before(:suite) do
-    MetricFu.run_dir = run_dir
-  end
-
   config.after(:suite) do
     cleanup_fs
   end
 
-  config.after(:each) do
+  config.append_after do
     MetricFu.reset
   end
 end

data/spec/support/samples/reek/alfa.rb

@@ -0,0 +1 @@
+def foo(echo); end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: metric_fu
 version: !ruby/object:Gem::Version
-  version: 4.12.0
+  version: 4.13.0
 platform: ruby
 authors:
 - Jake Scruggs
@@ -10,7 +10,7 @@ authors:
 - Petrik de Heus
 - Grant McInnes
 - Nick Quaranto
-- "Édouard Brière"
+- Édouard Brière
 - Carl Youngblood
 - Richard Huang
 - Dan Mayer
@@ -20,7 +20,7 @@ autorequire:
 bindir: bin
 cert_chain:
 - certs/bf4.pem
-date: 2015-06-18 00:00:00.000000000 Z
+date: 2020-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flay
@@ -46,16 +46,22 @@ dependencies:
   name: churn
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.2
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.35
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.2
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.35
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: flog
   requirement: !ruby/object:Gem::Requirement
@@ -82,20 +88,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.4
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 5.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.4
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 5.4.0
 - !ruby/object:Gem::Dependency
   name: cane
   requirement: !ruby/object:Gem::Requirement
@@ -162,14 +162,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: code_metrics
   requirement: !ruby/object:Gem::Requirement
@@ -286,16 +286,16 @@ dependencies:
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '0.18'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '0.18'
 description: Code metrics from Flog, Flay, Saikuro, Churn, Reek, Roodi, Code Statistics,
   and Rails Best Practices. (and optionally RCov)
 email: github@benjaminfleischer.com
@@ -333,6 +333,7 @@ files:
 - README.md
 - Rakefile
 - TODO.md
+- appveyor.yml
 - bin/metric_fu
 - bin/mf-cane
 - bin/mf-churn
@@ -348,6 +349,8 @@ files:
 - checksum/metric_fu-4.11.2.gem.sha512
 - checksum/metric_fu-4.11.3.gem.sha512
 - checksum/metric_fu-4.11.4.gem.sha512
+- checksum/metric_fu-4.12.0.gem.sha512
+- checksum/metric_fu-4.13.0.gem.sha512
 - checksum/metric_fu-4.2.0.gem.sha512
 - checksum/metric_fu-4.2.1.gem.sha512
 - checksum/metric_fu-4.3.0.gem.sha512
@@ -504,7 +507,6 @@ files:
 - spec/cli/helper_spec.rb
 - spec/dummy/.gitignore
 - spec/dummy/.gitkeep
-- spec/dummy/.metrics
 - spec/dummy/lib/.gitkeep
 - spec/dummy/lib/bad_encoding.rb
 - spec/dummy/spec/.gitkeep
@@ -596,10 +598,12 @@ files:
 - spec/shared/configured.rb
 - spec/shared/test_coverage.rb
 - spec/spec_helper.rb
+- spec/support/.metrics
 - spec/support/deferred_garbaged_collection.rb
 - spec/support/helper_methods.rb
 - spec/support/matcher_create_file.rb
 - spec/support/matcher_create_files.rb
+- spec/support/samples/reek/alfa.rb
 - spec/support/suite.rb
 - spec/support/test_fixtures.rb
 - spec/support/timeout.rb
@@ -626,8 +630,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubyforge_project: metric_fu
-rubygems_version: 2.4.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: A fistful of code metrics, with awesome templates and graphs
@@ -636,7 +639,6 @@ test_files:
 - spec/cli/helper_spec.rb
 - spec/dummy/.gitignore
 - spec/dummy/.gitkeep
-- spec/dummy/.metrics
 - spec/dummy/lib/.gitkeep
 - spec/dummy/lib/bad_encoding.rb
 - spec/dummy/spec/.gitkeep
@@ -728,13 +730,14 @@ test_files:
 - spec/shared/configured.rb
 - spec/shared/test_coverage.rb
 - spec/spec_helper.rb
+- spec/support/.metrics
 - spec/support/deferred_garbaged_collection.rb
 - spec/support/helper_methods.rb
 - spec/support/matcher_create_file.rb
 - spec/support/matcher_create_files.rb
+- spec/support/samples/reek/alfa.rb
 - spec/support/suite.rb
 - spec/support/test_fixtures.rb
 - spec/support/timeout.rb
 - spec/support/usage_test.rb
 - spec/usage_test_spec.rb
-has_rdoc: true