metric_fu 4.11.1 → 4.11.2

data/spec/metric_fu/gem_version_spec.rb

@@ -3,7 +3,7 @@ MetricFu.lib_require { 'gem_version' }
 
 describe MetricFu::GemVersion do
 
-  it 'has a list of gem deps' do
+  it "has a list of gem deps" do
     gem_version = MetricFu::GemVersion.new
     gem_deps = gem_version.gem_runtime_dependencies.map(&:name)
     MetricFu::Metric.metrics.reject{|metric| metric.name == :hotspots || metric.name == :stats}.map(&:name).map(&:to_s).each do |metric_name|

data/spec/metric_fu/generator_spec.rb

@@ -36,25 +36,25 @@ describe MetricFu::Generator do
     end
   end
 
-  describe '#metric_directory' do
-    it 'should return the results of ConcreteClass#metric_directory' do
+  describe "#metric_directory" do
+    it "should return the results of ConcreteClass#metric_directory" do
       allow(ConcreteClass).to receive(:metric_directory).and_return('foo')
       expect(@concrete_class.metric_directory).to eq('foo')
     end
   end
 
   describe "#generate_result" do
-    it 'should  raise an error when calling #emit' do
+    it "should  raise an error when calling #emit" do
       @abstract_class = MetricFu::Generator.new
       expect { @abstract_class.generate_result }.to  raise_error
     end
 
-    it 'should call #analyze' do
+    it "should call #analyze" do
       @abstract_class = MetricFu::Generator.new
       expect { @abstract_class.generate_result }.to  raise_error
     end
 
-    it 'should call #to_h' do
+    it "should call #to_h" do
       @abstract_class = MetricFu::Generator.new
       expect { @abstract_class.generate_result }.to  raise_error
     end

data/spec/metric_fu/metric_spec.rb

@@ -6,39 +6,39 @@ describe MetricFu::Metric do
     #@original_options = @metric.run_options.dup
   end
 
-  #it 'can have its run_options over-written' do
+  #it "can have its run_options over-written" do
     #new_options = {:foo => 'bar'}
     #@metric.run_options = new_options
     #expect(@original_options).to_not eq(new_options)
     #expect(@metric.run_options).to eq(new_options)
   #end
 
-  #it 'can have its run_options modified' do
+  #it "can have its run_options modified" do
     #new_options = {:foo => 'bar'}
     #@metric.run_options.merge!(new_options)
     #expect(@metric.run_options).to eq(@original_options.merge(new_options))
   #end
 
-  context 'given a valid configurable option' do
+  context "given a valid configurable option" do
 
     before do
       allow(@metric).to receive(:default_run_options).and_return({:foo => 'baz'})
     end
 
-    it 'can be configured as an attribute' do
+    it "can be configured as an attribute" do
       @metric.foo = 'qux'
       expect(@metric.run_options[:foo]).to eq('qux')
     end
 
   end
 
-  context 'given an invalid configurable option' do
+  context "given an invalid configurable option" do
 
     before do
       allow(@metric).to receive(:default_run_options).and_return({})
     end
 
-    it 'raises an error' do
+    it "raises an error" do
       expect { @metric.foo = 'bar' }.to raise_error(RuntimeError, /not a valid configuration option/)
     end
 

data/spec/metric_fu/metrics/churn/configuration_spec.rb

@@ -4,7 +4,7 @@ require 'shared/configured'
 describe MetricFu::Configuration, 'for churn' do
   it_behaves_like 'configured' do
 
-    it 'should set @churn to {}' do
+    it "should set @churn to {}" do
       load_metric 'churn'
       expect(MetricFu::Metric.get_metric(:churn).run_options).to eq(
               { :start_date => %q("1 year ago"), :minimum_churn_count => 10, :ignore_files=>[], :data_directory=> MetricFu::Io::FileSystem.scratch_directory('churn')}

data/spec/metric_fu/metrics/flay/configuration_spec.rb

@@ -4,7 +4,7 @@ require 'shared/configured'
 describe MetricFu::Configuration, 'for flay' do
   it_behaves_like 'configured' do
 
-    it 'should set @flay to {:dirs_to_flay => @code_dirs}' do
+    it "should set @flay to {:dirs_to_flay => @code_dirs}" do
       load_metric 'flay'
       expect(MetricFu::Metric.get_metric(:flay).run_options).to eq(
               {:dirs_to_flay => ['lib'], :minimum_score=>nil}

data/spec/metric_fu/metrics/flog/configuration_spec.rb

@@ -5,7 +5,7 @@ describe MetricFu::Configuration, 'for flog' do
   it_behaves_like 'configured' do
 
     if MetricFu.configuration.mri?
-      it 'should set @flog to {:dirs_to_flog => @code_dirs}' do
+      it "should set @flog to {:dirs_to_flog => @code_dirs}" do
         load_metric 'flog'
         expect(MetricFu::Metric.get_metric(:flog).run_options).to eq({
           :all => true,

data/spec/metric_fu/metrics/rails_best_practices/configuration_spec.rb

@@ -4,7 +4,7 @@ require 'shared/configured'
 describe MetricFu::Configuration, 'for rails_best_practices' do
   it_behaves_like 'configured' do
 
-    describe 'if #rails? is true ' do
+    describe "if #rails? is true " do
 
       before(:each) do
         @config = MetricFu.configuration
@@ -16,20 +16,20 @@ describe MetricFu::Configuration, 'for rails_best_practices' do
         end
       end
 
-      describe '#set_graphs ' do
-        it 'should set the graphs to include rails_best_practices' do
+      describe "#set_graphs " do
+        it "should set the graphs to include rails_best_practices" do
           expect(MetricFu::Metric.get_metric(:rails_best_practices).has_graph?).to be_truthy
         end
       end
 
-      it 'should set @rails_best_practices to {}' do
+      it "should set @rails_best_practices to {}" do
         load_metric 'rails_best_practices'
         expect(MetricFu::Metric.get_metric(:rails_best_practices).run_options).to eql({})
       end
     end
 
 
-    describe 'if #rails? is false ' do
+    describe "if #rails? is false " do
       before(:each) do
         get_new_config
         allow(@config).to receive(:rails?).and_return(false)
@@ -38,7 +38,7 @@ describe MetricFu::Configuration, 'for rails_best_practices' do
         end
       end
 
-      it 'should set the registered code_dirs to ["lib"]' do
+      it "should set the registered code_dirs to ['lib']" do
         expect(directory('code_dirs')).to eq(['lib'])
       end
     end

data/spec/metric_fu/metrics/rcov/configuration_spec.rb

@@ -4,7 +4,7 @@ require 'shared/configured'
 describe MetricFu::Configuration, 'for rcov' do
   it_behaves_like 'configured' do
 
-    it 'should set rcov run_options' do
+    it "should set rcov run_options" do
       load_metric 'rcov'
       expect(
         MetricFu::Metric.get_metric(:rcov).run_options

data/spec/metric_fu/metrics/rcov/simplecov_formatter_spec.rb

@@ -37,7 +37,7 @@ describe SimpleCov::Formatter::MetricFu do
     if defined?(JRUBY_VERSION)
       STDOUT.puts "Skipping spec 'cause JRuby doesn't do Coverage right"
     else
-    it 'calculates the same coverage from an RCov report as from SimpleCov' do
+    it "calculates the same coverage from an RCov report as from SimpleCov" do
       SimpleCov.start # start coverage
       require 'fixtures/coverage-153'
       result = SimpleCov.result # end coverage

data/spec/metric_fu/metrics/reek/configuration_spec.rb

@@ -3,7 +3,7 @@ require 'shared/configured'
 
 describe MetricFu::Configuration, 'for reek' do
   it_behaves_like 'configured' do
-    it 'should set @reek to {:dirs_to_reek => @code_dirs}' do
+    it "should set @reek to {:dirs_to_reek => @code_dirs}" do
       load_metric 'reek'
       expect(MetricFu::Metric.get_metric(:reek).run_options).to eq(
               {:config_file_pattern=>nil, :dirs_to_reek => ['lib']}

data/spec/metric_fu/metrics/reek/generator_spec.rb

@@ -13,29 +13,46 @@ describe MetricFu::ReekGenerator do
 
     it "includes config file pattern into reek parameters when specified" do
       options.merge!({:config_file_pattern => 'lib/config/*.reek' })
-      expect(reek).to receive(:run!).with(/--config lib\/config\/\*\.reek /).and_return("")
+      expect(reek).to receive(:run!) do |args|
+        expect(args).to include('--config lib/config/*.reek')
+      end.and_return('')
+      reek.emit
+    end
+
+    it "doesn't add an empty parameter when no config file pattern is specified" do
+      expect(reek).to receive(:run!) do |args|
+        expect(args).not_to include('')
+      end.and_return('')
       reek.emit
     end
 
     it "turns off color output from reek output, for reek 1.3.7 or greater" do
       allow(reek).to receive(:reek_version).and_return('1.3.7')
-      expect(reek).to receive(:run!).with(/(?=--no-color)/).and_return("")
+      expect(reek).to receive(:run!) do |args|
+        expect(args).to include('--no-color')
+      end.and_return("")
       reek.emit
     end
 
     it "does not set an (invalid) --no-color option for reek < 1.3.7" do
       allow(reek).to receive(:reek_version).and_return('1.3.6')
-      expect(reek).to receive(:run!).with(/(?!--no-color)/).and_return("")
+      expect(reek).to receive(:run!) do |args|
+        expect(args).not_to include('--no-color')
+      end.and_return("")
       reek.emit
     end
 
     it "disables lines numbers from reek output" do
-      expect(reek).to receive(:run!).with(/--no-line-numbers /).and_return("")
+      expect(reek).to receive(:run!) do |args|
+        expect(args).to include('--no-line-numbers')
+      end.and_return("")
       reek.emit
     end
 
     it "includes files to analyze into reek parameters" do
-      expect(reek).to receive(:run!).with(/lib\/foo.rb lib\/bar.rb$/).and_return("")
+      expect(reek).to receive(:run!) do |args|
+        expect(args).to include('lib/foo.rb', 'lib/bar.rb')
+      end.and_return("")
       reek.emit
     end
   end
@@ -153,29 +170,29 @@ app/controllers/newline_controller.rb -- 1 warnings:
       HERE
   end
 
-  context 'with Reek 1.1 output format' do
-    it 'reports 1.1 style when the output is empty' do
+  context "with Reek 1.1 output format" do
+    it "reports 1.1 style when the output is empty" do
       @reek.instance_variable_set(:@output, "")
       expect(@reek).not_to be_reek_12
     end
-    it 'detects 1.1 format output' do
+    it "detects 1.1 format output" do
       @reek.instance_variable_set(:@output, @lines11)
       expect(@reek).not_to be_reek_12
     end
 
-    it 'massages empty output to be unchanged' do
+    it "massages empty output to be unchanged" do
       @reek.instance_variable_set(:@output, "")
       expect(@reek.massage_for_reek_12).to be_empty
     end
   end
 
-  context 'with Reek 1.2 output format' do
-    it 'detects 1.2 format output' do
+  context "with Reek 1.2 output format" do
+    it "detects 1.2 format output" do
       @reek.instance_variable_set(:@output, @lines12)
       expect(@reek).to be_reek_12
     end
 
-    it 'correctly massages 1.2 output' do
+    it "correctly massages 1.2 output" do
       @reek.instance_variable_set(:@output, @lines12)
       expect(@reek.massage_for_reek_12).to eq(@lines11)
     end

data/spec/metric_fu/metrics/roodi/configuration_spec.rb

@@ -4,7 +4,7 @@ require 'shared/configured'
 describe MetricFu::Configuration, 'for roodi' do
   it_behaves_like 'configured' do
 
-    it 'should set @roodi to {:dirs_to_roodi => @code_dirs}' do
+    it "should set @roodi to {:dirs_to_roodi => @code_dirs}" do
       load_metric 'roodi'
       expect(MetricFu::Metric.get_metric(:roodi).run_options).to eq(
               { :dirs_to_roodi => directory('code_dirs'),

data/spec/metric_fu/metrics/stats/generator_spec.rb

@@ -64,7 +64,7 @@ describe StatsGenerator do
       expect(model_data[:loc_per_method]).to eq(7)
     end
 
-    it 'handles code to test ratio is ratio is 1:NaN' do
+    it "handles code to test ratio is ratio is 1:NaN" do
       lines =  <<-HERE.gsub(/^\s*/, "")
       +----------------------+-------+-------+---------+---------+-----+-------+
       | Name                 | Lines |   LOC | Classes | Methods | M/C | LOC/M |

data/spec/metric_fu/reporter_spec.rb

@@ -3,34 +3,34 @@ MetricFu.lib_require { 'reporter' }
 
 describe MetricFu::Reporter do
 
-  context 'given a single formatter' do
+  context "given a single formatter" do
     before do
       @formatter = double('formatter')
       allow(@formatter).to receive(:to_a).and_return([@formatter])
       @reporter = Reporter.new(@formatter)
     end
 
-    it 'notifies the formatter' do
+    it "notifies the formatter" do
       expect(@formatter).to receive(:start)
       expect(@formatter).to receive(:finish)
       @reporter.start
       @reporter.finish
     end
 
-    it 'only sends notifications when supported by formatter' do
+    it "only sends notifications when supported by formatter" do
       allow(@formatter).to receive(:respond_to?).with(:display_results).and_return(false)
       expect(@formatter).not_to receive(:display_results)
       @reporter.display_results
     end
   end
 
-  context 'given multiple formatters' do
+  context "given multiple formatters" do
     before do
       @formatters = [double('formatter'), double('formatter')]
       @reporter = Reporter.new(@formatters)
     end
 
-    it 'notifies all formatters' do
+    it "notifies all formatters" do
       @formatters.each do |formatter|
         expect(formatter).to receive(:start)
         expect(formatter).to receive(:finish)

data/spec/metric_fu/reporting/result_spec.rb

@@ -4,7 +4,7 @@ MetricFu.reporting_require { 'result' }
 describe MetricFu do
 
   describe "#result" do
-    it 'should return an instance of Result' do
+    it "should return an instance of Result" do
       expect(MetricFu.result.instance_of?(Result)).to be(true)
     end
   end
@@ -17,7 +17,7 @@ describe MetricFu::Result do
   end
 
   describe "#as_yaml" do
-    it 'should call #result_hash' do
+    it "should call #result_hash" do
       result_hash = double('result_hash')
       expect(result_hash).to receive(:to_yaml)
 
@@ -30,7 +30,7 @@ describe MetricFu::Result do
   end
 
   describe "#add" do
-    it 'should add a passed hash to the result_hash instance variable' do
+    it "should add a passed hash to the result_hash instance variable" do
       result_type = double('result_type')
       allow(result_type).to receive(:to_s).and_return('type')
 

data/spec/metric_fu/run_spec.rb

@@ -29,7 +29,7 @@ describe MetricFu do
       # limited set, so we can test the basic functionality
       # without significantly slowing down the specs.
       MetricFu.configuration.configure_metrics do |metric|
-        if metric.name == :reek
+        if metric.name == :cane
           metric.enable
           metric.activated = true
           # so this doesn't seem to always be true

data/spec/metric_fu/templates/configuration_spec.rb

@@ -3,7 +3,7 @@ require 'shared/configured'
 
 describe MetricFu::Configuration, 'for templates' do
   it_behaves_like 'configured' do
-    describe 'when there is no CC_BUILD_ARTIFACTS environment variable' do
+    describe "when there is no CC_BUILD_ARTIFACTS environment variable" do
 
       before(:each) do
         ENV['CC_BUILD_ARTIFACTS'] = nil
@@ -17,11 +17,11 @@ describe MetricFu::Configuration, 'for templates' do
     end
 
 
-    it 'should set @template_class to MetricFu::Templates::MetricsTemplate by default' do
+    it "should set @template_class to MetricFu::Templates::MetricsTemplate by default" do
       expect(template_class).to eq(MetricFu::Templates::MetricsTemplate)
     end
 
-    describe 'when a templates configuration is given' do
+    describe "when a templates configuration is given" do
 
       before do
         class DummyTemplate;end
@@ -34,19 +34,19 @@ describe MetricFu::Configuration, 'for templates' do
         end
       end
 
-      it 'should set given template_class' do
+      it "should set given template_class" do
         expect(template_class).to eq(DummyTemplate)
       end
 
-      it 'should set given link_prefix' do
+      it "should set given link_prefix" do
         expect(MetricFu::Formatter::Templates.option('link_prefix')).to eq('http:/')
       end
 
-      it 'should set given darwin_txmt_protocol_no_thanks' do
+      it "should set given darwin_txmt_protocol_no_thanks" do
         expect(MetricFu::Formatter::Templates.option('darwin_txmt_protocol_no_thanks')).to be_falsey
       end
 
-      it 'should set given syntax_highlighting' do
+      it "should set given syntax_highlighting" do
         expect(MetricFu::Formatter::Templates.option('syntax_highlighting')).to be_falsey
       end
 

data/spec/metric_fu/templates/template_spec.rb

@@ -9,7 +9,7 @@ describe MetricFu::Template do
   end
 
   describe "#erbify" do
-    it 'should evaluate a erb doc' do
+    it "should evaluate a erb doc" do
       section = 'section'
       erb = double('erb')
       expect(erb).to receive(:result)
@@ -25,8 +25,8 @@ describe MetricFu::Template do
       @section = double('section')
     end
 
-    describe 'if the template exists' do
-      it 'should return true' do
+    describe "if the template exists" do
+      it "should return true" do
         Tempfile.open('file') do |file|
           expect(@template).to receive(:template).with(@section).and_return(file.path)
           result = @template.send(:template_exists?,@section)
@@ -35,8 +35,8 @@ describe MetricFu::Template do
       end
     end
 
-    describe 'if the template does not exist' do
-      it 'should return false' do
+    describe "if the template does not exist" do
+      it "should return false" do
         path = 'path'
         expect(@template).to receive(:template).with(@section).and_return(path)
         result = @template.send(:template_exists?,@section)
@@ -46,7 +46,7 @@ describe MetricFu::Template do
   end
 
   describe "#create_instance_var" do
-    it 'should set an instance variable with the passed contents' do
+    it "should set an instance variable with the passed contents" do
       section = 'section'
       contents = 'contents'
       @template.send(:create_instance_var, section, contents)
@@ -55,7 +55,7 @@ describe MetricFu::Template do
   end
 
   describe "#template" do
-    it 'should generate the filename of the template file' do
+    it "should generate the filename of the template file" do
       section = double('section')
       allow(section).to receive(:to_s).and_return('section')
       expect(@template).to receive(:template_directory).and_return('dir')
@@ -65,7 +65,7 @@ describe MetricFu::Template do
   end
 
   describe "#output_filename" do
-    it 'should generate the filename of the output file' do
+    it "should generate the filename of the output file" do
       section = double('section')
       expect(section).to receive(:to_s).and_return('section')
       result = @template.send(:output_filename, section)
@@ -74,7 +74,7 @@ describe MetricFu::Template do
   end
 
   describe "#inline_css" do
-    it 'should return the contents of a css file' do
+    it "should return the contents of a css file" do
       css = 'mycss.css'
       dir = File.join(MetricFu.lib_dir, 'templates', css)
       contents = "css contents"
@@ -95,7 +95,7 @@ describe MetricFu::Template do
         allow(MetricFu).to receive(:configuration).and_return(config)
       end
 
-      it 'should return a textmate protocol link' do
+      it "should return a textmate protocol link" do
         expect(@template).to receive(:complete_file_path).with('filename').and_return('/expanded/filename')
         result = @template.send(:link_to_filename, 'filename')
         expect(result).to eql("<a href='txmt://open/?url=file://" \
@@ -153,7 +153,7 @@ describe MetricFu::Template do
         expect(@template).to receive(:complete_file_path).and_return('filename')
       end
 
-      it 'should return a file protocol link' do
+      it "should return a file protocol link" do
         name = "filename"
         result = @template.send(:link_to_filename, name)
         expect(result).to eq("<a href='file://filename'>filename</a>")
@@ -169,7 +169,7 @@ describe MetricFu::Template do
         expect(@template).to receive(:complete_file_path).and_return('filename')
       end
 
-      it 'should return a http protocol link' do
+      it "should return a http protocol link" do
         name = "filename"
         result = @template.send(:link_to_filename, name)
         expect(result).to eq("<a href='http://example.org/files/filename'>filename</a>")
@@ -178,7 +178,7 @@ describe MetricFu::Template do
   end
 
   describe "#cycle" do
-    it 'should return the first_value passed if iteration passed is even' do
+    it "should return the first_value passed if iteration passed is even" do
       first_val = "first"
       second_val = "second"
       iter = 2
@@ -186,7 +186,7 @@ describe MetricFu::Template do
       expect(result).to eq(first_val)
     end
 
-    it 'should return the second_value passed if iteration passed is odd' do
+    it "should return the second_value passed if iteration passed is odd" do
       first_val = "first"
       second_val = "second"
       iter = 1
@@ -196,12 +196,12 @@ describe MetricFu::Template do
   end
 
   describe "#render_partial" do
-    it 'should erbify a partial with the name prefixed with an underscore' do
+    it "should erbify a partial with the name prefixed with an underscore" do
       expect(@template).to receive(:erbify).with('_some_partial')
       @template.send(:render_partial, 'some_partial')
     end
 
-    it 'should set the given instance variables' do
+    it "should set the given instance variables" do
       variables = {:answer => 42}
       allow(@template).to receive(:erbify)
       expect(@template).to receive(:create_instance_vars).with(variables)