metric_fu 4.10.0 → 4.11.0

data/spec/metric_fu/formatter/html_spec.rb

@@ -78,18 +78,15 @@ describe MetricFu::Formatter::HTML do
       ])
     end
 
-    context 'when on OS X' do
-      before do
-        allow(MetricFu.configuration).to receive(:osx?).and_return(true)
-        allow(MetricFu.configuration).to receive(:is_cruise_control_rb?).and_return(false)
-      end
-
-      it "can open the results in the browser" do
-        formatter = MetricFu::Formatter::HTML.new
-        expect(formatter).to receive(:system).with("open #{MetricFu.run_path.join(directory('output_directory')).join('index.html')}")
-        formatter.finish
-        formatter.display_results
-      end
+
+    it "can open the results in the browser" do
+      allow(MetricFu.configuration).to receive(:is_cruise_control_rb?).and_return(false)
+      formatter = MetricFu::Formatter::HTML.new
+      path = MetricFu.run_path.join(directory('output_directory'))
+      uri = URI.join(URI.escape("file://#{path}/"), 'index.html')
+      expect(Launchy).to receive(:open).with(uri)
+      formatter.finish
+      formatter.display_results
     end
 
   end
@@ -129,19 +126,14 @@ describe MetricFu::Formatter::HTML do
       )
     end
 
-    context 'when on OS X' do
-      before do
-        allow(MetricFu.configuration).to receive(:osx?).and_return(true)
-        allow(MetricFu.configuration).to receive(:is_cruise_control_rb?).and_return(false)
-      end
-
-      it "can open the results in the browser from the custom output directory" do
-        formatter = MetricFu::Formatter::HTML.new(output: @output)
-        path = MetricFu.run_path.join("#{directory('base_directory')}/#{@output}/index.html")
-        expect(formatter).to receive(:system).with("open #{path}")
-        formatter.finish
-        formatter.display_results
-      end
+    it "can open the results in the browser from the custom output directory" do
+      allow(MetricFu.configuration).to receive(:is_cruise_control_rb?).and_return(false)
+      formatter = MetricFu::Formatter::HTML.new(output: @output)
+      path = MetricFu.run_path.join("#{directory('base_directory')}/#{@output}")
+      uri = URI.join(URI.escape("file://#{path}/"), 'index.html')
+      expect(Launchy).to receive(:open).with(uri)
+      formatter.finish
+      formatter.display_results
     end
 
   end

data/spec/metric_fu/formatter/yaml_spec.rb

@@ -53,7 +53,7 @@ describe MetricFu::Formatter::YAML do
     end
 
     it "creates a report yaml in the custom stream" do
-      out = MfDebugger::Logger.capture_output {
+      out = MetricFu::Utility.capture_output {
         MetricFu::Formatter::YAML.new(output: @output).finish
       }
       expect(out).to include ":#{@metric1}:"

data/spec/metric_fu/metrics/cane/configuration_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+require 'shared/configured'
+
+describe MetricFu::Configuration, 'for cane' do
+  it_behaves_like 'configured' do
+    if MetricFu.configuration.mri?
+      it 'should set @cane to ' +
+                          %q(:dirs_to_cane => @code_dirs, :abc_max => 15, :line_length => 80, :no_doc => 'n', :no_readme => 'y') do
+        load_metric 'cane'
+        expect(MetricFu::Metric.get_metric(:cane).run_options).to eq(
+          {
+            :dirs_to_cane => directory('code_dirs'),
+            :filetypes => ["rb"],
+            :abc_max => 15,
+            :line_length => 80,
+            :no_doc => "n",
+            :no_readme => "n"}
+            )
+      end
+    end
+  end # end it_behaves
+end

data/spec/metric_fu/metrics/cane/{cane_spec.rb → generator_spec.rb}

@@ -1,5 +1,5 @@
 require 'spec_helper'
-MetricFu.metrics_require { 'cane/cane' }
+MetricFu.metrics_require { 'cane/generator' }
 
 describe CaneGenerator do
   describe "emit method" do

data/spec/metric_fu/metrics/churn/configuration_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+require 'shared/configured'
+
+describe MetricFu::Configuration, 'for churn' do
+  it_behaves_like 'configured' do
+
+    it 'should set @churn to {}' do
+      load_metric 'churn'
+      expect(MetricFu::Metric.get_metric(:churn).run_options).to eq(
+              { :start_date => %q("1 year ago"), :minimum_churn_count => 10, :ignore_files=>[], :data_directory=> MetricFu::Io::FileSystem.scratch_directory('churn')}
+      )
+    end
+
+  end
+end

data/spec/metric_fu/metrics/churn/{churn_spec.rb → generator_spec.rb}

@@ -1,5 +1,5 @@
 require "spec_helper"
-MetricFu.metrics_require { 'churn/churn' }
+MetricFu.metrics_require { 'churn/generator' }
 
 describe MetricFu::ChurnGenerator do
 

data/spec/metric_fu/metrics/flay/configuration_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+require 'shared/configured'
+
+describe MetricFu::Configuration, 'for flay' do
+  it_behaves_like 'configured' do
+
+    it 'should set @flay to {:dirs_to_flay => @code_dirs}' do
+      load_metric 'flay'
+      expect(MetricFu::Metric.get_metric(:flay).run_options).to eq(
+              {:dirs_to_flay => ['lib'], :minimum_score=>nil}
+      )
+    end
+
+  end
+end

data/spec/metric_fu/metrics/flay/{flay_spec.rb → generator_spec.rb}

@@ -1,10 +1,10 @@
 require "spec_helper"
-MetricFu.metrics_require { 'flay/flay' }
+MetricFu.metrics_require { 'flay/generator' }
 
 describe MetricFu::FlayGenerator do
   describe "emit method" do
     it "should look at the dirs" do
-      options = { :dirs_to_flay => ['app', 'lib'], :filetypes => ['rb']  }
+      options = { :dirs_to_flay => ['app', 'lib'] }
       allow(File).to receive(:directory?).and_return(true)
       @flay = MetricFu::FlayGenerator.new(options)
 

data/spec/metric_fu/metrics/flay/{flay_grapher_spec.rb → grapher_spec.rb}

@@ -1,5 +1,5 @@
 require "spec_helper"
-MetricFu.metrics_require { 'flay/flay_grapher' }
+MetricFu.metrics_require { 'flay/grapher' }
 
 describe FlayGrapher do
   before :each do

data/spec/metric_fu/metrics/flog/configuration_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+require 'shared/configured'
+
+describe MetricFu::Configuration, 'for flog' do
+  it_behaves_like 'configured' do
+
+    if MetricFu.configuration.mri?
+      it 'should set @flog to {:dirs_to_flog => @code_dirs}' do
+        load_metric 'flog'
+        expect(MetricFu::Metric.get_metric(:flog).run_options).to eq({
+          :all => true,
+         :continue => true,
+         :dirs_to_flog => ["lib"],
+         :quiet => true
+         })
+      end
+    end
+
+  end
+end

data/spec/metric_fu/metrics/flog/{flog_spec.rb → generator_spec.rb}

@@ -1,5 +1,5 @@
 require "spec_helper"
-MetricFu.metrics_require { 'flog/flog' }
+MetricFu.metrics_require { 'flog/generator' }
 
 describe MetricFu::FlogGenerator do
 

data/spec/metric_fu/metrics/flog/{flog_grapher_spec.rb → grapher_spec.rb}

@@ -1,5 +1,5 @@
 require "spec_helper"
-MetricFu.metrics_require { 'flog/flog_grapher' }
+MetricFu.metrics_require { 'flog/grapher' }
 
 describe MetricFu::FlogGrapher do
   before :each do

data/spec/metric_fu/metrics/hotspots/{hotspots_spec.rb → generator_spec.rb}

@@ -1,5 +1,5 @@
 require "spec_helper"
-MetricFu.metrics_require { 'hotspots/hotspots' }
+MetricFu.metrics_require { 'hotspots/generator' }
 
 describe MetricFu::HotspotsGenerator do
   describe "analyze method" do

data/spec/metric_fu/metrics/rails_best_practices/configuration_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+require 'shared/configured'
+
+describe MetricFu::Configuration, 'for rails_best_practices' do
+  it_behaves_like 'configured' do
+
+    describe 'if #rails? is true ' do
+
+      before(:each) do
+        @config = MetricFu.configuration
+        allow(@config).to receive(:rails?).and_return(true)
+        @config.reset
+        MetricFu.configure
+        %w(rails_best_practices).each do |metric|
+          load_metric metric
+        end
+      end
+
+      describe '#set_graphs ' do
+        it 'should set the graphs to include rails_best_practices' do
+          expect(MetricFu::Metric.get_metric(:rails_best_practices).has_graph?).to be_truthy
+        end
+      end
+
+      it 'should set @rails_best_practices to {}' do
+        load_metric 'rails_best_practices'
+        expect(MetricFu::Metric.get_metric(:rails_best_practices).run_options).to eql({})
+      end
+    end
+
+
+    describe 'if #rails? is false ' do
+      before(:each) do
+        get_new_config
+        allow(@config).to receive(:rails?).and_return(false)
+        %w(rails_best_practices).each do |metric|
+          load_metric metric
+        end
+      end
+
+      it 'should set the registered code_dirs to ["lib"]' do
+        expect(directory('code_dirs')).to eq(['lib'])
+      end
+    end
+
+  end
+end

data/spec/metric_fu/metrics/rails_best_practices/{rails_best_practices_spec.rb → generator_spec.rb}

@@ -1,5 +1,5 @@
 require "spec_helper"
-MetricFu.metrics_require { 'rails_best_practices/rails_best_practices' }
+MetricFu.metrics_require { 'rails_best_practices/generator' }
 
 describe RailsBestPracticesGenerator do
 

data/spec/metric_fu/metrics/rails_best_practices/{rails_best_practices_grapher_spec.rb → grapher_spec.rb}

@@ -1,5 +1,5 @@
 require "spec_helper"
-MetricFu.metrics_require { 'rails_best_practices/rails_best_practices_grapher' }
+MetricFu.metrics_require { 'rails_best_practices/grapher' }
 
 describe RailsBestPracticesGrapher do
   before :each do

data/spec/metric_fu/metrics/rcov/configuration_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+require 'shared/configured'
+
+describe MetricFu::Configuration, 'for rcov' do
+  it_behaves_like 'configured' do
+
+    it 'should set rcov run_options' do
+      load_metric 'rcov'
+      expect(
+        MetricFu::Metric.get_metric(:rcov).run_options
+      ).to eq(
+      {
+        :environment => 'test',
+        :external => nil,
+        :test_files =>  Dir['{spec,test}/**/*_{spec,test}.rb'],
+        :rcov_opts => [
+                "--sort coverage",
+                "--no-html",
+                "--text-coverage",
+                "--no-color",
+                "--profile",
+                "--exclude-only '.*'",
+                '--include-file "\Aapp,\Alib"',
+                "-Ispec"
+              ],
+      })
+    end
+
+  end
+end

data/spec/metric_fu/metrics/rcov/generator_spec.rb

@@ -0,0 +1,26 @@
+require "spec_helper"
+MetricFu.metrics_require { 'rcov/generator' }
+require 'shared/test_coverage'
+
+describe MetricFu::RcovGenerator, "configured as rcov" do
+
+  it_behaves_like "rcov test coverage generator", :rcov do
+
+    describe "emit" do
+      before :each do
+        options = {:external =>  nil}
+        @test_coverage = MetricFu::RcovGenerator.new(@default_options.merge(options))
+      end
+
+      it "should set the RAILS_ENV" do
+        expect(MetricFu::Utility).to receive(:rm_rf).with(MetricFu::RcovGenerator.metric_directory, :verbose => false)
+        expect(MetricFu::Utility).to receive(:mkdir_p).with(MetricFu::RcovGenerator.metric_directory)
+        options = {:environment => 'metrics', :external => nil}
+        @test_coverage = MetricFu::RcovGenerator.new(@default_options.merge(options))
+        expect(@test_coverage.command).to include('RAILS_ENV=metrics')
+      end
+    end
+
+  end
+
+end

data/spec/metric_fu/metrics/rcov/{rcov_grapher_spec.rb → grapher_spec.rb}

@@ -1,5 +1,5 @@
 require "spec_helper"
-MetricFu.metrics_require { 'rcov/rcov_grapher' }
+MetricFu.metrics_require { 'rcov/grapher' }
 
 describe RcovGrapher do
   before :each do

data/spec/metric_fu/metrics/rcov/{rcov_hotspot_spec.rb → hotspot_spec.rb}

@@ -1,8 +1,8 @@
 require "spec_helper"
-MetricFu.metrics_require { 'hotspots/init' }
+MetricFu.metrics_require { 'hotspots/metric' }
 MetricFu.metrics_require { 'hotspots/hotspot' }
 MetricFu.metrics_require { 'hotspots/analysis/record' }
-MetricFu.metrics_require { 'rcov/rcov_hotspot' }
+MetricFu.metrics_require { 'rcov/hotspot' }
 
 describe MetricFu::RcovHotspot do
   describe "map" do

data/spec/metric_fu/metrics/rcov/simplecov_formatter_spec.rb

@@ -1,6 +1,7 @@
 require 'spec_helper'
 require 'simplecov'
 require 'metric_fu/metrics/rcov/simplecov_formatter'
+require 'metric_fu/metrics/rcov/generator'
 
 describe SimpleCov::Formatter::MetricFu do
   before do
@@ -14,8 +15,6 @@ describe SimpleCov::Formatter::MetricFu do
       }
     )
 
-    # Set to default encoding
-    Encoding.default_internal = nil if defined?(Encoding)
   end
 
   it "test_format" do
@@ -24,18 +23,47 @@ describe SimpleCov::Formatter::MetricFu do
     expect(File.exists?( @rcov_file )).to be_truthy
   end
 
-  it "test_encoding" do
-    # This is done in many rails environments
-    Encoding.default_internal = 'UTF-8' if defined?(Encoding)
+  if SimpleCov.running
+    MetricFu.logger.info "Skipping specs while SimpleCov is running"
+  else
+    it "test_create_content" do
+      content = SimpleCov::Formatter::MetricFu::FormatLikeRCov.new(@result).format
+      test = "\="*80
 
-    SimpleCov::Formatter::MetricFu.new.format( @result )
-  end
+      expect(content).to match(/#{test}/)
+      expect(content).to match(/!!     value \* value/)
+    end
+
+    if defined?(JRUBY_VERSION)
+      STDOUT.puts "Skipping spec 'cause JRuby doesn't do Coverage right"
+    else
+    it 'calculates the same coverage from an RCov report as from SimpleCov' do
+      SimpleCov.start # start coverage
+      require 'fixtures/coverage-153'
+      result = SimpleCov.result # end coverage
+      source_file = result.source_files.first
+
+
+      # formatter ouputs this from simplecov result
+      rcov_text = SimpleCov::Formatter::MetricFu::FormatLikeRCov.new(result).format
+
+      # generator analyzes the rcov text
+      analyzed_rcov_text = MetricFu::RCovFormatCoverage.new(rcov_text).to_h
+      # [:lines, :percent_run, :methods]
+      covered_lines_from_rcov_text = analyzed_rcov_text['./spec/fixtures/coverage-153.rb'][:lines]
+      # https://github.com/colszowka/simplecov/blob/master/lib/simplecov/source_file.rb
+      expect(source_file.coverage.count).to eq(covered_lines_from_rcov_text.count)
+
+      line_coverage_from_rcov_text = covered_lines_from_rcov_text.map{|line| line[:was_run] }
+      expect(source_file.coverage).to eq(line_coverage_from_rcov_text)
+
+      expect(source_file.covered_percent).to eq(MetricFu::RCovFormatCoverage::TestCoverage.percent_run(covered_lines_from_rcov_text))
 
-  it "test_create_content" do
-    content = SimpleCov::Formatter::MetricFu::FormatLikeRCov.new(@result).format
-    test = "\="*80
+      source_file.lines.each_with_index do |line, index|
+        expect(line.coverage).to eq(line_coverage_from_rcov_text[index])
+      end
+    end
+    end
 
-    expect(content).to match(/#{test}/)
-    expect(content).to match(/!!     value \* value/)
   end
 end

data/spec/metric_fu/metrics/reek/configuration_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+require 'shared/configured'
+
+describe MetricFu::Configuration, 'for reek' do
+  it_behaves_like 'configured' do
+    it 'should set @reek to {:dirs_to_reek => @code_dirs}' do
+      load_metric 'reek'
+      expect(MetricFu::Metric.get_metric(:reek).run_options).to eq(
+              {:config_file_pattern=>nil, :dirs_to_reek => ['lib']}
+      )
+    end
+  end
+end