metric_fu 4.1.2 → 4.1.3

data/spec/cli/helper_spec.rb

@@ -15,10 +15,6 @@ describe MetricFu::Cli::Helper do
         defaults[:open].should be_true
       end
 
-      it "enables Flog" do
-        defaults[:flog].should be_true
-      end
-
       it "enables Flay" do
         defaults[:flay].should be_true
       end
@@ -39,8 +35,14 @@ describe MetricFu::Cli::Helper do
         defaults[:saikuro].should be_true
       end
 
-      it "enables Cane" do
-        defaults[:cane].should be_true
+      if MetricFu.configuration.mri?
+        it "enables Flog" do
+          !defaults[:flog].should be_true
+        end
+
+        it "enables Cane" do
+          defaults[:cane].should be_true
+        end
       end
 
       it "enables RCov" do
@@ -49,24 +51,26 @@ describe MetricFu::Cli::Helper do
 
     end
 
-    context "on Ruby 1.8.7" do
+    if MetricFu.configuration.mri?
+      context "on Ruby 1.8.7" do
 
-      before { helper.stub(:ruby).and_return("1.8.7") }
+        before { helper.stub(:ruby).and_return("1.8.7") }
+
+        it "disables rails_best_practices" do
+          defaults[:rails_best_practices].should be_false
+        end
 
-      it "disables rails_best_practices" do
-        defaults[:rails_best_practices].should be_false
       end
 
-    end
+      context "on Ruby 1.9" do
 
-    context "on Ruby 1.9" do
+        before { helper.stub(:ruby).and_return("1.9.3") }
 
-      before { helper.stub(:ruby).and_return("1.9.3") }
+        xit "enables Rails Best Practices" do
+          defaults[:rails_best_practices].should be_true
+        end
 
-      xit "enables Rails Best Practices" do
-        defaults[:rails_best_practices].should be_true
       end
-
     end
 
   end
@@ -106,14 +110,27 @@ describe MetricFu::Cli::Helper do
       helper.process_options(["--flay"])[:flay].should be_true
     end
 
-    it "turns flog off" do
-      helper.process_options(["--no-flog"])[:flog].should be_false
-    end
+    if MetricFu.configuration.mri?
+
+      it "turns flog off" do
+        helper.process_options(["--no-flog"])[:flog].should be_false
+      end
+
+      it "turns flog on" do
+        helper.process_options(["--flog"])[:flog].should be_true
+      end
+
+      it "turns cane off" do
+        helper.process_options(["--no-cane"])[:cane].should be_false
+      end
+
+      it "turns cane on" do
+        helper.process_options(["--cane"])[:cane].should be_true
+      end
 
-    it "turns flog on" do
-      helper.process_options(["--flog"])[:flog].should be_true
     end
 
+
     it "turns hotspots off" do
       helper.process_options(["--no-hotspots"])[:hotspots].should be_false
     end
@@ -146,13 +163,6 @@ describe MetricFu::Cli::Helper do
       helper.process_options(["--roodi"])[:roodi].should be_true
     end
 
-    it "turns cane off" do
-      helper.process_options(["--no-cane"])[:cane].should be_false
-    end
-
-    it "turns cane on" do
-      helper.process_options(["--cane"])[:cane].should be_true
-    end
   end
 
 end

data/spec/metric_fu/configuration_spec.rb

@@ -101,12 +101,6 @@ describe MetricFu::Configuration do
                 should == {:dirs_to_flay => ['lib'], :filetypes=>["rb"], :minimum_score => 100}
       end
 
-      it 'should set @flog to {:dirs_to_flog => @code_dirs}' do
-        load_metric 'flog'
-        @config.send(:flog).
-                should == {:dirs_to_flog => ['lib']}
-      end
-
       it 'should set @reek to {:dirs_to_reek => @code_dirs}' do
         load_metric 'reek'
         @config.send(:reek).
@@ -126,18 +120,6 @@ describe MetricFu::Configuration do
                 should == { :start_date => %q("1 year ago"), :minimum_churn_count => 10}
       end
 
-      it 'should set @cane to ' +
-                          %q(:dirs_to_cane => @code_dirs, :abc_max => 15, :line_length => 80, :no_doc => 'n', :no_readme => 'y') do
-        load_metric 'cane'
-        @config.send(:cane).
-          should == {
-            :dirs_to_cane => MetricFu.code_dirs,
-            :filetypes => ["rb"],
-            :abc_max => 15,
-            :line_length => 80,
-            :no_doc => "n",
-            :no_readme => "n"}
-      end
 
       it 'should set @rcov to ' +
                             %q(:test_files =>  Dir['{spec,test}/**/*_{spec,test}.rb'],
@@ -186,6 +168,27 @@ describe MetricFu::Configuration do
                       :formater => "text"}
       end
 
+      if MetricFu.configuration.mri?
+        it 'should set @flog to {:dirs_to_flog => @code_dirs}' do
+          load_metric 'flog'
+          @config.send(:flog).
+                  should == {:dirs_to_flog => ['lib']}
+        end
+        it 'should set @cane to ' +
+                            %q(:dirs_to_cane => @code_dirs, :abc_max => 15, :line_length => 80, :no_doc => 'n', :no_readme => 'y') do
+          load_metric 'cane'
+          @config.send(:cane).
+            should == {
+              :dirs_to_cane => MetricFu.code_dirs,
+              :filetypes => ["rb"],
+              :abc_max => 15,
+              :line_length => 80,
+              :no_doc => "n",
+              :no_readme => "n"}
+        end
+      end
+
+
     end
     describe 'if #rails? is true ' do
 
@@ -240,7 +243,7 @@ describe MetricFu::Configuration do
       end
 
       it 'should set the available metrics' do
-        @config.metrics.should =~ [:churn, :flog, :flay, :reek, :roodi, :rcov, :hotspots, :saikuro, :cane]
+        @config.metrics.should =~ [:churn, :flog, :flay, :reek, :roodi, :rcov, :hotspots, :saikuro, :cane] - MetricFu.mri_only_metrics
       end
 
       it 'should set the @code_dirs instance var to ["lib"]' do
@@ -253,7 +256,10 @@ describe MetricFu::Configuration do
 
     before(:each) { get_new_config }
 
-    [:churn, :flog, :flay, :reek, :roodi, :rcov, :hotspots, :saikuro].each do |metric|
+    (
+      [:churn, :flog, :flay, :reek, :roodi, :rcov, :hotspots, :saikuro] -
+      MetricFu.mri_only_metrics
+    ).each do |metric|
       it "should have a reader for #{metric}" do
         expect {
           @config.send(metric.to_sym)
@@ -272,13 +278,20 @@ describe MetricFu::Configuration do
 
     before(:each) { get_new_config }
 
-    [:churn, :flog, :flay, :reek, :roodi, :rcov, :hotspots, :saikuro, :cane].each do |metric|
+    (
+      [:churn, :flog, :flay, :reek, :roodi, :rcov, :hotspots, :saikuro, :cane] -
+      MetricFu.mri_only_metrics
+
+    ).each do |metric|
       it "should add a #{metric} class method to the MetricFu module " do
         MetricFu.should respond_to(metric)
       end
     end
 
-    [:churn, :flog, :flay, :reek, :roodi, :rcov, :hotspots, :saikuro, :cane].each do |graph|
+    (
+      [:churn, :flog, :flay, :reek, :roodi, :rcov, :hotspots, :saikuro, :cane] -
+      MetricFu.mri_only_metrics
+    ).each do |graph|
       it "should add a #{graph} class metrhod to the MetricFu module" do
         MetricFu.should respond_to(graph)
       end

data/spec/metric_fu/metrics/base_template_spec.rb

@@ -94,21 +94,21 @@ describe MetricFu::Template do
       end
 
       it 'should return a textmate protocol link' do
-        File.stub!(:expand_path).with('filename').and_return('/expanded/filename')
+        @template.should_receive(:complete_file_path).with('filename').and_return('/expanded/filename')
         result = @template.send(:link_to_filename, 'filename')
         result.should eql("<a href='txmt://open/?url=file://" \
                          + "/expanded/filename'>filename</a>")
       end
 
       it "should do the right thing with a filename that starts with a slash" do
-        File.stub!(:expand_path).with('filename').and_return('/expanded/filename')
+        @template.should_receive(:complete_file_path).with('/filename').and_return('/expanded/filename')
         result = @template.send(:link_to_filename, '/filename')
         result.should eql("<a href='txmt://open/?url=file://" \
                          + "/expanded/filename'>/filename</a>")
       end
 
       it "should include a line number" do
-        File.stub!(:expand_path).with('filename').and_return('/expanded/filename')
+        @template.should_receive(:complete_file_path).with('filename').and_return('/expanded/filename')
         result = @template.send(:link_to_filename, 'filename', 6)
         result.should eql("<a href='txmt://open/?url=file://" \
                          + "/expanded/filename&line=6'>filename:6</a>")
@@ -121,7 +121,7 @@ describe MetricFu::Template do
           config.stub!(:darwin_txmt_protocol_no_thanks).and_return(true)
           config.stub!(:link_prefix).and_return(nil)
           MetricFu.stub!(:configuration).and_return(config)
-          File.should_receive(:expand_path).and_return('filename')
+          @template.should_receive(:complete_file_path).and_return('filename')
         end
 
         it "should return a file protocol link" do
@@ -133,7 +133,7 @@ describe MetricFu::Template do
 
       describe "and given link text" do
         it "should use the submitted link text" do
-          File.stub!(:expand_path).with('filename').and_return('/expanded/filename')
+          @template.should_receive(:complete_file_path).with('filename').and_return('/expanded/filename')
           result = @template.send(:link_to_filename, 'filename', 6, 'link content')
           result.should eql("<a href='txmt://open/?url=file://" \
                            + "/expanded/filename&line=6'>link content</a>")
@@ -148,7 +148,7 @@ describe MetricFu::Template do
         config.stub!(:link_prefix).and_return(nil)
         config.stub!(:darwin_txmt_protocol_no_thanks).and_return(false)
         MetricFu.stub!(:configuration).and_return(config)
-        File.should_receive(:expand_path).and_return('filename')
+        @template.should_receive(:complete_file_path).and_return('filename')
       end
 
       it 'should return a file protocol link' do
@@ -162,7 +162,7 @@ describe MetricFu::Template do
         config = mock("configuration")
         config.should_receive(:link_prefix).and_return('http://example.org/files')
         MetricFu.stub!(:configuration).and_return(config)
-        File.should_receive(:expand_path).and_return('filename')
+        @template.should_receive(:complete_file_path).and_return('filename')
       end
 
       it 'should return a http protocol link' do

data/spec/metric_fu/metrics/churn/churn_spec.rb

@@ -33,11 +33,18 @@ describe Churn do
       @changes = {"lib/generators/flog.rb" => 2, "lib/metric_fu.rb" => 3}
     end
 
-    it "should be empty on error" do
+    it "should be empty on error text" do
       churn = MetricFu::Churn.new
       churn.instance_variable_set(:@output, "Churning requires a subversion or git repo")
       result = churn.analyze
-      result.should == [:churn => {}]
+      result.should == {:churn => {}}
+    end
+
+    it "should be empty on error no output captured" do
+      churn = MetricFu::Churn.new
+      churn.instance_variable_set(:@output, nil)
+      result = churn.analyze
+      result.should == {:churn => {}}
     end
 
     it "should return yaml results" do

data/spec/metric_fu/metrics/flog/flog_spec.rb

@@ -1,70 +1,72 @@
 require "spec_helper"
 describe Flog do
-  before :each do
-    MetricFu::Configuration.run {}
-    File.stub!(:directory?).and_return(true)
-    @flog = MetricFu::Flog.new('base_dir')
-  end
+  if MetricFu.configuration.mri?
+    before :each do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      @flog = MetricFu::Flog.new('base_dir')
+    end
 
-  describe "emit method" do
-    it "should look for files and flog them" do
-      Dir.should_receive(:glob).with("lib/**/*.rb").and_return(["found/file.rb"])
-      ::Flog.should_receive(:parse_options).with(["--all", "--details"]).and_return("options")
-      ::Flog.should_receive(:new).with("options").and_return(flogger = mock('flogger'))
-      flogger.should_receive(:flog).with(["found/file.rb"])
-      @flog.emit
+    describe "emit method" do
+      it "should look for files and flog them" do
+        Dir.should_receive(:glob).with("lib/**/*.rb").and_return(["found/file.rb"])
+        ::Flog.should_receive(:parse_options).with(["--all", "--details"]).and_return("options")
+        ::Flog.should_receive(:new).with("options").and_return(flogger = mock('flogger'))
+        flogger.should_receive(:flog).with(["found/file.rb"])
+        @flog.emit
+      end
     end
-  end
 
-  describe "analyze method" do
-    it "should harvest the flog information and put it into method_containers" do
-      first_full_method_name = "ClassName#first_method_name"
-      second_full_method_name = "ClassName#second_method_name"
+    describe "analyze method" do
+      it "should harvest the flog information and put it into method_containers" do
+        first_full_method_name = "ClassName#first_method_name"
+        second_full_method_name = "ClassName#second_method_name"
 
-      flogger = mock('flogger', :calls => {first_full_method_name => {:branch => 11.1, :puts => 1.1},
-                                           second_full_method_name => {:branch => 22.2, :puts => 2.2}},
-                                :method_locations => {first_full_method_name => '/file/location.rb:11',
-                                                      second_full_method_name => '/file/location.rb:22'},
-                                :totals => {first_full_method_name => 11.11,
-                                            second_full_method_name => 22.22})
-      @flog.instance_variable_set(:@flogger, flogger)
-      @flog.analyze
-      method_containers = @flog.instance_variable_get(:@method_containers)
-      method_containers.size.should == 1
+        flogger = mock('flogger', :calls => {first_full_method_name => {:branch => 11.1, :puts => 1.1},
+                                             second_full_method_name => {:branch => 22.2, :puts => 2.2}},
+                                  :method_locations => {first_full_method_name => '/file/location.rb:11',
+                                                        second_full_method_name => '/file/location.rb:22'},
+                                  :totals => {first_full_method_name => 11.11,
+                                              second_full_method_name => 22.22})
+        @flog.instance_variable_set(:@flogger, flogger)
+        @flog.analyze
+        method_containers = @flog.instance_variable_get(:@method_containers)
+        method_containers.size.should == 1
 
-      expected={:methods=>{"ClassName#first_method_name" => { :path=>"/file/location.rb:11",
-                                                              :score=>11.11,
-                                                              :operators=>{ :branch=>11.1,
-                                                                            :puts=>1.1}},
-                           "ClassName#second_method_name" => {:path=>"/file/location.rb:22",
-                                                              :score=>22.22,
-                                                              :operators=>{ :branch=>22.2,
-                                                                            :puts=>2.2}}},
-                :path=>"/file/location.rb",
-                :average_score=>((11.11 + 22.22) / 2.0),
-                :total_score=>33.33,
-                :highest_score=>22.22,
-                :name=>"ClassName"}
+        expected={:methods=>{"ClassName#first_method_name" => { :path=>"/file/location.rb:11",
+                                                                :score=>11.11,
+                                                                :operators=>{ :branch=>11.1,
+                                                                              :puts=>1.1}},
+                             "ClassName#second_method_name" => {:path=>"/file/location.rb:22",
+                                                                :score=>22.22,
+                                                                :operators=>{ :branch=>22.2,
+                                                                              :puts=>2.2}}},
+                  :path=>"/file/location.rb",
+                  :average_score=>((11.11 + 22.22) / 2.0),
+                  :total_score=>33.33,
+                  :highest_score=>22.22,
+                  :name=>"ClassName"}
 
-      method_containers["ClassName"].to_h.should == expected
+        method_containers["ClassName"].to_h.should == expected
+      end
     end
-  end
 
-  describe "to_h method" do
-    it "should make-a nice hash" do
-      flogger = mock('flogger', :total => 111.1, :average => 7.3)
-      @flog.instance_variable_set(:@flogger, flogger)
-      method_containers = {:ignore_me_1 =>  mock('container_1', :highest_score => 11.1, :to_h => 'container_1'),
-                           :ignore_me_2 =>  mock('container_2', :highest_score => 33.3, :to_h => 'container_2'),
-                           :ignore_me_3 =>  mock('container_3', :highest_score => 22.2, :to_h => 'container_3')}
-      @flog.instance_variable_set(:@method_containers, method_containers)
+    describe "to_h method" do
+      it "should make-a nice hash" do
+        flogger = mock('flogger', :total => 111.1, :average => 7.3)
+        @flog.instance_variable_set(:@flogger, flogger)
+        method_containers = {:ignore_me_1 =>  mock('container_1', :highest_score => 11.1, :to_h => 'container_1'),
+                             :ignore_me_2 =>  mock('container_2', :highest_score => 33.3, :to_h => 'container_2'),
+                             :ignore_me_3 =>  mock('container_3', :highest_score => 22.2, :to_h => 'container_3')}
+        @flog.instance_variable_set(:@method_containers, method_containers)
 
-      expected = {:flog => { :total => 111.1,
-                  :average => 7.3,
-                  :method_containers => ['container_2', 'container_3', 'container_1']}}
+        expected = {:flog => { :total => 111.1,
+                    :average => 7.3,
+                    :method_containers => ['container_2', 'container_3', 'container_1']}}
 
-      @flog.to_h.should == expected
-    end
+        @flog.to_h.should == expected
+      end
 
+    end
   end
 end

data/spec/metric_fu/metrics/hotspots/hotspot_analyzer_spec.rb

@@ -448,5 +448,3 @@ __
   end
 
 end
-
-

data/spec/run_spec.rb

@@ -5,18 +5,10 @@ describe MetricFu, "running" do
 
   let(:helper)  { MetricFu::Cli::Helper.new }
 
-  before do
-    FileUtils.rm_rf("tmp/metric_fu")
-  end
-
   it "all these tests should not rely on shelling out to the command line" do
     pending("shelling to bundler is very slow")
   end
 
-  xit "has a clean start" do
-    File.should_not exist("tmp/metric_fu")
-  end
-
   xit "loads the .metrics file" do
     out = metric_fu
     out.should include "Metrics config loaded"