metric_fu 4.1.0 → 4.1.1

data/lib/metric_fu/metrics/hotspots/hotspots.rb

@@ -16,33 +16,7 @@ module MetricFu
     end
 
     def analyze
-      num = nil
-      worst_items = {}
-      if @analyzer
-        worst_items[:files] =
-          @analyzer.worst_files(num).inject([]) do |array, worst_file|
-          array <<
-            {:location => @analyzer.location(:file, worst_file),
-            :details => @analyzer.problems_with(:file, worst_file)}
-          array
-        end
-        worst_items[:classes] = @analyzer.worst_classes(num).inject([]) do |array, class_name|
-          location = @analyzer.location(:class, class_name)
-          array <<
-            {:location => location,
-            :details => @analyzer.problems_with(:class, class_name)}
-          array
-        end
-        worst_items[:methods] = @analyzer.worst_methods(num).inject([]) do |array, method_name|
-          location = @analyzer.location(:method, method_name)
-          array <<
-            {:location => location,
-            :details => @analyzer.problems_with(:method, method_name)}
-          array
-        end
-      end
-
-      @hotspots = worst_items
+      @hotspots = @analyzer && @analyzer.hotspots || {}
     end
 
     def to_h

data/lib/metric_fu/metrics/rails_best_practices/rails_best_practices_bluff_grapher.rb

@@ -0,0 +1,15 @@
+MetricFu.metrics_require   { 'rails_best_practices/rails_best_practices_grapher' }
+module MetricFu
+  class RailsBestPracticesBluffGrapher < RailsBestPracticesGrapher
+    def graph!
+      content = <<-EOS
+        #{BLUFF_DEFAULT_OPTIONS}
+        g.title = 'Rails Best Practices: design problems';
+        g.data('rails_best_practices', [#{@rails_best_practices_count.join(',')}]);
+        g.labels = #{@labels.to_json};
+        g.draw();
+      EOS
+      File.open(File.join(MetricFu.output_directory, 'rails_best_practices.js'), 'w') {|f| f << content }
+    end
+  end
+end

data/lib/metric_fu/metrics/rails_best_practices/rails_best_practices_gchart_grapher.rb

@@ -0,0 +1,21 @@
+MetricFu.metrics_require   { 'rails_best_practices/rails_best_practices_grapher' }
+module MetricFu
+  class RailsBestPracticesGchartGrapher < RailsBestPracticesGrapher
+    def graph!
+      determine_y_axis_scale(@rails_best_practices_count)
+      url = Gchart.line(
+        :size => GCHART_GRAPH_SIZE,
+        :title => URI.escape("Rails Best Practices: design problems"),
+        :data => self.rails_best_practices_count,
+        :bar_colors => COLORS[0..1],
+        :legend => ['Problems'],
+        :custom => "chdlp=t",
+        :max_value => @max_value,
+        :axis_with_labels => 'x,y',
+        :axis_labels => [@labels.values, @yaxis],
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'rails_best_practices.png')
+      )
+    end
+  end
+end

data/lib/metric_fu/metrics/rails_best_practices/rails_best_practices_grapher.rb

@@ -1,3 +1,4 @@
+MetricFu.reporting_require { 'graphs/grapher' }
 module MetricFu
   class RailsBestPracticesGrapher < Grapher
     attr_accessor :rails_best_practices_count, :labels

data/lib/metric_fu/metrics/rcov/rcov_bluff_grapher.rb

@@ -0,0 +1,15 @@
+MetricFu.metrics_require   { 'rcov/rcov_grapher' }
+module MetricFu
+  class RcovBluffGrapher < RcovGrapher
+    def graph!
+      content = <<-EOS
+        #{BLUFF_DEFAULT_OPTIONS}
+        g.title = 'Rcov: code coverage';
+        g.data('rcov', [#{@rcov_percent.join(',')}]);
+        g.labels = #{@labels.to_json};
+        g.draw();
+      EOS
+      File.open(File.join(MetricFu.output_directory, 'rcov.js'), 'w') {|f| f << content }
+    end
+  end
+end

data/lib/metric_fu/metrics/rcov/rcov_gchart_grapher.rb

@@ -0,0 +1,17 @@
+MetricFu.metrics_require   { 'rcov/rcov_grapher' }
+module MetricFu
+  class RcovGchartGrapher < RcovGrapher
+    def graph!
+      url = Gchart.line(
+        :size => GCHART_GRAPH_SIZE,
+        :title => URI.escape("Rcov: code coverage"),
+        :data => self.rcov_percent,
+        :max_value => 101,
+        :axis_with_labels => 'x,y',
+        :axis_labels => [self.labels.values, [0,20,40,60,80,100]],
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'rcov.png')
+      )
+    end
+  end
+end

data/lib/metric_fu/metrics/rcov/rcov_grapher.rb

@@ -1,3 +1,4 @@
+MetricFu.reporting_require { 'graphs/grapher' }
 module MetricFu
   class RcovGrapher < Grapher
     attr_accessor :rcov_percent, :labels

data/lib/metric_fu/metrics/rcov/rcov_hotspot.rb

@@ -1,4 +1,4 @@
-class RcovHotspot
+class RcovHotspot < MetricFu::Hotspot
   include MetricFu::HotspotScoringStrategies
 
   COLUMNS = %w{percentage_uncovered}
@@ -24,20 +24,32 @@ class RcovHotspot
   end
 
   def generate_records(data, table)
-   return if data==nil
-   data.each do |file_name, info|
-     next if (file_name == :global_percent_run) || (info[:methods].nil?)
-     info[:methods].each do |method_name, percentage_uncovered|
-       location = MetricFu::Location.for(method_name)
-       table << {
-         "metric" => :rcov,
-         'file_path' => file_name,
-         'class_name' => location.class_name,
-         "method_name" => location.method_name,
-         "percentage_uncovered" => percentage_uncovered
-       }
-     end
-   end
- end
+    return if data==nil
+    data.each do |file_name, info|
+      next if (file_name == :global_percent_run) || (info[:methods].nil?)
+      info[:methods].each do |method_name, percentage_uncovered|
+        location = MetricFu::Location.for(method_name)
+        table << {
+          "metric" => :rcov,
+          'file_path' => file_name,
+          'class_name' => location.class_name,
+          "method_name" => location.method_name,
+          "percentage_uncovered" => percentage_uncovered
+         }
+      end
+    end
+  end
+
+  def present_group(group)
+    occurences = group.size
+    average_code_uncoverage = get_mean(group.column("percentage_uncovered"))
+    "#{"average " if occurences > 1}uncovered code is %.1f%" % average_code_uncoverage
+  end
+
+  # TODO determine if no-op in pre-factored
+  # code was intentional
+  def present_group_details(group)
+
+  end
 
 end

data/lib/metric_fu/metrics/reek/reek_bluff_grapher.rb

@@ -0,0 +1,20 @@
+MetricFu.metrics_require   { 'reek/reek_grapher' }
+module MetricFu
+  class ReekBluffGrapher < ReekGrapher
+    def graph!
+      legend = @reek_count.keys.sort
+      data = ""
+      legend.each do |name|
+        data += "g.data('#{name}', [#{@reek_count[name].join(',')}])\n"
+      end
+      content = <<-EOS
+        #{BLUFF_DEFAULT_OPTIONS}
+        g.title = 'Reek: code smells';
+        #{data}
+        g.labels = #{@labels.to_json};
+        g.draw();
+      EOS
+      File.open(File.join(MetricFu.output_directory, 'reek.js'), 'w') {|f| f << content }
+    end
+  end
+end

data/lib/metric_fu/metrics/reek/reek_gchart_grapher.rb

@@ -0,0 +1,25 @@
+MetricFu.metrics_require   { 'reek/reek_grapher' }
+module MetricFu
+  class ReekGchartGrapher < ReekGrapher
+    def graph!
+      determine_y_axis_scale(@reek_count.values.flatten.uniq)
+      values = []
+      legend = @reek_count.keys.sort
+      legend.collect {|k| values << @reek_count[k]}
+
+      url = Gchart.line(
+        :size => GCHART_GRAPH_SIZE,
+        :title => URI.escape("Reek: code smells"),
+        :data => values,
+        :stacked => false,
+        :bar_colors => COLORS,
+        :legend => legend,
+        :custom => "chdlp=t",
+        :max_value => @max_value,
+        :axis_with_labels => 'x,y',
+        :axis_labels => [@labels.values, @yaxis],
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'reek.png'))
+    end
+  end
+end

data/lib/metric_fu/metrics/reek/reek_grapher.rb

@@ -1,3 +1,4 @@
+MetricFu.reporting_require { 'graphs/grapher' }
 module MetricFu
   class ReekGrapher < Grapher
     attr_accessor :reek_count, :labels

data/lib/metric_fu/metrics/reek/reek_hotspot.rb

@@ -1,6 +1,6 @@
 # coding: utf-8
 
-class ReekHotspot
+class ReekHotspot < MetricFu::Hotspot
   include MetricFu::HotspotScoringStrategies
 
   REEK_ISSUE_INFO = {
@@ -127,6 +127,21 @@ class ReekHotspot
     ["Large Class", "Long Method", "Long Parameter List"].include?(type)
   end
 
+  def present_group(group)
+    occurences = group.size
+    "found #{occurences} code smells"
+  end
+  def present_group_details(group)
+    occurences = group.size
+    message = "found #{occurences} code smells<br/>"
+    group.each do |item|
+      type    = item.data["reek__type_name"]
+      reek_message = item.data["reek__message"]
+      message << "* #{type}: #{reek_message}<br/>"
+    end
+    message
+  end
+
   private
 
   def comparable_message(type_name, message)

data/lib/metric_fu/metrics/roodi/roodi_bluff_grapher.rb

@@ -0,0 +1,15 @@
+MetricFu.metrics_require   { 'roodi/roodi_grapher' }
+module MetricFu
+  class RoodiBluffGrapher < RoodiGrapher
+    def graph!
+      content = <<-EOS
+        #{BLUFF_DEFAULT_OPTIONS}
+        g.title = 'Roodi: design problems';
+        g.data('roodi', [#{@roodi_count.join(',')}]);
+        g.labels = #{@labels.to_json};
+        g.draw();
+      EOS
+      File.open(File.join(MetricFu.output_directory, 'roodi.js'), 'w') {|f| f << content }
+    end
+  end
+end

data/lib/metric_fu/metrics/roodi/roodi_gchart_grapher.rb

@@ -0,0 +1,17 @@
+MetricFu.metrics_require   { 'roodi/roodi_grapher' }
+module MetricFu
+  class RoodiGchartGrapher < RoodiGrapher
+    def graph!
+      determine_y_axis_scale(@roodi_count)
+      url = Gchart.line(
+        :size => GCHART_GRAPH_SIZE,
+        :title => URI.escape("Roodi: potential design problems"),
+        :data => @roodi_count,
+        :max_value => @max_value,
+        :axis_with_labels => 'x,y',
+        :axis_labels => [@labels.values, @yaxis],
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'roodi.png'))
+    end
+  end
+end

data/lib/metric_fu/metrics/roodi/roodi_grapher.rb

@@ -1,3 +1,4 @@
+MetricFu.reporting_require { 'graphs/grapher' }
 module MetricFu
   class RoodiGrapher < Grapher
     attr_accessor :roodi_count, :labels

data/lib/metric_fu/metrics/roodi/roodi_hotspot.rb

@@ -1,4 +1,4 @@
-class RoodiHotspot
+class RoodiHotspot < MetricFu::Hotspot
   include MetricFu::HotspotScoringStrategies
 
   COLUMNS = %w{problems}
@@ -34,4 +34,19 @@ class RoodiHotspot
     end
   end
 
+  def present_group(group)
+    occurences = group.size
+    "found #{occurences} design problems"
+  end
+
+  def present_group_details(group)
+    occurences = group.size
+    message = "found #{occurences} design problems<br/>"
+    group.each do |item|
+      problem    = item.data["problems"]
+      message << "* #{problem}<br/>"
+    end
+    message
+  end
+
 end

data/lib/metric_fu/metrics/saikuro/saikuro_hotspot.rb

@@ -1,4 +1,4 @@
-class SaikuroHotspot
+class SaikuroHotspot < MetricFu::Hotspot
   include MetricFu::HotspotScoringStrategies
 
   COLUMNS = %w{lines complexity}
@@ -45,4 +45,16 @@ class SaikuroHotspot
     end
   end
 
+  def present_group(group)
+    occurences = group.size
+    complexity = get_mean(group.column("complexity"))
+    "#{"average " if occurences > 1}complexity is %.1f" % complexity
+  end
+
+  def present_group_details(group)
+    occurences = group.size
+    complexity = get_mean(group.column("complexity"))
+    "#{"average " if occurences > 1}complexity is %.1f" % complexity
+  end
+
 end

data/lib/metric_fu/metrics/stats/stats_bluff_grapher.rb

@@ -0,0 +1,16 @@
+MetricFu.metrics_require   { 'stats/stats_grapher' }
+module MetricFu
+  class StatsBluffGrapher < StatsGrapher
+    def graph!
+      content = <<-EOS
+        #{BLUFF_DEFAULT_OPTIONS}
+        g.title = 'Stats: LOC & LOT';
+        g.data('LOC', [#{@loc_counts.join(',')}]);
+        g.data('LOT', [#{@lot_counts.join(',')}])
+        g.labels = #{@labels.to_json};
+        g.draw();
+      EOS
+      File.open(File.join(MetricFu.output_directory, 'stats.js'), 'w') {|f| f << content }
+    end
+  end
+end

data/lib/metric_fu/metrics/stats/stats_gchart_grapher.rb

@@ -0,0 +1,20 @@
+MetricFu.metrics_require   { 'stats/stats_grapher' }
+module MetricFu
+  class StatsGchartGrapher < StatsGrapher
+    def graph!
+      determine_y_axis_scale(@loc_counts + @lot_counts)
+      url = Gchart.line(
+        :size => GCHART_GRAPH_SIZE,
+        :title => URI.escape("Stats: LOC & LOT"),
+        :data => [@loc_counts, @lot_counts],
+        :bar_colors => COLORS[0..1],
+        :legend => ['Lines of code', 'Lines of test'],
+        :custom => "chdlp=t",
+        :max_value => @max_value,
+        :axis_with_labels => 'x,y',
+        :axis_labels => [@labels.values, @yaxis],
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'stats.png'))
+    end
+  end
+end

data/lib/metric_fu/metrics/stats/stats_grapher.rb

@@ -1,3 +1,4 @@
+MetricFu.reporting_require { 'graphs/grapher' }
 module MetricFu
   class StatsGrapher < Grapher
     attr_accessor :loc_counts, :lot_counts, :labels

data/lib/metric_fu/metrics/stats/stats_hotspot.rb

@@ -1,4 +1,4 @@
-class StatsHotspot
+class StatsHotspot < MetricFu::Hotspot
 
   COLUMNS = %w{stat_name stat_value}
 

data/lib/metric_fu/reporting/graphs/engines/bluff.rb

@@ -1,5 +1,3 @@
-require 'active_support'
-
 module MetricFu
   class Grapher
     BLUFF_GRAPH_SIZE = "1000x600"
@@ -12,116 +10,4 @@ module MetricFu
       g.marker_font_size = "10px"
     EOS
   end
-
-  class FlayBluffGrapher < FlayGrapher
-    def graph!
-      content = <<-EOS
-        #{BLUFF_DEFAULT_OPTIONS}
-        g.title = 'Flay: duplication';
-        g.data('flay', [#{@flay_score.join(',')}]);
-        g.labels = #{@labels.to_json};
-        g.draw();
-      EOS
-      File.open(File.join(MetricFu.output_directory, 'flay.js'), 'w') {|f| f << content }
-    end
-  end
-
-  class FlogBluffGrapher < FlogGrapher
-    def graph!
-      content = <<-EOS
-        #{BLUFF_DEFAULT_OPTIONS}
-        g.title = 'Flog: code complexity';
-        g.data('average', [#{@flog_average.join(',')}]);
-        g.data('top 5% average', [#{@top_five_percent_average.join(',')}])
-        g.labels = #{@labels.to_json};
-        g.draw();
-      EOS
-      File.open(File.join(MetricFu.output_directory, 'flog.js'), 'w') {|f| f << content }
-    end
-  end
-
-  class RcovBluffGrapher < RcovGrapher
-    def graph!
-      content = <<-EOS
-        #{BLUFF_DEFAULT_OPTIONS}
-        g.title = 'Rcov: code coverage';
-        g.data('rcov', [#{@rcov_percent.join(',')}]);
-        g.labels = #{@labels.to_json};
-        g.draw();
-      EOS
-      File.open(File.join(MetricFu.output_directory, 'rcov.js'), 'w') {|f| f << content }
-    end
-  end
-
-  class ReekBluffGrapher < ReekGrapher
-    def graph!
-      legend = @reek_count.keys.sort
-      data = ""
-      legend.each do |name|
-        data += "g.data('#{name}', [#{@reek_count[name].join(',')}])\n"
-      end
-      content = <<-EOS
-        #{BLUFF_DEFAULT_OPTIONS}
-        g.title = 'Reek: code smells';
-        #{data}
-        g.labels = #{@labels.to_json};
-        g.draw();
-      EOS
-      File.open(File.join(MetricFu.output_directory, 'reek.js'), 'w') {|f| f << content }
-    end
-  end
-
-  class RoodiBluffGrapher < RoodiGrapher
-    def graph!
-      content = <<-EOS
-        #{BLUFF_DEFAULT_OPTIONS}
-        g.title = 'Roodi: design problems';
-        g.data('roodi', [#{@roodi_count.join(',')}]);
-        g.labels = #{@labels.to_json};
-        g.draw();
-      EOS
-      File.open(File.join(MetricFu.output_directory, 'roodi.js'), 'w') {|f| f << content }
-    end
-  end
-
-  class StatsBluffGrapher < StatsGrapher
-    def graph!
-      content = <<-EOS
-        #{BLUFF_DEFAULT_OPTIONS}
-        g.title = 'Stats: LOC & LOT';
-        g.data('LOC', [#{@loc_counts.join(',')}]);
-        g.data('LOT', [#{@lot_counts.join(',')}])
-        g.labels = #{@labels.to_json};
-        g.draw();
-      EOS
-      File.open(File.join(MetricFu.output_directory, 'stats.js'), 'w') {|f| f << content }
-    end
-  end
-
-  class RailsBestPracticesBluffGrapher < RailsBestPracticesGrapher
-    def graph!
-      content = <<-EOS
-        #{BLUFF_DEFAULT_OPTIONS}
-        g.title = 'Rails Best Practices: design problems';
-        g.data('rails_best_practices', [#{@rails_best_practices_count.join(',')}]);
-        g.labels = #{@labels.to_json};
-        g.draw();
-      EOS
-      File.open(File.join(MetricFu.output_directory, 'rails_best_practices.js'), 'w') {|f| f << content }
-    end
-  end
-
-  class CaneBluffGrapher < CaneGrapher
-    def graph!
-      content = <<-EOS
-        #{BLUFF_DEFAULT_OPTIONS}
-        g.title = 'Cane: code quality threshold violations';
-        g.data('cane', [#{@cane_violations.join(',')}]);
-        g.labels = #{@labels.to_json};
-        g.draw();
-      EOS
-      File.open(File.join(MetricFu.output_directory, 'cane.js'), 'w') {|f| f << content }
-    end
-  end
-
 end