method_man 0.0.2 → 1.0.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 3f6ff20e7c2d99f044220e1ec5ac2f2797e1d69e
+  data.tar.gz: 1c3d343db211b89563d90d542ca55571f7da57f6
+SHA512:
+  metadata.gz: 9ec339e5eb97608a7ef871d8bb2a6481f0e3bdb451de0b887c798ea810133b00afdcdd20398ed084250be4381ab4e36bc3bc7671c6d146e53371fe6e5a822f10
+  data.tar.gz: 5045fc01e0279d6c99dbe8e5dce37bf612e058f4f6da6edd5768f31ed531565ac610300f03327dbad301b81cbf5168626919f0a9e8053c700e7247620f51e51f

data/.ruby-version

@@ -1,2 +1 @@
-1.9.3-p374
-
+2.2.1

data/README.md

@@ -1,31 +1,43 @@
 # Method Man
 
-Defines a MethodObject class which implements Kent Beck's "[method object](http://c2.com/cgi/wiki?MethodObject)".
+Defines a MethodObject class which facilitates basic setup for Kent Beck's "[method object](http://c2.com/cgi/wiki?MethodObject)".
+
+The MethodObject class is largely based on a Ruby Struct, but with a few additional features:
+
+* Facilitates basic method object pattern setup. You only need to supply an instance `call` method.
+* Accepts a list of arguments which are mapped to required keyword arguments.
+* Disallows calling `new` on the resulting MethodObject class instance.
+
+## Bundler usage
+
+```ruby
+gem 'method_man', require: 'method_object'
+```
+
+## Requirements
+* Ruby >= 2.1
 
 ## Example
 
 ```ruby
   require 'method_object'
 
-  MakeArbitraryArray = MethodObject.new do
-    def call(name, age = 21, &test_block)
-      [shortname, age, yield(1), test_value] 
+  MakeArbitraryArray = MethodObject.new(:first_name, :last_name, :message) do
+    def call
+      [fullname, message, 42]
     end
-    
+
     private
-    
-    def shortname
-      # all passed (not optional default) arguments in the
-      # signature for call() are available as instance methods
-      name.slice(0,4).upcase
-    end
-    
-    def test_block_value
-      # block is available to be called by name
-      test_block.call(2)
+
+    def fullname
+      "#{first_name} #{last_name}"
     end
   end
-  
-  MakeArbitraryArray.call(name: 'Elliot') { |input| input + 1 }
-  => ["ELLI", 21, 2, 3]
+
+  MakeArbitraryArray.call(
+    first_name: 'John',
+    last_name: 'Smith',
+    message: 'Hi',
+  )
+  => ["John Smith", 'Hi', 42]
 ```

data/lib/method_object.rb

@@ -1,58 +1,42 @@
 require 'method_object/version'
-require 'method_object/base'
 
 class MethodObject
-  def self.new
-    super.call
+  def self.new(*args, &block)
+    super(*args, block).call
   end
 
-  def initialize(&definition_block)
-    @definition_block = definition_block
+  def initialize(*required_keyword_args, block)
+    @required_keyword_args = required_keyword_args
+    @block = block
   end
 
   def call
-    add_generator
-    add_getters
-    method_object_class
-  end
-
-  def block_name
-    block_parameter.fetch(1)
-  end
-
-  def parameter_names
-    @parameter_names ||= parameters.map(&:last)
-  end
-  
-  def non_block_parameter_names
-    @non_block_parameter_names ||= non_block_parameters.map { |parameter| parameter.fetch(1) }
-  end
-
-  def block_parameter
-    @block_parameter ||= parameters.find { |parameter| parameter[0] == :block }
-  end
-
-  private
-
-  def add_generator
-    method_object_class.instance_variable_set(:@generator, self)
+    code = self.code
+    block = @block
+
+    Struct.new(*@required_keyword_args) do
+      private_class_method :new
+      eval(code)
+      def call
+        fail NotImplementedError, "Please define the call method"
+      end
+      class_eval(&block)
+    end
   end
 
-  def method_object_class
-    @method_object_class ||= Class.new(Base, &@definition_block)
-  end
-  
-  def add_getters
-    parameter_names.each do |parameter_name|
-      method_object_class.send(:attr_reader, parameter_name)
-    end
+  def code
+    <<-CODE
+      def self.call(#{required_keyword_args_string})
+        new(#{ordered_args_string}).call
+      end
+    CODE
   end
 
-  def parameters
-    method_object_class.instance_method(:call).parameters
+  def required_keyword_args_string
+    @required_keyword_args.map { |arg| "#{arg}:" }.join(',')
   end
 
-  def non_block_parameters
-    parameters - [block_parameter]
+  def ordered_args_string
+    @required_keyword_args.join(',')
   end
 end

data/lib/method_object/version.rb

@@ -1,3 +1,3 @@
 class MethodObject
-  VERSION = '0.0.2'
+  VERSION = '1.0.0'
 end

data/method_man.gemspec

@@ -18,9 +18,9 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = %w(lib)
 
-  spec.required_ruby_version = '>= 1.9'
+  spec.required_ruby_version = '>= 2.1'
 
-  spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'bundler', '~> 1.9'
+  spec.add_development_dependency 'rake', '~> 10.4'
+  spec.add_development_dependency 'rspec', '~> 3.2'
 end

data/spec/method_man_spec.rb

@@ -2,61 +2,37 @@ require 'method_object'
 
 describe MethodObject do
   subject do
-    described_class.new do
-      def call(
-        required_arg_1,
-        required_arg_2,
-        optional_arg_1 = :optional_arg_1,
-        optional_arg_2 = :optional_arg_2,
-        &my_block)
-        result << optional_arg_2 << yield(1)
-      end
-
-      def result
-        [
-          required_arg_1,
-          required_arg_2,
-          optional_arg_1,
-          my_block.call(2),
-        ]
-      end
-
-      def required_arg_1
-        :required_arg_1
+    described_class.new(:value_one, :value_two) do
+      def call
+        value_one + value_two
       end
     end
   end
 
+  let(:value_one) { 1 }
+  let(:value_two) { 2 }
+  let(:actual_result) do
+    subject.call(value_one: value_one, value_two: value_two)
+  end
+
   it 'works' do
-    result = subject.call(
-      required_arg_1: :required_arg_1,
-      required_arg_2: :required_arg_2,
-      optional_arg_1: :optional_arg_1,
-      optional_arg_2: :optional_arg_2,
-    ) do |block_arg|
-      block_arg + 1
-    end
+    expect(actual_result).to eq 3
+  end
 
-    expect(result).to eq [
-                           :required_arg_1,
-                           :required_arg_2,
-                           :optional_arg_1,
-                           3,
-                           :optional_arg_2,
-                           2,
-                         ]
+  it 'uses required keyword arguments' do
+    expect { subject.call }.to raise_error ArgumentError
   end
 
-  context 'without arguments' do
-    subject do
-      described_class.new do
-        def call
-        end
-      end
-    end
+  it 'makes new a private class method' do
+    expect { subject.new }.to raise_error NoMethodError
+  end
+
+  context 'without a provided instance call method' do
+    subject { described_class.new(:value_one) {} }
 
-    it 'works' do
-      subject.call
+    it 'raises an error' do
+      expect { subject.call(value_one: value_one) }
+        .to raise_error NotImplementedError
     end
   end
 end

metadata

@@ -1,64 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: method_man
 version: !ruby/object:Gem::Version
-  version: 0.0.2
-  prerelease: 
+  version: 1.0.0
 platform: ruby
 authors:
 - Clay Shentrup
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-19 00:00:00.000000000 Z
+date: 2015-06-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.9'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.4'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.2'
 description: Provides a MethodObject class which implements Kent Beck's "method object"
   pattern.
 email:
@@ -67,16 +60,15 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .ruby-version
+- ".gitignore"
+- ".rspec"
+- ".ruby-version"
 - Gemfile
 - LICENSE
 - LICENSE.txt
 - README.md
 - Rakefile
 - lib/method_object.rb
-- lib/method_object/base.rb
 - lib/method_object/version.rb
 - method_man.gemspec
 - spec/method_man_spec.rb
@@ -84,27 +76,26 @@ files:
 homepage: https://github.com/brokenladder/method_man
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '1.9'
+      version: '2.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.4.5
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Provides a MethodObject class which implements Kent Beck's "method object"
   pattern.
 test_files:

data/lib/method_object/base.rb

@@ -1,27 +0,0 @@
-class MethodObject::Base
-  class << self
-    private :new
-
-    def call(options = {}, &block)
-      new(
-        options,
-        block,
-        @generator)
-      .call(*arguments_from_options(options), &block)
-    end
-
-    private
-
-    def arguments_from_options(options)
-      options.values_at(*@generator.non_block_parameter_names)
-    end
-  end
-
-  def initialize(options, block, generator)
-    options.each do |parameter_name, value|
-      instance_variable_set("@#{parameter_name}", value)
-    end
-    return unless generator.block_parameter
-    instance_variable_set("@#{generator.block_name}", block)
-  end
-end