method_hooks 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6ca8e032aad27caac92b5ae5f3cfead907279c04
-  data.tar.gz: 13f3a3c3ae45be7f97aabbe436f365367d017518
+  metadata.gz: f7e454d3f08fdcc2ee62ede53b2b570decdc8e93
+  data.tar.gz: cb9bf2fc3b04f9b10c65df6b2a3cde887cdf392d
 SHA512:
-  metadata.gz: 2798593f00ac3f6c0ae226c318b0dd4e7e6c497e1b7f462d4b08ec3faf04a724bc30c2f18ced994a43e31c33f59ea441cbae8192dffb3ec66bbe809fdca264d6
-  data.tar.gz: 3563544ebcbc7b928c2cd5389f0e4f4da011fc34cd3738f3172bc5f7eac0238adcc2dd89457afc839ab81f21b4891cbb56df3b5df209371e903f57fc14c92dc1
+  metadata.gz: 18014051b5fc06b6cbd3e2181b32f46c2902a26b30da7c7309135dc235c20185b39a73650a2517f551ca9aecc7a52c88d37d10cceb438e05ac23a790c8b3505c
+  data.tar.gz: ed644fb295f63dbe1d819c686dd68d6d74d0d6d5e77eb7ccfa5a06a042d9543328ecd25a43193c7fe85a5b71960a4357ba5c4d6c4a07686c2888ae22f9d569fc

data/lib/method_hooks/version.rb

@@ -1,3 +1,3 @@
 module MethodHooks
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

data/lib/method_hooks.rb

@@ -1,4 +1,6 @@
 require "method_hooks/version"
+require "active_support/core_ext/class/subclasses"
+require "active_support/core_ext/object/deep_dup"
 
 module MethodHooks
   @new_method = true
@@ -9,6 +11,15 @@ module MethodHooks
 
   private
 
+  def inherited(child_class)
+    child_class.instance_variable_set(:@new_method, true)
+    child_class.instance_variable_set(:@before_callbacks, before_callbacks.deep_dup)
+    child_class.instance_variable_set(:@around_callbacks, around_callbacks.deep_dup)
+    child_class.instance_variable_set(:@after_callbacks, after_callbacks.deep_dup)
+
+    super
+  end
+
   def method_added(method_name)
     super
     return if @new_method == false || [:initialize, :call_before_callbacks, :call_around_callbacks, :call_after_callbacks].include?(method_name)
@@ -45,18 +56,30 @@ module MethodHooks
     method_names.each do |method_name|
       before_callbacks[method_name] << block
     end
+
+    subclasses.each do |subclass|
+      descendant.before(method_names, &block)
+    end
   end
 
   def around(*method_names, &block)
     method_names.each do |method_name|
       around_callbacks[method_name] << block
     end
+
+    subclasses.each do |subclass|
+      descendant.around(method_names, &block)
+    end
   end
 
   def after(*method_names, &block)
     method_names.each do |method_name|
       after_callbacks[method_name] << block
     end
+
+    subclasses.each do |subclass|
+      subclass.after(method_names, &block)
+    end
   end
 
   module InstanceMethods

data/method_hooks.gemspec

@@ -21,4 +21,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.2.0"
+
+  spec.add_dependency "activesupport", "~> 4.1"
 end

data/spec/lib/method_hooks_spec.rb

@@ -103,4 +103,81 @@ describe MethodHooks do
     expect(Base._methods).to include(:some_method)
   end
 
+  describe 'inheritance' do
+    before do
+      Object.send(:remove_const, :Child) if Object.const_defined?(:Child)
+      Object.send(:remove_const, :Grandchild) if Object.const_defined?(:Grandchild)
+    end
+
+    it 'should pass parent hooks to the child' do
+      Base.instance_eval do
+        before(:save) { @events << 'before' }
+        
+        around(:save) do |method|
+          @events << 'before_around'
+          method.call
+          @events << 'after_around'
+        end
+
+        after(:save) { @events << 'after' }
+      end
+
+      class Child < Base; end
+
+      child = Child.new
+      child.save
+
+      expect(child.events).to eq(['before', 'before_around', 'save', 'after_around', 'after'])
+    end
+
+    it 'should not mutate the parent callbacks when a callback is added to a child' do
+      Base.instance_eval do
+        before(:save) { @events << 'parent before' }
+      end
+
+      class Child < Base; end
+
+      Child.instance_eval do
+        before(:save) { @events << 'child before' }
+      end
+
+      child = Child.new
+      child.save
+      parent = Base.new
+      parent.save
+
+      expect(child.events).to eq(['parent before', 'child before', 'save'])
+      expect(parent.events).to eq(['parent before', 'save'])
+    end
+
+    it 'should add callbacks to all descendents of a class, recursively' do
+      Base.instance_eval do
+        before(:save) { @events << 'parent before' }
+      end
+
+      class Child < Base; end
+
+      Child.instance_eval do
+        before(:save) { @events << 'child before' }
+      end
+
+      class Grandchild < Child; end
+
+      Grandchild.instance_eval do
+        before(:save) { @events << 'grandchild before' }
+      end
+
+      parent = Base.new
+      parent.save
+      child = Child.new
+      child.save
+      grandchild = Grandchild.new
+      grandchild.save
+
+
+      expect(parent.events).to eq(['parent before', 'save'])
+      expect(child.events).to eq(['parent before', 'child before', 'save'])
+      expect(grandchild.events).to eq(['parent before', 'child before', 'grandchild before', 'save'])
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: method_hooks
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Frank Bonetti
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-13 00:00:00.000000000 Z
+date: 2015-06-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,6 +52,20 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 3.2.0
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '4.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '4.1'
 description: Rails-style method hooks for plain old Ruby objects
 email:
 - frank.r.bonetti@gmail.com