metasploit_data_models 2.0.17 → 3.0.0

data/spec/app/models/mdm/vuln_spec.rb

@@ -1,16 +1,16 @@
 RSpec.describe Mdm::Vuln, type: :model do
   subject(:vuln) do
-    FactoryGirl.build(:mdm_vuln)
+    FactoryBot.build(:mdm_vuln)
   end
 
   it_should_behave_like 'Metasploit::Concern.run'
 
   context '#destroy' do
     it 'should successfully destroy the object and dependent objects' do
-      vuln = FactoryGirl.create(:mdm_vuln)
-      vuln_attempt = FactoryGirl.create(:mdm_vuln_attempt, :vuln => vuln)
-      vuln_detail = FactoryGirl.create(:mdm_vuln_detail, :vuln => vuln)
-      vuln_ref = FactoryGirl.create(:mdm_vuln_ref, :vuln => vuln)
+      vuln = FactoryBot.create(:mdm_vuln)
+      vuln_attempt = FactoryBot.create(:mdm_vuln_attempt, :vuln => vuln)
+      vuln_detail = FactoryBot.create(:mdm_vuln_detail, :vuln => vuln)
+      vuln_ref = FactoryBot.create(:mdm_vuln_ref, :vuln => vuln)
       expect {
         vuln.destroy
       }.to_not raise_error
@@ -49,20 +49,20 @@ RSpec.describe Mdm::Vuln, type: :model do
       context 'with Mdm::Refs' do
         let(:names) do
           2.times.collect {
-            FactoryGirl.generate :mdm_ref_name
+            FactoryBot.generate :mdm_ref_name
           }
         end
 
         let!(:refs) do
           names.collect do |name|
-            FactoryGirl.create(:mdm_ref, :name => name)
+            FactoryBot.create(:mdm_ref, :name => name)
           end
         end
 
         context 'with Mdm::VulnRefs' do
           let!(:vuln_refs) do
             refs.collect { |ref|
-              FactoryGirl.create(:mdm_vuln_ref, :ref => ref, :vuln => vuln)
+              FactoryBot.create(:mdm_vuln_ref, :ref => ref, :vuln => vuln)
             }
           end
           
@@ -74,7 +74,7 @@ RSpec.describe Mdm::Vuln, type: :model do
           
           context 'with Mdm::Module::Detail' do
             let!(:module_detail) do
-              FactoryGirl.create(
+              FactoryBot.create(
                   :mdm_module_detail
               )
             end
@@ -82,7 +82,7 @@ RSpec.describe Mdm::Vuln, type: :model do
             context 'with Mdm::Module::Refs with same names as Mdm::Refs' do
               let!(:module_refs) do
                 names.each do |name|
-                  FactoryGirl.create(
+                  FactoryBot.create(
                       :mdm_module_ref,
                       :detail => module_detail,
                       :name => name
@@ -149,7 +149,7 @@ RSpec.describe Mdm::Vuln, type: :model do
   context 'factories' do
     context 'mdm_host_vuln' do
       subject(:mdm_host_vuln) do
-        FactoryGirl.build(:mdm_host_vuln)
+        FactoryBot.build(:mdm_host_vuln)
       end
 
       it { is_expected.to be_valid }
@@ -157,7 +157,7 @@ RSpec.describe Mdm::Vuln, type: :model do
 
     context 'mdm_service_vuln' do
       subject(:mdm_service_vuln) do
-        FactoryGirl.build(:mdm_service_vuln)
+        FactoryBot.build(:mdm_service_vuln)
       end
 
       it { is_expected.to be_valid }
@@ -165,7 +165,7 @@ RSpec.describe Mdm::Vuln, type: :model do
 
     context 'mdm_vuln' do
       subject(:mdm_vuln) do
-        FactoryGirl.build(:mdm_vuln)
+        FactoryBot.build(:mdm_vuln)
       end
 
       it { is_expected.to be_valid }
@@ -180,17 +180,17 @@ RSpec.describe Mdm::Vuln, type: :model do
         end
 
         let!(:vuln) do
-          FactoryGirl.create(:mdm_vuln)
+          FactoryBot.create(:mdm_vuln)
         end
 
         context 'with Mdm::Ref' do
           let!(:ref) do
-            FactoryGirl.create(:mdm_ref)
+            FactoryBot.create(:mdm_ref)
           end
 
           context 'with Mdm::VulnRef' do
             let!(:vuln_ref) do
-              FactoryGirl.create(:mdm_vuln_ref, :ref => ref, :vuln => vuln)
+              FactoryBot.create(:mdm_vuln_ref, :ref => ref, :vuln => vuln)
             end
 
             context 'with query matching Mdm::Ref#name' do
@@ -259,7 +259,7 @@ RSpec.describe Mdm::Vuln, type: :model do
 
         context 'with Mdm::Host' do
           context 'with query matching Mdm::Host address' do
-            let(:vuln_with_host) { FactoryGirl.create(:mdm_vuln, :host)}
+            let(:vuln_with_host) { FactoryBot.create(:mdm_vuln, :host)}
             let(:query) { vuln_with_host.host.address}
 
             it 'should match Mdm::Vuln' do
@@ -268,7 +268,7 @@ RSpec.describe Mdm::Vuln, type: :model do
           end
 
           context 'with query matching Mdm::Host name' do
-            let(:vuln_with_host) { FactoryGirl.create(:mdm_vuln, :host)}
+            let(:vuln_with_host) { FactoryBot.create(:mdm_vuln, :host)}
             let(:query) { vuln_with_host.host.name}
 
             it 'should match Mdm::Vuln' do
@@ -285,7 +285,7 @@ RSpec.describe Mdm::Vuln, type: :model do
 
     context "invalid" do
       let(:mdm_vuln) do
-        FactoryGirl.build(:mdm_vuln)
+        FactoryBot.build(:mdm_vuln)
       end
 
       it "should not allow :name over 255 characters" do
@@ -296,4 +296,4 @@ RSpec.describe Mdm::Vuln, type: :model do
       end
     end
   end
-end
+end

data/spec/app/models/mdm/web_form_spec.rb

@@ -27,14 +27,14 @@ RSpec.describe Mdm::WebForm, type: :model do
 
   context 'factory' do
     it 'should be valid' do
-      web_form = FactoryGirl.build(:mdm_web_form)
+      web_form = FactoryBot.build(:mdm_web_form)
       expect(web_form).to be_valid
     end
   end
 
   context '#destroy' do
     it 'should successfully destroy the object' do
-      web_form = FactoryGirl.create(:mdm_web_form)
+      web_form = FactoryBot.create(:mdm_web_form)
       expect {
         web_form.destroy
       }.to_not raise_error
@@ -43,4 +43,4 @@ RSpec.describe Mdm::WebForm, type: :model do
       }.to raise_error(ActiveRecord::RecordNotFound)
     end
   end
-end
+end

data/spec/app/models/mdm/web_page_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Mdm::WebPage, type: :model do
 
   context 'serialized attributes' do
     context 'cookie' do
-      let(:web_page) { FactoryGirl.create(:mdm_web_page, cookie: cookie) }
+      let(:web_page) { FactoryBot.create(:mdm_web_page, cookie: cookie) }
 
       context 'with string cookie' do
         let(:cookie) { "test_name=test_value" }
@@ -82,14 +82,14 @@ RSpec.describe Mdm::WebPage, type: :model do
 
   context 'factory' do
     it 'should be valid' do
-      web_page = FactoryGirl.build(:mdm_web_page)
+      web_page = FactoryBot.build(:mdm_web_page)
       expect(web_page).to be_valid
     end
   end
 
   context '#destroy' do
     it 'should successfully destroy the object' do
-      web_page = FactoryGirl.create(:mdm_web_page)
+      web_page = FactoryBot.create(:mdm_web_page)
       expect {
         web_page.destroy
       }.to_not raise_error
@@ -98,4 +98,4 @@ RSpec.describe Mdm::WebPage, type: :model do
       }.to raise_error(ActiveRecord::RecordNotFound)
     end
   end
-end
+end

data/spec/app/models/mdm/web_site_spec.rb

@@ -3,7 +3,7 @@ RSpec.describe Mdm::WebSite, type: :model do
 
   context 'factory' do
     it 'should be valid' do
-      web_site = FactoryGirl.build(:mdm_web_site)
+      web_site = FactoryBot.build(:mdm_web_site)
       expect(web_site).to be_valid
     end
   end
@@ -31,7 +31,7 @@ RSpec.describe Mdm::WebSite, type: :model do
 
   context '#destroy' do
     it 'should successfully destroy the object' do
-      web_site = FactoryGirl.create(:mdm_web_site)
+      web_site = FactoryBot.create(:mdm_web_site)
       expect {
         web_site.destroy
       }.to_not raise_error
@@ -51,35 +51,35 @@ RSpec.describe Mdm::WebSite, type: :model do
   context 'methods' do
     context '#form_count' do
       it 'should return an accurate count of associated Webforms' do
-        mysite = FactoryGirl.create(:mdm_web_site)
-        FactoryGirl.create(:mdm_web_form, :web_site => mysite)
-        FactoryGirl.create(:mdm_web_form, :web_site => mysite)
+        mysite = FactoryBot.create(:mdm_web_site)
+        FactoryBot.create(:mdm_web_form, :web_site => mysite)
+        FactoryBot.create(:mdm_web_form, :web_site => mysite)
         expect(mysite.form_count).to eq(2)
-        FactoryGirl.create(:mdm_web_form, :web_site => mysite)
+        FactoryBot.create(:mdm_web_form, :web_site => mysite)
         expect(mysite.form_count).to eq(3)
       end
     end
 
     context '#page_count' do
       it 'should return an accurate count of associated Webpages' do
-        mysite = FactoryGirl.create(:mdm_web_site)
-        FactoryGirl.create(:mdm_web_page, :web_site => mysite)
-        FactoryGirl.create(:mdm_web_page, :web_site => mysite)
+        mysite = FactoryBot.create(:mdm_web_site)
+        FactoryBot.create(:mdm_web_page, :web_site => mysite)
+        FactoryBot.create(:mdm_web_page, :web_site => mysite)
         expect(mysite.page_count).to eq(2)
-        FactoryGirl.create(:mdm_web_page, :web_site => mysite)
+        FactoryBot.create(:mdm_web_page, :web_site => mysite)
         expect(mysite.page_count).to eq(3)
       end
     end
 
     context '#vuln_count' do
       it 'should return an accurate count of associated Webvulns' do
-        mysite = FactoryGirl.create(:mdm_web_site)
-        FactoryGirl.create(:mdm_web_vuln, :web_site => mysite)
-        FactoryGirl.create(:mdm_web_vuln, :web_site => mysite)
+        mysite = FactoryBot.create(:mdm_web_site)
+        FactoryBot.create(:mdm_web_vuln, :web_site => mysite)
+        FactoryBot.create(:mdm_web_vuln, :web_site => mysite)
         expect(mysite.vuln_count).to eq(2)
-        FactoryGirl.create(:mdm_web_vuln, :web_site => mysite)
+        FactoryBot.create(:mdm_web_vuln, :web_site => mysite)
         expect(mysite.vuln_count).to eq(3)
       end
     end
   end
-end
+end

data/spec/app/models/mdm/web_vuln_spec.rb

@@ -46,7 +46,7 @@ RSpec.describe Mdm::WebVuln, type: :model do
 
   context '#destroy' do
     it 'should successfully destroy the object' do
-      web_vuln = FactoryGirl.create(:mdm_web_vuln)
+      web_vuln = FactoryBot.create(:mdm_web_vuln)
       expect {
         web_vuln.destroy
       }.to_not raise_error
@@ -91,7 +91,7 @@ RSpec.describe Mdm::WebVuln, type: :model do
   context 'factories' do
     context 'mdm_web_vuln' do
       subject(:mdm_web_vuln) do
-        FactoryGirl.build(:mdm_web_vuln)
+        FactoryBot.build(:mdm_web_vuln)
       end
 
       it { is_expected.to be_valid }
@@ -302,11 +302,11 @@ RSpec.describe Mdm::WebVuln, type: :model do
     end
 
     it 'should return default if set to nil and saved' do
-      web_vuln = FactoryGirl.build(:mdm_web_vuln)
+      web_vuln = FactoryBot.build(:mdm_web_vuln)
       web_vuln.params = nil
       web_vuln.save!
 
       expect(web_vuln.params).to eq(default)
     end
   end
-end
+end

data/spec/app/models/mdm/workspace_spec.rb

@@ -1,6 +1,6 @@
 RSpec.describe Mdm::Workspace, type: :model do
   subject(:workspace) do
-    FactoryGirl.build(:mdm_workspace)
+    FactoryBot.build(:mdm_workspace)
   end
 
   let(:default) do
@@ -11,16 +11,16 @@ RSpec.describe Mdm::Workspace, type: :model do
 
   context 'factory' do
     it 'should be valid' do
-      workspace = FactoryGirl.build(:mdm_workspace)
+      workspace = FactoryBot.build(:mdm_workspace)
       expect(workspace).to be_valid
     end
   end
 
   context '#destroy' do
     it 'should successfully destroy the object and dependent objects' do
-      workspace = FactoryGirl.create(:mdm_workspace)
-      listener = FactoryGirl.create(:mdm_listener, :workspace => workspace)
-      task = FactoryGirl.create(:mdm_task, :workspace => workspace)
+      workspace = FactoryBot.create(:mdm_workspace)
+      listener = FactoryBot.create(:mdm_listener, :workspace => workspace)
+      task = FactoryBot.create(:mdm_task, :workspace => workspace)
 
       expect {
         workspace.destroy
@@ -98,38 +98,38 @@ RSpec.describe Mdm::Workspace, type: :model do
 
   context 'methods' do
     let(:hosts) do
-      FactoryGirl.create_list(:mdm_host, 2, :workspace => workspace)
+      FactoryBot.create_list(:mdm_host, 2, :workspace => workspace)
     end
 
     let(:other_hosts) do
-      FactoryGirl.create_list(:mdm_host, 2, :workspace => other_workspace)
+      FactoryBot.create_list(:mdm_host, 2, :workspace => other_workspace)
     end
 
     let(:other_services) do
       other_hosts.collect do |host|
-        FactoryGirl.create(:mdm_service, :host => host)
+        FactoryBot.create(:mdm_service, :host => host)
       end
     end
 
     let(:other_web_sites) do
       other_services.collect { |service|
-        FactoryGirl.create(:mdm_web_site, :service => service)
+        FactoryBot.create(:mdm_web_site, :service => service)
       }
     end
 
     let(:other_workspace) do
-      FactoryGirl.create(:mdm_workspace)
+      FactoryBot.create(:mdm_workspace)
     end
 
     let(:services) do
       hosts.collect do |host|
-        FactoryGirl.create(:mdm_service, :host => host)
+        FactoryBot.create(:mdm_service, :host => host)
       end
     end
 
     let(:web_sites) do
       services.collect { |service|
-        FactoryGirl.create(:mdm_web_site, :service => service)
+        FactoryBot.create(:mdm_web_site, :service => service)
       }
     end
 
@@ -140,13 +140,13 @@ RSpec.describe Mdm::Workspace, type: :model do
 
       let!(:creds) do
         services.collect do |service|
-          FactoryGirl.create(:mdm_cred, :service => service)
+          FactoryBot.create(:mdm_cred, :service => service)
         end
       end
 
       let!(:other_creds) do
         other_services.collect do |service|
-          FactoryGirl.create(:mdm_cred, :service => service)
+          FactoryBot.create(:mdm_cred, :service => service)
         end
       end
 
@@ -183,7 +183,7 @@ RSpec.describe Mdm::Workspace, type: :model do
     context 'default' do
       context 'with default workspace' do
         before(:example) do
-          FactoryGirl.create(
+          FactoryBot.create(
               :mdm_workspace,
               :name => default
           )
@@ -233,7 +233,7 @@ RSpec.describe Mdm::Workspace, type: :model do
 
     context '#each_cred' do
       it 'should pass each of the #creds to the block' do
-        creds = FactoryGirl.create_list(:mdm_cred, 2)
+        creds = FactoryBot.create_list(:mdm_cred, 2)
         allow(workspace).to receive(:creds).and_return(creds)
 
         expect { |block|
@@ -244,7 +244,7 @@ RSpec.describe Mdm::Workspace, type: :model do
 
     context '#each_host_tag' do
       it 'should pass each of the #host_tags to the block' do
-        tags = FactoryGirl.create_list(:mdm_tag, 2)
+        tags = FactoryBot.create_list(:mdm_tag, 2)
         expect(workspace).to receive(:host_tags).and_return(tags)
 
         expect { |block|
@@ -263,14 +263,14 @@ RSpec.describe Mdm::Workspace, type: :model do
       #
 
       let(:other_tags) do
-        FactoryGirl.create_list(
+        FactoryBot.create_list(
             :mdm_tag,
             2
         )
       end
 
       let(:tags) do
-        FactoryGirl.create_list(
+        FactoryBot.create_list(
             :mdm_tag,
             2
         )
@@ -284,7 +284,7 @@ RSpec.describe Mdm::Workspace, type: :model do
         host_tags = []
 
         hosts.zip(tags) do |host, tag|
-          host_tag = FactoryGirl.create(:mdm_host_tag, :host => host, :tag => tag)
+          host_tag = FactoryBot.create(:mdm_host_tag, :host => host, :tag => tag)
 
           host_tags << host_tag
         end
@@ -296,7 +296,7 @@ RSpec.describe Mdm::Workspace, type: :model do
         host_tags = []
 
         other_hosts.zip(other_tags) do |host, tag|
-          host_tag = FactoryGirl.create(:mdm_host_tag, :host => host, :tag => tag)
+          host_tag = FactoryBot.create(:mdm_host_tag, :host => host, :tag => tag)
 
           host_tags << host_tag
         end
@@ -371,13 +371,13 @@ RSpec.describe Mdm::Workspace, type: :model do
 
       let!(:other_web_forms) do
         other_web_sites.collect { |web_site|
-          FactoryGirl.create(:web_form, :web_site => web_site)
+          FactoryBot.create(:web_form, :web_site => web_site)
         }
       end
 
       let!(:web_forms) do
         web_sites.collect { |web_site|
-          FactoryGirl.create(:web_form, :web_site => web_site)
+          FactoryBot.create(:web_form, :web_site => web_site)
         }
       end
 
@@ -443,13 +443,13 @@ RSpec.describe Mdm::Workspace, type: :model do
 
       let!(:other_web_vulns) do
         other_web_sites.collect { |web_site|
-          FactoryGirl.create(:mdm_web_vuln, :web_site => web_site)
+          FactoryBot.create(:mdm_web_vuln, :web_site => web_site)
         }
       end
 
       let!(:web_vulns) do
         web_sites.collect { |web_site|
-          FactoryGirl.create(:mdm_web_vuln, :web_site => web_site)
+          FactoryBot.create(:mdm_web_vuln, :web_site => web_site)
         }
       end
 

data/spec/app/models/metasploit_data_models/automatic_exploitation/match_result_spec.rb

@@ -15,9 +15,9 @@ RSpec.describe MetasploitDataModels::AutomaticExploitation::MatchResult, type: :
 
   context 'scopes' do
     before do
-      match_failed    = FactoryGirl.create(:automatic_exploitation_match)
-      match_succeeded = FactoryGirl.create(:automatic_exploitation_match)
-      run             = FactoryGirl.create(:automatic_exploitation_run)
+      match_failed    = FactoryBot.create(:automatic_exploitation_match)
+      match_succeeded = FactoryBot.create(:automatic_exploitation_match)
+      run             = FactoryBot.create(:automatic_exploitation_run)
 
       described_class.create do |match_result|
         match_result.match = match_failed
@@ -58,7 +58,7 @@ RSpec.describe MetasploitDataModels::AutomaticExploitation::MatchResult, type: :
   context 'validations' do
     context 'state' do
       subject(:match_result) do
-        FactoryGirl.build(:automatic_exploitation_match_result, state: state)
+        FactoryBot.build(:automatic_exploitation_match_result, state: state)
       end
       context 'with nil' do
         let(:state) { nil }

data/spec/app/models/metasploit_data_models/automatic_exploitation/match_set_spec.rb

@@ -23,7 +23,7 @@ RSpec.describe MetasploitDataModels::AutomaticExploitation::MatchSet, type: :mod
   end
 
   describe "validations" do
-    subject(:match_set){ FactoryGirl.build(:automatic_exploitation_match_set)}
+    subject(:match_set){ FactoryBot.build(:automatic_exploitation_match_set)}
 
     describe "missing user" do
       before(:example) do
@@ -43,4 +43,4 @@ RSpec.describe MetasploitDataModels::AutomaticExploitation::MatchSet, type: :mod
 
   end
 
-end
+end

data/spec/app/models/metasploit_data_models/automatic_exploitation/match_spec.rb

@@ -3,8 +3,8 @@ RSpec.describe MetasploitDataModels::AutomaticExploitation::Match, type: :model
 
   describe "associations" do
     describe "connecting to a Mdm::Module::Detail" do
-      let(:vuln){ FactoryGirl.create(:mdm_vuln) }
-      let(:module_detail){FactoryGirl.create(:mdm_module_detail)}
+      let(:vuln){ FactoryBot.create(:mdm_vuln) }
+      let(:module_detail){FactoryBot.create(:mdm_module_detail)}
 
       subject(:automatic_exploitation_match){ described_class.new }
 
@@ -20,7 +20,7 @@ RSpec.describe MetasploitDataModels::AutomaticExploitation::Match, type: :model
     end
 
     describe "deleting the associated Mdm::Module::Detail" do
-      subject(:automatic_exploitation_match){ FactoryGirl.create(:automatic_exploitation_match) }
+      subject(:automatic_exploitation_match){ FactoryBot.create(:automatic_exploitation_match) }
       let(:match_id){ automatic_exploitation_match.id }
 
       before(:example) do

data/spec/app/models/metasploit_data_models/automatic_exploitation/run_spec.rb

@@ -1,5 +1,5 @@
 RSpec.describe MetasploitDataModels::AutomaticExploitation::Run, type: :model do
-  subject(:run) { FactoryGirl.create(:automatic_exploitation_run) }
+  subject(:run) { FactoryBot.create(:automatic_exploitation_run) }
 
 
   describe "database" do
@@ -23,10 +23,10 @@ RSpec.describe MetasploitDataModels::AutomaticExploitation::Run, type: :model do
   describe "destroying" do
     describe "associated MatchResults" do
       before(:example) do
-        match_set = FactoryGirl.create(:automatic_exploitation_match_set)
-        match = FactoryGirl.create(:automatic_exploitation_match, match_set: match_set)
+        match_set = FactoryBot.create(:automatic_exploitation_match_set)
+        match = FactoryBot.create(:automatic_exploitation_match, match_set: match_set)
         run.match_set = match_set
-        FactoryGirl.create(:automatic_exploitation_match_result, match: match, run: run)
+        FactoryBot.create(:automatic_exploitation_match_result, match: match, run: run)
       end
 
       it 'should happen when you delete the Run' do
@@ -35,4 +35,4 @@ RSpec.describe MetasploitDataModels::AutomaticExploitation::Run, type: :model do
     end
 
   end
-end
+end

data/spec/app/models/metasploit_data_models/module_run_spec.rb

@@ -1,6 +1,6 @@
 RSpec.describe MetasploitDataModels::ModuleRun, type: :model do
 
-  subject(:module_run){FactoryGirl.build(:metasploit_data_models_module_run)}
+  subject(:module_run){FactoryBot.build(:metasploit_data_models_module_run)}
 
   context "database columns" do
     it { is_expected.to have_db_column(:attempted_at).of_type(:datetime) }
@@ -34,7 +34,7 @@ RSpec.describe MetasploitDataModels::ModuleRun, type: :model do
   context "validations" do
     describe "when a target_session is set on the module run" do
       before(:example) do
-        module_run.target_session = FactoryGirl.build(:mdm_session)
+        module_run.target_session = FactoryBot.build(:mdm_session)
       end
 
       context "when the module is an exploit" do
@@ -58,7 +58,7 @@ RSpec.describe MetasploitDataModels::ModuleRun, type: :model do
 
     describe "when a spawned_session is set on the module run" do
       before(:example) do
-        module_run.spawned_session  = FactoryGirl.build(:mdm_session)
+        module_run.spawned_session  = FactoryBot.build(:mdm_session)
       end
 
       context "when the module is not an exploit" do

data/spec/app/models/metasploit_data_models/search/visitor/includes_spec.rb

@@ -101,7 +101,7 @@ RSpec.describe MetasploitDataModels::Search::Visitor::Includes, type: :model do
 
     context 'with Metasploit::Model::Search::Operator::Association' do
       let(:association) do
-        FactoryGirl.generate :metasploit_model_search_operator_association_association
+        FactoryBot.generate :metasploit_model_search_operator_association_association
       end
 
       let(:node) do
@@ -109,10 +109,6 @@ RSpec.describe MetasploitDataModels::Search::Visitor::Includes, type: :model do
             :association => association
         )
       end
-
-      it 'is #association' do
-        expect(visit).to eq(association)
-      end
     end
 
     context 'with Metasploit::Model::Search::Operator::Attribute' do
@@ -151,7 +147,7 @@ RSpec.describe MetasploitDataModels::Search::Visitor::Includes, type: :model do
 
           context 'with name' do
             let(:name) do
-              FactoryGirl.generate :mdm_host_name
+              FactoryBot.generate :mdm_host_name
             end
 
             let(:formatted) do
@@ -163,7 +159,7 @@ RSpec.describe MetasploitDataModels::Search::Visitor::Includes, type: :model do
 
           context 'with services.name' do
             let(:name) do
-              FactoryGirl.generate :mdm_service_name
+              FactoryBot.generate :mdm_service_name
             end
 
             let(:formatted) do
@@ -176,4 +172,4 @@ RSpec.describe MetasploitDataModels::Search::Visitor::Includes, type: :model do
       end
     end
   end
-end
+end