metasploit_data_models 0.7.0 → 0.11.2

data/spec/app/models/mdm/{module_arch_spec.rb → module/arch_spec.rb}

@@ -1,18 +1,18 @@
 require 'spec_helper'
 
-describe Mdm::ModuleArch do
+describe Mdm::Module::Arch do
   context 'associations' do
-    it { should belong_to(:module_detail).class_name('Mdm::ModuleDetail') }
+    it { should belong_to(:detail).class_name('Mdm::Module::Detail') }
   end
 
   context 'database' do
     context 'columns' do
-      it { should have_db_column(:module_detail_id).of_type(:integer) }
+      it { should have_db_column(:detail_id).of_type(:integer) }
       it { should have_db_column(:name).of_type(:text) }
     end
 
     context 'indices' do
-      it { should have_db_index(:module_detail_id) }
+      it { should have_db_index(:detail_id) }
     end
   end
 
@@ -27,12 +27,12 @@ describe Mdm::ModuleArch do
   end
 
   context 'mass assignment security' do
-    it { should_not allow_mass_assignment_of(:module_detail_id) }
+    it { should_not allow_mass_assignment_of(:detail_id) }
     it { should allow_mass_assignment_of(:name) }
   end
 
   context 'validations' do
-    it { should validate_presence_of(:module_detail) }
+    it { should validate_presence_of(:detail) }
     it { should validate_presence_of(:name) }
   end
 end

data/spec/app/models/mdm/{module_author_spec.rb → module/author_spec.rb}

@@ -1,19 +1,19 @@
 require 'spec_helper'
 
-describe Mdm::ModuleAuthor do
+describe Mdm::Module::Author do
   context 'associations' do
-    it { should belong_to(:module_detail).class_name('Mdm::ModuleDetail') }
+    it { should belong_to(:detail).class_name('Mdm::Module::Detail') }
   end
 
   context 'database' do
     context 'columns' do
-      it { should have_db_column(:module_detail_id).of_type(:integer) }
+      it { should have_db_column(:detail_id).of_type(:integer) }
       it { should have_db_column(:name).of_type(:text) }
       it { should have_db_column(:email).of_type(:text) }
     end
 
     context 'indices' do
-      it { should have_db_index(:module_detail_id) }
+      it { should have_db_index(:detail_id) }
     end
   end
 
@@ -37,14 +37,14 @@ describe Mdm::ModuleAuthor do
   end
 
   context 'mass assignment security' do
-    it { should_not allow_mass_assignment_of(:module_detail_id) }
+    it { should_not allow_mass_assignment_of(:detail_id) }
     it { should allow_mass_assignment_of(:email) }
     it { should allow_mass_assignment_of(:name) }
   end
 
   context 'validations' do
+    it { should validate_presence_of(:detail) }
     it { should_not validate_presence_of(:email) }
-    it { should validate_presence_of(:module_detail) }
     it { should validate_presence_of(:name) }
   end
 end

data/spec/app/models/mdm/{module_detail_spec.rb → module/detail_spec.rb}

@@ -1,18 +1,97 @@
 require 'spec_helper'
 
-describe Mdm::ModuleDetail do
+describe Mdm::Module::Detail do
   subject(:module_detail) do
     FactoryGirl.build(:mdm_module_detail)
   end
 
+  let(:ranks) do
+    [
+        0,
+        100,
+        200,
+        300,
+        400,
+        500,
+        600
+    ]
+  end
+
+  let(:stances) do
+    [
+        'aggressive',
+        'passive'
+    ]
+  end
+
+  let(:types) do
+    [
+        'auxiliary',
+        'encoder',
+        'exploit',
+        'nop',
+        'payload',
+        'post'
+    ]
+  end
+
   context 'associations' do
-    it { should have_many(:actions).class_name('Mdm::ModuleAction').dependent(:destroy) }
-    it { should have_many(:archs).class_name('Mdm::ModuleArch').dependent(:destroy) }
-    it { should have_many(:authors).class_name('Mdm::ModuleAuthor').dependent(:destroy) }
-    it { should have_many(:mixins).class_name('Mdm::ModuleMixin').dependent(:destroy) }
-    it { should have_many(:platforms).class_name('Mdm::ModulePlatform').dependent(:destroy) }
-    it { should have_many(:refs).class_name('Mdm::ModuleRef').dependent(:destroy) }
-    it { should have_many(:targets).class_name('Mdm::ModuleTarget').dependent(:destroy) }
+    it { should have_many(:actions).class_name('Mdm::Module::Action').dependent(:destroy) }
+    it { should have_many(:archs).class_name('Mdm::Module::Arch').dependent(:destroy) }
+    it { should have_many(:authors).class_name('Mdm::Module::Author').dependent(:destroy) }
+    it { should have_many(:mixins).class_name('Mdm::Module::Mixin').dependent(:destroy) }
+    it { should have_many(:platforms).class_name('Mdm::Module::Platform').dependent(:destroy) }
+    it { should have_many(:refs).class_name('Mdm::Module::Ref').dependent(:destroy) }
+    it { should have_many(:targets).class_name('Mdm::Module::Target').dependent(:destroy) }
+  end
+
+  context 'CONSTANTS' do
+    context 'DIRECTORY_BY_TYPE' do
+      subject(:directory_by_type) do
+        described_class::DIRECTORY_BY_TYPE
+      end
+
+      its(['auxiliary']) { should == 'auxiliary' }
+      its(['encoder']) { should == 'encoders' }
+      its(['exploit']) { should == 'exploits' }
+      its(['nop']) { should == 'nops' }
+      its(['payload']) { should == 'payloads' }
+      its(['post']) { should == 'post' }
+    end
+
+    context 'PRIVILEGES' do
+      subject(:privileges) do
+        described_class::PRIVILEGES
+      end
+
+      it 'should contain both Boolean values' do
+        privileges.should include(false)
+        privileges.should include(true)
+      end
+    end
+
+    context 'RANK_BY_NAME' do
+      subject(:rank_by_name) do
+        described_class::RANK_BY_NAME
+      end
+
+      its(['Manual']) { should == 0 }
+      its(['Low']) { should == 100 }
+      its(['Average']) { should == 200 }
+      its(['Normal']) { should == 300 }
+      its(['Good']) { should == 400 }
+      its(['Great']) { should == 500 }
+      its(['Excellent']) { should == 600 }
+    end
+
+    context 'STANCES' do
+      subject(:stances) do
+        described_class::STANCES
+      end
+
+      it { should include('aggressive') }
+      it { should include('passive') }
+    end
   end
 
   context 'database' do
@@ -52,7 +131,18 @@ describe Mdm::ModuleDetail do
   end
 
   context 'validations' do
+    it { should ensure_inclusion_of(:mtype).in_array(types) }
+
+    # Because the boolean field will cast most strings to false,
+    # ensure_inclusion_of(:privileged).in_array([true, false]) will fail on the disallowed values check.
+
+    context 'rank' do
+      it { should validate_numericality_of(:rank).only_integer }
+      it { should ensure_inclusion_of(:rank).in_array(ranks) }
+    end
+
     it { should validate_presence_of(:refname) }
+    it { should ensure_inclusion_of(:stance).in_array(stances) }
   end
 
   context 'with saved' do
@@ -69,13 +159,13 @@ describe Mdm::ModuleDetail do
         FactoryGirl.generate :mdm_module_action_name
       end
 
-      it 'should add an Mdm::ModuleAction under the Mdm::ModuleDetail' do
+      it 'should add an Mdm::Action under the Mdm::ModuleDetail' do
         expect {
           add_action
         }.to change(module_detail.actions, :length).by(1)
       end
 
-      context 'new Mdm::ModuleAction' do
+      context 'new Mdm::Action' do
         subject(:module_action) do
           add_action
 
@@ -287,5 +377,5 @@ describe Mdm::ModuleDetail do
         its(:name) { should == name }
       end
     end
-  end
+	end
 end

data/spec/app/models/mdm/{module_mixin_spec.rb → module/mixin_spec.rb}

@@ -1,18 +1,18 @@
 require 'spec_helper'
 
-describe Mdm::ModuleMixin do
+describe Mdm::Module::Mixin do
   context 'associations' do
-    it { should belong_to(:module_detail).class_name('Mdm::ModuleDetail') }
+    it { should belong_to(:detail).class_name('Mdm::Module::Detail') }
   end
 
   context 'database' do
     context 'columns' do
-      it { should have_db_column(:module_detail_id).of_type(:integer) }
+      it { should have_db_column(:detail_id).of_type(:integer) }
       it { should have_db_column(:name).of_type(:text) }
     end
 
     context 'indices' do
-      it { should have_db_index(:module_detail_id) }
+      it { should have_db_index(:detail_id) }
     end
   end
 
@@ -27,12 +27,12 @@ describe Mdm::ModuleMixin do
   end
 
   context 'mass assignment security' do
-    it { should_not allow_mass_assignment_of(:module_detail_id) }
+    it { should_not allow_mass_assignment_of(:detail_id) }
     it { should allow_mass_assignment_of(:name) }
   end
 
   context 'validations' do
-    it { should validate_presence_of(:module_detail) }
+    it { should validate_presence_of(:detail) }
     it { should validate_presence_of(:name) }
   end
 end

data/spec/app/models/mdm/{module_platform_spec.rb → module/platform_spec.rb}

@@ -1,18 +1,18 @@
 require 'spec_helper'
 
-describe Mdm::ModulePlatform do
+describe Mdm::Module::Platform do
   context 'associations' do
-    it { should belong_to(:module_detail).class_name('Mdm::ModuleDetail') }
+    it { should belong_to(:detail).class_name('Mdm::Module::Detail') }
   end
 
   context 'database' do
     context 'columns' do
-      it { should have_db_column(:module_detail_id).of_type(:integer) }
+      it { should have_db_column(:detail_id).of_type(:integer) }
       it { should have_db_column(:name).of_type(:text) }
     end
 
     context 'indices' do
-      it { should have_db_index(:module_detail_id) }
+      it { should have_db_index(:detail_id) }
     end
   end
 
@@ -27,12 +27,12 @@ describe Mdm::ModulePlatform do
   end
 
   context 'mass assignment security' do
-    it { should_not allow_mass_assignment_of(:module_detail_id) }
+    it { should_not allow_mass_assignment_of(:detail_id) }
     it { should allow_mass_assignment_of(:name) }
   end
 
   context 'validations' do
-    it { should validate_presence_of :module_detail }
+    it { should validate_presence_of :detail }
     it { should validate_presence_of :name }
   end
 end

data/spec/app/models/mdm/module/ref_spec.rb

@@ -0,0 +1,62 @@
+require 'spec_helper'
+
+describe Mdm::Module::Ref do
+  context 'associations' do
+    it { should belong_to(:detail).class_name('Mdm::Module::Detail') }
+
+    # shoulda matchers don't have support for :primary_key option, so need
+    # to test this association manually
+    context 'refs' do
+      context 'with Mdm::Refs' do
+        context 'with same name' do
+          let(:name) do
+            FactoryGirl.generate :mdm_module_ref_name
+          end
+
+          let!(:module_ref) do
+            FactoryGirl.create(:mdm_module_ref, :name => name)
+          end
+
+          let!(:ref) do
+            FactoryGirl.create(:mdm_ref, :name => name)
+          end
+
+          it 'should have refs in association' do
+            module_ref.refs.should =~ [ref]
+          end
+        end
+      end
+    end
+  end
+
+  context 'database' do
+    context 'columns' do
+      it { should have_db_column(:detail_id).of_type(:integer) }
+      it { should have_db_column(:name) }
+    end
+
+    context 'indices' do
+      it { should have_db_column(:detail_id) }
+    end
+  end
+
+  context 'factories' do
+    context 'mdm_module_ref' do
+      subject(:mdm_module_ref) do
+        FactoryGirl.build :mdm_module_ref
+      end
+
+      it { should be_valid }
+    end
+  end
+
+  context 'mass assignment security' do
+    it { should_not allow_mass_assignment_of(:detail_id) }
+    it { should allow_mass_assignment_of(:name) }
+  end
+
+  context 'validations' do
+    it { should validate_presence_of(:detail) }
+    it { should validate_presence_of(:name) }
+  end
+end

data/spec/app/models/mdm/{module_target_spec.rb → module/target_spec.rb}

@@ -1,19 +1,19 @@
 require 'spec_helper'
 
-describe Mdm::ModuleTarget do
+describe Mdm::Module::Target do
   context 'associations' do
-    it { should belong_to(:module_detail).class_name('Mdm::ModuleDetail') }
+    it { should belong_to(:detail).class_name('Mdm::Module::Detail') }
   end
 
   context 'database' do
     context 'columns' do
+      it { should have_db_column(:detail_id).of_type(:integer) }
       it { should have_db_column(:index).of_type(:integer) }
-      it { should have_db_column(:module_detail_id).of_type(:integer) }
       it { should have_db_column(:name).of_type(:text) }
     end
 
     context 'indices' do
-      it { should have_db_index(:module_detail_id) }
+      it { should have_db_index(:detail_id) }
     end
   end
 
@@ -28,14 +28,14 @@ describe Mdm::ModuleTarget do
   end
 
   context 'mass assignment security' do
+    it { should_not allow_mass_assignment_of(:detail_id) }
     it { should allow_mass_assignment_of(:index) }
-    it { should_not allow_mass_assignment_of(:module_detail_id) }
     it { should allow_mass_assignment_of(:name) }
   end
 
   context 'validations' do
+    it { should validate_presence_of(:detail) }
     it { should validate_presence_of(:index) }
-    it { should validate_presence_of(:module_detail) }
     it { should validate_presence_of(:name) }
   end
 end

data/spec/app/models/mdm/ref_spec.rb

@@ -0,0 +1,62 @@
+require 'spec_helper'
+
+describe Mdm::Ref do
+  context 'associations' do
+    # shoulda matchers don't have support for :primary_key option, so need to
+    # test this association manually
+    context 'module_refs' do
+      context 'with Mdm::Module::Refs' do
+        context 'with same name' do
+          let(:name) do
+            FactoryGirl.generate :mdm_ref_name
+          end
+
+          let!(:module_ref) do
+            FactoryGirl.create(:mdm_module_ref, :name => name)
+          end
+
+          let!(:ref) do
+            FactoryGirl.create(:mdm_ref, :name => name)
+          end
+
+          it 'should have module_refs in assocation' do
+            ref.module_refs.should =~ [module_ref]
+          end
+        end
+      end
+    end
+
+    # @todo https://www.pivotaltracker.com/story/show/48915453
+    it { should have_many(:vulns_refs).class_name('Mdm::VulnRef') }
+  end
+
+  context 'database' do
+    context 'columns' do
+      it { should have_db_column(:name).of_type(:string) }
+      it { should have_db_column(:ref_id).of_type(:integer) }
+
+      context 'timestamps' do
+        it { should have_db_column(:created_at).of_type(:datetime) }
+        it { should have_db_column(:updated_at).of_type(:datetime) }
+      end
+    end
+
+    context 'indices' do
+      it { should have_db_index(:name) }
+    end
+  end
+
+  context 'factories' do
+    context 'mdm_ref' do
+      subject(:mdm_ref) do
+        FactoryGirl.build :mdm_ref
+      end
+
+      it { should be_valid }
+    end
+  end
+
+  context 'mass assignment security' do
+    it { should allow_mass_assignment_of(:name) }
+  end
+end