metar-parser 1.5.0 → 1.6.0

data/lib/metar/data/weather_phenomenon.rb

@@ -1,86 +1,104 @@
+# frozen_string_literal: true
+
 require "metar/i18n"
 
-class Metar::Data::WeatherPhenomenon < Metar::Data::Base
-  Modifiers = {
-    '+'   => 'heavy',
-    '-'   => 'light',
-    'VC'  => 'nearby',
-    '-VC' => 'nearby light',
-    '+VC' => 'nearby heavy',
-  }
+module Metar
+  module Data
+    class WeatherPhenomenon < Metar::Data::Base
+      MODIFIERS = {
+        '+' => 'heavy',
+        '-' => 'light',
+        'VC' => 'nearby',
+        '-VC' => 'nearby light',
+        '+VC' => 'nearby heavy'
+      }.freeze
 
-  Descriptors = {
-    'BC' => 'patches of',
-    'BL' => 'blowing',
-    'DR' => 'low drifting',
-    'FZ' => 'freezing',
-    'MI' => 'shallow',
-    'PR' => 'partial',
-    'SH' => 'shower of',
-    'TS' => 'thunderstorm and',
-  }
+      DESCRIPTORS = {
+        'BC' => 'patches of',
+        'BL' => 'blowing',
+        'DR' => 'low drifting',
+        'FZ' => 'freezing',
+        'MI' => 'shallow',
+        'PR' => 'partial',
+        'SH' => 'shower of',
+        'TS' => 'thunderstorm and'
+      }.freeze
 
-  Phenomena = {
-    'BR'   => 'mist',
-    'DU'   => 'dust',
-    'DZ'   => 'drizzle',
-    'FG'   => 'fog',
-    'FU'   => 'smoke',
-    'GR'   => 'hail',
-    'GS'   => 'small hail',
-    'HZ'   => 'haze',
-    'IC'   => 'ice crystals',
-    'PL'   => 'ice pellets',
-    'PO'   => 'dust whirls',
-    'PY'   => 'spray', # US only
-    'RA'   => 'rain',
-    'SA'   => 'sand',
-    'SH'   => 'shower',
-    'SN'   => 'snow',
-    'SG'   => 'snow grains',
-    'SQ'   => 'squall',
-    'UP'   => 'unknown phenomenon', # => AUTO
-    'VA'   => 'volcanic ash',
-    'FC'   => 'funnel cloud',
-    'SS'   => 'sand storm',
-    'DS'   => 'dust storm',
-    'TS'   => 'thunderstorm',
-  }
+      PHENOMENA = {
+        'BR' => 'mist',
+        'DU' => 'dust',
+        'DZ' => 'drizzle',
+        'FG' => 'fog',
+        'FU' => 'smoke',
+        'GR' => 'hail',
+        'GS' => 'small hail',
+        'HZ' => 'haze',
+        'IC' => 'ice crystals',
+        'PL' => 'ice pellets',
+        'PO' => 'dust whirls',
+        'PY' => 'spray', # US only
+        'RA' => 'rain',
+        'SA' => 'sand',
+        'SH' => 'shower',
+        'SN' => 'snow',
+        'SG' => 'snow grains',
+        'SQ' => 'squall',
+        'UP' => 'unknown phenomenon', # => AUTO
+        'VA' => 'volcanic ash',
+        'FC' => 'funnel cloud',
+        'SS' => 'sand storm',
+        'DS' => 'dust storm',
+        'TS' => 'thunderstorm'
+      }.freeze
 
-  # Accepts all standard (and some non-standard) present weather codes
-  def self.parse(raw)
-    phenomena   = Phenomena.keys.join('|')
-    descriptors = Descriptors.keys.join('|')
-    modifiers   = Modifiers.keys.join('|')
-    modifiers.gsub!(/([\+\-])/) { |m| "\\#{m}" }
-    rxp = Regexp.new("^(RE)?(#{modifiers})?(#{descriptors})?((?:#{phenomena}){1,2})$")
-    m   = rxp.match(raw)
-    return nil if m.nil?
+      # Accepts all standard (and some non-standard) present weather codes
+      def self.parse(raw)
+        modifiers = MODIFIERS.keys.join('|')
+        modifiers.gsub!(/([\+\-])/) { |m| "\\#{m}" }
 
-    recent           = m[1] == "RE"
-    modifier_code    = m[2]
-    descriptor_code  = m[3]
-    phenomena_codes  = m[4].scan(/../)
-    phenomena_phrase = phenomena_codes.map { |c| Phenomena[c] }.join(' and ')
+        descriptors = DESCRIPTORS.keys.join('|')
 
-    new(
-      raw,
-      phenomenon: phenomena_phrase,
-      modifier: Modifiers[modifier_code],
-      descriptor: Descriptors[descriptor_code]
-    )
-  end
+        phenomena = PHENOMENA.keys.join('|')
 
-  attr_reader :phenomenon, :modifier, :descriptor, :recent
+        rxp = Regexp.new(
+          "^(RE)?(#{modifiers})?(#{descriptors})?((?:#{phenomena}){1,2})$"
+        )
 
-  def initialize(raw, phenomenon:, modifier: nil, descriptor: nil, recent: false)
-    @raw = raw
-    @phenomenon, @modifier, @descriptor = phenomenon, modifier, descriptor
-    @recent = recent
-  end
+        m = rxp.match(raw)
+        return nil if m.nil?
+
+        recent = m[1] == "RE"
+        modifier_code = m[2]
+        descriptor_code = m[3]
+        phenomena_codes = m[4].scan(/../)
+        phenomena = phenomena_codes.map { |c| PHENOMENA[c] }
+        phenomena_phrase = phenomena.join(' and ')
+
+        new(
+          raw,
+          phenomenon: phenomena_phrase,
+          modifier: MODIFIERS[modifier_code],
+          descriptor: DESCRIPTORS[descriptor_code],
+          recent: recent
+        )
+      end
+
+      attr_reader :phenomenon, :modifier, :descriptor, :recent
+
+      def initialize(
+        raw, phenomenon:, modifier: nil, descriptor: nil, recent: false
+      )
+        @raw = raw
+        @phenomenon = phenomenon
+        @modifier = modifier
+        @descriptor = descriptor
+        @recent = recent
+      end
 
-  def to_s
-    key = [modifier, descriptor, phenomenon].compact.join(' ')
-    I18n.t("metar.present_weather.%s" % key)
+      def to_s
+        key = [modifier, descriptor, phenomenon].compact.join(' ')
+        I18n.t("metar.present_weather.#{key}")
+      end
+    end
   end
 end

data/lib/metar/data/wind.rb

@@ -1,108 +1,120 @@
-class Metar::Data::Wind < Metar::Data::Base
-  def self.parse(raw, strict: false)
-    return nil if raw.nil?
-
-    plain_match =
-      if strict
-        /^(\d{3})(\d{2}(|MPS|KMH|KT))$/
-      else
-        /^(\d{3})(\d{2,3}(|MPS|KMH|KT))$/
-      end
+# frozen_string_literal: true
 
-    m1 = raw.match(plain_match)
-    if m1
-      return nil if m1[1].to_i > 360
-      return new(
-        raw,
-        direction: Metar::Data::Direction.new(m1[1]),
-        speed: Metar::Data::Speed.parse(m1[2])
-      )
-    end
+module Metar
+  module Data
+    class Wind < Metar::Data::Base
+      def self.parse(raw, strict: false)
+        return nil if raw.nil?
 
-    m2 = raw.match(/^(\d{3})(\d{2})G(\d{2,3}(|MPS|KMH|KT))$/)
-    if m2
-      return nil if m2[1].to_i > 360
-      return new(
-        raw,
-        direction: Metar::Data::Direction.new(m2[1]),
-        speed: Metar::Data::Speed.parse(m2[2] + m2[4]),
-        gusts: Metar::Data::Speed.parse(m2[3])
-      )
-    end
+        plain_match =
+          if strict
+            /^(\d{3})(\d{2}(|MPS|KMH|KT))$/
+          else
+            /^(\d{3})(\d{2,3}(|MPS|KMH|KT))$/
+          end
 
-    m3 = raw.match(/^VRB(\d{2})G(\d{2,3})(|MPS|KMH|KT)$/)
-    if m3
-      speed = m3[1] + m3[3]
-      gusts = m3[2] + m3[3]
-      return new(
-        raw,
-        direction: :variable_direction,
-        speed: Metar::Data::Speed.parse(speed),
-        gusts: Metar::Data::Speed.parse(gusts)
-      )
-    end
+        m1 = raw.match(plain_match)
+        if m1
+          return nil if m1[1].to_i > 360
 
-    m4 = raw.match(/^VRB(\d{2}(|MPS|KMH|KT))$/)
-    if m4
-      speed = Metar::Data::Speed.parse(m4[1])
-      return new(raw, direction: :variable_direction, speed: speed)
-    end
+          return new(
+            raw,
+            direction: Metar::Data::Direction.new(m1[1]),
+            speed: Metar::Data::Speed.parse(m1[2])
+          )
+        end
 
-    m5 = raw.match(/^\/{3}(\d{2}(|MPS|KMH|KT))$/)
-    if m5
-      speed = Metar::Data::Speed.parse(m5[1])
-      return new(raw, direction: :unknown_direction, speed: speed)
-    end
+        m2 = raw.match(/^(\d{3})(\d{2})G(\d{2,3}(|MPS|KMH|KT))$/)
+        if m2
+          return nil if m2[1].to_i > 360
 
-    m6 = raw.match(%r(^/////(|MPS|KMH|KT)$))
-    if m6
-      return new(raw, direction: :unknown_direction, speed: :unknown_speed)
-    end
+          return new(
+            raw,
+            direction: Metar::Data::Direction.new(m2[1]),
+            speed: Metar::Data::Speed.parse(m2[2] + m2[4]),
+            gusts: Metar::Data::Speed.parse(m2[3])
+          )
+        end
 
-    nil
-  end
+        m3 = raw.match(/^VRB(\d{2})G(\d{2,3})(|MPS|KMH|KT)$/)
+        if m3
+          speed = m3[1] + m3[3]
+          gusts = m3[2] + m3[3]
+          return new(
+            raw,
+            direction: :variable_direction,
+            speed: Metar::Data::Speed.parse(speed),
+            gusts: Metar::Data::Speed.parse(gusts)
+          )
+        end
 
-  attr_reader :direction, :speed, :gusts
+        m4 = raw.match(/^VRB(\d{2}(|MPS|KMH|KT))$/)
+        if m4
+          speed = Metar::Data::Speed.parse(m4[1])
+          return new(raw, direction: :variable_direction, speed: speed)
+        end
 
-  def initialize(raw, direction:, speed:, gusts: nil)
-    @raw = raw
-    @direction, @speed, @gusts = direction, speed, gusts
-  end
+        m5 = raw.match(%r{^/{3}(\d{2}(|MPS|KMH|KT))$})
+        if m5
+          speed = Metar::Data::Speed.parse(m5[1])
+          return new(raw, direction: :unknown_direction, speed: speed)
+        end
+
+        m6 = raw.match(%r{^/////(|MPS|KMH|KT)$})
+        if m6
+          return new(raw, direction: :unknown_direction, speed: :unknown_speed)
+        end
+
+        nil
+      end
 
-  def to_s(options = {})
-    options = {
-      direction_units: :compass,
-      speed_units:     :kilometers_per_hour,
-    }.merge(options)
-    speed =
-      case @speed
-      when :unknown_speed
-           I18n.t('metar.wind.unknown_speed')
-      else
-        @speed.to_s(
-          abbreviated: true,
-          precision:   0,
-          units:       options[:speed_units]
-        )
+      attr_reader :direction, :speed, :gusts
+
+      def initialize(raw, direction:, speed:, gusts: nil)
+        @raw = raw
+        @direction = direction
+        @speed = speed
+        @gusts = gusts
       end
-    direction =
-      case @direction
-      when :variable_direction
-           I18n.t('metar.wind.variable_direction')
-      when :unknown_direction
-           I18n.t('metar.wind.unknown_direction')
-      else
-        @direction.to_s(units: options[:direction_units])
+
+      def to_s(options = {})
+        options = {
+          direction_units: :compass,
+          speed_units: :kilometers_per_hour
+        }.merge(options)
+        speed =
+          case @speed
+          when :unknown_speed
+            I18n.t('metar.wind.unknown_speed')
+          else
+            @speed.to_s(
+              abbreviated: true,
+              precision: 0,
+              units: options[:speed_units]
+            )
+          end
+        direction =
+          case @direction
+          when :variable_direction
+            I18n.t('metar.wind.variable_direction')
+          when :unknown_direction
+            I18n.t('metar.wind.unknown_direction')
+          else
+            @direction.to_s(units: options[:direction_units])
+          end
+        s = "#{speed} #{direction}"
+
+        if !@gusts.nil?
+          g = @gusts.to_s(
+            abbreviated: true,
+            precision: 0,
+            units: options[:speed_units]
+          )
+          s += " #{I18n.t('metar.wind.gusts')} #{g}"
+        end
+
+        s
       end
-    s = "#{speed} #{direction}"
-    if not @gusts.nil?
-      g = @gusts.to_s(
-        abbreviated: true,
-        precision:   0,
-        units:       options[:speed_units]
-      )
-      s += " #{I18n.t('metar.wind.gusts')} #{g}"
     end
-    s
   end
 end

data/lib/metar/data.rb

@@ -1,25 +1,27 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-module Metar::Data
-  autoload :Base, "metar/data/base"
-  autoload :DensityAltitude, "metar/data/density_altitude"
-  autoload :Direction, "metar/data/direction"
-  autoload :Distance, "metar/data/distance"
-  autoload :Lightning, "metar/data/lightning"
-  autoload :Observer, "metar/data/observer"
-  autoload :Pressure, "metar/data/pressure"
-  autoload :Remark, "metar/data/remark"
-  autoload :RunwayVisibleRange, "metar/data/runway_visible_range"
-  autoload :SkyCondition, "metar/data/sky_condition"
-  autoload :Speed, "metar/data/speed"
-  autoload :StationCode, "metar/data/station_code"
-  autoload :Temperature, "metar/data/temperature"
-  autoload :TemperatureAndDewPoint, "metar/data/temperature_and_dew_point"
-  autoload :Time, "metar/data/time"
-  autoload :VariableWind, "metar/data/variable_wind"
-  autoload :VerticalVisibility, "metar/data/vertical_visibility"
-  autoload :Visibility, "metar/data/visibility"
-  autoload :VisibilityRemark, "metar/data/visibility_remark"
-  autoload :WeatherPhenomenon, "metar/data/weather_phenomenon"
-  autoload :Wind, "metar/data/wind"
+module Metar
+  module Data
+    autoload :Base, "metar/data/base"
+    autoload :DensityAltitude, "metar/data/density_altitude"
+    autoload :Direction, "metar/data/direction"
+    autoload :Distance, "metar/data/distance"
+    autoload :Lightning, "metar/data/lightning"
+    autoload :Observer, "metar/data/observer"
+    autoload :Pressure, "metar/data/pressure"
+    autoload :Remark, "metar/data/remark"
+    autoload :RunwayVisibleRange, "metar/data/runway_visible_range"
+    autoload :SkyCondition, "metar/data/sky_condition"
+    autoload :Speed, "metar/data/speed"
+    autoload :StationCode, "metar/data/station_code"
+    autoload :Temperature, "metar/data/temperature"
+    autoload :TemperatureAndDewPoint, "metar/data/temperature_and_dew_point"
+    autoload :Time, "metar/data/time"
+    autoload :VariableWind, "metar/data/variable_wind"
+    autoload :VerticalVisibility, "metar/data/vertical_visibility"
+    autoload :Visibility, "metar/data/visibility"
+    autoload :VisibilityRemark, "metar/data/visibility_remark"
+    autoload :WeatherPhenomenon, "metar/data/weather_phenomenon"
+    autoload :Wind, "metar/data/wind"
+  end
 end

data/lib/metar/i18n.rb

@@ -1,6 +1,9 @@
+# frozen_string_literal: true
+
 require "i18n"
 
-locales_path = File.expand_path(File.join(File.dirname(__FILE__), "..", "..", "locales"))
+locales_path = File.expand_path(
+  File.join(File.dirname(__FILE__), "..", "..", "locales")
+)
 I18n.load_path += Dir.glob("#{locales_path}/*.yml")
 I18n::Backend::Simple.send(:include, I18n::Backend::Fallbacks)
-

data/lib/metar/parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "m9t"
 
 require "metar/data"
@@ -13,7 +15,7 @@ module Metar
       new(raw)
     end
 
-    COMPLIANCE = [:strict, :loose]
+    COMPLIANCE = %i(strict loose).freeze
 
     def self.thread_attributes
       Thread.current[:metar_parser] ||= {}
@@ -25,6 +27,7 @@ module Metar
 
     def self.compliance=(compliance)
       raise 'Unknown compliance' unless COMPLIANCE.find(compliance)
+
       thread_attributes[:compliance] = compliance
     end
 
@@ -65,11 +68,13 @@ module Metar
 
     def temperature
       return nil if @temperature_and_dew_point.nil?
+
       @temperature_and_dew_point.temperature
     end
 
     def dew_point
       return nil if @temperature_and_dew_point.nil?
+
       @temperature_and_dew_point.dew_point
     end
 
@@ -77,7 +82,7 @@ module Metar
       attr = {
         metar: metar,
         datetime: @time.raw,
-        station_code: station_code,
+        station_code: station_code
       }
       %i(
         minimum_visibility
@@ -106,6 +111,7 @@ module Metar
       value = send(attribute)
       return hash if value.nil?
       return hash if value.raw.nil?
+
       hash[attribute] = value.raw
       hash
     end
@@ -113,7 +119,8 @@ module Metar
     def add_raw_if_not_empty(hash, attribute)
       values = send(attribute)
       raws = values.map(&:raw).compact
-      return hash if raws.size == 0
+      return hash if raws.empty?
+
       hash[attribute] = raws.join(" ")
       hash
     end
@@ -121,8 +128,8 @@ module Metar
     def analyze
       @chunks = @metar.split(' ')
       # Strip final '='
-      if !strict? && @chunks.length > 0
-        @chunks[-1].gsub!(/\s?=$/, '')
+      if !strict?
+        @chunks[-1].gsub!(/\s?=$/, '') if !@chunks.empty?
       end
 
       @station_code         = nil
@@ -167,7 +174,8 @@ module Metar
     def seek_station_code
       @station_code = Metar::Data::StationCode.parse(@chunks[0])
       if @station_code.nil?
-        raise ParseError.new("Expecting location, found '#{ @chunks[0] }' in #{@metar}")
+        message = "Expecting location, found '#{@chunks[0]}' in #{@metar}"
+        raise ParseError, message
       end
       @chunks.shift
       @station_code
@@ -178,9 +186,11 @@ module Metar
       @time = Metar::Data::Time.parse(
         datetime, year: raw.time.year, month: raw.time.month, strict: strict?
       )
+
       if !@time
-        raise ParseError.new("Expecting datetime, found '#{datetime}' in #{@metar}")
+        raise ParseError, "Expecting datetime, found '#{datetime}' in #{@metar}"
       end
+
       @time
     end
 
@@ -228,17 +238,17 @@ module Metar
         end
       end
 
-      if @chunks[0] == '1' or @chunks[0] == '2'
-        @visibility = Metar::Data::Visibility.parse(@chunks[0] + ' ' + @chunks[1])
+      if @chunks[0] == '1' || @chunks[0] == '2'
+        @visibility = Metar::Data::Visibility.parse(
+          @chunks[0] + ' ' + @chunks[1]
+        )
         if @visibility
           @chunks.shift
           @chunks.shift
         end
       else
         @visibility = Metar::Data::Visibility.parse(@chunks[0])
-        if @visibility
-          @chunks.shift
-        end
+        @chunks.shift if @visibility
       end
       @visibility
     end
@@ -254,6 +264,7 @@ module Metar
       loop do
         rvr = Metar::Data::RunwayVisibleRange.parse(@chunks[0])
         break if rvr.nil?
+
         @chunks.shift
         @runway_visible_range << rvr
       end
@@ -271,11 +282,21 @@ module Metar
         end
       end
 
+      if @chunks[0] == 'NSW'
+        @present_weather << Metar::Data::WeatherPhenomenon.new(
+          nil, phenomenon: "no significant weather"
+        )
+        @chunks.shift
+        return
+      end
+
       loop do
-        break if @chunks.size == 0
+        break if @chunks.empty?
         break if @chunks[0].start_with?("RE")
+
         wtp = Metar::Data::WeatherPhenomenon.parse(@chunks[0])
         break if wtp.nil?
+
         @chunks.shift
         @present_weather << wtp
       end
@@ -284,7 +305,7 @@ module Metar
     # Repeatable: 15.9.1.3
     def seek_sky_conditions
       if observer.value == :auto # WMO 15.4
-        if @chunks[0] == '///' or @chunks[0] == '//////'
+        if @chunks[0] == '///' || @chunks[0] == '//////'
           @chunks.shift # Simply dispose of it
           return
         end
@@ -293,6 +314,7 @@ module Metar
       loop do
         sky_condition = Metar::Data::SkyCondition.parse(@chunks[0])
         break if sky_condition.nil?
+
         @chunks.shift
         @sky_conditions << sky_condition
       end
@@ -321,10 +343,12 @@ module Metar
 
     def seek_recent_weather
       loop do
-        return if @chunks.size == 0
+        return if @chunks.empty?
         break if !@chunks[0].start_with?("RE")
+
         recent_weather = Metar::Data::WeatherPhenomenon.parse(@chunks[0])
         break if recent_weather.nil?
+
         @chunks.shift
         @recent_weather << recent_weather
       end
@@ -333,11 +357,11 @@ module Metar
 
     def seek_to_remarks
       if strict?
-        if @chunks.size > 0 and @chunks[0] != 'RMK'
-          raise ParseError.new("Unparsable text found: '#{@chunks.join(' ')}'")
+        if !@chunks.empty? && @chunks[0] != 'RMK'
+          raise ParseError, "Unparsable text found: '#{@chunks.join(' ')}'"
         end
       else
-        while @chunks.size > 0 and @chunks[0] != 'RMK' do
+        while !@chunks.empty? && @chunks[0] != 'RMK' do
           @unparsed << @chunks.shift
         end
       end
@@ -345,13 +369,14 @@ module Metar
 
     # WMO: 15.15
     def seek_remarks
-      return if @chunks.size == 0
+      return if @chunks.empty?
       raise 'seek_remarks called without remark' if @chunks[0] != 'RMK'
 
       @chunks.shift # Drop 'RMK'
       @remarks = []
       loop do
-        break if @chunks.size == 0
+        break if @chunks.empty?
+
         r = Metar::Data::Remark.parse(@chunks[0])
         if r
           if r.is_a?(Array)
@@ -362,7 +387,7 @@ module Metar
           @chunks.shift
           next
         end
-        if @chunks[0] == 'VIS' and @chunks.size >= 3 and @chunks[1] == 'MIN'
+        if @chunks[0] == 'VIS' && @chunks.size >= 3 && @chunks[1] == 'MIN'
           @chunks.shift(2)
           r = Metar::Data::VisibilityRemark.parse(@chunks[0])
           @remarks << r