metar-parser 1.4.2 → 1.6.0

data/spec/data/lightning_spec.rb

@@ -1,13 +1,30 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Metar::Data::Lightning do
   context '.parse_chunks' do
     [
-      ['direction',                        'LTG SE',            [:default,      nil, ['SE']]],
-      ['distance direction',               'LTG DSNT SE',       [:default, 16093.44, ['SE']]],
-      ['distance direction and direction', 'LTG DSNT NE AND W', [:default, 16093.44, ['NE', 'W']]],
-      ['distance direction-direction',     'LTG DSNT SE-SW',    [:default, 16093.44, ['SE', 'SW']]],
-      ['distance all quandrants',          'LTG DSNT ALQDS',    [:default, 16093.44, ['N', 'E', 'S', 'W']]],
+      [
+        'direction', 'LTG SE',
+        [:default, nil, ['SE']]
+      ],
+      [
+        'distance direction', 'LTG DSNT SE',
+        [:default, 16_093.44, ['SE']]
+      ],
+      [
+        'distance direction and direction', 'LTG DSNT NE AND W',
+        [:default, 16_093.44, %w(NE W)]
+      ],
+      [
+        'distance direction-direction', 'LTG DSNT SE-SW',
+        [:default, 16_093.44, %w(SE SW)]
+      ],
+      [
+        'distance all quandrants', 'LTG DSNT ALQDS',
+        [:default, 16_093.44, %w(N E S W)]
+      ]
     ].each do |docstring, section, expected|
       example docstring do
         chunks = section.split(' ')
@@ -25,9 +42,9 @@ describe Metar::Data::Lightning do
     end
 
     it 'removes parsed chunks' do
-      chunks = ['LTG', 'DSNT', 'SE', 'FOO']
+      chunks = %w(LTG DSNT SE FOO)
 
-      r = described_class.parse_chunks(chunks)
+      described_class.parse_chunks(chunks)
 
       expect(chunks).to eq(['FOO'])
     end
@@ -39,9 +56,9 @@ describe Metar::Data::Lightning do
     end
 
     it "doesn't not fail if all chunks are parsed" do
-      chunks = ['LTG', 'DSNT', 'SE']
+      chunks = %w(LTG DSNT SE)
 
-      r = described_class.parse_chunks(chunks)
+      described_class.parse_chunks(chunks)
 
       expect(chunks).to eq([])
     end

data/spec/data/pressure_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Metar::Data::Pressure do

data/spec/data/remark_spec.rb

@@ -1,9 +1,12 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Metar::Data::Remark do
   context '.parse' do
     it 'delegate to subclasses' do
-      expect(described_class.parse('21012')).to be_a(Metar::Data::TemperatureExtreme)
+      expect(described_class.parse('21012')).
+        to be_a(Metar::Data::TemperatureExtreme)
     end
 
     it 'returns nil for unrecognised' do
@@ -12,13 +15,14 @@ describe Metar::Data::Remark do
 
     context '6-hour maximum or minimum' do
       [
-        ['positive maximum', '10046', [:maximum,  4.6]],
+        ['positive maximum', '10046', [:maximum, 4.6]],
         ['negative maximum', '11012', [:maximum, -1.2]],
-        ['positive minimum', '20046', [:minimum,  4.6]],
-        ['negative minimum', '21012', [:minimum, -1.2]],
+        ['positive minimum', '20046', [:minimum, 4.6]],
+        ['negative minimum', '21012', [:minimum, -1.2]]
       ].each do |docstring, raw, expected|
         example docstring do
-          expect(described_class.parse(raw)).to be_temperature_extreme(*expected)
+          expect(described_class.parse(raw)).
+            to be_temperature_extreme(*expected)
         end
       end
     end
@@ -27,7 +31,7 @@ describe Metar::Data::Remark do
       it 'returns minimum and maximum' do
         max, min = described_class.parse('400461006')
 
-        expect(max).to be_temperature_extreme(:maximum,  4.6)
+        expect(max).to be_temperature_extreme(:maximum, 4.6)
         expect(min).to be_temperature_extreme(:minimum, -0.6)
       end
     end
@@ -63,10 +67,23 @@ describe Metar::Data::Remark do
     end
 
     context 'automated station' do
-
       [
-        ['with precipitation dicriminator', 'AO1', [Metar::Data::AutomatedStationType, :with_precipitation_discriminator]],
-        ['without precipitation dicriminator', 'AO2', [Metar::Data::AutomatedStationType, :without_precipitation_discriminator]],
+        [
+          'with precipitation dicriminator',
+          'AO1',
+          [
+            Metar::Data::AutomatedStationType,
+            :with_precipitation_discriminator
+          ]
+        ],
+        [
+          'without precipitation dicriminator',
+          'AO2',
+          [
+            Metar::Data::AutomatedStationType,
+            :without_precipitation_discriminator
+          ]
+        ]
       ].each do |docstring, raw, expected|
         example docstring do
           aut = described_class.parse(raw)

data/spec/data/runway_visible_range_spec.rb

@@ -1,30 +1,29 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 require "spec_helper"
 
-RSpec::Matchers.define :be_runway_visible_range do |designator, visibility1, visibility2, tendency|
+RSpec::Matchers.define :be_runway_visible_range do |designator, v1, v2, tend|
   match do |rvr|
-    if rvr.nil?                && designator.nil?
+    if rvr.nil? && designator.nil?
       true
-    elsif rvr.nil?             != designator.nil?
-      false
-    elsif rvr.visibility1.nil? != visibility1.nil?
+    elsif rvr.nil? != designator.nil?
       false
-    elsif rvr.visibility2.nil? != visibility2.nil?
+    elsif rvr.visibility1.nil? != v1.nil?
       false
-    elsif rvr.tendency.nil? != tendency.nil?
+    elsif rvr.visibility2.nil? != v2.nil?
       false
-    elsif ! visibility1.nil? &&
-          ((rvr.visibility1.distance.value - visibility1[0]).abs > 0.01 ||
-            rvr.visibility1.comparator != visibility1[ 2 ])
+    elsif rvr.tendency.nil? != tend.nil?
       false
-    elsif ! visibility2.nil? &&
-          ((rvr.visibility2.distance.value - visibility2[0]).abs > 0.02 ||
-            rvr.visibility2.comparator != visibility2[2])
+    elsif !v1.nil? &&
+          ((rvr.visibility1.distance.value - v1[0]).abs > 0.01 ||
+          rvr.visibility1.comparator != v1[2])
       false
-    elsif tendency != rvr.tendency
+    elsif !v2.nil? &&
+          ((rvr.visibility2.distance.value - v2[0]).abs > 0.02 ||
+          rvr.visibility2.comparator != v2[2])
       false
     else
-      true
+      tend == rvr.tendency
     end
   end
 end
@@ -32,17 +31,44 @@ end
 describe Metar::Data::RunwayVisibleRange do
   context '.parse' do
     [
-      ['understands R + nn + / + nnnn',           'R12/3400',           ['12',  [3400.00, nil, nil],        nil,                  nil]],
-      ['understands runway positions: RLC',       'R12L/3400',          ['12L', [3400.00, nil, nil],        nil,                  nil]],
-      ['understands comparators: PM',             'R12/P3400',          ['12',  [3400.00, nil, :more_than], nil,                  nil]],
-      ['understands tendencies: NUD',             'R12/3400U',          ['12',  [3400.00, nil, nil],        nil,                  :improving]],
-      ['understands feet',                        'R12/3400FT',         ['12',  [1036.32, nil, nil],        nil,                  nil]],
-      ['understands second visibilities (m)',     'R26/0750V1200U',     ['12',  [ 750.0,  nil, nil],        [1200.0, nil, nil],   :improving]],
-      ['understands second visibilities (ft)',    'R12/1800V3400FT',    ['12',  [548.64, nil, nil],         [1036.32, nil, nil],  nil]],
-      ['understands second RVR (ft) w/ tendency', 'R29/1800V3400FT/U',  ['29',  [548.64, nil, nil],         [1036.32, nil, nil],  :improving]],
-      ['returns nil for nil',                     nil,                  [nil,   nil,                        nil,                  nil]],
-    ].each do |docstring, raw, expected|
-      example docstring do
+      [
+        'understands R + nn + / + nnnn', 'R12/3400',
+        ['12', [3400.00, nil, nil], nil, nil]
+      ],
+      [
+        'understands runway positions: RLC', 'R12L/3400',
+        ['12L', [3400.00, nil, nil], nil, nil]
+      ],
+      [
+        'understands comparators: PM', 'R12/P3400',
+        ['12', [3400.00, nil, :more_than], nil, nil]
+      ],
+      [
+        'understands tendencies: NUD', 'R12/3400U',
+        ['12', [3400.00, nil, nil], nil, :improving]
+      ],
+      [
+        'understands feet', 'R12/3400FT',
+        ['12', [1036.32, nil, nil], nil, nil]
+      ],
+      [
+        'understands second visibilities (m)', 'R26/0750V1200U',
+        ['12', [750.0, nil, nil], [1200.0, nil, nil], :improving]
+      ],
+      [
+        'understands second visibilities (ft)', 'R12/1800V3400FT',
+        ['12', [548.64, nil, nil], [1036.32, nil, nil], nil]
+      ],
+      [
+        'understands second RVR (ft) w/ tendency', 'R29/1800V3400FT/U',
+        ['29', [548.64, nil, nil], [1036.32, nil, nil], :improving]
+      ],
+      [
+        'returns nil for nil', nil,
+        [nil, nil, nil, nil]
+      ]
+    ].each do |title, raw, expected|
+      example title do
         expect(described_class.parse(raw)).to be_runway_visible_range(*expected)
       end
     end
@@ -59,26 +85,36 @@ describe Metar::Data::RunwayVisibleRange do
     end
 
     [
-      ['v1',        :en, [[3400.00, nil, nil], nil,                 nil], 'runway 14: 3400m'],
-      ['v1 and v2',       :en,  [[3400.00, nil, nil], [1900.00, nil, nil], nil ], 'runway 14: from 3400m to 1900m'],
-      ['v1 and tendency', :en, [[3400.00, nil, nil], nil,                 :improving ], 'runway 14: 3400m improving'],
-    ].each do |docstring, locale, (visibility1, visibility2, tendency), expected|
+      [
+        'v1',
+        :en, [[3400.00, nil, nil], nil, nil],
+        'runway 14: 3400m'
+      ],
+      [
+        'v1 and v2',
+        :en, [[3400.00, nil, nil], [1900.00, nil, nil], nil],
+        'runway 14: from 3400m to 1900m'
+      ],
+      [
+        'v1 and tendency',
+        :en, [[3400.00, nil, nil], nil, :improving],
+        'runway 14: 3400m improving'
+      ]
+    ].each do |title, locale, (visibility1, visibility2, tendency), expected|
       d1 = Metar::Data::Distance.new(visibility1[0])
       v1 = Metar::Data::Visibility.new(
         nil, distance: d1, direction: visibility1[1], comparator: visibility1[2]
       )
       v2 =
-        if ! visibility2.nil?
+        if !visibility2.nil?
           d2 = Metar::Data::Distance.new(visibility2[0])
           Metar::Data::Visibility.new(
             nil,
             distance: d2, direction: visibility2[1], comparator: visibility2[2]
           )
-        else
-          nil
         end
 
-      example docstring + " (#{locale})" do
+      example title + " (#{locale})" do
         I18n.locale = locale
         subject = described_class.new(
           nil,

data/spec/data/sky_condition_spec.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 require "spec_helper"
 
 RSpec::Matchers.define :be_sky_condition do |quantity, height, type|
@@ -11,10 +12,8 @@ RSpec::Matchers.define :be_sky_condition do |quantity, height, type|
       false
     elsif sk.height.is_a?(Metar::Data::Distance) && sk.height.value != height
       false
-    elsif sk.type != type
-      false
     else
-      true
+      sk.type == type
     end
   end
 end
@@ -22,13 +21,34 @@ end
 describe Metar::Data::SkyCondition do
   context '.parse' do
     [
-      ['understands clear skies codes', 'NSC',      [nil,            nil,            nil]],
-      ['quantity + height',             'BKN12',    ['broken',    365.76,            nil]],
-      ['quantity + height + type',      'BKN12CB',  ['broken',    365.76, 'cumulonimbus']],
-      ['quantity + ///',                'BKN///',   ['broken',       nil,            nil]],
-      ['quantity + height + ///',       'FEW038///',['few',      1158.24,            nil]],
-      ['cumulonimbus only',             'CB',       [nil,            nil, 'cumulonimbus']], # seems non-standard, but occurs
-      ['returns nil for unmatched',     'FUBAR',    [:expect_nil,    nil,            nil]],
+      [
+        'understands clear skies codes', 'NSC',
+        [nil, nil, nil]
+      ],
+      [
+        'quantity + height', 'BKN12',
+        ['broken', 365.76, nil]
+      ],
+      [
+        'quantity + height + type', 'BKN12CB',
+        ['broken', 365.76, 'cumulonimbus']
+      ],
+      [
+        'quantity + ///', 'BKN///',
+        ['broken', nil, nil]
+      ],
+      [
+        'quantity + height + ///', 'FEW038///',
+        ['few', 1158.24, nil]
+      ],
+      [
+        'cumulonimbus only', 'CB', # seems non-standard, but occurs
+        [nil, nil, 'cumulonimbus']
+      ],
+      [
+        'returns nil for unmatched', 'FUBAR',
+        [:expect_nil, nil, nil]
+      ]
     ].each do |docstring, raw, expected|
       example docstring do
         expect(described_class.parse(raw)).to be_sky_condition(*expected)
@@ -38,11 +58,26 @@ describe Metar::Data::SkyCondition do
 
   context '.to_summary' do
     [
-      ['all values nil',  [nil,      nil, nil           ], :en,      'clear skies'        ],
-      ['quantity',        ['broken', nil, nil           ], :en,      'broken cloud'       ],
-      ['quantity',        ['broken', nil, nil           ], :'en-US', 'broken clouds'      ],
-      ['quantity + type', ['broken', nil, 'cumulonimbus'], :en,      'broken cumulonimbus'],
-      ['quantity + type', ['broken', nil, 'cumulonimbus'], :'en-US', 'broken cumulonimbus clouds'],
+      [
+        'all values nil', [nil, nil, nil],
+        :en, 'clear skies'
+      ],
+      [
+        'quantity', ['broken', nil, nil],
+        :en, 'broken cloud'
+      ],
+      [
+        'quantity', ['broken', nil, nil],
+        :'en-US', 'broken clouds'
+      ],
+      [
+        'quantity + type', ['broken', nil, 'cumulonimbus'],
+        :en,      'broken cumulonimbus'
+      ],
+      [
+        'quantity + type', ['broken', nil, 'cumulonimbus'],
+        :'en-US', 'broken cumulonimbus clouds'
+      ]
     ].each do |docstring, (quantity, height, type), locale, expected|
       before { @old_locale = I18n.locale }
       after  { I18n.locale = @old_locale }
@@ -59,9 +94,18 @@ describe Metar::Data::SkyCondition do
 
   context '.to_s' do
     [
-      ['all values nil',  [nil,      nil, nil],            'clear skies'               ],
-      ['quantity',        ['broken', 360, nil],            'broken cloud at 360'       ],
-      ['quantity + type', ['broken', 360, 'cumulonimbus'], 'broken cumulonimbus at 360'],
+      [
+        'all values nil', [nil, nil, nil],
+        'clear skies'
+      ],
+      [
+        'quantity', ['broken', 360, nil],
+        'broken cloud at 360'
+      ],
+      [
+        'quantity + type', ['broken', 360, 'cumulonimbus'],
+        'broken cumulonimbus at 360'
+      ]
     ].each do |docstring, (quantity, height, type), expected|
       example docstring do
         subject = described_class.new(

data/spec/data/speed_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Metar::Data::Speed do

data/spec/data/temperature_spec.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Metar::Data::Temperature do

data/spec/data/variable_wind_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Metar::Data::VariableWind do

data/spec/data/vertical_visibility_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 RSpec::Matchers.define :be_distance do |expected|
@@ -8,10 +10,8 @@ RSpec::Matchers.define :be_distance do |expected|
       false
     elsif distance.value.nil? && expected.nil?
       true
-    elsif (distance.value - expected).abs > 0.01
-      false
     else
-      true
+      (distance.value - expected).abs <= 0.01
     end
   end
 end
@@ -21,7 +21,7 @@ describe Metar::Data::VerticalVisibility do
     [
       ['VV + nnn',                  'VV300',  9144],
       ['///',                       '///',    nil],
-      ['returns nil for unmatched', 'FUBAR',  :expect_nil],
+      ['returns nil for unmatched', 'FUBAR',  :expect_nil]
     ].each do |docstring, raw, expected|
       example docstring do
         expect(described_class.parse(raw)).to be_distance(expected)

data/spec/data/visibility_remark_spec.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Metar::Data::VisibilityRemark do

data/spec/data/visibility_spec.rb

@@ -1,11 +1,12 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 require "spec_helper"
 
 RSpec::Matchers.define :be_visibility do |distance, direction, comparator|
   match do |visibility|
-    if    visibility.nil? && [ distance, direction, comparator ].all?(&:nil?)
+    if visibility.nil? && [distance, direction, comparator].all?(&:nil?)
       true
-    elsif visibility.nil? != [ distance, direction, comparator ].all?(&:nil?)
+    elsif visibility.nil? != [distance, direction, comparator].all?(&:nil?)
       false
     elsif visibility.distance.nil?   != distance.nil?
       false
@@ -13,11 +14,13 @@ RSpec::Matchers.define :be_visibility do |distance, direction, comparator|
       false
     elsif visibility.comparator.nil? != comparator.nil?
       false
-    elsif visibility.distance.is_a?(Metar::Data::Distance) && (visibility.distance.value - distance).abs > 0.01
+    elsif visibility.distance.is_a?(Metar::Data::Distance) &&
+          (visibility.distance.value - distance).abs > 0.01
       false
-    elsif visibility.direction.is_a?(M9t::Direction) && (visibility.direction.value - direction).abs > 0.01
+    elsif visibility.direction.is_a?(M9t::Direction) &&
+          (visibility.direction.value - direction).abs > 0.01
       false
-    elsif comparator.is_a?(Symbol)                   && visibility.comparator != comparator
+    elsif comparator.is_a?(Symbol) && visibility.comparator != comparator
       false
     else
       true
@@ -28,17 +31,17 @@ end
 describe Metar::Data::Visibility do
   context '.parse' do
     [
-      ['understands 9999',          '9999',    [10000.00, nil,   :more_than]],
-      ['understands nnnn + NDV',    '0123NDV', [  123.00, nil,   nil]],
-      ['understands n/nSM',         '3/4SM',   [ 1207.01, nil,   nil]],
-      ['understands 3/16SM',        '3/16SM',  [ 301.752, nil,   nil]],
-      ['understands n n/nSM',       '1 1/4SM', [ 2011.68, nil,   nil]],
-      ['understands nSM',           '5SM',     [ 8046.72, nil,   nil]],
-      ['understands M1/4SM',        'M1/4SM',  [  402.34, nil,   :less_than]],
-      ['understands n + KM',        '5KM',     [ 5000.00, nil,   nil]],
-      ['understands n',             '500',     [  500.00, nil,   nil]],
-      ['understands n + compass',   '500NW',   [  500.00, 315.0, nil]],
-      ['returns nil for unmatched', 'FUBAR',   [     nil,   nil, nil]],
+      ['understands 9999',          '9999',    [10_000.00, nil, :more_than]],
+      ['understands nnnn + NDV',    '0123NDV', [123.00, nil, nil]],
+      ['understands n/nSM',         '3/4SM',   [1207.01, nil,   nil]],
+      ['understands 3/16SM',        '3/16SM',  [301.752, nil,   nil]],
+      ['understands n n/nSM',       '1 1/4SM', [2011.68, nil,   nil]],
+      ['understands nSM',           '5SM',     [8046.72, nil,   nil]],
+      ['understands M1/4SM',        'M1/4SM',  [402.34, nil, :less_than]],
+      ['understands n + KM',        '5KM',     [5000.00, nil, nil]],
+      ['understands n',             '500',     [500.00, nil,   nil]],
+      ['understands n + compass',   '500NW',   [500.00, 315.0, nil]],
+      ['returns nil for unmatched', 'FUBAR',   [nil, nil, nil]]
     ].each do |docstring, raw, expected|
       example docstring do
         expect(described_class.parse(raw)).to be_visibility(*expected)
@@ -57,15 +60,33 @@ describe Metar::Data::Visibility do
     end
 
     [
-      ['with distance',                           :en, [ :set, nil,  nil ],        '4km'],
-      ['with distance and direction',             :en, [ :set, :set, nil ],        '4km ESE'],
-      ['with distance and comparator',            :en, [ :set, nil,  :less_than ], 'less than 4km'],
-      ['with distance, direction and comparator', :en, [ :set, :set, :more_than ], 'more than 4km ESE'],
-      ['with distance and direction',             :it, [ :set, :set, nil ],        '4km ESE'],
-      ['with distance, direction and comparator', :it, [ :set, :set, :more_than ], 'piú di 4km ESE'],
+      [
+        'with distance',
+        :en, [:set, nil, nil], '4km'
+      ],
+      [
+        'with distance and direction',
+        :en, [:set, :set, nil], '4km ESE'
+      ],
+      [
+        'with distance and comparator',
+        :en, [:set, nil, :less_than], 'less than 4km'
+      ],
+      [
+        'with distance, direction and comparator',
+        :en, %i(set set more_than), 'more than 4km ESE'
+      ],
+      [
+        'with distance and direction',
+        :it, [:set, :set, nil], '4km ESE'
+      ],
+      [
+        'with distance, direction and comparator',
+        :it, %i(set set more_than), 'piú di 4km ESE'
+      ]
     ].each do |docstring, locale, (distance, direction, comparator), expected|
-      distance  = Metar::Data::Distance.new(4321) if distance  == :set
-      direction = M9t::Direction.new(123)   if direction == :set
+      distance  = Metar::Data::Distance.new(4321) if distance == :set
+      direction = M9t::Direction.new(123) if direction == :set
 
       example docstring + " (#{locale})" do
         I18n.locale = locale