metar-parser 0.9.11 → 0.9.12

data/lib/metar/station.rb

@@ -1,4 +1,3 @@
-require 'rubygems' if RUBY_VERSION < '1.9'
 require 'open-uri'
 require 'set'
 
@@ -14,7 +13,6 @@ module Metar
     class << self
 
       @nsd_cccc = nil # Contains the text of the station list
-      attr_accessor :nsd_cccc # Allow tests to run from local file
 
       def download_local
         nsd_cccc = Metar::Station.download_stations
@@ -33,7 +31,7 @@ module Metar
       end
 
       def countries
-        all_structures.reduce( Set.new ) { |a, s| a.add( s[ :country ] ); a }
+        all_structures.reduce( Set.new ) { |a, s| a.add( s[ :country ] ) }.to_a.sort
       end
 
       def all
@@ -44,6 +42,10 @@ module Metar
         end
       end
 
+      def find_by_cccc(cccc)
+        all.find { |station| station.cccc == cccc }
+      end
+
       # Does the given CCCC code exist?
       def exist?(cccc)
         not find_data_by_cccc(cccc).nil?
@@ -53,10 +55,6 @@ module Metar
         all.select { | s | s.country == country }
       end
 
-      def find_by_cccc(cccc)
-        all.find { |station| station.cccc == cccc }
-      end
-
       def to_longitude(s)
         s =~ /^(\d+)-(\d+)([EW])/ or return nil
         ($3 == 'E' ? 1.0 : -1.0) * ($1.to_f + $2.to_f / 60.0)
@@ -68,64 +66,23 @@ module Metar
       end
     end
 
-    attr_reader :cccc, :loaded
+    attr_reader :cccc, :name, :state, :country, :longitude, :latitude, :raw
     alias :code :cccc
-    # loaded? indicates whether the data has been collected from the Web
-    alias :loaded? :loaded
 
     # No check is made on the existence of the station
-    def initialize(cccc, options = {})
-      raise "Station identifier must not be nil" if cccc.nil?
-      raise "Station identifier must be a text" if not cccc.respond_to?('to_s')
-      @cccc      = cccc
-      @name      = options[:name]
-      @state     = options[:state]
-      @country   = options[:country]
-      @longitude = options[:longitude]
-      @latitude  = options[:latitude]
-      @raw       = options[:raw]
-      @loaded    = false
+    def initialize( cccc, noaa_data )
+      raise "Station identifier must not be nil"   if cccc.nil?
+      raise "Station identifier must not be empty" if cccc.to_s == ''
+      @cccc = cccc
+      load! noaa_data
     end
 
-    # Lazy loaded attributes
-    ## TODO: DRY this up by generating these methods
-    def name
-      load! if not @loaded
-      @name
-    end
-
-    def state
-      load! if not @loaded
-      @state
-    end
-
-    def country
-      load! if not @loaded
-      @country
-    end
-
-    def latitude
-      load! if not @loaded
-      @latitude
-    end
-
-    def longitude
-      load! if not @loaded
-      @longitude
-    end
-
-    def raw
-      load! if not @loaded
-      @raw
-    end
-
-    def exist?
-      Station.exist?(@cccc)
+    def parser
+      raw = Metar::Raw.new( @cccc )
+      Metar::Parser.new( raw )
     end
 
     def report
-      raw    = Metar::Raw.new( @cccc )
-      parser = Metar::Parser.new( raw )
       Metar::Report.new( parser )
     end
 
@@ -172,20 +129,16 @@ module Metar
 
     end
 
-    # Get data from the NOAA data file (very slow on first call!)
-    def load!
-      noaa_data  = Station.find_data_by_cccc(@cccc)
-      raise "Station identifier '#{ @cccc }' not found" if noaa_data.nil?
+    def load!( noaa_data )
       @name      = noaa_data[:name]
       @state     = noaa_data[:state]
       @country   = noaa_data[:country]
       @longitude = Station.to_longitude(noaa_data[:longitude])
       @latitude  = Station.to_latitude(noaa_data[:latitude])
       @raw       = noaa_data[:raw]
-      @loaded    = true
-      self
     end
 
   end
 
 end
+

data/lib/metar/version.rb

@@ -3,7 +3,7 @@ module Metar
   module VERSION #:nodoc:
     MAJOR = 0
     MINOR = 9
-    TINY  = 11
+    TINY  = 12
 
     STRING = [ MAJOR, MINOR, TINY ].join( '.' )
   end

data/locales/en.yml

@@ -6,6 +6,10 @@ en:
   comparison:
     more_than: more than
     less_than: less than
+  tendency:
+    no_change: no change
+    improving: improving
+    worsening: worsening
   units:
     pressure:
       bar:
@@ -34,6 +38,7 @@ en:
       variable_direction: variable direction
       unknown_direction: unknown direction
       unknown_speed: unknown speed
+      gusts: gusts
     variable_wind:
       title: wind variation
     visibility:
@@ -147,6 +152,7 @@ en:
     temperature:
       title: temperature
     dew_point:
-      title: punto di rugiada
+      title: dew point
     remarks:
-      title: annotazioni
+      title: remarks
+

data/locales/it.yml

@@ -6,6 +6,10 @@ it:
   comparison:
     more_than: piú di
     less_than: meno di
+  tendency:
+    no_change: invariato
+    improving: in miglioramento
+    worsening: tendente a peggiorare
   units:
     pressure:
       bar:
@@ -34,6 +38,7 @@ it:
       variable_direction: direzione variabile
       unknown_direction: direzione sconosciuta
       unknown_speed: velocità sconosciuta
+      gusts: folate di
     variable_wind:
       title: variazione del vento
     visibility:
@@ -150,3 +155,4 @@ it:
       title: punto di rugiada
     remarks:
       title: annotazioni
+

data/spec/spec_helper.rb

@@ -0,0 +1,5 @@
+require 'rspec'
+require 'rspec/autorun'
+
+require File.expand_path( File.dirname(__FILE__) + '/../lib/metar' )
+

data/spec/unit/distance_spec.rb

@@ -0,0 +1,85 @@
+load File.expand_path( '../spec_helper.rb', File.dirname(__FILE__) )
+
+describe Metar::Distance do
+
+  context '#value' do
+
+    it 'should treat the parameter as meters' do
+      @distance = Metar::Distance.new( 12345.67 )
+
+      @distance.units.            should     == :meters
+      @distance.value.            should     == 12345.67
+    end
+
+  end
+
+  context '#to_s' do
+
+    it 'should default to meters' do
+      @distance = Metar::Distance.new( rand * 1000.0 )
+
+      @distance.to_s.             should     =~ %r(^\d+m)
+    end
+
+    it 'should round down to the nearest meter' do
+      @distance = Metar::Distance.new( 12.345 )
+
+      @distance.to_s.             should     == '12m'
+    end
+
+    it 'should round up to meters' do
+      @distance = Metar::Distance.new( 8.750 )
+
+      @distance.to_s.             should     == '9m'
+    end
+
+    it 'should allow units overrides' do
+      @distance = Metar::Distance.new( 12345.67 )
+
+      @distance.to_s( :units => :kilometers ).
+                                  should     == '12km'
+    end
+
+    it 'should allow precision overrides' do
+      @distance = Metar::Distance.new( 12.34567 )
+
+      @distance.to_s( :precision => 1 ).
+                                  should     == '12.3m'
+    end
+
+    it 'should handle nil' do
+      @distance = Metar::Distance.new( nil )
+
+      @distance.to_s.             should     == 'unknown'
+    end
+
+    context 'translated' do
+
+      before :each do
+        @locale     = I18n.locale
+        I18n.locale = :it
+      end
+
+      after :each do
+        I18n.locale = @locale
+      end
+
+      it 'should allow precision overrides' do
+        @distance = Metar::Distance.new( 12.34567 )
+
+        @distance.to_s( :precision => 1 ).
+                                    should     == '12,3m'
+      end
+
+      it 'should handle nil' do
+        @distance = Metar::Distance.new( nil )
+
+        @distance.to_s.           should     == 'sconosciuto'
+      end
+
+    end
+
+  end
+
+end
+

data/spec/unit/parser_spec.rb

@@ -0,0 +1,234 @@
+load File.expand_path( '../spec_helper.rb', File.dirname(__FILE__) )
+# encoding: utf-8
+
+describe Metar::Parser do
+
+  context '.for_cccc' do
+
+    it 'returns a loaded parser' do
+      station = stub( 'station' )
+      raw = stub( 'raw', :metar => "XXXX 061610Z 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000",
+                         :time  => '2010/02/06 16:10' )
+      Metar::Station.stub!( :new => station )
+      Metar::Raw.stub!( :new => raw )
+
+      parser = Metar::Parser.for_cccc( 'XXXX' )
+
+      parser.                     should     be_a( Metar::Parser )
+      parser.station_code.        should     == 'XXXX'
+    end
+         
+  end
+
+  context 'attributes' do
+
+    it '.location missing' do
+      expect do
+        setup_parser('PAIL', "2010/02/06 16:10\nFUBAR 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000") 
+      end.       to         raise_error( Metar::ParseError, /Expecting location/ )
+    end
+
+    it '.time missing' do
+      expect do
+        setup_parser('PAIL', "2010/02/06 16:10\nPAIL 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000") 
+      end.       to         raise_error( Metar::ParseError, /Expecting datetime/ )
+    end
+
+    it 'date' do
+      parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000")
+      parser.date.    should     == Date.new(2010, 2, 6)
+    end
+
+    context '.observer' do
+
+      it 'real' do
+        parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000")
+        parser.observer.          should     == :real
+      end
+
+      it 'auto' do
+        parser = setup_parser('CYXS', "2010/02/15 10:34\nCYXS 151034Z AUTO 09003KT 1/8SM FZFG VV001 M03/M03 A3019 RMK SLP263 ICG")
+
+        parser.observer.          should     == :auto
+      end
+
+      it 'corrected' do
+        parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z COR 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000")
+        parser.observer.          should     == :corrected
+      end
+      
+    end
+
+    it 'wind' do
+      parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000")
+      parser.wind.direction.value.   should  be_within( 0.0001 ).of( 240 )
+      parser.wind.speed.to_knots.   should  be_within( 0.0001 ).of( 6 )
+    end
+
+    it 'variable_wind' do
+      parser = setup_parser('LIRQ', "2010/02/06 15:20\nLIRQ 061520Z 01007KT 350V050 9999 SCT035 BKN080 08/02 Q1005")
+      parser.variable_wind.direction1.value.should be_within( 0.0001 ).of( 350 )
+      parser.variable_wind.direction2.value.should be_within( 0.0001 ).of( 50 )
+    end
+
+    context '.visibility' do
+      it 'CAVOK' do
+        parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z 24006KT CAVOK M17/M20 A2910 RMK AO2 P0000")
+
+        parser.visibility.distance.value.
+                                  should     be_within( 0.01 ).of( 10000.00 )
+        parser.visibility.comparator.
+                                  should     == :more_than
+        parser.present_weather.size.
+                                  should     == 1
+        parser.present_weather[ 0 ].phenomenon.
+                                  should     == 'No significant weather'
+        parser.sky_conditions.size.
+                                  should     == 1
+        parser.sky_conditions[ 0 ].type.
+                                  should     == nil
+      end
+
+      it 'visibility_miles_and_fractions' do
+        parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000")
+
+        parser.visibility.distance.to_miles.
+                                  should     be_within( 0.01 ).of( 1.75 )
+      end
+
+      it '//// with automatic observer' do
+        parser = setup_parser('CYXS', "2010/02/15 10:34\nCYXS 151034Z AUTO 09003KT //// FZFG VV001 M03/M03 A3019 RMK SLP263 ICG")
+
+        parser.visibility.        should     be_nil
+      end
+    end
+
+    it 'runway_visible_range' do
+      parser = setup_parser('ESSB', "2010/02/15 10:20\nESSB 151020Z 26003KT 2000 R12/1000N R30/1500N VV002 M07/M07 Q1013 1271//55")
+      parser.runway_visible_range.length.    should     == 2
+      parser.runway_visible_range[0].designator.    should     == '12'
+      parser.runway_visible_range[0].visibility1.distance.value.    should     == 1000
+      parser.runway_visible_range[0].tendency.    should     == :no_change
+    end
+
+    it 'runway_visible_range_defaults_to_empty_array' do
+      parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000")
+      parser.runway_visible_range.length.    should     == 0
+    end
+
+    it 'runway_visible_range_variable' do
+      parser = setup_parser('KPDX', "2010/02/15 11:08\nKPDX 151108Z 11006KT 1/4SM R10R/1600VP6000FT FG OVC002 05/05 A3022 RMK AO2")
+
+      parser.runway_visible_range[0].visibility1.distance.to_feet.    should     == 1600.0
+      parser.runway_visible_range[0].visibility2.distance.to_feet.    should     == 6000.0
+    end
+
+    context '.present_weather' do
+
+      it 'normal' do
+        parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000")
+
+        parser.present_weather.size.
+                                  should     == 1
+        parser.present_weather[0].modifier.
+                                  should     == 'light'
+        parser.present_weather[0].phenomenon.
+                                  should     == 'snow'
+      end
+
+      it 'auto + //' do
+        parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z AUTO 24006KT 1 3/4SM // BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000")
+
+        parser.present_weather.size.
+                                  should     == 1
+        parser.present_weather[0].phenomenon.
+                                  should     == 'not observed'
+      end
+
+    end
+
+    it 'present_weather_defaults_to_empty_array' do
+      parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z 24006KT 1 3/4SM BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000")
+      parser.present_weather.length.    should     == 0
+    end
+
+    context '.sky_conditions' do
+
+      it 'normal' do
+        parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000")
+
+        parser.sky_conditions.size.
+                                  should     == 2
+        parser.sky_conditions[0].quantity.
+                                  should     == 'broken'
+        parser.sky_conditions[0].height.value.
+                                  should     == 480
+        parser.sky_conditions[1].quantity.
+                                  should     == 'overcast'
+        parser.sky_conditions[1].height.value.
+                                  should     == 900
+      end
+
+      it 'auto + ///' do
+        parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z AUTO 24006KT 1 3/4SM /// M17/M20 A2910 RMK AO2 P0000")
+
+        parser.sky_conditions.size.
+                                  should     == 0
+      end
+
+    end
+
+    it 'sky_conditions_defaults_to_empty_array' do
+      parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z 24006KT 1 3/4SM -SN M17/M20 A2910 RMK AO2 P0000")
+      parser.sky_conditions.length.    should     == 0
+    end
+
+    it 'vertical_visibility' do
+      parser = setup_parser('CYXS', "2010/02/15 10:34\nCYXS 151034Z AUTO 09003KT 1/8SM FZFG VV001 M03/M03 A3019 RMK SLP263 ICG")
+      parser.vertical_visibility.value.    should     == 30
+    end
+
+    it 'temperature_obligatory' do
+      expect do
+        setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z 24006KT 1 3/4SM -SN BKN016 OVC030 A2910 RMK AO2 P0000")
+      end.       to         raise_error( Metar::ParseError )
+    end
+
+    it 'temperature' do
+      parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000")
+      parser.temperature.value.    should     == -17
+    end
+
+    it 'dew_point' do
+      parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000")
+      parser.dew_point.value.    should     == -20
+    end
+
+    it 'sea_level_pressure' do
+      parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000")
+      parser.sea_level_pressure.to_inches_of_mercury.    should     == 29.10
+    end
+
+    it 'remarks' do
+      parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000")
+      parser.remarks.   should be_a Array
+      parser.remarks.length.    should     == 2
+      parser.remarks[0].    should     == 'AO2'
+      parser.remarks[1].    should     == 'P0000'
+    end
+
+    it 'remarks_defaults_to_empty_array' do
+      parser = setup_parser('PAIL', "2010/02/06 16:10\nPAIL 061610Z 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910")
+      parser.remarks.   should be_a Array
+      parser.remarks.length.    should     == 0
+    end
+  
+    def setup_parser( cccc, metar )
+      raw = Metar::Raw.new( cccc, metar )
+      Metar::Parser.new( raw )
+    end
+
+  end
+
+end
+