metanorma-standoc 2.3.4 → 2.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 62a2a480483e6cad337d48919668d1276a587c0c6173ffc7ea8cb773f605b1fb
-  data.tar.gz: 5a9bf620c79d8ec2993a96727f7b8c2874ee8d8c3865a5efd71941fb83ed8fc1
+  metadata.gz: 0f9f12b5e7f44419a449863f517b7d2d285b904f9e33380cbd42bfd1c91043f2
+  data.tar.gz: f7b1ed6976dfcf5711f6c287d9c442e82bbc754278f843b0f2066f7f046efab6
 SHA512:
-  metadata.gz: 226d8eaa68590e2dbf12917371afe5f2c4c60242397e459543da0ec3471a7a0abc7f5736e92b43f053854329f460bbc70155040bd0ae1df89efa0a62f8765d8e
-  data.tar.gz: 65a7c4e9794199fd48f3d18f3009a41d02ae837753d9e9e9cd41f755384f7b89f3376f5a6c9182de5f184eb4934a9fc9682b8ea708037aa315d9e243f83485bf
+  metadata.gz: d53ac6951b2ad0e44ae89353ea98d4fbe4790171677fcf0e995fc269c8a760853589d668ea2ee31f151edbb04cbc3931c60f45c22b9b809ee52d94da40443b79
+  data.tar.gz: 8381ff1864c867d118d60111752882ed3c5566301dfb7339e3bb10902c41e1bda29b23c755c4564a0a154304d0ddb18c28782e984dc55c6d3990753d6a42acfe

data/lib/metanorma/standoc/validate.rb

@@ -42,12 +42,11 @@ module Metanorma
       end
 
       def content_validate(doc)
-        nested_asset_validate_basic(doc)
-        nested_note_validate(doc)
-        xref_validate(doc)
+        repeat_id_validate(doc.root) # feeds xref_validate
+        xref_validate(doc) # feeds nested_asset_validate
+        nested_asset_validate(doc)
         section_validate(doc)
         norm_ref_validate(doc)
-        repeat_id_validate(doc.root)
         iev_validate(doc.root)
         concept_validate(doc, "concept", "refterm")
         concept_validate(doc, "related", "preferred//name")
@@ -58,6 +57,11 @@ module Metanorma
           clean_abort(@fatalerror.join("\n"), doc)
       end
 
+      def nested_asset_validate(doc)
+        nested_asset_validate_basic(doc)
+        nested_note_validate(doc)
+      end
+
       def nested_asset_validate_basic(doc)
         a = "//formula | //example | //figure | //termnote | //termexample | " \
             "//table"
@@ -78,9 +82,14 @@ module Metanorma
 
       def nested_asset_report(outer, inner, _doc)
         outer.name == "figure" && inner.name == "figure" and return
-        err = "There is an instance of #{inner.name} nested within #{outer.name}"
+        err =
+          "There is an instance of #{inner.name} nested within #{outer.name}"
         @log.add("Syntax", inner, err)
-        @fatalerror << "#{err}:\n#{inner.to_xml}"
+        i = @doc_xrefs[inner["id"]] or return
+        err2 = "There is a crossreference to an instance of #{inner.name} " \
+               "nested within #{outer.name}: #{i.to_xml}"
+        @log.add("Style", i, err2)
+        @fatalerror << err2
       end
 
       def norm_ref_validate(doc)
@@ -103,8 +112,8 @@ module Metanorma
           @log.add("Anchors", x, concept_validate_msg(doc, tag, refterm, x))
           found = true
         end
-        found and
-          @fatalerror << "#{tag.capitalize} not cross-referencing term or symbol"
+        found and @fatalerror << "#{tag.capitalize} not cross-referencing " \
+                                 "term or symbol"
       end
 
       def concept_validate_ids(doc)
@@ -126,20 +135,19 @@ module Metanorma
         ret
       end
 
-      def repeat_id_validate1(ids, elem)
-        if ids[elem["id"]]
+      def repeat_id_validate1(elem)
+        if @doc_ids[elem["id"]]
           @log.add("Anchors", elem, "Anchor #{elem['id']} has already been " \
-                                    "used at line #{ids[elem['id']]}")
+                                    "used at line #{@doc_ids[elem['id']]}")
           @fatalerror << "Multiple instances of same ID: #{elem['id']}"
-        else ids[elem["id"]] = elem.line
         end
-        ids
+        @doc_ids[elem["id"]] = elem.line
       end
 
       def repeat_id_validate(doc)
-        ids = {}
+        @doc_ids = {}
         doc.xpath("//*[@id]").each do |x|
-          ids = repeat_id_validate1(ids, x)
+          repeat_id_validate1(x)
         end
       end
 
@@ -188,11 +196,12 @@ module Metanorma
 
       # manually check for xref/@target, xref/@to integrity
       def xref_validate(doc)
-        ids = doc.xpath("//*/@id").each_with_object({}) { |x, m| m[x.text] = 1 }
-        doc.xpath("//xref/@target | //xref/@to").each do |x|
-          ids[x.text] and next
+        @doc_xrefs = doc.xpath("//xref/@target | //xref/@to")
+          .each_with_object({}) do |x, m|
+          m[x.text] = x
+          @doc_ids[x] and next
           @log.add("Anchors", x.parent,
-                   "Crossreference target #{x.text} is undefined")
+                   "Crossreference target #{x} is undefined")
         end
       end
 

data/lib/metanorma/standoc/version.rb

@@ -19,6 +19,6 @@ module Metanorma
   end
 
   module Standoc
-    VERSION = "2.3.4".freeze
+    VERSION = "2.3.5".freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: metanorma-standoc
 version: !ruby/object:Gem::Version
-  version: 2.3.4
+  version: 2.3.5
 platform: ruby
 authors:
 - Ribose Inc.