metanorma-standoc 1.9.1 → 1.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 03a2df03031208cf9cd54413c1dc342f748c3978a2e189f9cf4ae369fcc1820c
-  data.tar.gz: fc94c4cc2a0e117c06f41d709d8e5d6a6f3f0ba6e1ffc8a6ccdfb60b91ed3ffd
+  metadata.gz: b3b789e06df237e881bdd055cfe9b90e191d781e71e82dd6a80c098f23b08934
+  data.tar.gz: 27f1499d7f7adccf29c2b9c9ac731e6ff1988a008530a4aa13e63adb4fbef490
 SHA512:
-  metadata.gz: 32bac104b6523e30e510ada3e1e25861139b62c66c8d7bbcb782284648622b5f1da48acd8a6e97f511ead0baca45c7903ac7f31c1023596becc473d08deea87f
-  data.tar.gz: 4c0ee4e816c81ca1e98d5bbbb47ad2c755feca016c0b5ddae5283688291813e0d1d511444835d7bee1979dc49ef3d664a7d1966938b46b3a5ad0f2dd9a0da6d2
+  metadata.gz: c72e91aac553b2e9d3151a59fde54b02ae5cb6340aeb0781dd4326d5a6bce3166e20fd2ece37d909c3e8b7f72d6d26892bd279d4256b190cf28dbe41e1bdbf3e
+  data.tar.gz: 8314c96a3af15b47d56c42cd040e369455616b40dafb37a3d2ee32d0ba46976293eee36f3b9ab99d3b2d94002df3f3bf0a319e98f262e0d5eb3049fb90c30d4f

data/.rubocop.yml

@@ -10,5 +10,3 @@ AllCops:
   DisplayCopNames: false
   StyleGuideCopsOnly: false
   TargetRubyVersion: 2.4
-Rails:
-  Enabled: true

data/lib/asciidoctor/standoc/blocks.rb

@@ -30,6 +30,7 @@ module Asciidoctor
       def open(node)
         role = node.role || node.attr("style")
         reqt_subpart(role) and return requirement_subpart(node)
+        role == "form" and return form(node)
         result = []
         node.blocks.each do |b|
           result << send(b.context, b)
@@ -37,6 +38,17 @@ module Asciidoctor
         result
       end
 
+      def form(node)
+        noko do |xml|
+          xml.form **attr_code(
+            id: Metanorma::Utils::anchor_or_uuid,
+            name: node.attr("name"), action: node.attr("action")
+          ) do |f|
+            f << node.content
+          end
+        end
+      end
+
       def literal_attrs(node)
         attr_code(id_attr(node).merge(keep_attrs(node)))
       end
@@ -71,11 +83,14 @@ module Asciidoctor
 
       def example(node)
         return term_example(node) if in_terms?
+
         role = node.role || node.attr("style")
         %w(recommendation requirement permission).include?(role) and
           return requirement(node, role)
         return pseudocode_example(node) if role == "pseudocode"
         return svgmap_example(node) if role == "svgmap"
+        return form(node) if role == "form"
+
         example_proper(node)
       end
 
@@ -91,9 +106,9 @@ module Asciidoctor
         noko do |xml|
           xml.svgmap **attr_code(svgmap_attrs(node).merge(
             src: node.attr("src"), alt: node.attr("alt"))) do |ex|
-            figure_title(node, ex)
-            ex << node.content
-          end
+              figure_title(node, ex)
+              ex << node.content
+            end
         end.join("\n")
       end
 

data/lib/asciidoctor/standoc/blocks_notes.rb

@@ -2,33 +2,41 @@ module Asciidoctor
   module Standoc
     module Blocks
       def termnote_attrs(node)
-        attr_code(id_attr(node).merge(
-          unnumbered: node.attr("unnumbered"),
-          number: node.attr("number"),
-          subsequence: node.attr("subsequence"),
-          "keep-with-next": node.attr("keep-with-next"),
-          "keep-lines-together": node.attr("keep-with-next"),
-          "keep-separate": node.attr("keep-separate")))
+        attr_code(
+          id_attr(node).merge(
+            unnumbered: node.attr("unnumbered"),
+            number: node.attr("number"),
+            subsequence: node.attr("subsequence"),
+            "keep-with-next": node.attr("keep-with-next"),
+            "keep-lines-together": node.attr("keep-with-next"),
+            "keep-separate": node.attr("keep-separate")
+          )
+        )
       end
 
       def note_attrs(node)
-        attr_code(termnote_attrs(node)
-          .merge(
-        type: node.attr("type"),
-        beforeclauses: node.attr("beforeclauses") == "true" ? "true" : nil
-        ))
+        attr_code(
+          termnote_attrs(node).merge(
+            type: node.attr("type"),
+            beforeclauses: node.attr("beforeclauses") == "true" ? "true" : nil
+          )
+        )
       end
 
       def sidebar_attrs(node)
-        todo_attrs(node).merge(attr_code(
-          from: node.attr("from"), to: node.attr("to") || node.attr("from") ))
+        todo_attrs(node).merge(
+          attr_code(
+            from: node.attr("from"),
+            to: node.attr("to") || node.attr("from")
+          )
+        )
       end
 
       def sidebar(node)
         return unless draft?
 
         noko do |xml|
-          xml.review **(sidebar_attrs(node)) do |r|
+          xml.review **sidebar_attrs(node) do |r|
             wrap_in_para(node, r)
           end
         end
@@ -73,9 +81,12 @@ module Asciidoctor
         a = node.attr("type") and ["danger", "safety precautions"].each do |t|
           name = t if a.casecmp(t).zero?
         end
-        attr_code(keep_attrs(node)
-          .merge(id: Metanorma::Utils::anchor_or_uuid(node), type: name,
-        beforeclauses: node.attr("beforeclauses") == "true" ? "true" : nil))
+        attr_code(
+          keep_attrs(node).merge(
+            id: Metanorma::Utils::anchor_or_uuid(node), type: name,
+            beforeclauses: node.attr("beforeclauses") == "true" ? "true" : nil
+          )
+        )
       end
 
       def admonition(node)

data/lib/asciidoctor/standoc/cleanup.rb

@@ -33,6 +33,7 @@ module Asciidoctor
         obligations_cleanup(xmldoc)
         table_cleanup(xmldoc)
         formula_cleanup(xmldoc)
+        form_cleanup(xmldoc)
         sourcecode_cleanup(xmldoc)
         figure_cleanup(xmldoc)
         element_name_cleanup(xmldoc)

data/lib/asciidoctor/standoc/cleanup_block.rb

@@ -37,15 +37,15 @@ module Asciidoctor
         end
       end
 
-      def insert_thead(s)
-        thead = s.at("./thead")
+      def insert_thead(table)
+        thead = table.at("./thead")
         return thead unless thead.nil?
 
-        if tname = s.at("./name")
+        if tname = table.at("./name")
           thead = tname.add_next_sibling("<thead/>").first
           return thead
         end
-        s.children.first.add_previous_sibling("<thead/>").first
+        table.children.first.add_previous_sibling("<thead/>").first
       end
 
       def header_rows_cleanup(xmldoc)
@@ -144,7 +144,7 @@ module Asciidoctor
       ELEMS_ALLOW_NOTES = %w[p formula ul ol dl figure].freeze
 
       # if a note is at the end of a section, it is left alone
-      # if a note is followed by a non-note block, 
+      # if a note is followed by a non-note block,
       # it is moved inside its preceding block if it is not delimited
       # (so there was no way of making that block include the note)
       def note_cleanup(xmldoc)
@@ -164,7 +164,7 @@ module Asciidoctor
 
       def link_callouts_to_annotations(callouts, annotations)
         callouts.each_with_index do |c, i|
-          c["target"] = "_" + UUIDTools::UUID.random_create
+          c["target"] = "_#{UUIDTools::UUID.random_create}"
           annotations[i]["id"] = c["target"]
         end
       end
@@ -195,25 +195,43 @@ module Asciidoctor
         xmldoc.xpath("//sourcecode").each do |x|
           x.traverse do |n|
             next unless n.text?
-            next unless /#{Regexp.escape(@sourcecode_markup_start)}/.match?(n.text)
+            next unless /#{Regexp.escape(@sourcecode_markup_start)}/
+              .match?(n.text)
 
             n.replace(sourcecode_markup(n))
           end
         end
       end
 
-      def sourcecode_markup(n)
+      def safe_noko(text, doc)
+        Nokogiri::XML::Text.new(text, doc).to_xml(
+          encoding: "US-ASCII",
+          save_with: Nokogiri::XML::Node::SaveOptions::NO_DECLARATION
+        )
+      end
+
+      def sourcecode_markup(node)
         acc = []
-        n.text.split(/(#{Regexp.escape(@sourcecode_markup_start)}|#{Regexp.escape(@sourcecode_markup_end)})/)
+        node.text.split(/(#{Regexp.escape(@sourcecode_markup_start)}|
+                          #{Regexp.escape(@sourcecode_markup_end)})/x)
           .each_slice(4).map do |a|
-          acc << Nokogiri::XML::Text.new(a[0], n.document)
-            .to_xml(encoding: "US-ASCII", save_with: Nokogiri::XML::Node::SaveOptions::NO_DECLARATION)
+          acc << safe_noko(a[0], node.document)
           next unless a.size == 4
 
-          acc << Asciidoctor.convert(a[2], backend: (self&.backend&.to_sym || :standoc), doctype: :inline)
+          acc << Asciidoctor.convert(
+            a[2], doctype: :inline, backend: (self&.backend&.to_sym || :standoc)
+          )
         end
         acc.join
       end
+
+      def form_cleanup(xmldoc)
+        xmldoc.xpath("//select").each do |s|
+          while s&.next_element&.name == "option"
+            s << s.next_element
+          end
+        end
+      end
     end
   end
 end

data/lib/asciidoctor/standoc/cleanup_boilerplate.rb

@@ -39,11 +39,15 @@ module Asciidoctor
       end
 
       def norm_ref_preface(ref)
-        refs = ref.elements.select do |e|
-          %w(references bibitem).include? e.name
+        if ref.at("./note[@type = 'boilerplate']")
+          unwrap_boilerplate_clauses(ref, ".")
+        else
+          refs = ref.elements.select do |e|
+            %w(references bibitem).include? e.name
+          end
+          pref = refs.empty? ? @i18n.norm_empty_pref : @i18n.norm_with_refs_pref
+          ref.at("./title").next = "<p>#{pref}</p>"
         end
-        pref = refs.empty? ? @i18n.norm_empty_pref : @i18n.norm_with_refs_pref
-        ref.at("./title").next = "<p>#{pref}</p>"
       end
 
       TERM_CLAUSE = "//sections/terms | "\
@@ -69,25 +73,32 @@ module Asciidoctor
         xmldoc.xpath("//terms/p | //terms/ul").each(&:remove)
       end
 
-      def termdef_unwrap_boilerplate_clauses(xmldoc)
-        xmldoc.xpath(self.class::TERM_CLAUSE).each do |f|
-          f.xpath(".//clause[@type = 'boilerplate']").each do |c|
+      def unwrap_boilerplate_clauses(xmldoc, xpath)
+        xmldoc.xpath(xpath).each do |f|
+          f.xpath(".//clause[@type = 'boilerplate'] | "\
+                  ".//note[@type = 'boilerplate']").each do |c|
             c&.at("./title")&.remove
             c.replace(c.children)
           end
         end
       end
 
-      def boilerplate_cleanup(xmldoc)
-        isodoc = boilerplate_isodoc(xmldoc)
-        termdef_boilerplate_cleanup(xmldoc)
+      def termdef_boilerplate_insert(xmldoc, isodoc, once = false)
         xmldoc.xpath(self.class::TERM_CLAUSE).each do |f|
           next if f.at("./clause[@type = 'boilerplate']")
 
-          term_defs_boilerplate(f.at("./title"), xmldoc.xpath(".//termdocsource"),
+          term_defs_boilerplate(f.at("./title"),
+                                xmldoc.xpath(".//termdocsource"),
                                 f.at(".//term"), f.at(".//p"), isodoc)
+          break if once
         end
-        termdef_unwrap_boilerplate_clauses(xmldoc)
+      end
+
+      def boilerplate_cleanup(xmldoc)
+        isodoc = boilerplate_isodoc(xmldoc)
+        termdef_boilerplate_cleanup(xmldoc)
+        termdef_boilerplate_insert(xmldoc, isodoc)
+        unwrap_boilerplate_clauses(xmldoc, self.class::TERM_CLAUSE)
         f = xmldoc.at(self.class::NORM_REF) and norm_ref_preface(f)
         initial_boilerplate(xmldoc, isodoc)
       end

data/lib/asciidoctor/standoc/cleanup_ref.rb

@@ -74,8 +74,9 @@ module Asciidoctor
 
       def normref_cleanup(xmldoc)
         r = xmldoc.at(self.class::NORM_REF) || return
-        preface = r.xpath("./title/following-sibling::*") & # intersection
-          r.xpath("./bibitem[1]/preceding-sibling::*")
+        preface = ((r.xpath("./title/following-sibling::*") & # intersection
+                    r.xpath("./bibitem[1]/preceding-sibling::*")) -
+        r.xpath("./note[@type = 'boilerplate']/descendant-or-self::*"))
         preface.each(&:remove)
       end
 

data/lib/asciidoctor/standoc/converter.rb

@@ -41,6 +41,11 @@ module Asciidoctor
         inline_macro Asciidoctor::Standoc::IndexRangeInlineMacro
         inline_macro Asciidoctor::Standoc::AddMacro
         inline_macro Asciidoctor::Standoc::DelMacro
+        inline_macro Asciidoctor::Standoc::FormInputMacro
+        inline_macro Asciidoctor::Standoc::FormLabelMacro
+        inline_macro Asciidoctor::Standoc::FormTextareaMacro
+        inline_macro Asciidoctor::Standoc::FormSelectMacro
+        inline_macro Asciidoctor::Standoc::FormOptionMacro
         block Asciidoctor::Standoc::ToDoAdmonitionBlock
         treeprocessor Asciidoctor::Standoc::ToDoInlineAdmonitionBlock
         block Asciidoctor::Standoc::PlantUMLBlockMacro
@@ -78,8 +83,8 @@ module Asciidoctor
         attr_accessor :_file
       end
 
-      def self.inherited(k)
-        k._file = caller_locations.first.absolute_path
+      def self.inherited(konv) # rubocop:disable Lint/MissingSuper
+        konv._file = caller_locations(1..1).first.absolute_path
       end
 
       # path to isodoc assets in child gems

data/lib/asciidoctor/standoc/datamodel/plantuml_renderer.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
-require 'erb'
+require "erb"
 
 module Asciidoctor
   module Datamodel
     class PlantumlRenderer
-      TEMPLATES_PATH = File.expand_path('../views/datamodel', __dir__).freeze
+      TEMPLATES_PATH = File.expand_path("../views/datamodel", __dir__).freeze
 
       attr_reader :yml, :plantuml_path
 
@@ -15,23 +15,23 @@ module Asciidoctor
       end
 
       def join_as_plantuml(*ary)
-        ary.compact.join("\n").sub(/\s+\Z/, '')
+        ary.compact.join("\n").sub(/\s+\Z/, "")
       end
 
       def render
         ERB.new(
           File.read(
-            File.join(TEMPLATES_PATH, 'plantuml_representation.adoc.erb')
+            File.join(TEMPLATES_PATH, "plantuml_representation.adoc.erb")
           )
         ).result(binding)
       end
 
       def diagram_caption
-        yml['caption']
+        yml["caption"]
       end
 
       def imports_yml_to_plantuml
-        return if empty?(yml, 'imports')
+        return if empty?(yml, "imports")
 
         <<~TEMPLATE
           '******* IMPORTS ******************************************************
@@ -40,7 +40,7 @@ module Asciidoctor
       end
 
       def class_defs_yml_to_plantuml
-        return if empty?(yml, 'classes') && empty?(yml, 'enums')
+        return if empty?(yml, "classes") && empty?(yml, "enums")
 
         <<~TEMPLATE
           '******* CLASS DEFINITIONS ********************************************
@@ -52,7 +52,7 @@ module Asciidoctor
       end
 
       def class_groups_yml_to_plantuml
-        return if empty?(yml, 'groups')
+        return if empty?(yml, "groups")
 
         <<~TEMPLATE
           '******* CLASS GROUPS *************************************************
@@ -63,7 +63,7 @@ module Asciidoctor
       end
 
       def class_relations_yml_to_plantuml
-        return if empty?(yml, 'classes') && empty?(yml, 'relations')
+        return if empty?(yml, "classes") && empty?(yml, "relations")
 
         <<~TEMPLATE
           '******* CLASS RELATIONS **********************************************
@@ -75,7 +75,7 @@ module Asciidoctor
       end
 
       def diagram_options_yml_to_plantuml
-        return if empty?(yml, 'diagram_options')
+        return if empty?(yml, "diagram_options")
 
         <<~TEMPLATE
           '******* DIAGRAM SPECIFIC CONFIG **************************************
@@ -86,7 +86,7 @@ module Asciidoctor
       end
 
       def bottom_yml_to_plantuml
-        return if empty?(yml, 'bottom')
+        return if empty?(yml, "bottom")
 
         <<~TEMPLATE
           '******* BOTTOM OVERRIDE CONFIG **************************************
@@ -95,7 +95,7 @@ module Asciidoctor
       end
 
       def fidelity_yml_to_plantuml
-        return if empty?(yml, 'fidelity')
+        return if empty?(yml, "fidelity")
 
         <<~TEMPLATE
           '******* FIDELITY *****************************************************
@@ -133,7 +133,7 @@ module Asciidoctor
 
         attributes.map do |(attr_name, attr_hash)|
           attribute_to_plantuml(attr_name, attr_hash)
-        end.join('').sub(/\n\Z/, '')
+        end.join("").sub(/\n\Z/, "")
       end
 
       def attribute_to_plantuml(attr_name, attr_hash)
@@ -143,9 +143,10 @@ module Asciidoctor
       end
 
       def attribute_cardinality_plantuml(cardinality, with_bracket = true)
-        return '' if cardinality.nil? ||
-                     (cardinality['min'] == cardinality['max'] &&
-                       cardinality['min'] == 1)
+        return "" if cardinality.nil? ||
+          (cardinality["min"] == cardinality["max"] &&
+            cardinality["min"] == 1)
+
         card = "#{cardinality['min']}..#{cardinality['max']}"
         return card unless with_bracket
 
@@ -172,7 +173,7 @@ module Asciidoctor
       def classes_to_relations_plantuml(classes)
         output_ary = classes.map do |(class_name, class_hash)|
           class_hash ||= {}
-          relations = class_hash['relations']
+          relations = class_hash["relations"]
           relations_to_plantuml(class_name, relations)
         end
 
@@ -183,9 +184,9 @@ module Asciidoctor
         return unless relations
 
         output_ary = relations.map do |relation|
-          source = class_name || relation['source']
+          source = class_name || relation["source"]
           relation_to_plantuml(source,
-                               relation['target'],
+                               relation["target"],
                                relation)
         end
 
@@ -194,41 +195,41 @@ module Asciidoctor
 
       def relation_arrow(relationship, relation)
         [
-          relationship_type_to_plantuml('source',
-                                        relationship['source']['type']),
-          (relation['direction']).to_s,
-          relationship_type_to_plantuml('target',
-                                        relationship['target']['type'])
-        ].compact.join('-')
+          relationship_type_to_plantuml("source",
+                                        relationship["source"]["type"]),
+          (relation["direction"]).to_s,
+          relationship_type_to_plantuml("target",
+                                        relationship["target"]["type"]),
+        ].compact.join("-")
       end
 
       def relation_label(action)
-        return '' unless action
+        return "" unless action
 
-        case action['direction']
-        when 'source'
+        case action["direction"]
+        when "source"
           " : < #{action['verb']}"
-        when 'target'
+        when "target"
           " : #{action['verb']} >"
         else
-          ''
+          ""
         end
       end
 
       def source_arrow_end(source, relationship)
         source_attribute = relationship_cardinality_to_plantuml(
-          relationship['source']['attribute']
+          relationship["source"]["attribute"]
         )
-        [source, source_attribute].join(' ')
+        [source, source_attribute].join(" ")
       end
 
       def target_arrow_end(target, relationship, action)
         target_attribute = relationship_cardinality_to_plantuml(
-          relationship['target']['attribute']
+          relationship["target"]["attribute"]
         )
         [
-          [target_attribute, target].join(' '),
-          relation_label(action)
+          [target_attribute, target].join(" "),
+          relation_label(action),
         ].join
       end
 
@@ -239,9 +240,9 @@ module Asciidoctor
       end
 
       def relation_to_plantuml(source, target, relation)
-        relationship = relation['relationship'] || {}
-        relationship['source'] ||= {}
-        relationship['target'] ||= {}
+        relationship = relation["relationship"] || {}
+        relationship["source"] ||= {}
+        relationship["target"] ||= {}
         relation_output_lines(source, target, relation, relationship)
       end
 
@@ -249,22 +250,22 @@ module Asciidoctor
         output_lines = [
           source_arrow_end(source, relationship),
           relation_arrow(relationship, relation),
-          target_arrow_end(target, relationship, relation['action']),
-          relation_association(source, target, relationship['association'])
-        ].join(' ')
+          target_arrow_end(target, relationship, relation["action"]),
+          relation_association(source, target, relationship["association"]),
+        ].join(" ")
 
         join_as_plantuml(*output_lines)
       end
 
       def relationship_type_to_plantuml(relation_end, relationship_type)
-        is_source = (relation_end == 'source')
+        is_source = (relation_end == "source")
         mappings = {
-          'direct' => is_source ? '<' : '>',
-          'inheritance' => is_source ? '<|' : '|>',
-          'composition' => '*',
-          'aggregation' => 'o'
+          "direct" => is_source ? "<" : ">",
+          "inheritance" => is_source ? "<|" : "|>",
+          "composition" => "*",
+          "aggregation" => "o",
         }
-        mappings.fetch(relationship_type, '')
+        mappings.fetch(relationship_type, "")
       end
 
       def relationship_cardinality_to_plantuml(attribute)
@@ -273,12 +274,12 @@ module Asciidoctor
         return unless attribute_name
 
         attribute_hash = attribute[attribute_name] || {}
-        card = attribute_cardinality(attribute_hash['cardinality'])
+        card = attribute_cardinality(attribute_hash["cardinality"])
         "\"+#{attribute_name}#{card}\""
       end
 
       def attribute_cardinality(attribute_cardinality)
-        cardinality = ''
+        cardinality = ""
         if attribute_cardinality
           cardinality = attribute_cardinality_plantuml(
             attribute_cardinality,
@@ -308,7 +309,7 @@ module Asciidoctor
       end
 
       def model_stereotype_to_plantuml(model_stereotype)
-        return '' unless model_stereotype
+        return "" unless model_stereotype
 
         " <<#{model_stereotype}>>"
       end
@@ -325,7 +326,7 @@ module Asciidoctor
         groups ||= []
         return if groups.empty?
 
-        groups.reduce('') do |output, group|
+        groups.reduce("") do |output, group|
           output += "\ntogether {\n"
           group.each do |class_name|
             output += "\nclass #{class_name}\n"
@@ -350,9 +351,9 @@ module Asciidoctor
       end
 
       def format_hidden_class(accum, fidelity_classes, class_hash)
-        return accum if class_hash['relations'].nil?
+        return accum if class_hash["relations"].nil?
 
-        class_hash['relations'].each_with_object(accum) do |relation, acc|
+        class_hash["relations"].each_with_object(accum) do |relation, acc|
           format_source_target_relation(relation, fidelity_classes, acc)
           format_association_relation(relation, fidelity_classes, acc)
         end
@@ -367,36 +368,36 @@ module Asciidoctor
       end
 
       def format_association_relation(relation, fidelity_classes, acc)
-        return unless relation['relationship'] &&
-                      relation['relationship']['association']
+        return unless relation["relationship"] &&
+          relation["relationship"]["association"]
 
-        association = relation['relationship']['association']
+        association = relation["relationship"]["association"]
         return unless association && !fidelity_classes.key?(association)
 
         acc.merge!(association => true)
       end
 
       def hide_other_classes(fidelity)
-        return '' if fidelity.nil? || fidelity['classes'].nil?
+        return "" if fidelity.nil? || fidelity["classes"].nil?
 
-        output = ''
-        hidden_classes = fidelity['classes']
-                         .reduce({}) do |acc, (_class_name, class_hash)|
-          format_hidden_class(acc, fidelity['classes'], class_hash)
+        output = ""
+        hidden_classes = fidelity["classes"]
+          .reduce({}) do |acc, (_class_name, class_hash)|
+          format_hidden_class(acc, fidelity["classes"], class_hash)
         end
 
-        hidden_classes.keys.each do |hidden_class_name|
+        hidden_classes.each_key do |hidden_class_name|
           output += "\nhide #{hidden_class_name}\n"
         end
         output
       end
 
       def fidelity_to_plantuml(fidelity)
-        return '' if fidelity.nil?
+        return "" if fidelity.nil?
 
-        output = ''
-        output += hide_other_classes(fidelity) if fidelity['hideOtherClasses']
-        output += "\nhide members\n" if fidelity['hideMembers']
+        output = ""
+        output += hide_other_classes(fidelity) if fidelity["hideOtherClasses"]
+        output += "\nhide members\n" if fidelity["hideMembers"]
         output
       end