metanol 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 192b22e268ed2c08e3b83a989deba1c79035530b
-  data.tar.gz: 779557ee8a0cc78ac1ccabca931e741cc1a833ef
+SHA256:
+  metadata.gz: e5771b8a423b2a00649874c37703d23e4f1887bdacff02782d6114c00d25212e
+  data.tar.gz: edf84eae277f6304f323389f3fc52db66cec0c5c330c5c09a1591297ba180e01
 SHA512:
-  metadata.gz: b5a924dcf8196ae2a6d12c860b7aa792b547d54b38618688ad4ed215bb0854a7116534b21c14acef8fed6f4692c166fcb094dc5b512cef1bdfac2e2a00828c4c
-  data.tar.gz: 67cc4bab0f137f8dc6d99be1dedafbbd58fba91e8e64171ec09a0fe3caf341e287a6f95e0ef9339a81acca8188c44718123a5979c39c1e0a32caa664eb450162
+  metadata.gz: 77128d58842a5402013506b29993e9f29ad4ace21b1589b58df4d2b89b15e5c41a77eea1b2328f93ab0dde424c2e2909f95b4553a524da01658f79cbabdc1fa6
+  data.tar.gz: 8ead28875a8abe6785e80cb8d2ad1e43571e3f3e92c5141063b5c3db97aaeaabfdefe5ae7b0dda0aa28fa7be4b7efb7fe9eb85c994d27f6335a871e95d1a7136

data/.gitignore

@@ -1,19 +1,28 @@
-*.gem
-*.rbc
-.bundle
-.config
-.yardoc
-Gemfile.lock
-InstalledFiles
-_yardoc
-coverage
-doc/
-lib/bundler/man
-pkg
-rdoc
-spec/reports
-test/tmp
-test/version_tmp
-tmp
+/.bundle/
+/.yardoc
+/_yardoc/
+/coverage/
+/doc/
+/pkg/
+/spec/reports/
+/tmp/
+
+# rspec failure tracking
+.rspec_status
+
+# Ignore all logfiles and tempfiles.
+/log/*
+/tmp/*
 .idea/
-log/
+!/log/.keep
+!/tmp/.keep
+
+.DS_Store
+.byebug_history
+
+# Ignore ruby version and gemset
+.ruby-gemset
+.ruby-version
+
+# Ignore bin folder
+/bin/

data/.overcommit.yml

@@ -0,0 +1,73 @@
+gemfile: '.overcommit_gems'
+
+CommitMsg:
+  ALL:
+    requires_files: false
+    quiet: false
+
+  EmptyMessage:
+    enabled: true
+    description: 'Checking for empty commit message'
+    quiet: true
+
+  SingleLineSubject:
+    enabled: true
+    description: 'Checking subject line'
+
+  TextWidth:
+    enabled: true
+    description: 'Checking commit subject and body width'
+    max_subject_width: 60
+    max_body_width: 72
+
+  TrailingPeriod:
+    enabled: true
+    description: 'Checking for trailing periods in commit subject'
+
+PreCommit:
+  ALL:
+    problem_on_unmodified_line: report
+    requires_files: true
+    required: true
+    quiet: false
+
+  AuthorEmail:
+    enabled: true
+    description: 'Checking author email'
+    requires_files: false
+    pattern: '^[^@]+@.*$'
+
+  AuthorName:
+    enabled: true
+    description: 'Checking author name'
+    requires_files: false
+
+  BrokenSymlinks:
+    enabled: false # this was enabled by default
+    description: 'Checking for broken symlinks'
+
+  CaseConflicts:
+    enabled: true
+    description: 'Checking for case-insensitivity conflicts'
+
+  MergeConflicts:
+    enabled: true
+    description: 'Checking for merge conflicts'
+    required_executable: 'grep'
+    flags: ['-IHn', "^<<<<<<<[ \t]"]
+
+  RuboCop:
+    enabled: true
+    required: true
+    problem_on_unmodified_line: ignore
+    description: 'Analyzing ruby code with RuboCop'
+    required_executable: 'rubocop'
+    flags: ['--format=emacs', '--force-exclusion', '--display-cop-names', '--require=rubocop-rspec', '--require=rubocop-rails']
+    command: ['bundle', 'exec', 'rubocop']
+    install_command: 'gem install rubocop'
+    include:
+      - '**/*.rake'
+      - '**/*.rb'
+      - '**/*.ru'
+      - '**/Gemfile'
+      - '**/.overcommit_gems'

data/.overcommit_gems

@@ -0,0 +1,8 @@
+source 'https://rubygems.org'
+
+gem 'overcommit', '0.58.0'
+gem 'rubocop', '1.21.0'
+gem 'rubocop-performance', '1.11.5'
+gem 'rubocop-rails', '2.12.2'
+gem 'rubocop-rspec', '2.4.0'
+gem 'rubocop-faker', '1.1.0'

data/.overcommit_gems.lock

@@ -0,0 +1,72 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (6.1.4.1)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+      zeitwerk (~> 2.3)
+    ast (2.4.2)
+    childprocess (4.1.0)
+    concurrent-ruby (1.1.9)
+    faker (2.19.0)
+      i18n (>= 1.6, < 2)
+    i18n (1.8.10)
+      concurrent-ruby (~> 1.0)
+    iniparse (1.5.0)
+    minitest (5.14.4)
+    overcommit (0.58.0)
+      childprocess (>= 0.6.3, < 5)
+      iniparse (~> 1.4)
+      rexml (~> 3.2)
+    parallel (1.21.0)
+    parser (3.0.2.0)
+      ast (~> 2.4.1)
+    rack (2.2.3)
+    rainbow (3.0.0)
+    regexp_parser (2.1.1)
+    rexml (3.2.5)
+    rubocop (1.21.0)
+      parallel (~> 1.10)
+      parser (>= 3.0.0.0)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml
+      rubocop-ast (>= 1.9.1, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.11.0)
+      parser (>= 3.0.1.1)
+    rubocop-faker (1.1.0)
+      faker (>= 2.12.0)
+      rubocop (>= 0.82.0)
+    rubocop-performance (1.11.5)
+      rubocop (>= 1.7.0, < 2.0)
+      rubocop-ast (>= 0.4.0)
+    rubocop-rails (2.12.2)
+      activesupport (>= 4.2.0)
+      rack (>= 1.1)
+      rubocop (>= 1.7.0, < 2.0)
+    rubocop-rspec (2.4.0)
+      rubocop (~> 1.0)
+      rubocop-ast (>= 1.1.0)
+    ruby-progressbar (1.11.0)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (2.1.0)
+    zeitwerk (2.4.2)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  overcommit (= 0.58.0)
+  rubocop (= 1.21.0)
+  rubocop-faker (= 1.1.0)
+  rubocop-performance (= 1.11.5)
+  rubocop-rails (= 2.12.2)
+  rubocop-rspec (= 2.4.0)
+
+BUNDLED WITH
+   2.1.4

data/.rspec

@@ -1 +1 @@
---color
+--require spec_helper

data/.rubocop.yml

@@ -0,0 +1,139 @@
+inherit_from: .rubocop_todo.yml
+require:
+  - rubocop-performance
+  - rubocop-rails
+  - rubocop-rspec
+  - rubocop-faker
+
+# Following Cops were enabled:
+
+Style/CollectionMethods:
+  Description: 'Preferred collection methods.'
+  StyleGuide: '#map-find-select-reduce-size'
+  Enabled: true
+
+Layout/FirstArrayElementLineBreak:
+  Description: >-
+    Checks for a line break before the first element in a
+    multi-line array.
+  Enabled: true
+
+Layout/FirstHashElementLineBreak:
+  Description: >-
+    Checks for a line break before the first element in a
+    multi-line hash.
+  Enabled: true
+
+Style/ImplicitRuntimeError:
+  Description: >-
+    Use `raise` or `fail` with an explicit exception class and
+    message, rather than just a message.
+  Enabled: true
+
+Style/MethodCalledOnDoEndBlock:
+  Description: 'Avoid chaining a method call on a do...end block.'
+  StyleGuide: '#single-line-blocks'
+  Enabled: true
+
+Style/Send:
+  Description: 'Prefer `Object#__send__` or `Object#public_send` to `send`, as `send` may overlap with existing methods.'
+  StyleGuide: '#prefer-public-send'
+  Enabled: true
+
+Style/BlockDelimiters:
+  IgnoredMethods:
+    - lambda
+    - proc
+
+Rails/UnknownEnv:
+  Environments:
+    - production
+    - development
+    - test
+    - dev
+    - stage
+
+Bundler/DuplicatedGem:
+  Enabled: true
+  Include:
+    - '**/Gemfile'
+    - '**/gems.rb'
+    - '**/.overcommit_gems'
+
+Metrics/BlockLength:
+  Description: 'Avoid long blocks with many lines.'
+  Enabled: true
+  Exclude:
+    - 'Rakefile'
+    - '**/*.rake'
+    - 'spec/**/*.rb'
+    - 'config/routes.rb'
+    - 'config/routes/*.rb'
+    - 'config/environments/*.rb'
+    - 'app/api_docs/**/*.rb'
+
+# Following Cops were disabled:
+
+Style/Encoding:
+  Description: 'Use UTF-8 as the source file encoding.'
+  Enabled: false
+
+Style/Documentation:
+  Description: 'Document classes and non-namespace modules.'
+  Enabled: false
+
+Style/RescueModifier:
+  Description: 'Avoid using rescue in its modifier form.'
+  Enabled: false
+
+Style/EmptyCaseCondition:
+  Description: 'Avoid empty condition in case statements.'
+  Enabled: false
+
+# Rails cops
+
+Rails:
+  Enabled: true
+
+Rails/SkipsModelValidations:
+  Enabled: false
+
+Rails/NotNullColumn:
+  Enabled: false
+
+Rails/RenderInline:
+  Description: Prefer using a template over inline rendering.
+  Enabled: false
+
+# RSpec cops
+
+RSpec/ExampleLength:
+  Max: 15
+
+RSpec/FilePath:
+  Description: 'Checks that spec file paths are consistent with the test subject.'
+  Enabled: true
+  IgnoreMethods: true
+  SpecSuffixOnly: true
+
+RSpec/MultipleExpectations:
+  Description: 'Checks if examples contain too many `expect` calls.'
+  Enabled: false
+
+RSpec/VerifiedDoubles:
+  Description: 'Prefer using verifying doubles over normal doubles.'
+  Enabled: false
+
+RSpec/NestedGroups:
+  Max: 4
+
+# Global configuration:
+
+AllCops:
+  NewCops: enable
+  Exclude:
+    - 'db/schema.rb'
+    - 'bin/**/*'
+    - 'config/deploy.rb'
+    - 'config/puma.rb'
+  TargetRubyVersion: 2.6.3

data/Gemfile

@@ -1,11 +1,8 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
-# Specify your gem's dependencies in metanol.gemspec
-gemspec
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
-group :test do
-  gem 'rspec', '~> 2.14.0', require: nil
-  gem 'rspec-rails', '~> 2.14.0', require: nil
-  gem 'sqlite3', '>= 0'
-  gem 'webrat', '>= 0'
-end
+# Specify your gem's dependencies in asap-tools.gemspec
+gemspec

data/Gemfile.lock

@@ -0,0 +1,194 @@
+PATH
+  remote: .
+  specs:
+    metanol (0.0.9)
+      rails (>= 6.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    actioncable (6.1.4.1)
+      actionpack (= 6.1.4.1)
+      activesupport (= 6.1.4.1)
+      nio4r (~> 2.0)
+      websocket-driver (>= 0.6.1)
+    actionmailbox (6.1.4.1)
+      actionpack (= 6.1.4.1)
+      activejob (= 6.1.4.1)
+      activerecord (= 6.1.4.1)
+      activestorage (= 6.1.4.1)
+      activesupport (= 6.1.4.1)
+      mail (>= 2.7.1)
+    actionmailer (6.1.4.1)
+      actionpack (= 6.1.4.1)
+      actionview (= 6.1.4.1)
+      activejob (= 6.1.4.1)
+      activesupport (= 6.1.4.1)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 2.0)
+    actionpack (6.1.4.1)
+      actionview (= 6.1.4.1)
+      activesupport (= 6.1.4.1)
+      rack (~> 2.0, >= 2.0.9)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.2.0)
+    actiontext (6.1.4.1)
+      actionpack (= 6.1.4.1)
+      activerecord (= 6.1.4.1)
+      activestorage (= 6.1.4.1)
+      activesupport (= 6.1.4.1)
+      nokogiri (>= 1.8.5)
+    actionview (6.1.4.1)
+      activesupport (= 6.1.4.1)
+      builder (~> 3.1)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.1, >= 1.2.0)
+    activejob (6.1.4.1)
+      activesupport (= 6.1.4.1)
+      globalid (>= 0.3.6)
+    activemodel (6.1.4.1)
+      activesupport (= 6.1.4.1)
+    activerecord (6.1.4.1)
+      activemodel (= 6.1.4.1)
+      activesupport (= 6.1.4.1)
+    activestorage (6.1.4.1)
+      actionpack (= 6.1.4.1)
+      activejob (= 6.1.4.1)
+      activerecord (= 6.1.4.1)
+      activesupport (= 6.1.4.1)
+      marcel (~> 1.0.0)
+      mini_mime (>= 1.1.0)
+    activesupport (6.1.4.1)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+      zeitwerk (~> 2.3)
+    addressable (2.8.0)
+      public_suffix (>= 2.0.2, < 5.0)
+    builder (3.2.4)
+    byebug (11.1.3)
+    capybara (3.35.3)
+      addressable
+      mini_mime (>= 0.1.3)
+      nokogiri (~> 1.8)
+      rack (>= 1.6.0)
+      rack-test (>= 0.6.3)
+      regexp_parser (>= 1.5, < 3.0)
+      xpath (~> 3.2)
+    coderay (1.1.3)
+    concurrent-ruby (1.1.9)
+    crass (1.0.6)
+    diff-lcs (1.4.4)
+    erubi (1.10.0)
+    globalid (0.5.2)
+      activesupport (>= 5.0)
+    i18n (1.8.10)
+      concurrent-ruby (~> 1.0)
+    loofah (2.12.0)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
+    mail (2.7.1)
+      mini_mime (>= 0.1.1)
+    marcel (1.0.2)
+    method_source (1.0.0)
+    mini_mime (1.1.1)
+    mini_portile2 (2.6.1)
+    minitest (5.14.4)
+    nio4r (2.5.8)
+    nokogiri (1.12.5)
+      mini_portile2 (~> 2.6.1)
+      racc (~> 1.4)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    pry-byebug (3.9.0)
+      byebug (~> 11.0)
+      pry (~> 0.13.0)
+    public_suffix (4.0.6)
+    racc (1.5.2)
+    rack (2.2.3)
+    rack-test (1.1.0)
+      rack (>= 1.0, < 3)
+    rails (6.1.4.1)
+      actioncable (= 6.1.4.1)
+      actionmailbox (= 6.1.4.1)
+      actionmailer (= 6.1.4.1)
+      actionpack (= 6.1.4.1)
+      actiontext (= 6.1.4.1)
+      actionview (= 6.1.4.1)
+      activejob (= 6.1.4.1)
+      activemodel (= 6.1.4.1)
+      activerecord (= 6.1.4.1)
+      activestorage (= 6.1.4.1)
+      activesupport (= 6.1.4.1)
+      bundler (>= 1.15.0)
+      railties (= 6.1.4.1)
+      sprockets-rails (>= 2.0.0)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.4.2)
+      loofah (~> 2.3)
+    railties (6.1.4.1)
+      actionpack (= 6.1.4.1)
+      activesupport (= 6.1.4.1)
+      method_source
+      rake (>= 0.13)
+      thor (~> 1.0)
+    rake (13.0.6)
+    regexp_parser (2.1.1)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.1)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.10.0)
+    rspec-rails (5.0.2)
+      actionpack (>= 5.2)
+      activesupport (>= 5.2)
+      railties (>= 5.2)
+      rspec-core (~> 3.10)
+      rspec-expectations (~> 3.10)
+      rspec-mocks (~> 3.10)
+      rspec-support (~> 3.10)
+    rspec-support (3.10.2)
+    sprockets (4.0.2)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.2)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
+    sqlite3 (1.4.2)
+    thor (1.1.0)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+    websocket-driver (0.7.5)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.5)
+    xpath (3.2.0)
+      nokogiri (~> 1.8)
+    zeitwerk (2.4.2)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  capybara
+  metanol!
+  pry-byebug
+  rspec (>= 3.0)
+  rspec-rails (>= 5.0)
+  sqlite3
+
+BUNDLED WITH
+   2.1.4

data/README.md

@@ -6,7 +6,7 @@ This is a meta tags plugin which helps to manage meta tags in your Rails applica
 
 Add this line to your application's Gemfile:
 
-    gem 'metanol', '~> 0.0.5'
+    gem 'metanol', '~> 0.0.8'
 
 And then execute:
 
@@ -93,3 +93,8 @@ Also the plugin provides some helper's methods for getting a meta's value: `get_
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+### Do not forget to install OverCommit before making a PR
+
+1. Run `bundle install --gemfile=.overcommit_gems`
+2. Run `overcommit -i`

data/Rakefile

@@ -1 +1 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'

data/lib/metanol/engine.rb

@@ -1,4 +1,4 @@
 module Metanol
   class Engine < ::Rails::Engine
   end
-end
+end

data/lib/metanol/engine_controller.rb

@@ -1,13 +1,12 @@
 require 'active_support/dependencies'
 
 module Metanol
-
   # Engine's controller which has all methods for storing and processing meta tag's data
   module EngineController
     extend ActiveSupport::Concern
 
     included do
-      before_filter :clear_metanols
+      before_action :clear_metanols
     end
 
     module ClassMethods
@@ -43,7 +42,7 @@ module Metanol
         end
       end
 
-      def add_meta_by_type(repo, type, name, value, filters=[])
+      def add_meta_by_type(repo, type, name, value, filters = [])
         meta_class = SUPPORT_GROUPS[type]
         key = get_meta_key(type, name)
         unless repo.key? key
@@ -85,7 +84,5 @@ module Metanol
     def clear_metanols
       @action_metanols = {}
     end
-
   end
-
-end
+end

data/lib/metanol/helpers.rb

@@ -1,6 +1,5 @@
 module Metanol
   module Helpers
-
     # Render all meta tags
     def metanol_tags
       result = ''
@@ -20,10 +19,11 @@ module Metanol
     SUPPORT_GROUPS.keys.each do |method|
       get_method_name = "get_#{method == :main ? '' : "#{method}_"}meta"
       define_method get_method_name do |name|
-        self.controller.send(get_method_name, name)
+        controller.__send__(get_method_name, name)
       end
 
       next if method == :og
+
       method_name = "metanol_#{method}_tags"
       class_type = SUPPORT_GROUPS[method]
       define_method method_name do
@@ -40,13 +40,13 @@ module Metanol
 
     def metanol_render_tags(type)
       result = ''
-      metanols = self.controller.class.common_metanols.merge(self.controller.action_metanols)
+      metanols = controller.class.common_metanols.merge(controller.action_metanols)
       metanols.each_value do |value|
         next unless value.is_a? type
+
         result << value.render
       end
       result
     end
-
   end
-end
+end