metallum 0.2.3 → 0.2.4

data/.rvmrc

@@ -1 +1 @@
-rvm use 1.9.2
+rvm use 1.9.3

data/CHANGELOG

@@ -1,10 +1,9 @@
-09.09.2011
+13.04.2011
 ----------
 Peco Danajlovski <vortexmk@gmail.com>
-* Started this CHANGELOG
-* Introduced guard for automatic testing
-* Implemented fetching basic band info
-* Version bump to 0.1.0
+* Fixed some bugs
+* Updated the specs
+* Version bump to 0.2.4
 
 10.09.2011
 ----------
@@ -15,3 +14,12 @@ Peco Danajlovski <vortexmk@gmail.com>
 * Moved Band and Album under Metallum namespace
 * Fixed gem dependencies
 * Version bump to 0.2.3
+
+09.09.2011
+----------
+Peco Danajlovski <vortexmk@gmail.com>
+* Started this CHANGELOG
+* Introduced guard for automatic testing
+* Implemented fetching basic band info
+* Version bump to 0.1.0
+

data/lib/metallum/band.rb

@@ -8,7 +8,7 @@ module Metallum
 
     def name
       element = @page.search("h1[@class='band_name']")
-      element.text.strip!
+      element.text.strip
     end
 
     def country

data/lib/metallum/metallum.rb

@@ -8,12 +8,15 @@ module Metallum
       @agent = Mechanize.new
       @page = @agent.get(url)
       @discography = @agent.get("http://www.metal-archives.com/band/discography/id/#{extract_band_id}/tab/all")
+    rescue
+      # TODO: PD: Code smell
+      # Do nothing
     end
 
     def fetch_band
-      band = Band.new(@page, @discography) 
+      band = Band.new(@page, @discography)
     end
- 
+
     def fetch_album
       album = Album.new(@page)
     end
@@ -21,7 +24,7 @@ module Metallum
     def extract_band_id
       @page.uri.to_s.match(/\/(\d+)/)[1]
     end
-   
+
   end
 
 end

data/lib/metallum/version.rb

@@ -1,3 +1,3 @@
 module Metallum
-  VERSION = "0.2.3"
+  VERSION = "0.2.4"
 end

data/spec/metallum/album_spec.rb

@@ -2,44 +2,48 @@ require 'spec_helper'
 
 describe "Album" do
 
-  before(:each) do
+  before(:all) do
     @album_url = "http://www.metal-archives.com/albums/Dream_Theater/A_Dramatic_Turn_of_Events/309671"
     @agent = Metallum::Agent.new(@album_url)
     @album = @agent.fetch_album
   end
 
-  it "should fetch the title of the album" do
-    @album.title.should == "A Dramatic Turn of Events"
-  end
+  context "album info" do
 
-  it "should fetch the name of the band" do
-    @album.band_name.should == "Dream Theater"
-  end
+    it "should fetch the title of the album" do
+      @album.title.should == "A Dramatic Turn of Events"
+    end
 
-  it "should fetch the type of the album" do
-    @album.album_type.should == "Full-length"
-  end
+    it "should fetch the name of the band" do
+      @album.band_name.should == "Dream Theater"
+    end
 
-  it "should fetch the release date" do
-    @album.release_date.should == "September 13th, 2011"
-  end
+    it "should fetch the type of the album" do
+      @album.album_type.should == "Full-length"
+    end
 
-  it "should fetch the record label" do
-    @album.record_label.should == "Roadrunner Records"
-  end
+    it "should fetch the release date" do
+      @album.release_date.should == "September 13th, 2011"
+    end
 
-  it "should fetch track list" do
-    @album.track_list.size == 9
-  end
+    it "should fetch the record label" do
+      @album.record_label.should == "Roadrunner Records"
+    end
 
-  it "should fetch track titles" do
-    @album.track_list[0].title.should == "On the Backs of Angels"
-    @album.track_list[8].title.should == "Beneath the Surface"
-  end
+    it "should fetch track list" do
+      @album.track_list.size == 9
+    end
+
+    it "should fetch track titles" do
+      @album.track_list[0].title.should == "On the Backs of Angels"
+      @album.track_list[8].title.should == "Beneath the Surface"
+    end
+
+    it "should fetch the track length" do
+      @album.track_list[3].duration.should == "06:57"
+      @album.track_list[6].duration.should == "03:56"
+    end
 
-  it "should fetch the track length" do
-    @album.track_list[3].duration.should == "06:57"
-    @album.track_list[6].duration.should == "03:56"
   end
 
 end

data/spec/metallum/band_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe "Band" do
 
-  before(:each) do
+  before(:all) do
     @band_url = 'http://www.metal-archives.com/bands/Blind_Guardian/3'
     @agent = Metallum::Agent.new(@band_url)
     @band = @agent.fetch_band
@@ -14,7 +14,7 @@ describe "Band" do
     band = @agent.fetch_band
     band.name.should == "Hell"
   end
-  
+
   it "should fetch the band's name from url for band 'Blind Guardian'" do
     @band.name.should == "Blind Guardian"
   end
@@ -44,11 +44,11 @@ describe "Band" do
   end
 
   it "should fetch band's record label" do
-    @band.record_label.should == "Nuclear Blast Records"
+    @band.record_label.should == "Nuclear Blast"
   end
 
   it "should fetch band's photo url" do
-    @band.photo_url.should == "http://www.metal-archives.com/images/3/3_photo.jpg"
+    @band.photo_url.should == "http://www.metal-archives.com/images/3/3_photo.jpg?1846"
   end
 
   it "should fetch band's logo url" do

metadata

@@ -1,39 +1,39 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: metallum
-version: !ruby/object:Gem::Version 
+version: !ruby/object:Gem::Version
+  version: 0.2.4
   prerelease: 
-  version: 0.2.3
 platform: ruby
-authors: 
+authors:
 - Peco Danajlovski
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-09-10 00:00:00 +02:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-04-13 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: mechanize
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
+      - !ruby/object:Gem::Version
         version: 2.0.1
   type: :runtime
-  version_requirements: *id001
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.0.1
 description: Metallum is a simple gem that fetches various data from metal-archives.com
-email: 
+email:
 - vortexmk@gmail.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - .rspec
 - .rvmrc
@@ -51,33 +51,28 @@ files:
 - spec/metallum/band_spec.rb
 - spec/metallum/metallum_spec.rb
 - spec/spec_helper.rb
-has_rdoc: true
-homepage: ""
+homepage: ''
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: metallum
-rubygems_version: 1.6.2
+rubygems_version: 1.8.19
 signing_key: 
 specification_version: 3
 summary: Metallum is a simple gem that fetches various data from metal-archives.com
 test_files: []
-