metal_archives 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: '00870c0edc861f8ff624c887f5a83346e1d2cba6'
-  data.tar.gz: 19f0e38a29a17f35604ae692c5773c8bcee0cede
+  metadata.gz: 0ed8310a30556ecb2a4162a99f848fdb990c69cc
+  data.tar.gz: 0ab681f3fa13d9c26157490d6de20be03595e63c
 SHA512:
-  metadata.gz: 2499d481e8719a3913504a826214824b7871004ffabed9661e1bb623510bdc3d4cbd9a80499d8b7a2888d24b0314334d6fb29dad12f033057a23fe2e7bcb7949
-  data.tar.gz: d6825c4a2172caa7b37d3080154e653961c3e456e3018f20b283b286a493064a5401a00348752d3f207fb5af7a1b272df9d9145b136e922e3662b515fe499012
+  metadata.gz: c5e2062fc9b6ddc67bc2439c572cd6dd359bcf3ece870fbb09c4a3d294d075e588227c522273e276808507729834273becd1392cfd83c89a2839e6da4d4cd97c
+  data.tar.gz: f708e10fd9ed4d1eb4f35abe5585dd0703aa633b931bff6f1a8a4ed730c140b46f071582fc34be1c04751a4824fe7bc926b1d2c111cacf1f6b89c00a7536246a

data/lib/metal_archives/models/base_model.rb

@@ -35,6 +35,11 @@ module MetalArchives
       # Use constructor to set attributes
       initialize assemble
 
+      # Set empty properties to nil
+      self.class.properties.each do |prop|
+        instance_variable_set("@#{prop}", nil) unless instance_variable_defined? "@#{prop}"
+      end
+
       @loaded = true
       self.class.cache[id] = self
     rescue => e
@@ -108,13 +113,13 @@ module MetalArchives
 
         # property
         define_method(name) do
-          load! unless instance_variable_defined?("@#{name}") || name ==(:id)
+          load! unless instance_variable_defined?("@#{name}") || name == :id
           instance_variable_get("@#{name}")
         end
 
         # property?
         define_method("#{name}?") do
-          load! unless instance_variable_defined?("@#{name}") || name ==(:id)
+          load! unless instance_variable_defined?("@#{name}") || name == :id
 
           property = instance_variable_get("@#{name}")
           property.respond_to?(:empty?) ? !property.empty? : !!property

data/lib/metal_archives/utils/nil_date.rb

@@ -35,7 +35,7 @@ module MetalArchives
     # Return a +Date+ object
     #
     def date
-      raise MetalArchives::Errors::ArgumentError, 'invalid date' unless year?
+      raise MetalArchives::Errors::ArgumentError, "Invalid conversion to Date: #{self.to_s}" unless year?
 
       ::Date.new @year, month || 1, day || 1
     end
@@ -51,8 +51,8 @@ module MetalArchives
       day = Integer(split[2]) if split.length > 2
 
       return MetalArchives::NilDate.new year, month, day
-    rescue
-      raise MetalArchives::Errors::ArgumentError, 'invalid date'
+    rescue => e
+      raise MetalArchives::Errors::ArgumentError, "Invalid date: #{value}: #{e}"
     end
 
     def to_s

data/lib/metal_archives/version.rb

@@ -4,5 +4,5 @@ module MetalArchives
   ##
   # MetalArchives API version
   #
-  VERSION = '2.0.0'
+  VERSION = '2.0.1'
 end

data/spec/models/band_spec.rb

@@ -48,21 +48,6 @@ RSpec.describe MetalArchives::Band do
 
       expect(-> { MetalArchives::Parsers::Band.send(:map_status, :invalid_status) }).to raise_error MetalArchives::Errors::ParserError
     end
-
-    it 'rewrites URIs' do
-      old_endpoint = MetalArchives.config.endpoint
-      MetalArchives.config.endpoint = 'https://foo.bar/'
-
-      band = MetalArchives::Band.find! 122302
-
-      expect(band.logo.scheme).to eq 'https'
-      expect(band.logo.host).to eq 'foo.bar'
-
-      expect(band.logo.scheme).to eq 'https'
-      expect(band.photo.host).to eq 'foo.bar'
-
-      MetalArchives.config.endpoint = old_endpoint
-    end
   end
 
   describe 'methods' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: metal_archives
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Florian Dejonckheere