metal_archives 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 29c629e0d26e84fff55b4c57c2423e8f46c95547
-  data.tar.gz: 200e49292fd001e2b035f105c5f518323f7659e3
+  metadata.gz: 5e5c9e464d998ad27ebce937a23a7b9924ccf871
+  data.tar.gz: 758ebce5c4bb742680622b18c0fb5b3138a077c3
 SHA512:
-  metadata.gz: 6a2443f5b2f8bcdc4dd5d7f8cc96648b1182225d9ba2e27289fb4782fb5b8cbd283ee8995e3b50cb1dbc1c76e7a67edddffb92d8fda8f5d703d03a4dd4a16426
-  data.tar.gz: b824e554a0deac921487b096c93227989d9d1a440969114b6b2cf5fc35acbe7f831d4b7fbed2a8316d18b8e50d4ab298bd54931df1b21b847eaaec12e0052ef7
+  metadata.gz: b5c26112b01a3de24352096e0f3dc2b6a7394cd7a9ae0bf4f7607f8ec057668ca6cc5bd30dda216547128dff8c38f141463472645b2623b1507c13b9bf8fd5e2
+  data.tar.gz: 1848ff7bef54f75f913e7212b7c18b9e97c216ec3e8ce86f5b3b90e8c632614d9408b5cf43089b76de045e2591e472264b9d9bc9aa99e00f0f7c94f661dd5f69

data/.gitignore

@@ -9,3 +9,4 @@
 html/
 
 Gemfile.lock
+.idea

data/README.md

@@ -35,8 +35,8 @@ MetalArchives.configure do |c|
   c.request_rate = 1
   c.request_timeout = 3
 
-  # Print debugging information
-  c.debug = false
+  # Custom logger (optional)
+  c.logger = Logger.new File.new('metal_archives.log')
 end
 ```
 
@@ -61,17 +61,19 @@ require 'countries'
 
 @bands_containing_hell = MetalArchives::Band.search_by :name => '*hell*'
 @non_melodic_death_bands = MetalArchives::Band.search_by :genre => 'death -melodic'
-```
 
-Refer to the model's RDoc documentation for full documentation.
+# Methods returning multiple results return a MetalArchives::Collection.
+# Collection wraps a paginated resource, and can be used to iterate over huge queries.
+@non_melodic_death_bands.first(100).each do |band|
+  puts band.name
+end
+```
 
-## Debugging
+Refer to the model's [RDoc documentation](https://floriandejonckheere.github.io/metal_archives/html/).
 
-Turn on `debug` in the configuration block to enable logging HTTP requests and responses.
+## Lazy loading
 
-```
-$ irb -r metal_archives
-```
+By default when an model (Artist, Band, ...) is created, no data is fetched. This leads to instantiation of a model with an invalid ID not throwing any errors. Calling any attribute other than `id` will cause all data to be fetched and any errors to be thrown. Refer to the respective methods to find out what errors are thrown in what circumstances.  
 
 ## Testing
 ```

data/lib/metal_archives/configuration.rb

@@ -66,9 +66,9 @@ module MetalArchives
     attr_accessor :request_timeout
 
     ##
-    # Print debug information
+    # Logger instance
     #
-    attr_accessor :debug
+    attr_accessor :logger
 
     ##
     # Default configuration values
@@ -76,6 +76,7 @@ module MetalArchives
     def initialize
       @throttle_rate = 1
       @throttle_wait = 3
+      @logger = Logger.new STDOUT
     end
   end
 end

data/lib/metal_archives/error.rb

@@ -9,12 +9,12 @@ module Errors
   class Error < StandardError; end
 
   ##
-  # Error in data
+  # No or invalid ID
   #
-  class DataError < Error; end
+  class InvalidIDError < Error; end
 
   ##
-  # No or invalid configuration found
+  # No or invalid configuration
   #
   class InvalidConfigurationError < Error; end
 

data/lib/metal_archives/http_client.rb

@@ -15,6 +15,7 @@ module MetalArchives
       def get(*params)
         response = client.get *params
 
+        raise Errors::InvalidIDError, response.status if response.status == 404
         raise Errors::APIError, response.status if response.status >= 400
 
         response
@@ -31,14 +32,15 @@ module MetalArchives
 
           @faraday ||= Faraday.new do |f|
             f.request   :url_encoded            # form-encode POST params
-            f.response  :logger if !!MetalArchives.config.debug      # log requests to STDOUT
+            f.response  :logger, MetalArchives.config.logger
 
             f.use       MetalArchives::Middleware
             f.use       Faraday::HttpCache,
                                         :store => MetalArchives.config.cache_store if !!MetalArchives.config.enable_cache
             f.use       :throttler,
                                 :rate => MetalArchives.config.request_rate,
-                                :wait => MetalArchives.config.request_timeout
+                                :wait => MetalArchives.config.request_timeout,
+                                :logger => MetalArchives.config.logger
 
             f.adapter   Faraday.default_adapter
           end

data/lib/metal_archives/models/artist.rb

@@ -19,6 +19,9 @@ module MetalArchives
     #
     # Returns +String+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :name
 
     ##
@@ -26,6 +29,9 @@ module MetalArchives
     #
     # Returns +Array+ of +String+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :aliases, :multiple => true
 
     ##
@@ -33,6 +39,9 @@ module MetalArchives
     #
     # Returns +ISO3166::Country+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :country, :type => ISO3166::Country
 
     ##
@@ -40,6 +49,9 @@ module MetalArchives
     #
     # Returns +String+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :location
 
     ##
@@ -47,6 +59,9 @@ module MetalArchives
     #
     # Returns +Date+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :date_of_birth, :type => Date
 
     ##
@@ -54,6 +69,9 @@ module MetalArchives
     #
     # Returns +Date+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :date_of_death, :type => Date
 
     ##
@@ -61,6 +79,9 @@ module MetalArchives
     #
     # Returns +String+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :cause_of_death
 
     ##
@@ -68,6 +89,9 @@ module MetalArchives
     #
     # Returns +Symbol+, either +:male+ or +:female+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     enum :gender, :values => [:male, :female]
 
     ##
@@ -75,6 +99,9 @@ module MetalArchives
     #
     # Returns raw HTML +String+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :biography
 
     ##
@@ -82,6 +109,9 @@ module MetalArchives
     #
     # Returns raw HTML +String+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :trivia
 
     ##
@@ -89,6 +119,9 @@ module MetalArchives
     #
     # Returns +Array+ of +Hash+ containing the following keys
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     # [+similar+]
     #     - +:url+: +String+
     #     - +:type+: +Symbol+, either +:official+, +:unofficial+ or +:unlisted_bands+
@@ -105,7 +138,8 @@ module MetalArchives
       ##
       # Fetch the data and assemble the model
       #
-      # Raises rdoc-ref:MetalArchives::Errors::APIError
+      # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when receiving a status code == 404
+      # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
       #
       def assemble # :nodoc:
         ## Base attributes
@@ -132,8 +166,7 @@ module MetalArchives
 
         properties[:links] = Parsers::Artist.parse_links_html response.body
 
-        ## Use constructor to fill properties
-        initialize properties
+        properties
       end
 
     class << self
@@ -149,10 +182,30 @@ module MetalArchives
         Artist.new :id => id
       end
 
+      ##
+      # Find by ID (no lazy loading)
+      #
+      # Returns rdoc-ref:Band
+      #
+      # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+      # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+      #
+      # [+id+]
+      #     +Integer+
+      #
+      def find!(id)
+        obj = find id
+        obj.send :fetch
+
+        obj
+      end
+
       ##
       # Find by attributes
       #
-      # Returns rdoc-ref:Artist or nil when ID is invalid
+      # Returns rdoc-ref:Artist or nil when no results
+      #
+      # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400
       #
       # [+query+]
       #     Hash containing one or more of the following keys:
@@ -171,8 +224,6 @@ module MetalArchives
         id = Nokogiri::HTML(data.first).xpath('//a/@href').first.value.gsub('\\', '').split('/').last.gsub(/\D/, '').to_i
 
         Artist.new :id => id
-      rescue Errors::APIError
-        nil
       end
 
       ##
@@ -180,6 +231,8 @@ module MetalArchives
       #
       # Returns rdoc-ref:Collection of rdoc-ref:Artist
       #
+      # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400
+      #
       # [+name+]
       #     +String+
       #

data/lib/metal_archives/models/band.rb

@@ -19,6 +19,9 @@ module MetalArchives
     #
     # Returns +String+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :name
 
     ##
@@ -26,6 +29,9 @@ module MetalArchives
     #
     # Returns +Array+ of +String+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :aliases, :multiple => true
 
     ##
@@ -33,6 +39,9 @@ module MetalArchives
     #
     # Returns +ISO3166::Country+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :country, :type => ISO3166::Country
 
     ##
@@ -40,6 +49,9 @@ module MetalArchives
     #
     # Returns +String+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :location
 
     ##
@@ -47,6 +59,9 @@ module MetalArchives
     #
     # Returns +Date+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :date_formed, :type => Date
 
     ##
@@ -54,6 +69,9 @@ module MetalArchives
     #
     # Returns +Array+ of rdoc-ref:Range
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :date_active, :type => MetalArchives::Range, :multiple => true
 
     ##
@@ -61,6 +79,9 @@ module MetalArchives
     #
     # Returns +Array+ of +String+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :genres, :multiple => true
 
     ##
@@ -68,6 +89,9 @@ module MetalArchives
     #
     # Returns +Array+ of +String+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :lyrical_themes, :multiple => true
 
     ##
@@ -75,6 +99,9 @@ module MetalArchives
     #
     # Returns rdoc-ref:Label
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :label, :type => MetalArchives::Label
 
     ##
@@ -82,6 +109,9 @@ module MetalArchives
     #
     # Returns boolean
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     enum :independent, :values => [true, false]
 
     ##
@@ -89,6 +119,9 @@ module MetalArchives
     #
     # Returns raw HTML +String+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :comment
 
     ##
@@ -96,6 +129,9 @@ module MetalArchives
     #
     # Returns +:active+, +:split_up+, +:on_hold+, +:unknown+, +:changed_name+ or +:disputed+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     enum :status, :values => [:active, :split_up, :on_hold, :unknown, :changed_name, :disputed]
 
     # TODO: releases
@@ -106,6 +142,9 @@ module MetalArchives
     #
     # Returns +Array+ of +Hash+ containing the following keys
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     # [+similar+]
     #     - +:band+: rdoc-ref:Band
     #     - +:score+: +Integer+
@@ -117,6 +156,9 @@ module MetalArchives
     #
     # Returns +String+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :logo
 
     ##
@@ -124,6 +166,9 @@ module MetalArchives
     #
     # Returns +String+
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     property :photo
 
     ##
@@ -131,6 +176,9 @@ module MetalArchives
     #
     # Returns +Array+ of +Hash+ containing the following keys
     #
+    # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+    # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+    #
     # [+similar+]
     #     - +:url+: +String+
     #     - +:type+: +Symbol+, either +:official+ or +:merchandise+
@@ -142,7 +190,8 @@ module MetalArchives
       ##
       # Fetch the data and assemble the model
       #
-      # Raises rdoc-ref:MetalArchives::Errors::APIError
+      # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when receiving a status code == 404
+      # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
       #
       def assemble # :nodoc:
         ## Base attributes
@@ -169,16 +218,13 @@ module MetalArchives
 
         properties[:links] = Parsers::Band.parse_related_links_html response.body
 
-        ## Use constructor to fill properties
-        initialize properties
+        properties
       end
 
     class << self
       ##
       # Find by ID
       #
-      # Refer to {MA's FAQ}[http://www.metal-archives.com/content/help?index=3#tab_db] for search tips.
-      #
       # Returns rdoc-ref:Band, even when ID is invalid (because the data is lazily fetched)
       #
       # [+id+]
@@ -188,12 +234,32 @@ module MetalArchives
         Band.new :id => id
       end
 
+      ##
+      # Find by ID (no lazy loading)
+      #
+      # Returns rdoc-ref:Band
+      #
+      # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no or invalid id
+      # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
+      #
+      # [+id+]
+      #     +Integer+
+      #
+      def find!(id)
+        obj = find id
+        obj.send :fetch
+
+        obj
+      end
+
       ##
       # Find by attributes
       #
       # Refer to {MA's FAQ}[http://www.metal-archives.com/content/help?index=3#tab_db] for search tips.
       #
-      # Returns rdoc-ref:Band or nil when ID is invalid
+      # Returns rdoc-ref:Band or nil when no results
+      #
+      # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400
       #
       # [+query+]
       #     Hash containing one or more of the following keys:
@@ -233,6 +299,8 @@ module MetalArchives
       #
       # Returns rdoc-ref:Collection of rdoc-ref:Band
       #
+      # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400
+      #
       # [+query+]
       #     Hash containing one or more of the following keys:
       #     - +:name+: +String+
@@ -285,6 +353,8 @@ module MetalArchives
       #
       # Returns (possibly empty) +Array+ of rdoc-ref:Band
       #
+      # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400
+      #
       # [+name+]
       #     +String+
       #

data/lib/metal_archives/models/base_model.rb

@@ -14,18 +14,28 @@ module MetalArchives
       end
     end
 
+    ##
+    # Returns true if two objects have the same type and id
+    #
+    def ==(obj)
+      obj.instance_of? self.class and self.id == obj.id
+    end
+
     protected
       ##
       # Eagerly fetch the data
       #
-      # Raises rdoc-ref:MetalArchives::Errors::APIError
+      # Raises rdoc-ref:MetalArchives::Errors::InvalidIDError when no id
+      # Raises rdoc-ref:MetalArchives::Errors::NotImplementedError when no :assemble method is implemented
+      # Raises rdoc-ref:MetalArchives::Errors::APIError when receiving a status code >= 400 (except 404)
       #
       def fetch
-        raise Errors::DataError, 'no id present' unless !!id
+        raise Errors::InvalidIDError, 'no id present' unless !!id
 
         raise Errors::NotImplementedError, 'no :assemble method in model' unless self.respond_to? :assemble, true
 
-        assemble
+        # Use constructor to set attributes
+        initialize assemble
       end
 
     class << self

data/lib/metal_archives/parsers/artist.rb

@@ -72,6 +72,8 @@ module Parsers
         props[:aliases] << alt unless props[:name] == alt
 
         props
+      rescue => e
+        raise ParserError, e
       end
 
       def parse_links_html(response)

data/lib/metal_archives/parsers/band.rb

@@ -100,6 +100,8 @@ module Parsers
         end
 
         props
+      rescue => e
+        raise ParserError, e
       end
 
       def parse_similar_bands_html(response)

data/lib/metal_archives/version.rb

@@ -2,5 +2,5 @@ module MetalArchives
   ##
   # MetalArchives API version
   #
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 end

data/test/base_model_test.rb

@@ -18,7 +18,7 @@ class ModelTwo < MetalArchives::BaseModel
 end
 
 ##
-# Sample model
+# Sample complete model
 #
 class ModelThree < MetalArchives::BaseModel
   property :id
@@ -29,6 +29,18 @@ class ModelThree < MetalArchives::BaseModel
   end
 end
 
+##
+# Sample complete model
+#
+class ModelFour < MetalArchives::BaseModel
+  property :id
+  property :property_one
+
+  def assemble
+    instance_variable_set "@property_one", 'Property One'
+  end
+end
+
 ##
 # BaseModel tests
 #
@@ -84,4 +96,16 @@ class BaseModelTest < Test::Unit::TestCase
     assert model.instance_variable_defined? '@property_one'
     assert_equal 'Property One', model.property_one
   end
+
+  def test_equality
+    m1 = ModelThree.new :id => 'id_one'
+    m2 = ModelThree.new :id => 'id_one'
+    m3 = ModelThree.new :id => 'id_two'
+    m4 = ModelFour.new :id => 'id_one'
+
+    assert_equal m1, m2
+    assert_not_equal m2, m3
+    assert_not_equal m1, m3
+    assert_not_equal m1, m4
+  end
 end

data/test/query/artist_query_test.rb

@@ -12,6 +12,7 @@ class ArtistQueryTest < Test::Unit::TestCase
 
     assert_not_nil artist
     assert_instance_of MetalArchives::Artist, artist
+    assert_equal 60908, artist.id
     assert_equal 'Alberto Rionda', artist.name
     assert_equal ISO3166::Country['ES'], artist.country
 
@@ -20,6 +21,28 @@ class ArtistQueryTest < Test::Unit::TestCase
     assert_instance_of MetalArchives::Artist, artist
   end
 
+  def test_find!
+    artist = MetalArchives::Artist.find! 60908
+
+    assert_not_nil artist
+    assert_instance_of MetalArchives::Artist, artist
+    assert_equal 60908, artist.id
+    assert_equal 'Alberto Rionda', artist.name
+    assert_equal ISO3166::Country['ES'], artist.country
+
+    assert_raise MetalArchives::Errors::InvalidIDError do
+      MetalArchives::Artist.find! nil
+    end
+
+    assert_raise MetalArchives::Errors::InvalidIDError do
+      MetalArchives::Artist.find! 0
+    end
+
+    assert_raise MetalArchives::Errors::APIError do
+      MetalArchives::Artist.find! -1
+    end
+  end
+
   def test_find_by
     artist = MetalArchives::Artist.find_by :name => 'Alberto Rionda'
 
@@ -44,4 +67,29 @@ class ArtistQueryTest < Test::Unit::TestCase
 
     assert !MetalArchives::Artist.search('SomeNonExistantName').any?
   end
+
+  def test_errors
+    assert_nothing_raised do
+      MetalArchives::Artist.new :id => nil
+      MetalArchives::Artist.new :id => 0
+      MetalArchives::Artist.new :id => -1
+      MetalArchives::Artist.find_by :name => 'SomeNonExistantName'
+      MetalArchives::Artist.search 'SomeNonExistantName'
+    end
+
+    assert_raise MetalArchives::Errors::InvalidIDError do
+      MetalArchives::Artist.new(:id => nil).send :assemble
+    end
+
+    assert_raise MetalArchives::Errors::InvalidIDError do
+      MetalArchives::Artist.new(:id => 0).send :assemble
+    end
+
+    assert_raise MetalArchives::Errors::APIError do
+      MetalArchives::Artist.new(:id => -1).send :assemble
+    end
+
+    assert_nil MetalArchives::Artist.find_by :name => 'SomeNonExistantName'
+    assert !MetalArchives::Artist.search('SomeNonExistantName').any?
+  end
 end

data/test/query/band_query_test.rb

@@ -12,6 +12,7 @@ class BandQueryTest < Test::Unit::TestCase
 
     assert_not_nil band
     assert_instance_of MetalArchives::Band, band
+    assert_equal 3540361100, band.id
     assert_equal 'Alquimia', band.name
     assert_equal ISO3166::Country['ES'], band.country
 
@@ -23,6 +24,31 @@ class BandQueryTest < Test::Unit::TestCase
     assert_instance_of MetalArchives::Band, band
   end
 
+  def test_find!
+    band = MetalArchives::Band.find! 3540361100
+
+    assert_not_nil band
+    assert_instance_of MetalArchives::Band, band
+    assert_equal 3540361100, band.id
+    assert_equal 'Alquimia', band.name
+    assert_equal ISO3166::Country['ES'], band.country
+
+    assert_match 'http', band.logo
+    assert_match 'http', band.photo
+
+    assert_raise MetalArchives::Errors::InvalidIDError do
+      MetalArchives::Band.find! nil
+    end
+
+    assert_raise MetalArchives::Errors::InvalidIDError do
+      MetalArchives::Band.find! 0
+    end
+
+    assert_raise MetalArchives::Errors::APIError do
+      MetalArchives::Band.find! -1
+    end
+  end
+
   def test_find_by
     band = MetalArchives::Band.find_by :name => 'Falconer'
 
@@ -82,4 +108,31 @@ class BandQueryTest < Test::Unit::TestCase
 
     assert_equal 274, MetalArchives::Band.search_by(:country => ISO3166::Country['CN']).count
   end
+
+  def test_errors
+    assert_nothing_raised do
+      MetalArchives::Band.new :id => nil
+      MetalArchives::Band.new :id => 0
+      MetalArchives::Band.new :id => -1
+      MetalArchives::Band.find_by :name => 'SomeNonExistantName'
+      MetalArchives::Band.search_by :name => 'SomeNonExistantName'
+      MetalArchives::Band.search 'SomeNonExistantName'
+    end
+
+    assert_raise MetalArchives::Errors::InvalidIDError do
+      MetalArchives::Band.new(:id => nil).send :assemble
+    end
+
+    assert_raise MetalArchives::Errors::InvalidIDError do
+      MetalArchives::Band.new(:id => 0).send :assemble
+    end
+
+    assert_raise MetalArchives::Errors::APIError do
+      MetalArchives::Band.new(:id => -1).send :assemble
+    end
+
+    assert_nil MetalArchives::Band.find_by :name => 'SomeNonExistantName'
+    assert !MetalArchives::Band.search_by(:name => 'SomeNonExistantName').any?
+    assert !MetalArchives::Band.search('SomeNonExistantName').any?
+  end
 end

data/test/test_helper.rb

@@ -4,6 +4,10 @@ require 'test/unit'
 require 'metal_archives'
 
 # Configuration
+puts "Debug log is written to /tmp/test-#{Process.pid}.log"
+logger = Logger.new File.open('/tmp/test-#{Process.pid}.log', 'a')
+logger.level = Logger::DEBUG
+
 MetalArchives.configure do |c|
   c.app_name = 'MetalArchivesGemTestSuite'
   c.app_version = MetalArchives::VERSION
@@ -17,10 +21,6 @@ MetalArchives.configure do |c|
   c.request_rate = 1
   c.request_timeout = 3
 
-  # Print debugging information
-  c.debug = false
-end
-
-def data_for(filename)
-  File.read(File.join(File.dirname(__FILE__) + "/data/#{filename}"))
+  # Custom logger (optional)
+  c.logger = logger
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: metal_archives
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Florian Dejonckheere
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-12 00:00:00.000000000 Z
+date: 2016-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug