metal-archives 0.1.3 → 0.1.4

data/README.rdoc

@@ -10,24 +10,24 @@ Here is a quick and dirty example:
   require 'metal-archives'
 
   agent = MetalArchives::Agent.new
-  links = []
+  urls = []
 
-  agent.paginated_result_links.each do |search_result|
-    link = agent.album_links_from_url(search_result)
-    if link.nil?
+  agent.paginated_result_urls.each do |search_result|
+    url = agent.album_urls(search_result)
+    if url.nil?
       puts "\nThrew an exception so exit"
       break
     else
       print '.'
-      links << link
+      urls << url
     end
   end
-  links.flatten!
-  puts "DONE: #{links.size}"
+  urls.flatten!
+  puts "DONE: #{urls.size}"
 
-  if links.size >= 1
-    puts "album information for the first result: #{agent.album_from_url(links.first).inspect}"
-    puts "album information for the first result: #{agent.album_from_url(links.last).inspect}"
+  if urls.size >= 1
+    puts "album information for the first result: #{agent.album_from_url(urls.first).inspect}"
+    puts "album information for the first result: #{agent.album_from_url(urls.last).inspect}"
   end
 
 == Contributing to metal-archives

data/VERSION

@@ -1 +1 @@
-0.1.3
+0.1.4

data/lib/metal-archives.rb

@@ -25,35 +25,35 @@ module MetalArchives
       end
     end
 
-    # Finds all the links to the search results pages as they are paginated.
-    def paginated_result_links
-      # need the first page because it's not a link
-      links = ["/advanced.php?release_year=#{@year}&p=1"]
+    # Finds all the url to the search results pages as they are paginated.
+    def paginated_result_urls
+      # need the first page because it's not a url
+      urls = ["/advanced.php?release_year=#{@year}&p=1"]
       begin
         search_by_year.search('body table:nth-child(2n) tr:first-child a').each do |link|
-          links << link['href']
+          urls << link['href']
         end
       rescue Exception => e
-        puts "\nError accessing metal-archives.com's paginated result links: #{e}"
+        puts "\nError accessing metal-archives.com's paginated result urls: #{e}"
       ensure
-        return links
+        return urls
       end
     end
 
-    # Finds all the links to the albums on a given search results page.
-    def album_links_from_url(url)
-      links = []
+    # Finds all the urls to the albums on a given search results page.
+    def album_urls(url)
+      urls = []
       begin
         page = @agent.get(SITE_URL + url)
         page.encoding = 'iso-8859-1' if !page.nil? && page.encoding != 'iso-8859-1' # needed for foreign characters
         page.search('body table:nth-child(2n) tr td:nth-child(3n) a').each do |link|
-          links << link['href']
+          urls << link['href']
         end
       rescue Exception => e
-        puts "\nError accessing metal-archives.com's album links from url: #{e}"
+        puts "\nError accessing metal-archives.com's album urls: #{e}"
         return nil
       end
-      return links
+      return urls
     end
 
     # Finds the following fields on an album's page:

data/metal-archives.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{metal-archives}
-  s.version = "0.1.3"
+  s.version = "0.1.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Danny Olson"]

data/spec/metal-archives_spec.rb

@@ -26,22 +26,22 @@ describe "MetalArchives" do
       end
 
       context "with a results page" do
-        it "should find the paginated result links" do
+        it "should find the paginated result urls" do
           agent = MetalArchives::Agent.new(2011)
           agent.stub!(:search_by_year).and_return(@search_results)
 
-          links = (1..16).collect do |i|
+          urls = (1..16).collect do |i|
             "/advanced.php?release_year=2011&p=#{i}"
           end
-          agent.paginated_result_links.should == links
+          agent.paginated_result_urls.should == urls
         end
 
-        it "should find the album links" do
+        it "should find the album urls" do
           @mechanize.stub!(:get).and_return(@search_results)
           agent = MetalArchives::Agent.new(2011)
           agent.stub!(:search_by_year).and_return(@search_results)
 
-          links = [
+          urls = [
             "release.php?id=296061", "release.php?id=295756", "release.php?id=294429", "release.php?id=295451", "release.php?id=295197",
             "release.php?id=289824", "release.php?id=295519", "release.php?id=295457", "release.php?id=288298", "release.php?id=296048",
             "release.php?id=290116", "release.php?id=295059", "release.php?id=291931", "release.php?id=296081", "release.php?id=295301",
@@ -53,7 +53,7 @@ describe "MetalArchives" do
             "release.php?id=295806", "release.php?id=294017", "release.php?id=296098", "release.php?id=294092", "release.php?id=295551",
             "release.php?id=290740", "release.php?id=295410", "release.php?id=293189", "release.php?id=296140", "release.php?id=291295"
           ]
-          agent.album_links_from_url(agent.paginated_result_links.first).should == links
+          agent.album_urls(agent.paginated_result_urls.first).should == urls
         end
       end
     end
@@ -67,9 +67,9 @@ describe "MetalArchives" do
           Mechanize.stub!(:new).and_return(@mechanize)
           @mechanize.stub!(:get).and_return(@search_results)
           agent = MetalArchives::Agent.new(2011)
-          album_link_from_url = "release.php?id=000001"
+          album_url = "release.php?id=000001"
 
-          agent.album_from_url(album_link_from_url).should == {
+          agent.album_from_url(album_url).should == {
             :album => 'Fn-2+Fn-1=Fn',
             :band => 'A Tree',
             :label => 'Nazgûl Distro & Prod.',
@@ -88,9 +88,9 @@ describe "MetalArchives" do
           Mechanize.stub!(:new).and_return(@mechanize)
           @mechanize.stub!(:get).and_return(@search_results)
           agent = MetalArchives::Agent.new(2011)
-          album_link_from_url = "release.php?id=000001"
+          album_url = "release.php?id=000001"
 
-          agent.album_from_url(album_link_from_url).should == {
+          agent.album_from_url(album_url).should == {
             :album => 'Flesh Torn in Twilight',
             :band => 'Acephalix',
             :label => 'Deific Mourning',
@@ -109,9 +109,9 @@ describe "MetalArchives" do
           Mechanize.stub!(:new).and_return(@mechanize)
           @mechanize.stub!(:get).and_return(@search_results)
           agent = MetalArchives::Agent.new(2011)
-          album_link_from_url = "release.php?id=000001"
+          album_url = "release.php?id=000001"
 
-          agent.album_from_url(album_link_from_url).should == {
+          agent.album_from_url(album_url).should == {
             :album => 'The Mirror of Deliverance',
             :band => 'A Dream of Poe',
             :label => 'ARX Productions',

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 1
-  - 3
-  version: 0.1.3
+  - 4
+  version: 0.1.4
 platform: ruby
 authors: 
 - Danny Olson
@@ -143,7 +143,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 834701885390149642
+      hash: 3280097642105159980
       segments: 
       - 0
       version: "0"