metainspector 5.17.0 → 5.17.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 293357cd2d7638ce799d31024e708ba8b82ae8c6bb376304ab8b400aa959be05
-  data.tar.gz: a358b95df5bb28c81325d8f48ff6dfff85b423054ddd25195a91d3906e04c409
+  metadata.gz: 2e9605e47f410256715a5a3944362e203535eaa37603f1e8cfdf4f5a94d55890
+  data.tar.gz: 46cdbfdb7ecfa22091777a49f81f5bf261fed551ed624a7ea80d5c7c19c51008
 SHA512:
-  metadata.gz: 113e3d9d929b7e9df03b107ba40a5b813ce9732510ccf858764048a607074cee10208a50686f0f1b3efb952de1185dff5b1739d41d8a278ec8097de010677137
-  data.tar.gz: 8c090ead5bb14f40a2c6c867da1e9178d6cc8665bdae7853395c28ed9ddee3de235880bc9727622964afab3ba24408c67a0a68e6b7c082ebb67f88c6a6eae42e
+  metadata.gz: c0f771666159eda7086cfc912fa5db8bccf00924248da36483574198716ff527d558d106b53d08d0bb774e59db70a6225b9fe3441658a387eef170a239726007
+  data.tar.gz: ef0d3abdf02d14777c06fdc529e20f801e6c7a7061adf2230837d877d80b0f57b3cf010b1e745444f2df442971afc2bc78b4cf20c4a41742069be1b23d4f0b9e

data/.circleci/config.yml

@@ -1,43 +1,51 @@
 version: 2.1
-orbs:
-  ruby: circleci/ruby@1.0.4
+
 jobs:
   test_3_2:
     docker:
-      - image: cimg/ruby:3.2.9
+      - image: cimg/ruby:3.2
     steps:
       - checkout
-      - ruby/install-deps
+      - run:
+          name: Install dependencies
+          command: bundle install
       - run:
           name: Run tests
           command: bundle exec rake
   test_3_3:
     docker:
-      - image: cimg/ruby:3.3.10
+      - image: cimg/ruby:3.3
     steps:
       - checkout
-      - ruby/install-deps
+      - run:
+          name: Install dependencies
+          command: bundle install
       - run:
           name: Run tests
           command: bundle exec rake
   test_3_4:
     docker:
-      - image: cimg/ruby:3.4.8
+      - image: cimg/ruby:3.4
     steps:
       - checkout
-      - ruby/install-deps
+      - run:
+          name: Install dependencies
+          command: bundle install
       - run:
           name: Run tests
           command: bundle exec rake
   test_4_0:
     docker:
-      - image: cimg/ruby:4.0.0
+      - image: cimg/ruby:4.0
     steps:
       - checkout
-      - ruby/install-deps
+      - run:
+          name: Install dependencies
+          command: bundle install
       - run:
           name: Run tests
           command: bundle exec rake
+
 workflows:
   version: 2
   deploy:

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # MetaInspector Changelog
 
+## [Changes in 5.17.1](https://github.com/jaimeiniesta/metainspector/compare/v5.17.0...v5.17.1)
+
+* Upgrade addressable and puma dependencies
+
+## [Changes in 5.17.0](https://github.com/jaimeiniesta/metainspector/compare/v5.16.0...v5.17.0)
+
+* Add support for Ruby 4.0
+* Remove support for Ruby 3.1
+* Several dependencies upgrade
+
 ## [Changes in 5.16.0](https://github.com/jaimeiniesta/metainspector/compare/v5.15.0...v5.16.0)
 
 * Upgraded dependencies and supported Ruby versions.

data/lib/meta_inspector/parsers/texts.rb

@@ -86,7 +86,7 @@ module MetaInspector
         candidates.compact!
         candidates.map! { |c| (c.respond_to? :inner_text) ? c.inner_text : c }
         candidates.map! { |c| c.strip.gsub(/\s+/, ' ') }
-        candidates.first
+        candidates.find { |c| !c.to_s.empty? }
       end
 
       def find_best_author
@@ -100,7 +100,7 @@ module MetaInspector
         candidates.compact!
         candidates.map! { |c| (c.respond_to? :inner_text) ? c.inner_text : c }
         candidates.map! { |c| c.strip.gsub(/\s+/, ' ') }
-        candidates.first
+        candidates.find { |c| !c.to_s.empty? }
       end
 
       def find_best_description

data/lib/meta_inspector/request.rb

@@ -1,3 +1,4 @@
+require 'http/cookie'
 require 'faraday'
 require 'faraday-cookie_jar'
 require 'faraday-http-cache'

data/lib/meta_inspector/version.rb

@@ -1,3 +1,3 @@
 module MetaInspector
-  VERSION = '5.17.0'
+  VERSION = '5.17.2'
 end

data/meta_inspector.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'faraday-gzip', '>= 0.1', '< 4.0'
   gem.add_dependency 'faraday-http-cache', '~> 2.5'
   gem.add_dependency 'faraday-retry', '~> 2.0'
-  gem.add_dependency 'addressable', '~> 2.8.4'
+  gem.add_dependency 'addressable', '~> 2.9.0'
   gem.add_dependency 'fastimage', '~> 2.2'
   gem.add_dependency 'nesty', '~> 1.0'
 
@@ -31,8 +31,8 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'awesome_print', '~> 1.9'
   gem.add_development_dependency 'rake', '~> 13.0'
   gem.add_development_dependency 'pry', '~> 0.14'
-  gem.add_development_dependency 'puma', '~> 7.0.2'
+  gem.add_development_dependency 'puma', '~> 8.0.0'
   gem.add_development_dependency 'rubocop', '~> 1.34'
-  gem.add_development_dependency 'resolv', '~> 0.6.2'
+  gem.add_development_dependency 'resolv', '~> 0.7.1'
   gem.add_development_dependency 'sinatra', '~> 4.2.0'
 end

data/spec/fixtures/author_in_link_with_empty_meta_author.response

@@ -0,0 +1,23 @@
+HTTP/1.1 200 OK
+Age: 13
+Cache-Control: max-age=120
+Content-Type: text/html
+Date: Mon, 06 Jan 2014 12:47:42 GMT
+Expires: Mon, 06 Jan 2014 12:49:28 GMT
+Server: Apache/2.2.14 (Ubuntu)
+Vary: Accept-Encoding
+Via: 1.1 varnish
+X-Powered-By: PHP/5.3.2-1ubuntu4.22
+X-Varnish: 1188792404 1188790413
+Content-Length: 320
+Connection: keep-alive
+
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml" xmlns:fb="http://www.facebook.com/2008/fbml">
+  <head>
+    <meta name="author" content="" />
+  </head>
+  <body>
+    <a rel="author">This author came from the link when the meta author was empty</a>
+  </body>
+</html>

data/spec/fixtures/title_in_head_with_empty_og_title.response

@@ -0,0 +1,24 @@
+HTTP/1.1 200 OK
+Age: 13
+Cache-Control: max-age=120
+Content-Type: text/html
+Date: Mon, 06 Jan 2014 12:47:42 GMT
+Expires: Mon, 06 Jan 2014 12:49:28 GMT
+Server: Apache/2.2.14 (Ubuntu)
+Vary: Accept-Encoding
+Via: 1.1 varnish
+X-Powered-By: PHP/5.3.2-1ubuntu4.22
+X-Varnish: 1188792404 1188790413
+Content-Length: 365
+Connection: keep-alive
+
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml" xmlns:fb="http://www.facebook.com/2008/fbml">
+  <head>
+    <title>This title came from the head when og:title was empty</title>
+    <meta property="og:title" content="" />
+  </head>
+  <body>
+    <p>A sample page with an empty og:title that should fall through to the head title</p>
+  </body>
+</html>

data/spec/meta_inspector/texts_spec.rb

@@ -79,6 +79,11 @@ describe MetaInspector do
       expect(page.best_title).to eq('This title came from the head and has leading and trailing whitespace')
     end
 
+    it "should skip empty candidates and fall back to the next one" do
+      page = MetaInspector.new('http://example.com/title_in_head_with_empty_og_title')
+      expect(page.best_title).to eq('This title came from the head when og:title was empty')
+    end
+
     it "should return nil if none of the candidates are present" do
       page = MetaInspector.new('http://example.com/title_not_present')
       expect(page.best_title).to be(nil)
@@ -122,6 +127,11 @@ describe MetaInspector do
       expect(page.best_author).to eq("This author came from the twitter creator tag")
     end
 
+    it "should skip empty candidates and fall back to the next one" do
+      page = MetaInspector.new('http://example.com/author_in_link_with_empty_meta_author')
+      expect(page.best_author).to eq("This author came from the link when the meta author was empty")
+    end
+
     it "should return nil if no author information present" do
       page = MetaInspector.new('http://example.com/empty')
 

data/spec/spec_helper.rb

@@ -45,10 +45,12 @@ RSpec.configure do |config|
     stub_request(:get, "http://example.com/title_in_h1").to_return(fixture_file("title_in_h1.response"))
     stub_request(:get, "http://example.com/title_in_head").to_return(fixture_file("title_in_head.response"))
     stub_request(:get, "http://example.com/title_in_head_with_whitespace").to_return(fixture_file("title_in_head_with_whitespace.response"))
+    stub_request(:get, "http://example.com/title_in_head_with_empty_og_title").to_return(fixture_file("title_in_head_with_empty_og_title.response"))
     stub_request(:get, "http://example.com/title_not_present").to_return(fixture_file("title_not_present.response"))
     stub_request(:get, "http://example.com/author_in_meta").to_return(fixture_file("author_in_meta.response"))
     stub_request(:get, "http://example.com/author_in_body").to_return(fixture_file("author_in_body.response"))
     stub_request(:get, "http://example.com/author_in_link").to_return(fixture_file("author_in_link.response"))
+    stub_request(:get, "http://example.com/author_in_link_with_empty_meta_author").to_return(fixture_file("author_in_link_with_empty_meta_author.response"))
     stub_request(:get, "http://example.com/author_in_twitter").to_return(fixture_file("author_in_twitter.response"))
     stub_request(:get, "http://example.com/?name=joe martins").to_return(fixture_file("example.response"))
     stub_request(:get, "http://example.com/?name=joe+martins").to_return(fixture_file("example.response"))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: metainspector
 version: !ruby/object:Gem::Version
-  version: 5.17.0
+  version: 5.17.2
 platform: ruby
 authors:
 - Jaime Iniesta
@@ -133,14 +133,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.8.4
+        version: 2.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.8.4
+        version: 2.9.0
 - !ruby/object:Gem::Dependency
   name: fastimage
   requirement: !ruby/object:Gem::Requirement
@@ -245,14 +245,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.0.2
+        version: 8.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.0.2
+        version: 8.0.0
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -273,14 +273,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.6.2
+        version: 0.7.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.6.2
+        version: 0.7.1
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
@@ -344,6 +344,7 @@ files:
 - spec/fixtures/alazan_websolution.response
 - spec/fixtures/author_in_body.response
 - spec/fixtures/author_in_link.response
+- spec/fixtures/author_in_link_with_empty_meta_author.response
 - spec/fixtures/author_in_meta.response
 - spec/fixtures/author_in_twitter.response
 - spec/fixtures/broken_head_links.response
@@ -394,6 +395,7 @@ files:
 - spec/fixtures/title_in_body.response
 - spec/fixtures/title_in_h1.response
 - spec/fixtures/title_in_head.response
+- spec/fixtures/title_in_head_with_empty_og_title.response
 - spec/fixtures/title_in_head_with_whitespace.response
 - spec/fixtures/title_not_present.response
 - spec/fixtures/twitter_markupvalidator.response